From patchwork Thu May 19 22:12:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Muddebihal, Basheer Ahmed" X-Patchwork-Id: 12856106 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7643FC433FE for ; Thu, 19 May 2022 22:15:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245419AbiESWNg (ORCPT ); Thu, 19 May 2022 18:13:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245411AbiESWNe (ORCPT ); Thu, 19 May 2022 18:13:34 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61F165AEEE; Thu, 19 May 2022 15:13:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652998413; x=1684534413; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=VMpRKFTZtbEhyzjMomHrBaNoBO6gZj0JVxggZnWjDKs=; b=iWqoyCevDSHGKNTYCwQJtvUXBoEhOQSsRleSTEtw82C2jr/vX9haEUVW RmZ9aHIw+tOoC8VXqDt8yTAiHyVmwxp3MWsCZtLpWYMY7KVmtmgp8sHjC Zk1E7dCyxbqBmPD2NKEOjZS4yhE/asdVGgJw9uzNKbCOXGBXbguZVPaUD Mfwwbv72aNwqDycYlAGtoBqosIy2N3mEyEab/FLdXFzoag50/5v5IvSeD ujFn5q6PQqLyvIHV7gYoKCGtIkB0svbVLlH0bD9HS8gl7ebq0myb/xdYD XxtER1jUSCc93aEzErZuLRCeUOQ0Lktkro9gY2LwcvIItxfBB5JvfbVoN g==; X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="272097505" X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="272097505" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 15:13:31 -0700 X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="743162369" Received: from rhweight-wrk1.ra.intel.com ([137.102.106.43]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 15:13:31 -0700 From: Basheer Ahmed Muddebihal To: hao.wu@intel.com, trix@redhat.com, mdf@kernel.org, yilun.xu@intel.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org Cc: matthew.gerlach@linux.intel.com, marpagan@redhat.com, tianfei.zhang@intel.com, Basheer Ahmed Muddebihal Subject: [PATCH 1/3] fpga: dfl: Fix kernel-doc warning in dfl.h for revision Date: Thu, 19 May 2022 15:12:47 -0700 Message-Id: <20220519221249.858873-2-basheer.ahmed.muddebihal@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220519221249.858873-1-basheer.ahmed.muddebihal@linux.intel.com> References: <20220519221249.858873-1-basheer.ahmed.muddebihal@linux.intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org Fixed the following warning: drivers/fpga/dfl.h:255: warning: Function parameter or member 'revision' not described in 'dfl_feature' Signed-off-by: Basheer Ahmed Muddebihal --- drivers/fpga/dfl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h index 06cfcd5e84bb..766429e618f6 100644 --- a/drivers/fpga/dfl.h +++ b/drivers/fpga/dfl.h @@ -231,6 +231,7 @@ struct dfl_feature_irq_ctx { * * @dev: ptr to pdev of the feature device which has the sub feature. * @id: sub feature id. + * @revision: sub feature revision. * @resource_index: each sub feature has one mmio resource for its registers. * this index is used to find its mmio resource from the * feature dev (platform device)'s resources. From patchwork Thu May 19 22:12:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Muddebihal, Basheer Ahmed" X-Patchwork-Id: 12856104 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E61A3C433F5 for ; Thu, 19 May 2022 22:13:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245395AbiESWNf (ORCPT ); Thu, 19 May 2022 18:13:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245413AbiESWNe (ORCPT ); Thu, 19 May 2022 18:13:34 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62126A5005; Thu, 19 May 2022 15:13:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652998414; x=1684534414; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=uFmq/RU+MxSprUYx5V19OMcQd3bPLRLL+9B9N2X/Hlg=; b=nBlKAKG3wE2sHb+vxREiNIbCO8X6DonPvDOiWQgc3PXTak8l2MWyyvIM 5QpZXikDZu73Uvv5stWRHfYtByqT9zV/ZxAnwasplJE8yV1sJdMJWyge2 1s9ZNcVPcC9Ch1CiFB7RwSy4bWY00RCJhDDUE07J0oD4KCZ9IQZJtqpe+ oBcnSUo3ElXzqTrmKex42RCb14cGJlO0lsQtLRYJZdwSV0xQPlpNbj6Hh itcCujMRo26eIt8czR3ivrMZaemrJSk8GWOZPc+FUFWxo3mF1MZIjsZ+B 3Wa528C2S/eQcfVpcJfxb1Skdf+1VoYEtIlGV6fdQ887g+anasIm4IzcZ Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="272097513" X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="272097513" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 15:13:32 -0700 X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="743162376" Received: from rhweight-wrk1.ra.intel.com ([137.102.106.43]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 15:13:32 -0700 From: Basheer Ahmed Muddebihal To: hao.wu@intel.com, trix@redhat.com, mdf@kernel.org, yilun.xu@intel.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org Cc: matthew.gerlach@linux.intel.com, marpagan@redhat.com, tianfei.zhang@intel.com, Basheer Ahmed Muddebihal Subject: [PATCH 2/3] fpga: dfl: Fix kernel-doc warnings in include/linux/dfl.h Date: Thu, 19 May 2022 15:12:48 -0700 Message-Id: <20220519221249.858873-3-basheer.ahmed.muddebihal@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220519221249.858873-1-basheer.ahmed.muddebihal@linux.intel.com> References: <20220519221249.858873-1-basheer.ahmed.muddebihal@linux.intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org Fixed the following warnings: include/linux/dfl.h:21: warning: Enum value 'FME_ID' not described in enum 'dfl_id_type' include/linux/dfl.h:21: warning: Enum value 'PORT_ID' not described in enum 'dfl_id_type' include/linux/dfl.h:21: warning: Enum value 'DFL_ID_MAX' not described in enum 'dfl_id_type' include/linux/dfl.h:47: warning: Function parameter or member 'revision' not described in 'dfl_device' Signed-off-by: Basheer Ahmed Muddebihal --- include/linux/dfl.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/linux/dfl.h b/include/linux/dfl.h index 431636a0dc78..4caa2d99d8dc 100644 --- a/include/linux/dfl.h +++ b/include/linux/dfl.h @@ -13,6 +13,9 @@ /** * enum dfl_id_type - define the DFL FIU types + * @FME_ID: dfl id for FPGA Management Engine node. + * @PORT_ID: dfl id for Port. + * @DFL_ID_MAX: maximum number for dfl ids. */ enum dfl_id_type { FME_ID = 0, @@ -27,6 +30,7 @@ enum dfl_id_type { * @id: id of the dfl device. * @type: type of DFL FIU of the device. See enum dfl_id_type. * @feature_id: feature identifier local to its DFL FIU type. + * @revision: feature revision local to its DFL FIU type. * @mmio_res: mmio resource of this dfl device. * @irqs: list of Linux IRQ numbers of this dfl device. * @num_irqs: number of IRQs supported by this dfl device. From patchwork Thu May 19 22:12:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Muddebihal, Basheer Ahmed" X-Patchwork-Id: 12856107 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 668EBC433F5 for ; Thu, 19 May 2022 22:15:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245428AbiESWNh (ORCPT ); Thu, 19 May 2022 18:13:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245425AbiESWNg (ORCPT ); Thu, 19 May 2022 18:13:36 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0F12EAD2A; Thu, 19 May 2022 15:13:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652998415; x=1684534415; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LSWyhoO1Ig77aYyVHyGbxNkD/urdHpbw8i03bIc1n70=; b=NR748dOIU4a02iLsDy16AY42tQZqXE7aSXywzwXayOZOq8gp+r19UhY6 CTXvCR9XzxeqQKiHjFdZEmQQKdAxUQtMgy+DLtNAONfTiDNuvCKYM93jo FVbR+U3KADVfmNjT5dKTWmrBmKdWf4CLqoC42ZgAFBjh4fApTDsmimOha jxZZWrPqNjqFtDP7ThnvePgs7UcQ5z6HuTZ0sDSya9LG+rfmVfW0HPHbN xpaTK4k0rOJY4SjkkoubCE9I+4wFIYR04bhzRGFwb4DIJJZoXZdmY6fho 5NmCh9/sRk6MWBdAhFWM3nSDEDVWOdehyqZcEvxfX3/IllyzUCU5I3acX w==; X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="272097523" X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="272097523" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 15:13:34 -0700 X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="743162385" Received: from rhweight-wrk1.ra.intel.com ([137.102.106.43]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 15:13:34 -0700 From: Basheer Ahmed Muddebihal To: hao.wu@intel.com, trix@redhat.com, mdf@kernel.org, yilun.xu@intel.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org Cc: matthew.gerlach@linux.intel.com, marpagan@redhat.com, tianfei.zhang@intel.com, Basheer Ahmed Muddebihal Subject: [PATCH 3/3] fpga: dfl: Fix kernel-doc warnings in drivers/fpga/dfl.c Date: Thu, 19 May 2022 15:12:49 -0700 Message-Id: <20220519221249.858873-4-basheer.ahmed.muddebihal@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220519221249.858873-1-basheer.ahmed.muddebihal@linux.intel.com> References: <20220519221249.858873-1-basheer.ahmed.muddebihal@linux.intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org Fixed the following warnings: drivers/fpga/dfl.c:54: warning: cannot understand function prototype: 'struct dfl_dev_info ' drivers/fpga/dfl.c:74: warning: cannot understand function prototype: 'struct dfl_chardev_info ' drivers/fpga/dfl.c:725: warning: Function parameter or member 'revision' not described in 'dfl_feature_info' Signed-off-by: Basheer Ahmed Muddebihal --- drivers/fpga/dfl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c index 6bff39ff21a0..4086cabd25b0 100644 --- a/drivers/fpga/dfl.c +++ b/drivers/fpga/dfl.c @@ -45,7 +45,7 @@ static const char *dfl_pdata_key_strings[DFL_ID_MAX] = { }; /** - * dfl_dev_info - dfl feature device information. + * struct dfl_dev_info - dfl feature device information. * @name: name string of the feature platform device. * @dfh_id: id value in Device Feature Header (DFH) register by DFL spec. * @id: idr id of the feature dev. @@ -67,7 +67,7 @@ static struct dfl_dev_info dfl_devs[] = { }; /** - * dfl_chardev_info - chardev information of dfl feature device + * struct dfl_chardev_info - chardev information of dfl feature device * @name: nmae string of the char device. * @devt: devt of the char device. */ @@ -708,6 +708,7 @@ struct build_feature_devs_info { * struct dfl_feature_info - sub feature info collected during feature dev build * * @fid: id of this sub feature. + * @revision: revision of this sub feature. * @mmio_res: mmio resource of this sub feature. * @ioaddr: mapped base address of mmio resource. * @node: node in sub_features linked list.