From patchwork Thu Jan 10 12:15:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 10755635 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3DEFC1399 for ; Thu, 10 Jan 2019 12:15:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2C3F3294A0 for ; Thu, 10 Jan 2019 12:15:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2078A294C7; Thu, 10 Jan 2019 12:15:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 93B7A294A0 for ; Thu, 10 Jan 2019 12:15:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727860AbfAJMPK (ORCPT ); Thu, 10 Jan 2019 07:15:10 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:43987 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727849AbfAJMPK (ORCPT ); Thu, 10 Jan 2019 07:15:10 -0500 Received: by mail-lf1-f68.google.com with SMTP id u18so8110268lff.10 for ; Thu, 10 Jan 2019 04:15:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MlLtCmDcbH5nNEkEnU/NkwX+N13og6JNg3kr1P9qqL4=; b=KpoEYD4VD4gGwKm8SVK6XKDPr1n4cYfYuMFCEcifEPzHtQ+L/XwkwEDnUklJV+8uEh lvKmdYXKbD6R3ZFHd8a9VWNE+NMsAFZ56k+tXC1E8tcWiVVeZEK2Plye4aZC/58Oc6VO jcoJK0iCwvJeAZGc4zbvJptTaYbI+QB4H1muI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MlLtCmDcbH5nNEkEnU/NkwX+N13og6JNg3kr1P9qqL4=; b=IvYBZtbJL/nNcAwU1FD9B7PLBYIbhV2ldNOkie6/4zVHR0HqGeWZjeXa55uO1XFrgA X6oah5NVCiOWDPQ8+D+5CGn5O7//+2cygUclHfRdmSQREkqdR/3B6TZiIqcqVp0VNbPl ERj/0kKx+3iB37CKzijSTo6ElaXC0W49IYaBFcP+PvHnDdz1v83kdqRLu9je94/gVGQe INaPPGDnJSkWF4hC0GZSqR6qjljC1ZxLlibasOlUHB7zzolJiDaYlYItVK8cyAIZuZYH ANwnA/osyX3wqO/kIf0mrHNgSWHYs8YtTwF5IKRV+G4QVeoA93svtauC+f3mBc0srb3M w2oQ== X-Gm-Message-State: AJcUukfb1LWp2GhuviOBZ2Uk+z+A5sywWVisIRhTZizJDnB3Y40N6ATI pHcYcr7MOxYuxby999ICy4BTBw== X-Google-Smtp-Source: ALg8bN6vPkIt3yWFMnlsbv8hrJy9g6SiKXE4EIVsapvFszeSZaG4gnthCZIzl9BSK009ya1OdyVbWA== X-Received: by 2002:a19:a104:: with SMTP id k4mr5889921lfe.36.1547122507908; Thu, 10 Jan 2019 04:15:07 -0800 (PST) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id d24-v6sm15141282ljg.2.2019.01.10.04.15.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Jan 2019 04:15:06 -0800 (PST) From: Linus Walleij To: Mark Brown , linux-spi@vger.kernel.org Cc: linux-gpio@vger.kernel.org, Bartosz Golaszewski , linuxarm@huawei.com, Linus Walleij , Janek Kotas Subject: [PATCH] spi: Support high CS when using descriptors Date: Thu, 10 Jan 2019 13:15:03 +0100 Message-Id: <20190110121503.25436-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP All controllers using GPIO descriptors can by definition support high CS connections, so just enforce this when registering an SPI controller. This fixes a regression where controllers were missing SPI_CS_HIGH, the drivers would fail like this: spi spi0.0: setup: unsupported mode bits 4 cdns-spi fd0b0000.spi: can't setup spi0.0, status -22 This is because as using descriptors moves the CS inversion logic over to gpiolib, all such controllers are registered with CS active high. Cc: Janek Kotas Reported-by: Janek Kotas Fixes: f3186dd87669 ("spi: Optionally use GPIO descriptors for CS GPIOs") Signed-off-by: Linus Walleij --- Janek, it'd be great if you could test this patch and confirm that it makes the DW driver tick again. --- drivers/spi/spi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 06b9139664a3..31696f2fc8d5 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -2336,6 +2336,11 @@ int spi_register_controller(struct spi_controller *ctlr) status = spi_get_gpio_descs(ctlr); if (status) return status; + /* + * A controller using GPIO descriptors always + * supports SPI_CS_HIGH if need be. + */ + ctlr->mode_bits |= SPI_CS_HIGH; } else { /* Legacy code path for GPIOs from DT */ status = of_spi_register_master(ctlr);