From patchwork Thu Jan 10 14:50:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 10755983 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2F7591515 for ; Thu, 10 Jan 2019 14:50:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1FB27299EF for ; Thu, 10 Jan 2019 14:50:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 13D8C29A14; Thu, 10 Jan 2019 14:50:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BA9CF299EF for ; Thu, 10 Jan 2019 14:50:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729322AbfAJOuy (ORCPT ); Thu, 10 Jan 2019 09:50:54 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:45243 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729174AbfAJOux (ORCPT ); Thu, 10 Jan 2019 09:50:53 -0500 Received: by mail-lj1-f193.google.com with SMTP id s5-v6so9913648ljd.12 for ; Thu, 10 Jan 2019 06:50:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Q0HQyZdzxTvoAzgCdS78WuvS6bSWXWchuUQCFdCboQ4=; b=ZADNJv1bAq6ReF9oMaUjKqRgOpSpfbmOY8oDNK4zOxaokanN1Vlt33dn0EZ7qY+hzl dQXDpvYk/WRmGsRQXKParGv/5fkW5SsjYJGHKa1LQPcgEnmnAXJlDo6a1tOuZ59ut7lt ooT8ytgVl87E3LoxmUmolFMnRp+sMDCbx8j8s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Q0HQyZdzxTvoAzgCdS78WuvS6bSWXWchuUQCFdCboQ4=; b=GkWpXumPZWhFbVrRhckvlWxu4naaQ40oOLZspvPq0h2HT0Yv4i4fe9h1bcCZdhs2GX O/2CxdCIIrB/OcEi4bjPVCVHrVan/xFXvR5MEfQ9+oBlYTe27tHrcH+An3/m3LnaZMSN C9CWVkTz5zwiFaR/YE5yPZM/u6Hr7Tbwbdd1AMjkeOA5+iAM2Bpxlm4E/S4fkcb5pRlJ EEDH8F60YVCYAIZEFwpjrANw3doFsVgBbraQZyKR7s7/OokWOlxP3Ta6fKVdd3cHb36n 2lqIDZENZ4Xso/25vVKc2Qy0GghTN4EWukCuZ8/mGU7TVPkV3wwNXhdhPJWZNamf5/qL RQKw== X-Gm-Message-State: AJcUukd3GAVh749xsJfMo1DlnnxVrw+puXoHOL1I1vrESYYZ5Uf7vvRs 3WRqYXeadx/YjfH0TIrwW0BlCHN1nYA= X-Google-Smtp-Source: ALg8bN6oQxIvW546zJcOn7MAFcUpFaqCPnT9rlrbSQn/YMUxkGddA4ZGsEP4sA/KrTe5nIdCSRxG8A== X-Received: by 2002:a2e:81d3:: with SMTP id s19-v6mr5371033ljg.138.1547131850755; Thu, 10 Jan 2019 06:50:50 -0800 (PST) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id d15-v6sm15205652lja.38.2019.01.10.06.50.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Jan 2019 06:50:49 -0800 (PST) From: Linus Walleij To: linux-arm-msm@vger.kernel.org, Andy Gross , David Brown Cc: linux-arm-kernel@lists.infradead.org, Linus Walleij Subject: [PATCH 1/2 RESEND] ARM: dts: msm8660: Mark two GSBI blocks "disabled" Date: Thu, 10 Jan 2019 15:50:45 +0100 Message-Id: <20190110145045.11883-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The GSBI module complains: gsbi 16500000.gsbi: missing mode configuration gsbi: probe of 16500000.gsbi failed with error -22 gsbi 16600000.gsbi: missing mode configuration gsbi: probe of 16600000.gsbi failed with error -22 gsbi 19800000.gsbi: GSBI port protocol: 2 crci: 0 So we should mark these GSBIs as "disabled" in the SoC file by default. If boards appear that make use of them, we can simply set status = "ok" in the DTS for them. Signed-off-by: Linus Walleij --- arch/arm/boot/dts/qcom-msm8660.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/qcom-msm8660.dtsi b/arch/arm/boot/dts/qcom-msm8660.dtsi index 70698941f64c..9b1cf00d8ca3 100644 --- a/arch/arm/boot/dts/qcom-msm8660.dtsi +++ b/arch/arm/boot/dts/qcom-msm8660.dtsi @@ -133,6 +133,7 @@ #address-cells = <1>; #size-cells = <1>; ranges; + status = "disabled"; syscon-tcsr = <&tcsr>; @@ -167,6 +168,7 @@ #address-cells = <1>; #size-cells = <1>; ranges; + status = "disabled"; syscon-tcsr = <&tcsr>; From patchwork Thu Jan 10 14:50:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 10755987 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8D7106C2 for ; Thu, 10 Jan 2019 14:51:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 736CB29144 for ; Thu, 10 Jan 2019 14:51:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 65E4C299EF; Thu, 10 Jan 2019 14:51:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EF18E299F2 for ; Thu, 10 Jan 2019 14:51:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728137AbfAJOvA (ORCPT ); Thu, 10 Jan 2019 09:51:00 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:39189 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728130AbfAJOvA (ORCPT ); Thu, 10 Jan 2019 09:51:00 -0500 Received: by mail-lj1-f195.google.com with SMTP id t9-v6so9956333ljh.6 for ; Thu, 10 Jan 2019 06:50:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CcNwEXfi6ZlUWBcW2Bye6DgIumypfVjE/iqyPungPEM=; b=e1p3/EeOMacVEz/eSnrPj5h5JE79nhsL407Ef84/I6mEd+wTf1mkTcMBa3yTouepSx RaEugdd9HkihedamHuEYSU8z/D8TV1CSNMAsPFmT5+uIES7uInOZ0nwxzU0W50sf0EX1 VdiNbSMeH3ENC3jCJD1Ym5mybuIi+qizwMyAo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CcNwEXfi6ZlUWBcW2Bye6DgIumypfVjE/iqyPungPEM=; b=MBo4kc2X7gHFSiba2fL3xohynnH5eXhIImXryJG0xrO/I1DjVAAtpRBkV0Za5DtPjy Yx5cxp0OOzrgEFT9TWIG7T2JEpIW+q7KBCynbLua6WC7oZuQv0uhQBjePpOHiWX/FiUE nC1uY3i5H6Hp2VSaCaaSCtreiKQV/1dKyn+iFun1kMbMBMLZBsbdrLeo33VIqDLY4QTS 6uwVnbVs39G7RE/ZeVedJj+SCzvzuKMrnDu7nLUuLRuqmEguuzrxfipFz3QeP76EEUPO BDAJ1AzeyuqX75jMza7EUCbn8/hvkPYjMeWFMv74kTI5CKDflSaAKobODc+mGNccGCnp 167A== X-Gm-Message-State: AJcUukdYtI7uEo5+5YmwG62nBAXBh97y/1WPpil5sC4nMw6C78bvEyH8 JuXbolgoDWqMVuUgkzoi4z5zKopb/jE= X-Google-Smtp-Source: ALg8bN7crAFz1W1gq/oTIJOBLS5Rudt857YLHTdESshHo5upLiakIPuRjKCedUWBA5TlOUkjvwe+6g== X-Received: by 2002:a2e:9556:: with SMTP id t22-v6mr6727732ljh.36.1547131858075; Thu, 10 Jan 2019 06:50:58 -0800 (PST) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id 12-v6sm15226157ljf.96.2019.01.10.06.50.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Jan 2019 06:50:56 -0800 (PST) From: Linus Walleij To: linux-arm-msm@vger.kernel.org, Andy Gross , David Brown Cc: linux-arm-kernel@lists.infradead.org, Linus Walleij Subject: [PATCH 2/2 RESEND] ARM: dts: msm8660: Fix up GIC IRQ flags Date: Thu, 10 Jan 2019 15:50:54 +0100 Message-Id: <20190110145054.11952-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP All the GSBI blocks are marking their GIC IRQ lines as "IRQ_TYPE_NONE" but there is no such thing: all GIC IRQ lines have a trigger type. That yields the following warning from the GIC driver: WARNING: CPU: 0 PID: 1 at ../drivers/irqchip/irq-gic.c:1016 gic_irq_domain_translate+0xdc/0xe4 (...) Mark all of these IRQ_TYPE_LEVEL_HIGH as is common so this warning goes away. Signed-off-by: Linus Walleij --- arch/arm/boot/dts/qcom-msm8660.dtsi | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm/boot/dts/qcom-msm8660.dtsi b/arch/arm/boot/dts/qcom-msm8660.dtsi index 9b1cf00d8ca3..e5da87036dbb 100644 --- a/arch/arm/boot/dts/qcom-msm8660.dtsi +++ b/arch/arm/boot/dts/qcom-msm8660.dtsi @@ -141,7 +141,7 @@ compatible = "qcom,msm-uartdm-v1.3", "qcom,msm-uartdm"; reg = <0x16540000 0x1000>, <0x16500000 0x1000>; - interrupts = ; + interrupts = ; clocks = <&gcc GSBI6_UART_CLK>, <&gcc GSBI6_H_CLK>; clock-names = "core", "iface"; status = "disabled"; @@ -150,7 +150,7 @@ gsbi6_i2c: i2c@16580000 { compatible = "qcom,i2c-qup-v1.1.1"; reg = <0x16580000 0x1000>; - interrupts = ; + interrupts = ; clocks = <&gcc GSBI6_QUP_CLK>, <&gcc GSBI6_H_CLK>; clock-names = "core", "iface"; #address-cells = <1>; @@ -176,7 +176,7 @@ compatible = "qcom,msm-uartdm-v1.3", "qcom,msm-uartdm"; reg = <0x16640000 0x1000>, <0x16600000 0x1000>; - interrupts = ; + interrupts = ; clocks = <&gcc GSBI7_UART_CLK>, <&gcc GSBI7_H_CLK>; clock-names = "core", "iface"; status = "disabled"; @@ -185,7 +185,7 @@ gsbi7_i2c: i2c@16680000 { compatible = "qcom,i2c-qup-v1.1.1"; reg = <0x16680000 0x1000>; - interrupts = ; + interrupts = ; clocks = <&gcc GSBI7_QUP_CLK>, <&gcc GSBI7_H_CLK>; clock-names = "core", "iface"; #address-cells = <1>; @@ -209,7 +209,7 @@ gsbi8_i2c: i2c@19880000 { compatible = "qcom,i2c-qup-v1.1.1"; reg = <0x19880000 0x1000>; - interrupts = ; + interrupts = ; clocks = <&gcc GSBI8_QUP_CLK>, <&gcc GSBI8_H_CLK>; clock-names = "core", "iface"; #address-cells = <1>; @@ -234,7 +234,7 @@ compatible = "qcom,msm-uartdm-v1.3", "qcom,msm-uartdm"; reg = <0x19c40000 0x1000>, <0x19c00000 0x1000>; - interrupts = <0 195 IRQ_TYPE_NONE>; + interrupts = <0 195 IRQ_TYPE_LEVEL_HIGH>; clocks = <&gcc GSBI12_UART_CLK>, <&gcc GSBI12_H_CLK>; clock-names = "core", "iface"; status = "disabled"; @@ -243,7 +243,7 @@ gsbi12_i2c: i2c@19c80000 { compatible = "qcom,i2c-qup-v1.1.1"; reg = <0x19c80000 0x1000>; - interrupts = <0 196 IRQ_TYPE_NONE>; + interrupts = <0 196 IRQ_TYPE_LEVEL_HIGH>; clocks = <&gcc GSBI12_QUP_CLK>, <&gcc GSBI12_H_CLK>; clock-names = "core", "iface"; #address-cells = <1>;