From patchwork Wed Jun 1 08:09:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12866480 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E7E2C433EF for ; Wed, 1 Jun 2022 08:12:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KzsTmMnjkRNenpJAoQm+imezKGlTL9O9oBvKbqzn504=; b=zDtJYs+0Ul4CRz ZrSFQ1uLa6VlHsr4DvzxRoMy1X0scVbsRGiFvy0TqG4SP/kU26vuiAem/sJbhJin/YpmMx3fPhJC4 X0fu57slPr3i6UZ3vZB3fBu4EfmmBJeluf7CX+h4Yj+QIWI76a/yoE0t9M+2sUvYR2abeh0+hc+04 gSbbs3EBekpiNjyT0KnS0pRBPDLR/CDZA9/ypdRe5J6+xzlZDjqOuXQjFeKH/g/QdEtw95JwmH116 2qKFOiibE7yWKL2/rDrt19Fj1WqGR+D88W1el8U2wNhZ9EUAnQRvm6Z6MXcI9atZttX6BLMquVMir duoQIliDImg5Qh4DaR1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwJS6-00EXlH-7H; Wed, 01 Jun 2022 08:11:38 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwJS1-00EXjp-EF for linux-arm-kernel@lists.infradead.org; Wed, 01 Jun 2022 08:11:34 +0000 Received: by mail-pl1-x636.google.com with SMTP id i1so1081299plg.7 for ; Wed, 01 Jun 2022 01:11:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Px54YeB8y4JCFlFNgwFGWbi1FoMMkCqF3KundDZ3EiM=; b=M8QTLybUaNBk1aN+aW6WTC6oMiD4gHTGH1IngOQcZXfUt6/9wkK5VwiDq6/TgBjLAi VVsj1zx/ZRNW6HwMWapL1em5dRTDFO1BdGM4XJEzdGl465emrnSipiJlkXL99sIWN7qI 9CSmCdLCdbtaS5kOdWFVaX+dXjXQFG3VInPenaz9FVnGInt6sogEJ3OUq9UKXKTUi8Tg y3iCO9U3saux5xWEPNNxjZUTr3CRhtjY9lza1ynF5mNDhIArJKqHuSDLhxPIyjv8C8Q+ tVZdl1wi9BZZSp8Cv+flw3+ENseAF/nVTGBzMznepyaQD+/Awxu8IeXC1MK+Dka/qAib EvnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Px54YeB8y4JCFlFNgwFGWbi1FoMMkCqF3KundDZ3EiM=; b=Nc8UuNF0fGSO3X1pZCkg1FV0H/2vOfSY9e6X4dX8Wp6iT74+Qu6OSfaSEbojhjXiJG VCUqBkBfYDjIqiCw+RdsagkZVSlj/e2DkvNOVcBIs+Gvvt7XGspwbc65jZR2AtULljIP KiJwkEbVzXJZn7xj0MFgUT8X1JkomXwm/6BIRavGKKtbChHO9uL5CJwgIPjUEfgq9CH+ XkuqNb+KBbxpVKH67mvuMKw6ysd62l/RxTsifhj8w/8OKaHu1YLbD5Pufd1BcGQG9uS4 yvK/U1oX5zaTs0+c5W5BGH/JomdSMCKWm38+O+Bpj2wKrOAjYslwaMmvK4ieG589eyuG uVwg== X-Gm-Message-State: AOAM531UgfXpN0x21K1FXWrTwy4Nbmn9JzEtsnjfalpsUAPTw2MobrM0 et8vL/xDGov1ONa2bP/Fqv0= X-Google-Smtp-Source: ABdhPJzG3vlU3jO48Ym1PPOrpdAe+gZj7tJD29o/oekC+E8060IQUrfmuoDVjXjxS3qI7mfLWO385Q== X-Received: by 2002:a17:902:690b:b0:159:65c:9044 with SMTP id j11-20020a170902690b00b00159065c9044mr66244014plk.47.1654071090228; Wed, 01 Jun 2022 01:11:30 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id y1-20020a17090ad0c100b001e2f3831102sm792288pjw.17.2022.06.01.01.11.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 01:11:29 -0700 (PDT) From: Miaoqian Lin To: Hector Martin , Sven Peter , Alyssa Rosenzweig , Thomas Gleixner , Marc Zyngier , Linus Walleij , Birger Koblitz , John Crispin , Bert Vermeulen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Miaoqian Lin Subject: [PATCH 1/6] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init Date: Wed, 1 Jun 2022 12:09:25 +0400 Message-Id: <20220601080930.31005-2-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220601080930.31005-1-linmq006@gmail.com> References: <20220601080930.31005-1-linmq006@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_011133_517092_87A22938 X-CRM114-Status: GOOD ( 13.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_matching_node_and_match() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 82b0a434b436 ("irqchip/gic/realview: Support more RealView DCC variants") Signed-off-by: Miaoqian Lin --- drivers/irqchip/irq-gic-realview.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-gic-realview.c b/drivers/irqchip/irq-gic-realview.c index b4c1924f0255..38fab02ffe9d 100644 --- a/drivers/irqchip/irq-gic-realview.c +++ b/drivers/irqchip/irq-gic-realview.c @@ -57,6 +57,7 @@ realview_gic_of_init(struct device_node *node, struct device_node *parent) /* The PB11MPCore GIC needs to be configured in the syscon */ map = syscon_node_to_regmap(np); + of_node_put(np); if (!IS_ERR(map)) { /* new irq mode with no DCC */ regmap_write(map, REALVIEW_SYS_LOCK_OFFSET, From patchwork Wed Jun 1 08:09:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12866481 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A1C3C433F5 for ; Wed, 1 Jun 2022 08:12:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Dxcf4pYAXA4f/vVUtkMWrL/3MfNtqW9jBvAXufE7k/U=; b=iE7RuWsCe0NCLn Q9UO3brc0wt0/FhyF6u3tlvOAyUtXLcPABw0wTq8ViK17PZeX5X250SYDTFp+pI2UZiK5PNhJCyDk UQjolCOJW8+nrPIOmovPojqp2Do5mzpyxEsWCfaV3cVRWCwa033MDb+9dUTStcE2pBrHHP+WmmLUp dcr7GRrSj/w5q9qEusKiol9BQUPixNk20hvBIkC6PEKWx0nUk1PTRbZEh1vGBmpa+N6BmH6PvxwYb 2tmD8+MztMSKBC4Pp4QUwbxROX42lMR7ibepzVNzlMfi4j5YIUtpCeNcvFIsJH7R0H5V4yr3S/f/M lbpiaoHTWLdfligOp1+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwJSF-00EXoX-Aj; Wed, 01 Jun 2022 08:11:47 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwJS5-00EXlG-Qq for linux-arm-kernel@lists.infradead.org; Wed, 01 Jun 2022 08:11:39 +0000 Received: by mail-pl1-x636.google.com with SMTP id t2so1090660pld.4 for ; Wed, 01 Jun 2022 01:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3He5zqQafCaqxIZZoOREzUNxsIzRMeOPPdePDkzSSxg=; b=qq9VhWsouBy8dPsUw0DdBt28a/qRbqk696UR/zScNQXa6Pi7KY2McPssAJ1mKoUkv7 uVrRQm6pZstAqrdUSPKX87knMJV4KXUA3Aeb/Tt+7hczVx/aSq5wQazrO/5unjQ1r3df pb/pROCHQc7RQwCBCEa/bCDOqDzviTCL1mRVgUbNg7bJxIPlGlr3D6l0FI4xvrUjdZRN hv4WsyIDc/y+LByUw3u1AgTorxoUq8AVsG60WdihRWp5u2/ceoThtMTxZJihoZ8MAcY/ OnIaoliAV5+me8384xFFMQRbW57UORsgKmj1ZDNILAnvckpLK7YGwh1osExA2jMN2+X6 7z+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3He5zqQafCaqxIZZoOREzUNxsIzRMeOPPdePDkzSSxg=; b=U813qpNZ5plnWuP0EqGGgWHWF4r/1MUr1rP0OiZaQ12+qLav6riD5Tn87LI7k5Tvto jIkiC+JB0Qhkj4r81gvswXalG1U7Ijy3vDJSRHngqDUCxziz+x79cEbrPlWjJnBpWm0H sVV7fg4bLQDaaze9QDAQTeuN1sF+IeIGF5QtlpAGf2NGxvSOJkvuWjTrqW5zpZtW8cI2 cI9CmwjGG3OC6u/tysbLVZ/AzLBzplN0cAgot2vigrq8CfJ/HNamQD32h2czREujtyEQ m/ogx12j+XG36qde5PuymMkJOWg8LMqX//k2qulkzqGf1ozpj4JCNcz1vcdW+8t5MTc7 5pFg== X-Gm-Message-State: AOAM533poGGqHEfhvoBT6giT6AiSFLdvPXgG6jf9MZ1X5NJdOB7uH21m 6PeUQELrh4rgwDRqCHhX/3I= X-Google-Smtp-Source: ABdhPJzBCG24CTqcAbxbuUX+p7x/yKqMY2QNv/dS6wzJy4NlNTOe030W2heDInH+ViGtU8VE+LwDmg== X-Received: by 2002:a17:902:e484:b0:164:1c:57a with SMTP id i4-20020a170902e48400b00164001c057amr8152447ple.12.1654071097415; Wed, 01 Jun 2022 01:11:37 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id y1-20020a17090ad0c100b001e2f3831102sm792288pjw.17.2022.06.01.01.11.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 01:11:36 -0700 (PDT) From: Miaoqian Lin To: Hector Martin , Sven Peter , Alyssa Rosenzweig , Thomas Gleixner , Marc Zyngier , Linus Walleij , Bert Vermeulen , John Crispin , Birger Koblitz , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Miaoqian Lin Subject: [PATCH 2/6] irqchip/apple-aic: Fix refcount leak in build_fiq_affinity Date: Wed, 1 Jun 2022 12:09:26 +0400 Message-Id: <20220601080930.31005-3-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220601080930.31005-1-linmq006@gmail.com> References: <20220601080930.31005-1-linmq006@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_011137_910397_5D296E0E X-CRM114-Status: GOOD ( 12.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_node_by_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: a5e8801202b3 ("irqchip/apple-aic: Parse FIQ affinities from device-tree") Signed-off-by: Miaoqian Lin --- drivers/irqchip/irq-apple-aic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c index 12dd48727a15..478d0af16d9f 100644 --- a/drivers/irqchip/irq-apple-aic.c +++ b/drivers/irqchip/irq-apple-aic.c @@ -1035,6 +1035,7 @@ static void build_fiq_affinity(struct aic_irq_chip *ic, struct device_node *aff) continue; cpu = of_cpu_node_to_id(cpu_node); + of_node_put(cpu_node); if (WARN_ON(cpu < 0)) continue; From patchwork Wed Jun 1 08:09:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12866482 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3BF1C433EF for ; Wed, 1 Jun 2022 08:13:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WszeIpLxciQRhA886JzxF3IyzO97OATrsDR9fpRqtFI=; b=XNmENoEcTT/hMT Ziw1bspQrbfMZy4Di0ND2ZjxNlcCQqLu4Z/qTI6IdDN/mgb/hdNTgsBJWaudLwVwXhAKF/49y1FhI gPZHcRPl6G1oOjdejzeTavWZn6J5FKO2iBOAVlmmzS16Hru7zLAj8SyjmXp/O8ysv5JkcROp4VuzR E2TESIRFsYO0YvS48kyEPkO7m9higm6pyJ5XXjKpjS9kBTmMh22GPgYDKkfTyxSlYO3q+/9UU5NYe bZcva9/PvjD4j2U1t6AfwwKe+yMoJV4dOI03tP13jM9TBVJn6z/GJis1RhegAVjKqDIKSuj4OJq3B I1WZ7mZGQ5EqrywlTBvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwJSX-00EXvD-BM; Wed, 01 Jun 2022 08:12:05 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwJSU-00EXpM-Jh for linux-arm-kernel@lists.infradead.org; Wed, 01 Jun 2022 08:12:03 +0000 Received: by mail-pj1-x1034.google.com with SMTP id n13-20020a17090a394d00b001e30a60f82dso5440578pjf.5 for ; Wed, 01 Jun 2022 01:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GWjGR+uUnc6AYWehSdkH/qKXs6QNn54ho2G5cZ8+zoc=; b=lO2Wb90PRtDZzwh2kw70sxt7A/gYeEkNtkUsS3yqAgTMWQOTDGZva4fzz7aMr+4i5C DJAuNZ4iAMF68sPTRHzMJwT0Ko9mpjCrn5dt1zjSqBBanJ9PRMJxrCYZNz4YWoScI+1f tE3E9sl6Ug1NFOXH6ezkTyoj2yQg7spcEAyiADgR5vbMerxjw85BIzJx6mpN2QjVo2t7 bdc20Jtg3vL2gHqJj4G3MOIICtESleFZOhnw3LRN/i+ngeEg78csnWrvfMl4QGJjwdbm SyXqchhjD+rYzhWdJtf7b3EAyHxKrGzJOCN9iK5lTZYEI4lrsn0WflvXFUnPLmiCCfYZ t+jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GWjGR+uUnc6AYWehSdkH/qKXs6QNn54ho2G5cZ8+zoc=; b=iWn2+gxgZh20hOBSFWtcVdL2U5GyuCZxBDkreOfGAmrTjMWDrdvCP9GXIxN1zPuKAk 9vX51IIN52uYerbzIdo6GPdWgMUVTj25KEr37rNqnop9pnTib5IQ5/bWUqgKJedFw6O7 oF3Azv2WHxCKvilPjYb/U5JK9Yv9W6KoFD63R6pSr87uyqF/7Sk/AxqmyxxFBbhoHVqb XrT2XCcUX0c5bP9roYFzt213ENP+1iEBFBGz8rAUTA0qj382+qeEZ0egzjDq9rul6SyA DAumqN5/di87JpB68l6MFf/jKfqaZlxt4CvaRmG361uKbAWgHtTgkuExpEBGyjOZ/kkc 6iGg== X-Gm-Message-State: AOAM533l6TE5/0CCG0PaXRQ2YP5V1giV7uJ0uQElH5lr9PV7aVGJJKOG FNitLPqbYlBG+gr3Gz2/7LM= X-Google-Smtp-Source: ABdhPJyELGcS1L/91yKuLn5SIOvjSQzhnoeJComUUBK/MJj1z2x7Sd+TlkrWgVt8POtKp+07fMGkLQ== X-Received: by 2002:a17:90b:1e4f:b0:1e0:b91:39ef with SMTP id pi15-20020a17090b1e4f00b001e00b9139efmr32876048pjb.51.1654071109571; Wed, 01 Jun 2022 01:11:49 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id y1-20020a17090ad0c100b001e2f3831102sm792288pjw.17.2022.06.01.01.11.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 01:11:49 -0700 (PDT) From: Miaoqian Lin To: Hector Martin , Sven Peter , Alyssa Rosenzweig , Thomas Gleixner , Marc Zyngier , Linus Walleij , Birger Koblitz , John Crispin , Bert Vermeulen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Miaoqian Lin Subject: [PATCH 3/6] irqchip/apple-aic: Fix refcount leak in aic_of_ic_init Date: Wed, 1 Jun 2022 12:09:27 +0400 Message-Id: <20220601080930.31005-4-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220601080930.31005-1-linmq006@gmail.com> References: <20220601080930.31005-1-linmq006@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_011202_664724_3F3EC524 X-CRM114-Status: GOOD ( 12.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_get_child_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: a5e8801202b3 ("irqchip/apple-aic: Parse FIQ affinities from device-tree") Signed-off-by: Miaoqian Lin --- drivers/irqchip/irq-apple-aic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c index 478d0af16d9f..5ac83185ff47 100644 --- a/drivers/irqchip/irq-apple-aic.c +++ b/drivers/irqchip/irq-apple-aic.c @@ -1144,6 +1144,7 @@ static int __init aic_of_ic_init(struct device_node *node, struct device_node *p for_each_child_of_node(affs, chld) build_fiq_affinity(irqc, chld); } + of_node_put(affs); set_handle_irq(aic_handle_irq); set_handle_fiq(aic_handle_fiq); From patchwork Wed Jun 1 08:09:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12866483 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45E92C433F5 for ; Wed, 1 Jun 2022 08:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l+bKBvu6/TkfjUI8IypvaYyR6E8UzhiGS3Rgf+pE/NY=; b=U1rw3b42oW/Woi qT8AlG+E/OJM9z8sx0xBPYBVTx5VTLC9IPJl5rSMMYNYvKiduUWyfvSJBADilAA80gNfcaVmyBPEd 2XsAl3CbsUFVHt+c664hJVJP3oRZxCkvgskghzJ/+pV9IxwR89MWUH0/py8feDOCnTsfK0uz3VaKB VSS3yfQi4omxYVy/BN9HZAU+MswdlNmWgHaJg77NMYltcdHk7STm3C6zk3BbC8dXZ879QtRPqTdOs Cp7NcEpLiOi6vBnhB/pQLRSJUGkbkrYr8KXSOpPQcF7bH17Tr5rgsztFqQrvU/zyyK40XqpyItYPY ZtUUnOOv+QFqFKHy31ZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwJSl-00EY1F-C7; Wed, 01 Jun 2022 08:12:19 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwJSW-00EXsQ-85 for linux-arm-kernel@lists.infradead.org; Wed, 01 Jun 2022 08:12:05 +0000 Received: by mail-pf1-x42b.google.com with SMTP id z17so1277222pff.7 for ; Wed, 01 Jun 2022 01:11:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CjxfEwNZAv/Ns2YjhAVktI1vfhpKFNGdsrqBv+NvOkk=; b=aKhB0zYrAcHE9EQYEKT2g7DsA3648OnKR/M8ytLi01NrDKBfQOWtxZ0GlOwRXPWShx 8X3OUs/gp80cLKaoNhpPXvuvrdxOQw7cpf+jK0webG1TA85XOEfve62vpkGjXVOkid2+ 6UL51qe0apR+nNwdNVXcSeY83YA5GKWB8H6meLszdRK8DIkJHe13oLACV4sQvvQqcSQB RcDaxRIkVlA8g1ym8drygJvmSLNOwhtQuLCtmb4jhLNFwrMgHRQuF2u0UtTcmGShGOpI 7SreIHf38Ouddqe27CWE6Te3i0BxNVWqHQE4qw3F69h6z4TIn36NR2ZEMhYyy/U6OvyS BZxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CjxfEwNZAv/Ns2YjhAVktI1vfhpKFNGdsrqBv+NvOkk=; b=yZG6Sy0bp+Xj+2T4pME6VGXkq9seYn2rYAVD+MnIFHFZ+v6F6EQeBnqb+rQbYQ3WGW DYbG6assFOm57CbUNu+MS8md5AKgFxIWgQs+2eAMbbq5cOWs2IrDWp1leRm9O/CAhJxl 35JFGR73Lv39nkyj6hSmM2PrT9UabSNNd9injwlPD1ZBCWnns0p8KYukySGSBbPxZ33x jb9jAcSrY9uJ3U4nJiwrOuj729FQLXHyl3oqoRIvVBJDIIqmFMuwnbNAxAy1guN+DjZN UxPWvks5epNjCnnArF6TMGat/OCMQQ3d9zwimEC3kdoDQtAW3uL9l/dur8QIXb0uJCeg x0ww== X-Gm-Message-State: AOAM531t2b4bx200P4acnj2rwKZmBKz8oDyp333vBvLHnP4i28vhdfqN m99awO2IowPr0KSUlw8F7Mc= X-Google-Smtp-Source: ABdhPJxjBIdiCetN9iBXLJVU/D5c4YBixW5Uqour1lmH8glwsFGvDrj0ZkgjEyCEoOM6tS+5L/X6GQ== X-Received: by 2002:a63:184d:0:b0:3fb:74ce:effa with SMTP id 13-20020a63184d000000b003fb74ceeffamr23908491pgy.621.1654071119384; Wed, 01 Jun 2022 01:11:59 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id y1-20020a17090ad0c100b001e2f3831102sm792288pjw.17.2022.06.01.01.11.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 01:11:58 -0700 (PDT) From: Miaoqian Lin To: Hector Martin , Sven Peter , Alyssa Rosenzweig , Thomas Gleixner , Marc Zyngier , Linus Walleij , Birger Koblitz , John Crispin , Bert Vermeulen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Miaoqian Lin Subject: [PATCH 4/6] irqchip/gic-v3: Fix error handling in gic_populate_ppi_partitions Date: Wed, 1 Jun 2022 12:09:28 +0400 Message-Id: <20220601080930.31005-5-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220601080930.31005-1-linmq006@gmail.com> References: <20220601080930.31005-1-linmq006@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_011204_309737_24A66FFE X-CRM114-Status: GOOD ( 15.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_get_child_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. When kcalloc fails, it missing of_node_put() and results in refcount leak. Fix this by goto out_put_node label. Fixes: 52085d3f2028 ("irqchip/gic-v3: Dynamically allocate PPI partition descriptors") Signed-off-by: Miaoqian Lin --- drivers/irqchip/irq-gic-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 2be8dea6b6b0..1d5b4755a27e 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -1932,7 +1932,7 @@ static void __init gic_populate_ppi_partitions(struct device_node *gic_node) gic_data.ppi_descs = kcalloc(gic_data.ppi_nr, sizeof(*gic_data.ppi_descs), GFP_KERNEL); if (!gic_data.ppi_descs) - return; + goto out_put_node; nr_parts = of_get_child_count(parts_node); From patchwork Wed Jun 1 08:09:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12866484 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55CF9C433EF for ; Wed, 1 Jun 2022 08:13:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g26cwICCjpEU6ooxPOyEhz72LrR1nPdjS7btoL+ytDM=; b=GMfLFaH/6g4k1A yFzV92BoHoOSy3en/c+V0Qv7bT6JyypF7YWIUgHRMIX2GBrlqGTcHdcjTJtZgvfJo7LWXyQKj8Mhz W41zvIKQ+9GCiS+d9tEjUoRcb1pnRYXOsZOFGCyDJ/pSnPRNS0VzW2e3AgDPcN9QV37LymgptWAzp ZVt7zAW7EgzGI6x474WozDEgO2xP/TrggMTnjPe7VR3k0Zizkw3Oir4975FxbMXbiIhJc+a0putyM fGwn04EhYTeehQoWEcR63vHpxNZA2hZNVwu5yuIfB4430NR28RXsb10G1jmKTOuv4DDDLXsZL6Igu QxpxbEWkb9rzK4lKGmHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwJSz-00EY7i-Or; Wed, 01 Jun 2022 08:12:33 +0000 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwJSd-00EXwT-9W for linux-arm-kernel@lists.infradead.org; Wed, 01 Jun 2022 08:12:12 +0000 Received: by mail-pf1-x430.google.com with SMTP id 187so1269841pfu.9 for ; Wed, 01 Jun 2022 01:12:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yDHLNk2lC1y820Hnctg510Z3pMFH42mdXU5O+qRYKas=; b=arrmauLcCxQndylaqkIA9fZ0VPxT810s39+vQWP3F3WnNMGOPYnIZ3hBSdBdD3B4Ej s4prptJWPl5/vqxaSc/fUl7y70PfQACoZzJj61xE4n30EZTA4BV4Bi6r8rZ/YZOu10m5 IEZQNt7MGu79BotcQeQ/3OQzBG4QJ8dSxtfWeYoOJErGMKP2lkkn/N/yB8RJtvRUYDZ5 G181GMNlHoon+ht/Fm5HLrPRYysHkMFSa+cVNFwoaiNsnh4ZXRZhEBAyIpvUf4L4w7YP A2EWDdpUHRMH0407FM/jMRqzvQ6HA4EzsmKSWiTwENCwBvriwJau1SMYxSfaign62Kae LL0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yDHLNk2lC1y820Hnctg510Z3pMFH42mdXU5O+qRYKas=; b=2px+b6I27SaFS/TuFTcRR0NVfNTPIPKiHTO71lAp/Apss+R4uOmNie7EAY1j/tLHKx u2+g8124I+Gvhfg323VrAcQZ6QA+/X9iYOS5smaZyrzWJzix+Cv1gcorzSEwi54zkr7j B/QLHm/mOgvclo0+sbG36Rc0UOMXuT8pTNpDoZvXUxoVi259XQLtbuw7Jz57geYNlIhF nP7IRWgi8ZD9CTwNTZ5xddMAcCVhtmdAy5dJP72ZYiHnecDeO/fnDhPUquxsUynfB73I UMWigMKIhGWtz1CxOo/k7yE5nifPNvZ1Hx3jEB5gvLG+9vU1DQqbxnBIw78JtLqU5PZa 3auQ== X-Gm-Message-State: AOAM531thpyqCYAD3ddcZXAjHU5m2AMe+3U1AgIb1tgCG4A6ni/oNDQV RKJRXnqTtGs6HXyjjLr4e/s= X-Google-Smtp-Source: ABdhPJw4BidUZQTAmV3LJkHDKE7X1qt6fzaWbucahjUCngpbzdX11O/YdU3Uf72mxrMRfIb6Tt5WQA== X-Received: by 2002:a63:69c5:0:b0:3fb:a606:819a with SMTP id e188-20020a6369c5000000b003fba606819amr22251860pgc.81.1654071126469; Wed, 01 Jun 2022 01:12:06 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id y1-20020a17090ad0c100b001e2f3831102sm792288pjw.17.2022.06.01.01.12.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 01:12:05 -0700 (PDT) From: Miaoqian Lin To: Hector Martin , Sven Peter , Alyssa Rosenzweig , Thomas Gleixner , Marc Zyngier , Linus Walleij , Birger Koblitz , John Crispin , Bert Vermeulen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Miaoqian Lin Subject: [PATCH 5/6] irqchip/gic-v3: Fix refcount leak in gic_populate_ppi_partitions Date: Wed, 1 Jun 2022 12:09:29 +0400 Message-Id: <20220601080930.31005-6-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220601080930.31005-1-linmq006@gmail.com> References: <20220601080930.31005-1-linmq006@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_011211_377014_2E991819 X-CRM114-Status: GOOD ( 15.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_node_by_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: e3825ba1af3a ("irqchip/gic-v3: Add support for partitioned PPIs") Signed-off-by: Miaoqian Lin --- drivers/irqchip/irq-gic-v3.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 1d5b4755a27e..5c1cf907ee68 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -1973,12 +1973,15 @@ static void __init gic_populate_ppi_partitions(struct device_node *gic_node) continue; cpu = of_cpu_node_to_id(cpu_node); - if (WARN_ON(cpu < 0)) + if (WARN_ON(cpu < 0)) { + of_node_put(cpu_node); continue; + } pr_cont("%pOF[%d] ", cpu_node, cpu); cpumask_set_cpu(cpu, &part->mask); + of_node_put(cpu_node); } pr_cont("}\n"); From patchwork Wed Jun 1 08:09:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12866485 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 970AAC433EF for ; Wed, 1 Jun 2022 08:14:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bB+tWLQDbyRKCqlUiRWxosm8m1mket5RBco8xP/ZPbw=; b=i+230eef57sZTm ZumMXVLAsHigY/Ebw6TFk03sN331KvVBWcPUR7W148avmwUG4zQXwUKUlXaWWQrKulUWcFGhvAiNS pyZmDAwcUI48tO89mT2nv0kASLW+0fCHLj6LXlzZlRYRXQkHawr/bQSxyNpvHSGAXh1Qy0RhzjYHJ ZrV7AJtxiItXMnKDfqhQchPvF6pX3we4HtYUydPX9tld3cJQJ3ro7AS1sbNVmbWGW6rhZ6RgZQOmv rBjhhwYKbgBo0NKCPOPAZUvMzJINecVCDkXPU7S9cND8VxNFiX+dq5rlRL++DkkNs+05hsy36SlSC MT7a2f9ID0C14RChbBPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwJTJ-00EYGK-NZ; Wed, 01 Jun 2022 08:12:54 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwJSi-00EXzD-N3 for linux-arm-kernel@lists.infradead.org; Wed, 01 Jun 2022 08:12:18 +0000 Received: by mail-pl1-x632.google.com with SMTP id u18so1098248plb.3 for ; Wed, 01 Jun 2022 01:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m+PEPLe6RgZ/co/uaiAinJBginVPw5Z9zDkizQywe5E=; b=km40SlpgsEcHZucZJOMM58TzoKmps1pvbmNm/0yqRjeCUeLKj6NHUZPPOJQisuxz+I rs9cx7BB0u1eIYLzMLL1UwKxI0Z7njWVlGW+l2GnEWZ0T3MqpChFsOrCE9YptV3SEEfa 6DKzWT5fd28uC8AzWz1kf+D9xlXYwJrVccOcbMlq3jyROjBzntUh3sOefIJsygyrUO0I HElvR9jNp87t4Sw/+ZXDV4uI8+LT+E0qJqg60uNna25YcqOMbWe42urRnYoq1YsFJ8J2 gGsPMeV37dd5rwRKh7ei0ghgmWKcFyfBshDxi2utkBoGqs747Wp1vPlo+3fqw7StAVIq 3bJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m+PEPLe6RgZ/co/uaiAinJBginVPw5Z9zDkizQywe5E=; b=Mgn/3UZSPYMgS7yi+498j86a+MgKyzRzSIqng0HZbHPuleu5OCOZoLP4udXV+Ensb9 EjwwLpbSRVft0ySliU8AEK//i5x56Sq84rPWUBy1EZ6Ca6HlSpEDfR5lUiea455QTKvR C2h0lWlrGieD/tyG4YDBEOy/HJ59lOpT+OSU5irGJa2jq4HbmL+HQw46MRQqOj34CWCQ HJb2wgOZclNCxMoAAQKgDttZ+w490dsUFyi5R5ympxbeCL20JyVHod+7AJwBNfkuagWP pT9g7ey5xCRFgkohMVw20BM4dadkAamliVtqh8O1Owd42GtoZWgyTTU96Io+flefbO18 Jamw== X-Gm-Message-State: AOAM530jxMm9+l2qjjNfI9DH48SpiqM9FsOjSfMdl6Qw8eihSYEcOSrK S2cO6RoYVow8vx8VRTvKco4= X-Google-Smtp-Source: ABdhPJwFrVaDOS+yHOraldAu8p/JQBxp84sZBopNyIVCcUoYq2dXh8kiVGYqtM8BBG6ywJ4n/pN6Kw== X-Received: by 2002:a17:903:124a:b0:154:c7a4:9374 with SMTP id u10-20020a170903124a00b00154c7a49374mr65595986plh.68.1654071133567; Wed, 01 Jun 2022 01:12:13 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id y1-20020a17090ad0c100b001e2f3831102sm792288pjw.17.2022.06.01.01.12.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 01:12:13 -0700 (PDT) From: Miaoqian Lin To: Hector Martin , Sven Peter , Alyssa Rosenzweig , Thomas Gleixner , Marc Zyngier , Linus Walleij , John Crispin , Bert Vermeulen , Birger Koblitz , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Miaoqian Lin Subject: [PATCH 6/6] irqchip/realtek-rtl: Fix refcount leak in map_interrupts Date: Wed, 1 Jun 2022 12:09:30 +0400 Message-Id: <20220601080930.31005-7-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220601080930.31005-1-linmq006@gmail.com> References: <20220601080930.31005-1-linmq006@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_011216_802848_0A2E46C5 X-CRM114-Status: GOOD ( 15.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_node_by_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. This function doesn't call of_node_put() in error path. Call of_node_put() directly after of_property_read_u32() to cover both normal path and error path. Fixes: 9f3a0f34b84a ("irqchip: Add support for Realtek RTL838x/RTL839x interrupt controller") Signed-off-by: Miaoqian Lin --- drivers/irqchip/irq-realtek-rtl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-realtek-rtl.c b/drivers/irqchip/irq-realtek-rtl.c index 50a56820c99b..56bf502d9c67 100644 --- a/drivers/irqchip/irq-realtek-rtl.c +++ b/drivers/irqchip/irq-realtek-rtl.c @@ -134,9 +134,9 @@ static int __init map_interrupts(struct device_node *node, struct irq_domain *do if (!cpu_ictl) return -EINVAL; ret = of_property_read_u32(cpu_ictl, "#interrupt-cells", &tmp); + of_node_put(cpu_ictl); if (ret || tmp != 1) return -EINVAL; - of_node_put(cpu_ictl); cpu_int = be32_to_cpup(imap + 2); if (cpu_int > 7 || cpu_int < 2)