From patchwork Fri Jun 3 14:12:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12869128 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 375F7C43334 for ; Fri, 3 Jun 2022 14:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=LdpcTrMPwnW2T08GFzmNpgbC2gsVegFiI+QN79S27w4=; b=NwtmzQtg4H+HnU //Bf+d2ndz2/SlZdKlIVyeS2BeGZEDIc/7pc9sFM7643D6QAreGpwBybYP2SfxdUW/I1NZzXwzmjr 2PXQ1Q8AU37QuRnBuKLSSyM5A2eGyVxrZBpSWskbxb6dUCzH3w81ax+qbWwj551CIXR86+T7MbTsR SuzWVw1hBMqEGfNkby+Ew3IXLlbQq8x20+3XeeVa5m3oYSOTX6oN6drvEThaYp4DrNbAfIsHT+4nR K/SaGKt/yWb7mmF17OxyZ0XZwoz/JTMGN4n+Wk4aIiRlQ7vj8FeULhxG6Si65nGSYPTh/2MUMln0K AbYLR8ztLoK4X2+EqE9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nx82f-007fOa-Ve; Fri, 03 Jun 2022 14:12:46 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nx82d-007fNA-2o for linux-arm-kernel@lists.infradead.org; Fri, 03 Jun 2022 14:12:44 +0000 Received: by mail-pj1-x1029.google.com with SMTP id q12-20020a17090a304c00b001e2d4fb0eb4so12145154pjl.4 for ; Fri, 03 Jun 2022 07:12:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AQ10zYcRBw5WaFdheuLXgUA9xdtkMVpnXoJErK9bTIg=; b=UMVzcVtb+3Z2wU0z6hHwpYX7UN2nVww6/sPmspOqL46hQ4vBX8lmCa1JcaFLdaZGIg CVAT+G22yBUe5HYrYZMCVTiMxnT1zBscvh7n8+IPenj3FjFhe6W+w9AdACJB21ufgge+ K0cUW4vlQTYjRsG1RVoFzIn/VfhUZybGCxhvQQMD3NP3NZVkkZXh4IMzZy4NH9V4Q3DC BSfrKdbfkinvzbhA6n/0jqc7DlKf+WNhse7Sml80d+iQRQ1euHkM/l214UHW5HeFTrmB jPeX4O5ZBWs815r1875FgnbuoPYwLaSDWwqB1unFJwAHITiWYclc8bOKZv01juPxPWM9 V5Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AQ10zYcRBw5WaFdheuLXgUA9xdtkMVpnXoJErK9bTIg=; b=Uu/Tex34IY8tePofESiQHpBV7ryiSHEiK5hi2QA7vsJBf0DCybH0yHuZMcXGh+QtRD AYwE/FU4/ZPqgVJhhZIj3yMPBQqzGcxkf+msXFIfnvibChmqS+2oOfqAuJ+AmkbgMDOX qqAcjRhJ1UJ+EjHIhH6O8rxOW4IETJyCEwxmn9nqfEhh+HLvw7E1qD/0og3Paj8LhUOh vfSQZ4E1Ojdm6OktshY6Vj7yGFYQGZKkfdpuXIx+pKpmepWuxxNBF/cLUu/jfW31jj37 +ksKFQbsb/cSQeuqNZbt/HXeeDx32+o++g0Fj6feM07918QimmDM2oMHIQRzvv8X9Ydi qCwg== X-Gm-Message-State: AOAM533OUNR/FyuvCwkcKzsb5KJKaz3Z75ioSegLH2Kk67Ru/JYD3b7p L201yOz9et+qRQeEr0lWVlo= X-Google-Smtp-Source: ABdhPJywRw39nosBa2BdbHpD4jnRfnjqPoofU9FiYlyhxmebM9me3u2Bd0XzV0wheQS1+ffp9LkGMw== X-Received: by 2002:a17:90b:314a:b0:1e6:826e:73b2 with SMTP id ip10-20020a17090b314a00b001e6826e73b2mr10318647pjb.239.1654265560240; Fri, 03 Jun 2022 07:12:40 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id 13-20020a170902c20d00b0015e8d4eb2adsm5403360pll.247.2022.06.03.07.12.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jun 2022 07:12:39 -0700 (PDT) From: Miaoqian Lin To: Vladimir Zapolskiy , Alan Stern , Greg Kroah-Hartman , Roland Stigge , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] usb: ohci-nxp: Fix refcount leak in ohci_hcd_nxp_probe Date: Fri, 3 Jun 2022 18:12:30 +0400 Message-Id: <20220603141231.979-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220603_071243_161712_B2139ECB X-CRM114-Status: GOOD ( 12.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 73108aa90cbf ("USB: ohci-nxp: Use isp1301 driver") Signed-off-by: Miaoqian Lin Acked-by: Alan Stern --- drivers/usb/host/ohci-nxp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c index 85878e8ad331..106a6bcefb08 100644 --- a/drivers/usb/host/ohci-nxp.c +++ b/drivers/usb/host/ohci-nxp.c @@ -164,6 +164,7 @@ static int ohci_hcd_nxp_probe(struct platform_device *pdev) } isp1301_i2c_client = isp1301_get_client(isp1301_node); + of_node_put(isp1301_node); if (!isp1301_i2c_client) return -EPROBE_DEFER;