From patchwork Wed Aug 8 08:56:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hangbin Liu X-Patchwork-Id: 10559653 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 40E831390 for ; Wed, 8 Aug 2018 08:57:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2F5C62A9A1 for ; Wed, 8 Aug 2018 08:57:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 23B432A9A9; Wed, 8 Aug 2018 08:57:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from bastion.fedoraproject.org (bastion01.fedoraproject.org [209.132.181.2]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8B5782A9A1 for ; Wed, 8 Aug 2018 08:57:23 +0000 (UTC) Received: from mailman01.phx2.fedoraproject.org (mailman01.phx2.fedoraproject.org [10.5.126.36]) by bastion01.phx2.fedoraproject.org (Postfix) with ESMTP id BA3F6609379F; Wed, 8 Aug 2018 08:57:22 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 bastion01.phx2.fedoraproject.org BA3F6609379F Received: from mailman01.phx2.fedoraproject.org (localhost [IPv6:::1]) by mailman01.phx2.fedoraproject.org (Postfix) with ESMTP id AE6A02211970A; Wed, 8 Aug 2018 08:57:22 +0000 (UTC) Received: by mailman01.phx2.fedoraproject.org (Postfix, from userid 991) id 107C42211970A; Wed, 8 Aug 2018 08:57:19 +0000 (UTC) Received: from smtp-mm-osuosl01.fedoraproject.org (smtp-mm-osuosl01.vpn.fedoraproject.org [192.168.1.23]) by mailman01.phx2.fedoraproject.org (Postfix) with ESMTP id 03A40221196E0 for ; Wed, 8 Aug 2018 08:57:18 +0000 (UTC) Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by smtp-mm-osuosl01.fedoraproject.org (Postfix) with ESMTPS id 9777898069 for ; Wed, 8 Aug 2018 08:57:17 +0000 (UTC) Received: by mail-pg1-x541.google.com with SMTP id h12-v6so786729pgs.3 for ; Wed, 08 Aug 2018 01:57:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1++9g0tVqTZP1yQINWOmOs0HzIXAoECVMbb9QhmNsl8=; b=FReW0gkXaQ6hfTHNAPWjZtpx7SfDlsyMV2VSGBAxMb6bBay3Sv0/i74hFXOAY09fl3 LbHcRSv6aGrltcHBIaA0jM+4ijsat9cq33+rPJOKqosEnCsih/TN7ha6IkybwBxA0G+a Aa4dRGVWJARlU5Z2beba1gm6+JXajt2WcTJUUkNkPo+R9uYyAVzUtUiF5dhWxm6R5lwl U7Zptxb1EdifCna974GQPoqhUIKqjARokCG+QYkOWlQ7sFLE42ANjHYX0gqSQ5mWv3m9 uPC9A+8jS/1Id4ARhGl6dm5qsCSepXuSKiI5a2kLY25sJSeljOYnhf7DdMYmt3StllNc gBRA== X-Gm-Message-State: AOUpUlHy/rpbQULlTwVHlwFEYa/cx944vXn9NeT29nR39a+OUo1DRf3a nM408oIWgGljmdOOAUzIDdSBgRdW X-Google-Smtp-Source: AA+uWPwVhseHowxUx2Kx9yyIrZNnBTmrURqfLXU8dguj7d6LuSBdA/g7WWFebsK2pics7RT+MJIlEA== X-Received: by 2002:a63:e811:: with SMTP id s17-v6mr1662644pgh.176.1533718633746; Wed, 08 Aug 2018 01:57:13 -0700 (PDT) Received: from leo.usersys.redhat.com ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id u83-v6sm12883856pfj.37.2018.08.08.01.57.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Aug 2018 01:57:12 -0700 (PDT) From: Hangbin Liu To: libteam@lists.fedorahosted.org Subject: [PATCHv3] teamd: add port_master_ifindex_changed for teamd_event_watch_ops Date: Wed, 8 Aug 2018 16:56:52 +0800 Message-Id: <1533718612-20619-1-git-send-email-liuhangbin@gmail.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1533278629-26147-1-git-send-email-liuhangbin@gmail.com> References: <1533278629-26147-1-git-send-email-liuhangbin@gmail.com> Message-ID-Hash: NZGPQQRM3MWRGDZDGTDBP2PHVSHYIDGW X-Message-ID-Hash: NZGPQQRM3MWRGDZDGTDBP2PHVSHYIDGW X-MailFrom: liuhangbin@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Jiri Pirko , Jamie Bainbridge , Hangbin Liu X-Mailman-Version: 3.1.1 Precedence: list List-Id: Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Virus-Scanned: ClamAV using ClamSMTP When we add port to new active-backup teams with multi threads. After the port is set to link up and trigger function obj_input_newlink(), it's possible that there is no master index in rtnl link info. So the team slave's master_ifindex is not updated. On the other hand, the port is up and trigger functions like - teamd_link_watch_check_link_up() - teamd_event_port_link_changed() - ab_event_watch_port_link_changed() - ab_link_watch_handler() - teamd_for_each_tdport() - teamd_get_next_tdport() - teamd_port_present() Here the teamd_port_present() failed as the port master ifindex is not update to team ifindex yet. Finally we get nothing and no active port is set. Here is the reproducer: \#bin/bash if [ -z $1 ] || [ -z $2 ]; then echo "Usage: $0 iface1 iface2" exit 1 else iface1=$1 iface2=$2 fi WAIT=2 COUNT=0 start_team() { local num=$1 local iface=$2 teamd -o -n -U -d -t team$num -c '{"runner": {"name": "activebackup"},"link_watch": {"name": "ethtool"}}' -gg teamdctl team$num port add $iface } while :; do echo "-----------------------------------------------------------" let "COUNT++" echo "Loop $COUNT" teamd -k -t team1 teamd -k -t team2 sleep "$WAIT" start_team 1 $iface1 & start_team 2 $iface2 & sleep "$WAIT" if teamdctl team1 state | grep -q "active port: $iface1" && \ teamdctl team2 state | grep -q "active port: $iface2"; then echo "Pass" else echo "FAIL" exit 1 fi done Failure as follows: ]# teamdctl teamX state dump "runner": { "active_port": "" }, Currently we only reproduced this with active-backup mode(I could reproduce it in VM easily, but hard to reproduce it on physical machines). Fix it by adding a new teamd_event_watch_ops port_master_ifindex_changed for active-backup mode. V2: update commit description from Jamie Bainbridge's reply. v3: update description and reproducer. Signed-off-by: Hangbin Liu --- teamd/teamd.h | 5 +++++ teamd/teamd_events.c | 19 +++++++++++++++++++ teamd/teamd_ifinfo_watch.c | 5 +++++ teamd/teamd_runner_activebackup.c | 8 ++++++++ 4 files changed, 37 insertions(+) diff --git a/teamd/teamd.h b/teamd/teamd.h index 5dbfb9b..3934fc2 100644 --- a/teamd/teamd.h +++ b/teamd/teamd.h @@ -189,6 +189,9 @@ struct teamd_event_watch_ops { struct teamd_port *tdport, void *priv); int (*port_ifname_changed)(struct teamd_context *ctx, struct teamd_port *tdport, void *priv); + int (*port_master_ifindex_changed)(struct teamd_context *ctx, + struct teamd_port *tdport, + void *priv); int (*option_changed)(struct teamd_context *ctx, struct team_option *option, void *priv); char *option_changed_match_name; @@ -208,6 +211,8 @@ int teamd_event_ifinfo_hwaddr_changed(struct teamd_context *ctx, struct team_ifinfo *ifinfo); int teamd_event_ifinfo_ifname_changed(struct teamd_context *ctx, struct team_ifinfo *ifinfo); +int teamd_event_ifinfo_master_ifindex_changed(struct teamd_context *ctx, + struct team_ifinfo *ifinfo); int teamd_event_ifinfo_admin_state_changed(struct teamd_context *ctx, struct team_ifinfo *ifinfo); int teamd_events_init(struct teamd_context *ctx); diff --git a/teamd/teamd_events.c b/teamd/teamd_events.c index 1a95974..65aa46a 100644 --- a/teamd/teamd_events.c +++ b/teamd/teamd_events.c @@ -167,6 +167,25 @@ int teamd_event_ifinfo_ifname_changed(struct teamd_context *ctx, return 0; } +int teamd_event_ifinfo_master_ifindex_changed(struct teamd_context *ctx, + struct team_ifinfo *ifinfo) +{ + struct event_watch_item *watch; + uint32_t ifindex = team_get_ifinfo_ifindex(ifinfo); + struct teamd_port *tdport = teamd_get_port(ctx, ifindex); + int err; + + list_for_each_node_entry(watch, &ctx->event_watch_list, list) { + if (watch->ops->port_master_ifindex_changed && tdport) { + err = watch->ops->port_master_ifindex_changed(ctx, tdport, + watch->priv); + if (err) + return err; + } + } + return 0; +} + int teamd_event_ifinfo_admin_state_changed(struct teamd_context *ctx, struct team_ifinfo *ifinfo) { diff --git a/teamd/teamd_ifinfo_watch.c b/teamd/teamd_ifinfo_watch.c index f334ff6..6a19532 100644 --- a/teamd/teamd_ifinfo_watch.c +++ b/teamd/teamd_ifinfo_watch.c @@ -59,6 +59,11 @@ static int ifinfo_change_handler_func(struct team_handle *th, void *priv, if (err) return err; } + if (team_is_ifinfo_master_ifindex_changed(ifinfo)) { + err = teamd_event_ifinfo_master_ifindex_changed(ctx, ifinfo); + if (err) + return err; + } } return 0; } diff --git a/teamd/teamd_runner_activebackup.c b/teamd/teamd_runner_activebackup.c index 8a3447f..f92d341 100644 --- a/teamd/teamd_runner_activebackup.c +++ b/teamd/teamd_runner_activebackup.c @@ -520,6 +520,13 @@ static int ab_event_watch_port_link_changed(struct teamd_context *ctx, return ab_link_watch_handler(ctx, priv); } +static int ab_event_watch_port_master_ifindex_changed(struct teamd_context *ctx, + struct teamd_port *tdport, + void *priv) +{ + return ab_link_watch_handler(ctx, priv); +} + static int ab_event_watch_prio_option_changed(struct teamd_context *ctx, struct team_option *option, void *priv) @@ -532,6 +539,7 @@ static const struct teamd_event_watch_ops ab_event_watch_ops = { .port_hwaddr_changed = ab_event_watch_port_hwaddr_changed, .port_added = ab_event_watch_port_added, .port_link_changed = ab_event_watch_port_link_changed, + .port_master_ifindex_changed = ab_event_watch_port_master_ifindex_changed, .option_changed = ab_event_watch_prio_option_changed, .option_changed_match_name = "priority", };