From patchwork Fri Jun 10 21:12:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 12878108 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E766C433EF for ; Fri, 10 Jun 2022 21:13:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350878AbiFJVNf (ORCPT ); Fri, 10 Jun 2022 17:13:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350876AbiFJVNV (ORCPT ); Fri, 10 Jun 2022 17:13:21 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7824821AC for ; Fri, 10 Jun 2022 14:13:19 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzlwP-0007EQ-A1; Fri, 10 Jun 2022 23:13:13 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nzlwL-007eRR-K2; Fri, 10 Jun 2022 23:13:08 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nzlwJ-00FTci-D7; Fri, 10 Jun 2022 23:13:07 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Jaehoon Chung , Ulf Hansson , Krzysztof Kozlowski Cc: kernel@pengutronix.de, Alim Akhtar , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] mmc: dw_mmc: exynos: Obviously always return success in remove callback Date: Fri, 10 Jun 2022 23:12:53 +0200 Message-Id: <20220610211257.102071-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1171; h=from:subject; bh=BRwj7xwGwlRzPBbTfi1y6IsL5WQeCl3kon3cuPiA4x8=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBio7PFmJ2wmL2gWS1HcC1y6c3VYDRsXBzbViHOxx0m f/APl0eJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCYqOzxQAKCRDB/BR4rcrsCcIOB/ 9jMfHMsc6Uy0I1iYhcfcv3qVW6zLOx71pr6WjFWokedg82aakk2yg6YD3SYFm0peyZ3gvIoYceuyH6 q4u5fIa6CzL1iORfXmFd4DHJIaOWQZ604o54ZGUdJFv7kcWdKjd7tiLHreOrmRG+mwxvZsZL5u+pp1 RNsxOckrqNwdHEPjTg6yqunaUBwrZ+ruzOM2eDn7lxiczsaUuDVkrTAh0zP/kaEnTVpXxAy0oyl2Fz FvGHFh6B0BuQgZxP/eaxEtK5MCHaegv9wYnzBOSgvBjTBVuyyL8vjBWd0Eql9rloW3UusMJBSJGF8T Hj96drPuyQMmqsOwW4YUsjVn2aPM0f X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mmc@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org dw_mci_pltfm_remove() returns 0 unconditionally and returning an error in a platform remove callback isn't very sensible. (The only effect of the latter is that the device core emits a generic warning and then removes the device anyhow.) So return 0 unconditionally to make it obvious there is no error forwarded to the upper layers. This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König --- drivers/mmc/host/dw_mmc-exynos.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56 diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c index ca5be4445ae0..9f20ac524c8b 100644 --- a/drivers/mmc/host/dw_mmc-exynos.c +++ b/drivers/mmc/host/dw_mmc-exynos.c @@ -670,7 +670,9 @@ static int dw_mci_exynos_remove(struct platform_device *pdev) pm_runtime_set_suspended(&pdev->dev); pm_runtime_put_noidle(&pdev->dev); - return dw_mci_pltfm_remove(pdev); + dw_mci_pltfm_remove(pdev); + + return 0; } static const struct dev_pm_ops dw_mci_exynos_pmops = { From patchwork Fri Jun 10 21:12:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 12878104 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C6ECC433EF for ; Fri, 10 Jun 2022 21:13:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348750AbiFJVNc (ORCPT ); Fri, 10 Jun 2022 17:13:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350839AbiFJVNS (ORCPT ); Fri, 10 Jun 2022 17:13:18 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 000D938B2 for ; Fri, 10 Jun 2022 14:13:16 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzlwP-0007ER-A1; Fri, 10 Jun 2022 23:13:13 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nzlwL-007eRT-Kl; Fri, 10 Jun 2022 23:13:08 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nzlwJ-00FTcl-JW; Fri, 10 Jun 2022 23:13:07 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Jaehoon Chung , Ulf Hansson Cc: kernel@pengutronix.de, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/5] mmc: dw_mmc: hi3789cv200: Obviously always return success in remove callback Date: Fri, 10 Jun 2022 23:12:54 +0200 Message-Id: <20220610211257.102071-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220610211257.102071-1-u.kleine-koenig@pengutronix.de> References: <20220610211257.102071-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1161; h=from:subject; bh=viNGkUvqfRnsE+HfCQ1CcM0mjXBb4xEa/v9l9EqPujE=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBio7PJor4jUz6P2o8yDT2w2Hh3DDuDDinpPHs5VxyS RyGv8HWJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCYqOzyQAKCRDB/BR4rcrsCXU1CA CN7Uwlar/bp45saE9xZ1+7fRHeDjz+HEiYwy4slkyCiavvs6H9oYugz/gvptadLy5rRAoRNAabMRCJ dvrpOwe9P1KU2y5bxX1N3u1o5AXCW5yIcQOI9FP+U4L6Ja0w0c4ciD7Kjrg21/38hahFA4Jax8+R32 f+v5KvgUY+2NYhediqPzH62pzzJKO0ZJFnsLcdK32UTXvmY8qZu0Cjv4inXtO9bsQjgEc6ykdoMNAw xMMGe9lMcIhYkRIfQtVLzDBcWAXLd86p4khn51qUzXEITCW6Q0d44KgywsAOlmrZmZw1ZZH+UeW0iu 6tB1vY9sSKWSc2Y39tffTexarJ0L00 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mmc@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org dw_mci_pltfm_remove() returns 0 unconditionally and returning an error in a platform remove callback isn't very sensible. (The only effect of the latter is that the device core emits a generic warning and then removes the device anyhow.) So return 0 unconditionally to make it obvious there is no error forwarded to the upper layers. This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König --- drivers/mmc/host/dw_mmc-hi3798cv200.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/dw_mmc-hi3798cv200.c b/drivers/mmc/host/dw_mmc-hi3798cv200.c index e9437ef8ef19..6f22fe054087 100644 --- a/drivers/mmc/host/dw_mmc-hi3798cv200.c +++ b/drivers/mmc/host/dw_mmc-hi3798cv200.c @@ -179,7 +179,9 @@ static int dw_mci_hi3798cv200_remove(struct platform_device *pdev) clk_disable_unprepare(priv->drive_clk); clk_disable_unprepare(priv->sample_clk); - return dw_mci_pltfm_remove(pdev); + dw_mci_pltfm_remove(pdev); + + return 0; } static const struct of_device_id dw_mci_hi3798cv200_match[] = { From patchwork Fri Jun 10 21:12:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 12878106 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DF2CCCA47F for ; Fri, 10 Jun 2022 21:13:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350870AbiFJVNf (ORCPT ); Fri, 10 Jun 2022 17:13:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350875AbiFJVNV (ORCPT ); Fri, 10 Jun 2022 17:13:21 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B82DBC78 for ; Fri, 10 Jun 2022 14:13:19 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzlwP-0007ES-Kg; Fri, 10 Jun 2022 23:13:13 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nzlwM-007eRZ-0b; Fri, 10 Jun 2022 23:13:08 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nzlwJ-00FTco-PH; Fri, 10 Jun 2022 23:13:07 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Jaehoon Chung , Ulf Hansson , Heiko Stuebner Cc: kernel@pengutronix.de, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] mmc: dw_mmc: rockchip: Obviously always return success in remove callback Date: Fri, 10 Jun 2022 23:12:55 +0200 Message-Id: <20220610211257.102071-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220610211257.102071-1-u.kleine-koenig@pengutronix.de> References: <20220610211257.102071-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1127; h=from:subject; bh=X7sBJEOoF/EYAe4rLWNuktAtosW9B7BT2XqynC8bowU=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBio7PMozMORTXicDL+cWiZL0+Ts8EeeJIr5sgKtzDj DWI0AU+JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCYqOzzAAKCRDB/BR4rcrsCbr8B/ 4ww4MPsxCrFYZhS1rElYQwerv5C4lY5BjWqgaBlcfsraeppQaP3NeMAtMU8YGxvP9lldcNhQqsg1Zg B57X+QdbcI2rv0HmXmMqmYWkX/UM0RYx7I/Y5r5qSwKQMPOBqOfO3029045FWVIadBfGBdGbgBdLww +CjUaCrqJ+vLzDc82IF03Q/704NBHMBwhClKK2XoSsKWamtnzlwTbYMI3oY+S0qHlKCQMCg5W7gWUp XnWLvmw1JBRu7Peru8eGNWTfilc6Yn3PP5tb5CBDkPZfLx0DKjOmskOSAbXHfA+gd9yU3RInfwlTfK bsO36Y+eUJ1xkr3eY5zxqU2HvakH99 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mmc@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org dw_mci_pltfm_remove() returns 0 unconditionally and returning an error in a platform remove callback isn't very sensible. (The only effect of the latter is that the device core emits a generic warning and then removes the device anyhow.) So return 0 unconditionally to make it obvious there is no error forwarded to the upper layers. This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König --- drivers/mmc/host/dw_mmc-rockchip.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c index f825487aa739..2a99f15f527f 100644 --- a/drivers/mmc/host/dw_mmc-rockchip.c +++ b/drivers/mmc/host/dw_mmc-rockchip.c @@ -377,7 +377,9 @@ static int dw_mci_rockchip_remove(struct platform_device *pdev) pm_runtime_disable(&pdev->dev); pm_runtime_put_noidle(&pdev->dev); - return dw_mci_pltfm_remove(pdev); + dw_mci_pltfm_remove(pdev); + + return 0; } static const struct dev_pm_ops dw_mci_rockchip_dev_pm_ops = { From patchwork Fri Jun 10 21:12:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 12878105 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86649CCA47B for ; Fri, 10 Jun 2022 21:13:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350839AbiFJVNe (ORCPT ); Fri, 10 Jun 2022 17:13:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350871AbiFJVNU (ORCPT ); Fri, 10 Jun 2022 17:13:20 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A75C616F for ; Fri, 10 Jun 2022 14:13:18 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzlwM-0007ET-Sn; Fri, 10 Jun 2022 23:13:10 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nzlwM-007eRc-2V; Fri, 10 Jun 2022 23:13:08 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nzlwJ-00FTcr-VC; Fri, 10 Jun 2022 23:13:07 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Michal Simek , Adrian Hunter , Ulf Hansson Cc: kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/5] mmc: sdhci-of-arasan: Obviously always return success in remove callback Date: Fri, 10 Jun 2022 23:12:56 +0200 Message-Id: <20220610211257.102071-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220610211257.102071-1-u.kleine-koenig@pengutronix.de> References: <20220610211257.102071-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1514; h=from:subject; bh=4mF/yvCZvZim6IRItQzqfJKbygUWPODGaWd7tQugb+k=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBio7PPNwF0ygfJn1htE00Mxq3NiXsl6zlx8wuX0cxJ eectjlyJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCYqOzzwAKCRDB/BR4rcrsCerCB/ 9+OmMxyxw27OjkgnbafMBIpF1tlL2OY2CljwjkaAYQyqpdm0oIKu1hHws6bGk/SmoDmhqWCa0aA5ek R2t74vDmN9NG3zhEEzWLoqTO++Qu4c4Y63Lj1i8mvX7Ktcq9Rmd513dPQD71ab+DrNX0iv6SvoCAaA Zqfna43Z8WBWc/wXXci61EtpgBUmtc/dZZzwcnAd6KUQcKTILnGN16NS9vI6tLcy0hYrts8k24e1AK yuRSMF+Ta1Ys/hUD98/z7xRHXL4ACmyfWLA/8QDUH9ZE82fgRWpmJynkb64owHbRdUIPBjegsMPFlY gCSTYby5QTn4WgcLZZ+mwc5RlF0R73 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mmc@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org sdhci_pltfm_unregister() returns 0 unconditionally and returning an error in a platform remove callback isn't very sensible. (The only effect of the latter is that the device core emits a generic warning and then removes the device anyhow.) So return 0 unconditionally to make it obvious there is no error forwarded to the upper layers. This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-of-arasan.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index 757801dfc308..3997cad1f793 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -1733,7 +1733,6 @@ static int sdhci_arasan_probe(struct platform_device *pdev) static int sdhci_arasan_remove(struct platform_device *pdev) { - int ret; struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); struct sdhci_arasan_data *sdhci_arasan = sdhci_pltfm_priv(pltfm_host); @@ -1747,11 +1746,11 @@ static int sdhci_arasan_remove(struct platform_device *pdev) sdhci_arasan_unregister_sdclk(&pdev->dev); - ret = sdhci_pltfm_unregister(pdev); + sdhci_pltfm_unregister(pdev); clk_disable_unprepare(clk_ahb); - return ret; + return 0; } static struct platform_driver sdhci_arasan_driver = { From patchwork Fri Jun 10 21:12:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 12878107 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF1B8CCA480 for ; Fri, 10 Jun 2022 21:13:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350876AbiFJVNg (ORCPT ); Fri, 10 Jun 2022 17:13:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350883AbiFJVNX (ORCPT ); Fri, 10 Jun 2022 17:13:23 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D7C61139 for ; Fri, 10 Jun 2022 14:13:22 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzlwQ-0007EU-Lr; Fri, 10 Jun 2022 23:13:14 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nzlwM-007eRf-Ef; Fri, 10 Jun 2022 23:13:09 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nzlwK-00FTcu-57; Fri, 10 Jun 2022 23:13:08 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Adrian Hunter , Patrice Chotard , Ulf Hansson Cc: kernel@pengutronix.de, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/5] mmc: sdhci-st: Obviously always return success in remove callback Date: Fri, 10 Jun 2022 23:12:57 +0200 Message-Id: <20220610211257.102071-5-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220610211257.102071-1-u.kleine-koenig@pengutronix.de> References: <20220610211257.102071-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1264; h=from:subject; bh=sBfylUDn+YAcBJHwK5z2IulY8PCwOzF75hj/D976Zfo=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBio7PSDbPU5yZFpswOW+XYImggSvAQ/6ay2hPvdKMD v9/xSr+JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCYqOz0gAKCRDB/BR4rcrsCQBYB/ 9N7hpY3gM34f4oA9rrTOYJQUqg9o4V6U3/FzJtvrFGQWTs4oWbFiPLlXhnvx1Kb8ME8V3qnomET9q3 yGJwwl36xMvqiatk9VxSWEZUR8IJbONsirNukvhbmjVqo9P8CfnMwnI9DjbsnFfue5krFJU+O2z6om eiOLBX0lW0Lew8Yfs0LlqwVafAExsQPAP/1uOmGICCUB/geijfwkTtbRSYv9jZ8lp58ED9JlDE+qC8 nzGLAKbd8d7pW6nhV3qYwJGWrPK4pqgV7IJgsf11Juxxup2CA7kgT8PdFvnMvq8afGQGA5fg5A+xTf JQJZ3ey9+7sx3dabCuEEdnehcCjaUp X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mmc@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org sdhci_pltfm_unregister() returns 0 unconditionally and returning an error in a platform remove callback isn't very sensible. (The only effect of the latter is that the device core emits a generic warning and then removes the device anyhow.) So return 0 unconditionally to make it obvious there is no error forwarded to the upper layers. This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-st.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c index d41582c21aa3..6415916fbd91 100644 --- a/drivers/mmc/host/sdhci-st.c +++ b/drivers/mmc/host/sdhci-st.c @@ -440,15 +440,14 @@ static int sdhci_st_remove(struct platform_device *pdev) struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); struct st_mmc_platform_data *pdata = sdhci_pltfm_priv(pltfm_host); struct reset_control *rstc = pdata->rstc; - int ret; - ret = sdhci_pltfm_unregister(pdev); + sdhci_pltfm_unregister(pdev); clk_disable_unprepare(pdata->icnclk); reset_control_assert(rstc); - return ret; + return 0; } #ifdef CONFIG_PM_SLEEP