From patchwork Thu Jun 16 20:28:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Dickson X-Patchwork-Id: 12884802 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31DDCC43334 for ; Thu, 16 Jun 2022 20:29:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378666AbiFPU3H (ORCPT ); Thu, 16 Jun 2022 16:29:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378653AbiFPU3G (ORCPT ); Thu, 16 Jun 2022 16:29:06 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4934C5B3E3 for ; Thu, 16 Jun 2022 13:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655411344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=5Hr2VYvXX1tdApUxGfR+NIaa3qtnHHAMnCbLPFlMupg=; b=T4ru5CIyCQDaRK0ZrbReELGohMnP3Nb+320Qzdu/mCNwL46s4ifJEMYgEBL5QkDcEik6vS Ugbpr+f0ROcGaYNtqAzDRZO70jqMnz9uUqGSRsq++ZcuFiKo26+vYQ4is2vL8ecbOBfZUA J9b8BvOgf1n8bwycJpnXeyvis7Ubofw= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-517-IGTBrLQPNRy-gJjYj9yY8Q-1; Thu, 16 Jun 2022 16:29:03 -0400 X-MC-Unique: IGTBrLQPNRy-gJjYj9yY8Q-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D5D441D33866 for ; Thu, 16 Jun 2022 20:29:02 +0000 (UTC) Received: from madhat.home.dicksonnet.net (unknown [10.2.16.194]) by smtp.corp.redhat.com (Postfix) with ESMTP id A8AE840334E for ; Thu, 16 Jun 2022 20:29:02 +0000 (UTC) From: Steve Dickson To: Linux NFS Mailing list Subject: [PATCH 1/4] Makefile: Added the creation of config.guess and config.sub Date: Thu, 16 Jun 2022 16:28:59 -0400 Message-Id: <20220616202902.53969-1-steved@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Signed-off-by: Steve Dickson --- .gitignore | 2 ++ Makefile | 3 +++ 2 files changed, 5 insertions(+) diff --git a/.gitignore b/.gitignore index df58159..72bdb22 100644 --- a/.gitignore +++ b/.gitignore @@ -6,6 +6,8 @@ aclocal.m4 autom4te.cache/ config.log +config.guess +config.sub config.status configure include/builddefs diff --git a/Makefile b/Makefile index 5302e11..be7454d 100644 --- a/Makefile +++ b/Makefile @@ -60,6 +60,7 @@ clean: # if configure hasn't run, nothing to clean endif $(CONFIGURE): aclocal.m4 + autoreconf --install autoconf ./configure \ --prefix=/ \ @@ -96,3 +97,5 @@ install-lib: default realclean distclean: clean rm -f $(LDIRT) $(CONFIGURE) rm -rf autom4te.cache Logs + rm -rf config.guess config.sub configure~ + From patchwork Thu Jun 16 20:29:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Dickson X-Patchwork-Id: 12884805 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39BFDC433EF for ; Thu, 16 Jun 2022 20:29:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378671AbiFPU3L (ORCPT ); Thu, 16 Jun 2022 16:29:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378667AbiFPU3K (ORCPT ); Thu, 16 Jun 2022 16:29:10 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 64B4B5C746 for ; Thu, 16 Jun 2022 13:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655411344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9T0GnKTcsKnAojWZXM1sG2Cwvgvk3+u089Zo6OvZTh8=; b=fl5A8v0tSZq0hqeT4JI9lxGqCdjsNrCzgyDHyNFaFrM3xx8EpWz7siwXZTVthQk4EFjIV7 15138CtCW9KWdWe5TolO7kWKccKBz5IyyuSekGbs7VPzOJ/XjKq+YzE008FEm+nfg9Ej5F XVnB+vn7p1dy4Q/M/G+pPeExFmAf3Rg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-520-eJ82sWl0MNS0UAdxXh7tXg-1; Thu, 16 Jun 2022 16:29:03 -0400 X-MC-Unique: eJ82sWl0MNS0UAdxXh7tXg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 289DB3C0CD52 for ; Thu, 16 Jun 2022 20:29:03 +0000 (UTC) Received: from madhat.home.dicksonnet.net (unknown [10.2.16.194]) by smtp.corp.redhat.com (Postfix) with ESMTP id EF7AC403350 for ; Thu, 16 Jun 2022 20:29:02 +0000 (UTC) From: Steve Dickson To: Linux NFS Mailing list Subject: [PATCH 2/4] configure.ac: Removed a number warnings Date: Thu, 16 Jun 2022 16:29:00 -0400 Message-Id: <20220616202902.53969-2-steved@redhat.com> In-Reply-To: <20220616202902.53969-1-steved@redhat.com> References: <20220616202902.53969-1-steved@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Signed-off-by: Steve Dickson --- Makefile | 4 ++-- configure.ac | 8 ++++---- include/builddefs.in | 1 + 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index be7454d..a460e78 100644 --- a/Makefile +++ b/Makefile @@ -60,8 +60,8 @@ clean: # if configure hasn't run, nothing to clean endif $(CONFIGURE): aclocal.m4 + autoupdate --force autoreconf --install - autoconf ./configure \ --prefix=/ \ --exec-prefix=/ \ @@ -96,6 +96,6 @@ install-lib: default realclean distclean: clean rm -f $(LDIRT) $(CONFIGURE) - rm -rf autom4te.cache Logs + rm -rf autom4te.cache Logs configure.ac~ rm -rf config.guess config.sub configure~ diff --git a/configure.ac b/configure.ac index c624295..3337575 100644 --- a/configure.ac +++ b/configure.ac @@ -1,5 +1,5 @@ -AC_INIT([nfs4-acl-tools], [0.3.3]) -AC_CONFIG_HEADER(include/config.h) +AC_INIT([nfs4-acl-tools],[0.3.3]) +AC_CONFIG_HEADERS(include/config.h) AC_PREFIX_DEFAULT(/usr/local) AC_CONFIG_MACRO_DIRS([m4]) @@ -12,7 +12,6 @@ AC_SUBST(enable_shared) AC_PROG_INSTALL AC_PROG_CC -AC_HEADER_STDC AC_CHECK_HEADERS([netinet/in.h stdlib.h string.h unistd.h]) AC_CHECK_HEADERS([attr/xattr.h sys/xattr.h]) @@ -33,4 +32,5 @@ AC_PACKAGE_UTILITIES([nfs4acl]) AC_PACKAGE_NEED_GETXATTR_LIBATTR AC_MANUAL_FORMAT -AC_OUTPUT(include/builddefs) +AC_CONFIG_FILES([include/builddefs]) +AC_OUTPUT diff --git a/include/builddefs.in b/include/builddefs.in index fe49b08..3dab1de 100644 --- a/include/builddefs.in +++ b/include/builddefs.in @@ -43,6 +43,7 @@ LIBNFS4ACL = $(TOPDIR)/libnfs4acl/libnfs4acl.la LIBATTR = @libattr@ prefix = @prefix@ +datarootdir = @datarootdir@ exec_prefix = @exec_prefix@ DESTDIR = From patchwork Thu Jun 16 20:29:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Dickson X-Patchwork-Id: 12884803 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3176CCA47A for ; Thu, 16 Jun 2022 20:29:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378653AbiFPU3I (ORCPT ); Thu, 16 Jun 2022 16:29:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378664AbiFPU3G (ORCPT ); Thu, 16 Jun 2022 16:29:06 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DDCE85C74F for ; Thu, 16 Jun 2022 13:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655411345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c95RB5sUuj8zeo/zntmmgVuTfefS+E+oCIeWB3YYEGE=; b=Rxtk9kA0bK+wGeLRCXHUXMgHMOBqRHcU1w6OCEiSFEFdLvSQJWn86lfVvxDYSIikmnTTLX ouxjBolqtYNA7X1HFJf52y4lC83fopTCIbp8TyxU8RhRbENU701Lie6R8Foh0U6/8q2KWI fcfFYihDn1HDGc4LBoDOcJ4pfm68AD0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-567-a_ZC7cADM-Ga5QPTueNQng-1; Thu, 16 Jun 2022 16:29:03 -0400 X-MC-Unique: a_ZC7cADM-Ga5QPTueNQng-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 702C485A580 for ; Thu, 16 Jun 2022 20:29:03 +0000 (UTC) Received: from madhat.home.dicksonnet.net (unknown [10.2.16.194]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4224E40334E for ; Thu, 16 Jun 2022 20:29:03 +0000 (UTC) From: Steve Dickson To: Linux NFS Mailing list Subject: [PATCH 3/4] nfs4_print_ace_verbose: Removed a differ in signedness warning Date: Thu, 16 Jun 2022 16:29:01 -0400 Message-Id: <20220616202902.53969-3-steved@redhat.com> In-Reply-To: <20220616202902.53969-1-steved@redhat.com> References: <20220616202902.53969-1-steved@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Signed-off-by: Steve Dickson --- libnfs4acl/nfs4_print_ace_verbose.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libnfs4acl/nfs4_print_ace_verbose.c b/libnfs4acl/nfs4_print_ace_verbose.c index 96a6573..ef87e89 100644 --- a/libnfs4acl/nfs4_print_ace_verbose.c +++ b/libnfs4acl/nfs4_print_ace_verbose.c @@ -64,7 +64,7 @@ int nfs4_print_ace_verbose(struct nfs4_ace * ace, u32 is_dir) char * whotype_s; char * type_s; u32 flag; - u32 whotype; + int whotype; u32 mask; From patchwork Thu Jun 16 20:29:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Dickson X-Patchwork-Id: 12884804 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A3C4C433EF for ; Thu, 16 Jun 2022 20:29:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378664AbiFPU3I (ORCPT ); Thu, 16 Jun 2022 16:29:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378667AbiFPU3H (ORCPT ); Thu, 16 Jun 2022 16:29:07 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1EDAD5C750 for ; Thu, 16 Jun 2022 13:29:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655411345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kx/LUPv0bPXL1iyWPVt9+hVuqushkKMELxnCgrepSVQ=; b=Zq3ufc1vS15RtRUTuvwV3cmsTuKL1+SMaeh+GLQiOoqXWcnj4rsTXH5UQzeaRClI9xfY7C CpW/CkXWXc2tzdN0Jlr1/Sof0chc8G6qZsQ5ia0fPMLb+K3n94ZqMxFTwDR9OCvBQIGCRe LZyzgUCKem2BDe0Q8OSECDCgwkVhpt0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-526-H8Odn6DhPqm84xQB1StjiA-1; Thu, 16 Jun 2022 16:29:04 -0400 X-MC-Unique: H8Odn6DhPqm84xQB1StjiA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B648F3C0CD50 for ; Thu, 16 Jun 2022 20:29:03 +0000 (UTC) Received: from madhat.home.dicksonnet.net (unknown [10.2.16.194]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8994C40334E for ; Thu, 16 Jun 2022 20:29:03 +0000 (UTC) From: Steve Dickson To: Linux NFS Mailing list Subject: [PATCH 4/4] acl_nfs4_get_who: removed an always false evaluate warning Date: Thu, 16 Jun 2022 16:29:02 -0400 Message-Id: <20220616202902.53969-4-steved@redhat.com> In-Reply-To: <20220616202902.53969-1-steved@redhat.com> References: <20220616202902.53969-1-steved@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Signed-off-by: Steve Dickson --- libnfs4acl/acl_nfs4_get_who.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libnfs4acl/acl_nfs4_get_who.c b/libnfs4acl/acl_nfs4_get_who.c index 695db2e..3e2fd7c 100644 --- a/libnfs4acl/acl_nfs4_get_who.c +++ b/libnfs4acl/acl_nfs4_get_who.c @@ -49,7 +49,7 @@ int acl_nfs4_get_who(struct nfs4_ace* ace, int* type, char** who) char* iwho = NULL; int wholen; - if (ace == NULL || ace->who == NULL) + if (ace == NULL) goto inval_failed; itype = acl_nfs4_get_whotype(ace->who);