From patchwork Sun Jun 26 21:11:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xenia Ragiadakou X-Patchwork-Id: 12895903 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8E64C43334 for ; Sun, 26 Jun 2022 21:12:05 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.356136.584178 (Exim 4.92) (envelope-from ) id 1o5ZXm-0003FF-92; Sun, 26 Jun 2022 21:11:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 356136.584178; Sun, 26 Jun 2022 21:11:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o5ZXm-0003F8-6J; Sun, 26 Jun 2022 21:11:46 +0000 Received: by outflank-mailman (input) for mailman id 356136; Sun, 26 Jun 2022 21:11:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o5ZXl-0002ze-MG for xen-devel@lists.xenproject.org; Sun, 26 Jun 2022 21:11:45 +0000 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [2a00:1450:4864:20::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9534bc44-f594-11ec-b725-ed86ccbb4733; Sun, 26 Jun 2022 23:11:45 +0200 (CEST) Received: by mail-ej1-x62e.google.com with SMTP id ay16so15177748ejb.6 for ; Sun, 26 Jun 2022 14:11:45 -0700 (PDT) Received: from uni.. (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.googlemail.com with ESMTPSA id cq12-20020a056402220c00b004356b8ad003sm6367556edb.60.2022.06.26.14.11.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jun 2022 14:11:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9534bc44-f594-11ec-b725-ed86ccbb4733 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1/ZGiB26wkc6ln+SQl2Q+9yHj6lnaAaAN9Iu/vPcQ1g=; b=c/Dx4jLVI71H6lIglKPncvyiMVNDcz+lkyCneD8pZ0VtZmZafuJUi1+Q5Qt6BHFiKh G6vsEExUx4P0si3ydzfXuDuki08c0yI8CnkuJ98DvUKU0uSDi7QkQ+Ppz/9UvJC8yky7 CCH+ioHJhpJAtINMlqymaglWBHHFLfU9ACjtDm7X+qJ/I1XKsv+Un1I2Lum0s4d+GFDA upMuIytPTF7UPt4ZOnCpS6SApPR57tNEVpX0UXC8AmXRfTNz78rYH2upOG5BFXjsGaVR Dc7/7J6EBQifZWCxH4EozAUio1gL72jC2uvgu8CKHaRHbbNwp8vIECIXU68d/mZUpjMi 2elQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1/ZGiB26wkc6ln+SQl2Q+9yHj6lnaAaAN9Iu/vPcQ1g=; b=RFkzZQAoVpcdhbm23Tb0vnwJHc2IxBiDSrAmAlpNiK6suAHzTQugzqO6kNY5bO0Hug xAcBP8lDfsD5dSJteRq+AUjFFzGh65w2BkiJm080nTqrVmNergy4ZUo1FmLPoCmSEOlk vd6IFWhG1jGqC+tiHiLwVD03XS65KfAF/K3w02cwwSgGkSAEmVrIk98a4HDsGk3WG+L5 dbM0UWw9zLO1Umd7AokeNtwIJX4LLnBvOMbQfSGBbVfsBLicyX+SCFp+Dy7mAw7/e6fR gvRyxcPzl4DbY/hSmva6RSr58yMGXZP/bJ65tYvsBquJRjff+lDo95xupBykNquRMaan WMxg== X-Gm-Message-State: AJIora93uM8t27pGkdjHecPaSH3kUjM6MNm2Z0jzw+Xvxe43SrZHKhJ0 wMLXrYVLHlRhAGtgQmXYAqmfVi9GcXQ= X-Google-Smtp-Source: AGRyM1v8+NAGMGdbj+ckdz0wTt/lfqZgApC1gUcOB5R7jZe3PmGOCbeCDS/tOeQiWv+e7nDFBOe4Wg== X-Received: by 2002:a17:907:c0a:b0:726:22b1:9734 with SMTP id ga10-20020a1709070c0a00b0072622b19734mr9850234ejc.195.1656277904377; Sun, 26 Jun 2022 14:11:44 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Xenia Ragiadakou , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 1/5] xen/common: page_alloc: Fix MISRA C 2012 Rule 8.7 violation Date: Mon, 27 Jun 2022 00:11:27 +0300 Message-Id: <20220626211131.678995-2-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220626211131.678995-1-burzalodowa@gmail.com> References: <20220626211131.678995-1-burzalodowa@gmail.com> MIME-Version: 1.0 The variables page_offlined_list and page_broken_list are referenced only in page_alloc.c. Change their linkage from external to internal by adding the storage-class specifier static to their definitions. This patch aims to resolve indirectly a MISRA C 2012 Rule 8.4 violation warning. Signed-off-by: Xenia Ragiadakou Reviewed-by: Jan Beulich --- xen/common/page_alloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 000ae6b972..fe0e15429a 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -235,9 +235,9 @@ static unsigned int dma_bitsize; integer_param("dma_bits", dma_bitsize); /* Offlined page list, protected by heap_lock. */ -PAGE_LIST_HEAD(page_offlined_list); +static PAGE_LIST_HEAD(page_offlined_list); /* Broken page list, protected by heap_lock. */ -PAGE_LIST_HEAD(page_broken_list); +static PAGE_LIST_HEAD(page_broken_list); /************************* * BOOT-TIME ALLOCATOR From patchwork Sun Jun 26 21:11:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xenia Ragiadakou X-Patchwork-Id: 12895901 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25FB1C433EF for ; Sun, 26 Jun 2022 21:12:05 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.356137.584189 (Exim 4.92) (envelope-from ) id 1o5ZXp-0003W8-Gp; Sun, 26 Jun 2022 21:11:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 356137.584189; Sun, 26 Jun 2022 21:11:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o5ZXp-0003W1-Dq; Sun, 26 Jun 2022 21:11:49 +0000 Received: by outflank-mailman (input) for mailman id 356137; Sun, 26 Jun 2022 21:11:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o5ZXo-0002ze-4J for xen-devel@lists.xenproject.org; Sun, 26 Jun 2022 21:11:48 +0000 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [2a00:1450:4864:20::52f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 96a317e6-f594-11ec-b725-ed86ccbb4733; Sun, 26 Jun 2022 23:11:47 +0200 (CEST) Received: by mail-ed1-x52f.google.com with SMTP id eo8so10553039edb.0 for ; Sun, 26 Jun 2022 14:11:47 -0700 (PDT) Received: from uni.. (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.googlemail.com with ESMTPSA id cq12-20020a056402220c00b004356b8ad003sm6367556edb.60.2022.06.26.14.11.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jun 2022 14:11:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96a317e6-f594-11ec-b725-ed86ccbb4733 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nuU5RdK7p3A+qPrUO/Jr3dM+wawCSfpGpfW4baMZN1o=; b=WpQxztn4nBsr82cJ9eOZah6UtylOZg7AnA56/KVKxKTt9oh2n1FZWC3Bm3MprrBI5m 9cNC6/OGiNYKWqZm14RYDQvL8OO5O6swZL1K91SmSlC+eJHvIubQmaS4RmNqAAP80U2g CsTG1O68POh/vetLnbSuc+dS1GaV6PzisV1sVOA1PFgFVjOYK/NomIx/VuWyUrwc3ZDa BTXw06zoRN8pLFb9aJoVyFbHaAw4INhhLeMpFKv6uyrP7TStYcWisyQbNlxb0NaV1btx dw3ZcSaj/tmw4pRP0da5dyeUT2nL72p26qq0sKfqeMV491SnuGoh3I/WUE3wSQHvOezc DgQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nuU5RdK7p3A+qPrUO/Jr3dM+wawCSfpGpfW4baMZN1o=; b=t21KKj1KKy436cHUNN+AJNN2Tor0I8hPbB6+k8EeDcCnSy9USmYsuL/VIj3ZiGpE2j TUzcYayZxXTUCOvVodehFSm/73bPXPkfk4vxvgSAmIcQ7os+DMInsyIq+/Oz+GUXUbP7 sm28gSD7Wowwpn9P+mItpoqhw7a+LVGS1GF47tZpf/U5rsfxLxcSHGmoWw+5LGXYnpjx +Bg0PXsqv6vjOLoL6oLoHiX9dx0Rk720DQnbn0hYUEQtmuV02pGPBEjvCeUaJOFStpDD hmyuvwp9sfKKD9QtPyZ6e8Z706+rylqKYW1mb1L0k/MR7I9i7E66iTwQkN8FBcUC6ozr Kljg== X-Gm-Message-State: AJIora+RjC0SFh2vrHomQBWULY/4DT2jrkLvq9I7C5sLmnETWasccYx9 I8Q94BUZBYrlySsePVmsjYbcwrGZ7fU= X-Google-Smtp-Source: AGRyM1uqxPILZfgMHtiSrlaohNVIDdzBMh410mKVJtBS0assx2Gn2edp44afW8udB/i1s3pRO8iozA== X-Received: by 2002:a05:6402:4496:b0:435:d605:6ff8 with SMTP id er22-20020a056402449600b00435d6056ff8mr12821122edb.357.1656277906805; Sun, 26 Jun 2022 14:11:46 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Xenia Ragiadakou , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu Subject: [PATCH 2/5] xen/common: vm_event: Fix MISRA C 2012 Rule 8.7 violation Date: Mon, 27 Jun 2022 00:11:28 +0300 Message-Id: <20220626211131.678995-3-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220626211131.678995-1-burzalodowa@gmail.com> References: <20220626211131.678995-1-burzalodowa@gmail.com> MIME-Version: 1.0 The function vm_event_wake() is referenced only in vm_event.c. Change the linkage of the function from external to internal by adding the storage-class specifier static to the function definition. This patch aims to resolve indirectly a MISRA C 2012 Rule 8.4 violation warning. Signed-off-by: Xenia Ragiadakou Reviewed-by: Jan Beulich Reviewed-by: Stefano Stabellini --- xen/common/vm_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c index 0b99a6ea72..ecf49c38a9 100644 --- a/xen/common/vm_event.c +++ b/xen/common/vm_event.c @@ -173,7 +173,7 @@ static void vm_event_wake_queued(struct domain *d, struct vm_event_domain *ved) * call vm_event_wake() again, ensuring that any blocked vCPUs will get * unpaused once all the queued vCPUs have made it through. */ -void vm_event_wake(struct domain *d, struct vm_event_domain *ved) +static void vm_event_wake(struct domain *d, struct vm_event_domain *ved) { if ( !list_empty(&ved->wq.list) ) vm_event_wake_queued(d, ved); From patchwork Sun Jun 26 21:11:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xenia Ragiadakou X-Patchwork-Id: 12895904 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0620C433EF for ; Sun, 26 Jun 2022 21:12:07 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.356138.584201 (Exim 4.92) (envelope-from ) id 1o5ZXr-0003o9-R1; Sun, 26 Jun 2022 21:11:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 356138.584201; Sun, 26 Jun 2022 21:11:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o5ZXr-0003nu-Ml; Sun, 26 Jun 2022 21:11:51 +0000 Received: by outflank-mailman (input) for mailman id 356138; Sun, 26 Jun 2022 21:11:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o5ZXq-0002ze-E8 for xen-devel@lists.xenproject.org; Sun, 26 Jun 2022 21:11:50 +0000 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [2a00:1450:4864:20::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9824f61a-f594-11ec-b725-ed86ccbb4733; Sun, 26 Jun 2022 23:11:49 +0200 (CEST) Received: by mail-ej1-x62e.google.com with SMTP id lw20so15193372ejb.4 for ; Sun, 26 Jun 2022 14:11:49 -0700 (PDT) Received: from uni.. (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.googlemail.com with ESMTPSA id cq12-20020a056402220c00b004356b8ad003sm6367556edb.60.2022.06.26.14.11.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jun 2022 14:11:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9824f61a-f594-11ec-b725-ed86ccbb4733 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Fupjb85vIsrQ5wu4RYb1H4Kw82O2kq4W3orr63txTa4=; b=E3Vv7SItkwItycz2Z90J9YWQzUXfs/W4ID/1ICVv59a2BoVVRP07Co36VlfZgOrK8f 5PUTHUSZOE7B4hIM23fLATd3GtAptz81tYTAAnx8mr8ceJfKMcQY3xjGk63Sx3SUR7Pl A+5NSmM6f0/+N16HBAfVqgboTEUBvPo0eqwH1I9d264XKFXH47mTuMhg/U6r33DMxVh6 CwzKB0O3vvd1HSr/rsOOXp80dJ2QrWo7ywmRXqjSm/bv0dpZmc1tONuYFO6kY3je9484 d/868zYhwf+ZpbxAvcLT/T1ZeQCDDUu50xPlj86akj6TGa2KeqUvgpSuunXS6Id5zbNm msnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fupjb85vIsrQ5wu4RYb1H4Kw82O2kq4W3orr63txTa4=; b=aBdQb4n2Lur1G47qN38vTp4U0LO5NTjIZmsEEcvTzdo6rdeeI9+uOMiCdOYh2iMjjc ZeQwcdKMzVuA0gFGMpkLwb7mQXM5AZexz60qETE3bianEiT+1pk4iarPGQ+qeTrwWIKR qpiIWY2KSdbbL2mmjphASBHnghs3JgfNMAtAr04rbJ5OyenZOE/speM+i0VlDTib2Wgh 7FEqzn345TpGwsfEbhpdkn0+x8Dfq08rl+IpF3iDW6VhdM2hudzl2OdF7dBrduxkyS4R HmGqk/MWHSSMVVI4l/2yS57xQBjYqLDGgWjkhFUlfVxl4J2ywx9oRXkn60RqfTXH+8oi R8EA== X-Gm-Message-State: AJIora+jHr6PFaIcw6T1i6vHeVpRcpz/LJNSa4WIVElabL+QZTsmNpVm QoJ5tCnIHB38R2qQP/pYuTdSw7xrYgk= X-Google-Smtp-Source: AGRyM1tLzA9SebPtts7XsjFRsbDPlaTmSVFsa+i933FIzXFhm28U+TMrLx5hXNT/Kyhk0u9WGZKyKw== X-Received: by 2002:a17:906:6a11:b0:726:97b8:51e9 with SMTP id qw17-20020a1709066a1100b0072697b851e9mr4832004ejc.115.1656277909391; Sun, 26 Jun 2022 14:11:49 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Xenia Ragiadakou , Jan Beulich , Paul Durrant , =?utf-8?q?Roger_Pau_Monn=C3=A9?= Subject: [PATCH 3/5] xen/drivers: iommu: Fix MISRA C 2012 Rule 8.7 violation Date: Mon, 27 Jun 2022 00:11:29 +0300 Message-Id: <20220626211131.678995-4-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220626211131.678995-1-burzalodowa@gmail.com> References: <20220626211131.678995-1-burzalodowa@gmail.com> MIME-Version: 1.0 The variable iommu_crash_disable is referenced only in one translation unit. Change its linkage from external to internal by adding the storage-class specifier static to its definition. This patch aims to resolve indirectly a MISRA C 2012 Rule 8.4 violation warning. Signed-off-by: Xenia Ragiadakou Reviewed-by: Jan Beulich --- xen/drivers/passthrough/iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index 75df3aa8dd..77f64e6174 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -29,7 +29,7 @@ bool_t __initdata iommu_enable = 1; bool_t __read_mostly iommu_enabled; bool_t __read_mostly force_iommu; bool_t __read_mostly iommu_verbose; -bool_t __read_mostly iommu_crash_disable; +static bool_t __read_mostly iommu_crash_disable; #define IOMMU_quarantine_none 0 /* aka false */ #define IOMMU_quarantine_basic 1 /* aka true */ From patchwork Sun Jun 26 21:11:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xenia Ragiadakou X-Patchwork-Id: 12895905 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8767DC43334 for ; Sun, 26 Jun 2022 21:12:08 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.356139.584212 (Exim 4.92) (envelope-from ) id 1o5ZXv-00049Z-52; Sun, 26 Jun 2022 21:11:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 356139.584212; Sun, 26 Jun 2022 21:11:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o5ZXv-00049R-1C; Sun, 26 Jun 2022 21:11:55 +0000 Received: by outflank-mailman (input) for mailman id 356139; Sun, 26 Jun 2022 21:11:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o5ZXt-00045G-Eu for xen-devel@lists.xenproject.org; Sun, 26 Jun 2022 21:11:53 +0000 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [2a00:1450:4864:20::52b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 999fc724-f594-11ec-bd2d-47488cf2e6aa; Sun, 26 Jun 2022 23:11:52 +0200 (CEST) Received: by mail-ed1-x52b.google.com with SMTP id fd6so10484717edb.5 for ; Sun, 26 Jun 2022 14:11:52 -0700 (PDT) Received: from uni.. (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.googlemail.com with ESMTPSA id cq12-20020a056402220c00b004356b8ad003sm6367556edb.60.2022.06.26.14.11.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jun 2022 14:11:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 999fc724-f594-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xj9geaDYiDJeXi2P/hZ4T8+FfXgCNZI+BFN5XSupO2M=; b=AOaGcV0vT+0cYRABSoUay9LVQ06yx+0+VUBptJY1W5sEO+rs2OrtIw+McAnr97zO/m NUXbavyrIvEqQhreBluaN+AEb/IzXjcsf4FOvGB8b10MvGxOMfqQ0wG3D4Q2tD7+V+VZ d277lwcgIdGwFhI1iVPx2S7cC306oVHpLJiSwGdzXYLqjo6fbu/uMFxNP99beGSuuwQQ IwLkMXw/PYcUcj0LY+GaETqENcqmC5AvLkX+oz0TTMpRHZsTRz7fyU7C5dJcsL0GoUzR m4NHKj2JTW/P65gbfsFqsjfv7lvBrZ9ibfTHZhX0UuS5yUEj6rLO/6IGh3sT5+q11mgt z/nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xj9geaDYiDJeXi2P/hZ4T8+FfXgCNZI+BFN5XSupO2M=; b=kto4FgTVuLRE0D3FvAHcIpOIWDPlTKpw8BkY20qi6av0fGzYXOTUtKVEINA6GuIYiw LRPnGzk8pokcZNgmbWqNqCXCgrJvFNJw3B22ii8UMOncKp/pwQ3jl2NPvkZk1mgVU9+f cSdZRsLfqdcA2iG4yBHLXkK0zRzDt5RZ1zgmWVEdbZU0CSGn+56ortGTwmUncSW9NN0a 5mzVzkNMLBIretDfmmgt2AFRAuz3q3s3yiD+3fRiIrFmko0J+pDN8F8f7eBKYpYfcX2y qS0mcsJE7dXpcorcHkdSBiS/oliuyjXYPDPxLVHjz7AsAIAwG+X66a25FjM4ec/FRmep mKjw== X-Gm-Message-State: AJIora/BubJefBRgQ2UEUWlmZ19xoFY9W4exLPKLSw96u6qaAG5C00ZA o+2LQYvp8AVvOyyDBxeYsvgZ++UkETE= X-Google-Smtp-Source: AGRyM1suuYGZAMFsKza4q0oXYNza4EVXS2SZIk6Rq2XRGJ6H8ZAgjiEKy6qsbFUeaB2/R+gyoXWuDA== X-Received: by 2002:a05:6402:320f:b0:435:7236:e312 with SMTP id g15-20020a056402320f00b004357236e312mr12957410eda.115.1656277911895; Sun, 26 Jun 2022 14:11:51 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Xenia Ragiadakou , George Dunlap , Dario Faggioli Subject: [PATCH 4/5] xen/sched: credit: Fix MISRA C 2012 Rule 8.7 violation Date: Mon, 27 Jun 2022 00:11:30 +0300 Message-Id: <20220626211131.678995-5-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220626211131.678995-1-burzalodowa@gmail.com> References: <20220626211131.678995-1-burzalodowa@gmail.com> MIME-Version: 1.0 The per-cpu variable last_tickle_cpu is referenced only in credit.c. Change its linkage from external to internal by adding the storage-class specifier static to its definitions. This patch aims to resolve indirectly a MISRA C 2012 Rule 8.4 violation warning. Signed-off-by: Xenia Ragiadakou Reviewed-by: Jan Beulich Reviewed-by: Stefano Stabellini --- xen/common/sched/credit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/sched/credit.c b/xen/common/sched/credit.c index 4d3bd8cba6..47945c2834 100644 --- a/xen/common/sched/credit.c +++ b/xen/common/sched/credit.c @@ -348,7 +348,7 @@ static void burn_credits(struct csched_unit *svc, s_time_t now) static bool __read_mostly opt_tickle_one_idle = true; boolean_param("tickle_one_idle_cpu", opt_tickle_one_idle); -DEFINE_PER_CPU(unsigned int, last_tickle_cpu); +static DEFINE_PER_CPU(unsigned int, last_tickle_cpu); static inline void __runq_tickle(const struct csched_unit *new) { From patchwork Sun Jun 26 21:11:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xenia Ragiadakou X-Patchwork-Id: 12895906 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C38C0CCA47C for ; Sun, 26 Jun 2022 21:12:09 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.356140.584223 (Exim 4.92) (envelope-from ) id 1o5ZXw-0004Rc-Gj; Sun, 26 Jun 2022 21:11:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 356140.584223; Sun, 26 Jun 2022 21:11:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o5ZXw-0004QA-BS; Sun, 26 Jun 2022 21:11:56 +0000 Received: by outflank-mailman (input) for mailman id 356140; Sun, 26 Jun 2022 21:11:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o5ZXv-0002ze-Ou for xen-devel@lists.xenproject.org; Sun, 26 Jun 2022 21:11:55 +0000 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [2a00:1450:4864:20::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9b18f4a4-f594-11ec-b725-ed86ccbb4733; Sun, 26 Jun 2022 23:11:55 +0200 (CEST) Received: by mail-ej1-x62f.google.com with SMTP id g26so15156220ejb.5 for ; Sun, 26 Jun 2022 14:11:54 -0700 (PDT) Received: from uni.. (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.googlemail.com with ESMTPSA id cq12-20020a056402220c00b004356b8ad003sm6367556edb.60.2022.06.26.14.11.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jun 2022 14:11:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b18f4a4-f594-11ec-b725-ed86ccbb4733 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zO50M0sKicPYbO3MfGNjKmAChEFlsCUJ3Pd09z6d3B8=; b=gt44c+Q2MGza2lsgnlUfudnqddhWLluw63hNoC7ABVuhmNz+eMsZ/igzq4PPys7uAt 0KLpejzAQI1lgnQKGtTswVKzrEUzVLuSh6VVt13Wsw/Q0HIZ/SmXU5tOC09097ga1xGo 9no9l3d/Yv+YQhM7Q7up8Flsvewa5RTsBERnSMvrIU6ILBrbFBJUo3HGTObRbMqCnSxQ 4dn0sEkDSl28qqj2kdZqdmR7VPPtKUDy7EqykAndJvZ1u/1iS6f7Jf2ax0ZMmlF5BiFn ZXv38QdzmItBDLpCPS8t4Di+xSmb/8UClkgMJT+OaVI79nH7gdGXfAXG0nEhhW+jjxAm SbUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zO50M0sKicPYbO3MfGNjKmAChEFlsCUJ3Pd09z6d3B8=; b=yIIc0dyclkGiyflFSqp7/pLtx3tNplULoJUQS2jh7Ok19f6k5dMPIwVo6R9oE+of4u 4X7V53eX/Nw+1JnsQ2m2sDV7RRbfMyALg0WuJNSWmPQOEdrSSeziPhYccw6XlFilBvSA 8rIrxMAfBI2oXpOchrf2ovctoUmvq3vG03KKR7wgHqnTlLvuvPak+GbbO2KlsnVT3men 2MTixMb5aYcjLa2lrl27FYE0JMwTecmrCC3ZYEqFRi4r1Eyt+voMbFm8Sf8Il5HhSxJ1 3PHIkJYVsRPI1uxlYK3GccKLtquTbfbOG4uke/fi+f1kUdhfKeGd6jBd99NV6RwS3Lw3 eO1Q== X-Gm-Message-State: AJIora/6JQaUXm+kNX4QpKgsdprR1oAiO9ZX2WeHgU1ftiPiI2Y/Wvcu WszIat4Qsim9ns0pGs3mMQLYYCxd3DE= X-Google-Smtp-Source: AGRyM1sjgtHzgRZhQw1AoPrP9Py9kuXuomYrtZtw3vkLr3eTO0+YKeIo3PRd3Ing0GNcgtRcEXxhFg== X-Received: by 2002:a17:907:3e18:b0:722:be7e:302c with SMTP id hp24-20020a1709073e1800b00722be7e302cmr9590234ejc.437.1656277914377; Sun, 26 Jun 2022 14:11:54 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Xenia Ragiadakou , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 5/5] xen/arm64: traps: Fix MISRA C 2012 Rule 8.4 violations Date: Mon, 27 Jun 2022 00:11:31 +0300 Message-Id: <20220626211131.678995-6-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220626211131.678995-1-burzalodowa@gmail.com> References: <20220626211131.678995-1-burzalodowa@gmail.com> MIME-Version: 1.0 Add a function prototype for do_bad_mode() in and include header in traps.c, so that the declarations of the functions do_bad_mode() and finalize_instr_emulation(), which have external linkage, are visible before the function definitions. Signed-off-by: Xenia Ragiadakou Reviewed-by: Bertrand Marquis --- xen/arch/arm/arm64/traps.c | 1 + xen/arch/arm/include/asm/arm64/traps.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/xen/arch/arm/arm64/traps.c b/xen/arch/arm/arm64/traps.c index 3f8858acec..a995ad7c2c 100644 --- a/xen/arch/arm/arm64/traps.c +++ b/xen/arch/arm/arm64/traps.c @@ -22,6 +22,7 @@ #include #include #include +#include #include diff --git a/xen/arch/arm/include/asm/arm64/traps.h b/xen/arch/arm/include/asm/arm64/traps.h index 2379b578cb..a347cb13d6 100644 --- a/xen/arch/arm/include/asm/arm64/traps.h +++ b/xen/arch/arm/include/asm/arm64/traps.h @@ -6,6 +6,8 @@ void inject_undef64_exception(struct cpu_user_regs *regs, int instr_len); void do_sysreg(struct cpu_user_regs *regs, const union hsr hsr); +void do_bad_mode(struct cpu_user_regs *regs, int reason); + #endif /* __ASM_ARM64_TRAPS__ */ /* * Local variables: