From patchwork Thu Jun 30 08:23:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 12901406 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67697C43334 for ; Thu, 30 Jun 2022 08:24:09 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.358298.587435 (Exim 4.92) (envelope-from ) id 1o6pSv-0000KI-8B; Thu, 30 Jun 2022 08:23:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358298.587435; Thu, 30 Jun 2022 08:23:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o6pSv-0000KB-5F; Thu, 30 Jun 2022 08:23:57 +0000 Received: by outflank-mailman (input) for mailman id 358298; Thu, 30 Jun 2022 08:23:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o6pSt-0000Hf-6u for xen-devel@lists.xenproject.org; Thu, 30 Jun 2022 08:23:55 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f7988413-f84d-11ec-bdce-3d151da133c5; Thu, 30 Jun 2022 10:23:51 +0200 (CEST) Received: from mail-mw2nam12lp2048.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.48]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Jun 2022 04:23:50 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB5421.namprd03.prod.outlook.com (2603:10b6:a03:289::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Thu, 30 Jun 2022 08:23:49 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534%7]) with mapi id 15.20.5395.015; Thu, 30 Jun 2022 08:23:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7988413-f84d-11ec-bdce-3d151da133c5 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1656577433; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=LiQtz8zgdXUTY6GP7spjzbqn2+XZTbP5Ey9lVx8mnXY=; b=h84DVu3Fki86Wa5Y2yoK6xA2biwKEvtM1g7INMlrGsDjpp0xFsgIlE2f ub32ubf2fdcJZ3kKYLJ/Yjq01EgZ3kmq7LEZi1PVjOP22h7G+bksVx/QR fZMQb+HVLk/SZjdKhZnp2SfTQMqu6eOv1pUFsf941/+Ium5O2eWM8W14Q g=; X-IronPort-RemoteIP: 104.47.66.48 X-IronPort-MID: 74792292 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Zq9CN69Jm8bjULZSfpfNDrUDnX+TJUtcMsCJ2f8bNWPcYEJGY0x3z WQeD2yPa/6MMTGhe9kjYI7g8EhXsZfSyddjTgVorX08E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ74f5fs7Rh2NQw34PhW1rlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnaaOdDw2FPPmpLsMcgleCARXGr98wKCSdBBTseTLp6HHW13F5qw0SWQJZ8gf8OsxBnxS/ /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHfuMuY8wMDQY36iiGd7EY MUUc3x3ZQnoaBxTIFYHTpk5mY9Eg1GgL2IJ8gjE/8Lb5UDCzRM2yYHfLuCId4S6VOJsmxeb+ n3ZqjGR7hYycYb3JSC+2mKhgKrDkD32XKoWFaak7bh6jVuL3GsRBRYKE1yhrpGRiESzRtZeI Ew84Tc1oO4580nDZtvgWxy1plaUsxhaXMBfe8Uh8x2EwKfQ5wefB0AHQyRHZdhgs9U5LRQ10 neZktWvAiZg2IB5UlqY/7aQ6DatYy4cKDZYYTdeFVdVpd7+vIs0kxTDCM55F7K4hcH0Hje2x C2WqC85hPMYistjO7iHwG0rSgmE/vDhJjPZLC2ONo55xmuVvLKYWrE= IronPort-HdrOrdr: A9a23:VSU0+KoWYL+cDEUYXyIZqGYaV5uwL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwI080kqQFm7X5XI3SJzUO3VHFEGgM1/qH/9SNIU3DH6tmpN 5dmstFeaLN5CZB/KHHCWCDer5PoeVvsprY/ds2p00dMT2CAJsQijuRZDzrcXGfE2J9dOcE/d enl7x6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr18jegIK5Y1n3X nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKvS/lQFwhNvqxEchkd HKrRtlF8Nv60nJdmXwmhfp0xmI6kda11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza NixQuixtZqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW/HAbgcYa dT5fznlbdrmQvwVQGYgoAv+q3nYp0LJGbIfqBY0fblkAS/nxhCvjklLYIk7zU9HakGOuh5Dt T/Q9pVfY51P78rhNpGdYE8qOuMexjwqEH3QRWvCGWiMp07EFTwjLOyyIkJxYiRCe81Jd0J6d /8bG8= X-IronPort-AV: E=Sophos;i="5.92,233,1650945600"; d="scan'208";a="74792292" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h1nJANIOw43GRn2uUJN7wZbfABXSrBiBRQtmUp8PY1kseLDK1fu3OKKm9C8qqG6iBfQ7QIl7L76O9f20yt+WeFNg/ipthcCJmkCjfCX/WNrBnXD5h8cEpkaA3zf/WhsgJmVoERF6rsrQ0b2BWawpvC5eYb9iBHw4ruq6x97GW3fgp5fkp9KkteLXe8lpO6L034X1bMdZGa0FhWZFffaw1UFqVBt/YhS18v6Jt1HxaTUH1QwPkM1yJGoFVOks1czlEFOwzs6biLddXzsr/Btmr+uWEcmM6k+xPbEHHCMs2B1U7PYwaU7lT3MJBLwTEomBBM0J5JSTuCKEjrU57WkuJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nfkwqWP0v5owMG2H+4Xard4Xv9SJblLQOcMul3+LP/Y=; b=KC9NwnBLvnbSW6CZ7AE7P1414OY0URnwlZscOV8xThzqNlHU/P7XKDQ2YThlZXbEKCBUSsLJp2SkBVmvQ+r6kJYUZzaHE2PSmhBEF8zshixmR2fsCQswtKTSmDT55uHMrkk66pTO3lG9nHtbQnNHvbzZ266VOP+rl8gQ8yc89ynBDVAUaQhyVN8jWzoU8agBkjWAC7/IDl4lwmk/RyDZExRgjrE9uUusYXX2CAEMUFS3DnPXVg/5oDHyqQ5llTsADygOXowmnaGzlTVHwWFt1QVuZ+pYicA1yiV29yo1MqwoRYN6bwHeyzFa8DeVLFmy6JTPiWZd3GDtcRspM+EKwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nfkwqWP0v5owMG2H+4Xard4Xv9SJblLQOcMul3+LP/Y=; b=fGdOMJO3S7DtpsE9USz4zqXp1EcwE7r3muu23nU/dnAkFndejhQ3/f0dKHSmNH+VvEtDFxsP3p1IN07lZc48JqquQ/WRU3LJ34mt3l+VfjfxgQMtmHP1/utyKipguSfOW04GfefviuSz9FPfZMSLWzeeuExeN5lhmYXdGs0A5gs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 1/2] console/serial: set the default transmit buffer size in Kconfig Date: Thu, 30 Jun 2022 10:23:29 +0200 Message-Id: <20220630082330.82706-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220630082330.82706-1-roger.pau@citrix.com> References: <20220630082330.82706-1-roger.pau@citrix.com> X-ClientProxiedBy: LO2P265CA0191.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::35) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2698f678-b027-4984-cf69-08da5a71dbce X-MS-TrafficTypeDiagnostic: SJ0PR03MB5421:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BHSWxp5hLoF8OqI9xBXAXYzQevNpji3uhDrxM0cIBpx6cpTGFp3dXSKlHQqfp1FVyWeoaXIDtLanh0s305BOjcMGgjAx9nvP+DRxwfdPX+0kXQ+IkWrOrCnzqGzz53MfMWqNssikfM+mylwXF6ZjkTzoDgYA8gVgi1xriMbCfTyGHA7PXWTjUwZ0yeegaQ6Vj9vN5MhwLK4egh4h32t7WMlwQM7Cu3Tq/y6kksI54xgqJZ045/fVioaIxPvk+4JP3WxZhJzL2FJUuBXchRyPojyDRohKu5U/GeW2yUQnhK/3jkthkJVtXMyyZ8dul+x+P+1V6SfZnJuj0X5D5HXA/d4XckXkiUlsNw8lnPURGsjR/U9FrOFMfrzotJ3BcvI/H4HPrgqsZQfodVFAjI4mKPTshrd5OUEHvxkh3W7MuNJbHqUBsF14Qbub5SISR/hxStOHTQ0NHaWTBf8xz2AbLCDkI5sPYF1N8Nsnz6tI31gqfo80SDq13psbUzUqL8u5qFLofsHNAL/K30D+mynoTZG94VYK1ZkVrHV3KEPGgK3YxJ24nHoadslb0qVhHNsDlt0gxT3F2EwFMlnrMoVve4BTX3rSQxF1iOj+caELxwHIYKt5y5ixvZBAnv/wb5I62Hej/MPuWxLBQxA+AKFdjhyJgyeckOg2alBW7SrA1orQh933yTHeBpd/tvitXZUJd+MSbdGTdbcbAo7n4T8l+s+k7GqQm8wn+HRPOklHvJgzB/t0+beW97mDhfCxFMTAmbQXu3CUi5XxkUHTvCarIg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(366004)(376002)(346002)(396003)(2906002)(86362001)(6666004)(478600001)(6506007)(2616005)(1076003)(5660300002)(8936002)(186003)(6916009)(82960400001)(38100700002)(6512007)(41300700001)(316002)(26005)(66946007)(6486002)(4326008)(36756003)(8676002)(66476007)(54906003)(66556008)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?09QTTKA3cLKkMTb2/kF8/sirjUly?= =?utf-8?q?AWRPVX1XtCZmYjUqljG/aW0ha3U+8PB6FHixGSsMFK1rZqQgvIwpnubvPpjJbSM1H?= =?utf-8?q?rYFvKr0xZg0OWfGgafUcfWNg9Dw+gxF7ssAZRRTK9ItlprnPG2BgAUo+o4jI/l1IS?= =?utf-8?q?6acUnDrNw/yhudRW/G5GQ1VJhqZoNR+wkTCvI9wG4YMcFQGx33eV4/+9lyzP28S6Z?= =?utf-8?q?mMOKgbi8yxJ3TtaZo8Yt4YhnIpBDONPcAIYzPusscyUa1fWI97db6QFB+pa97Copq?= =?utf-8?q?PEA6w+tPu3l5xcdvUGijGxAiBDzsdqyqPXTr928vlSOK7g2lLvIn7lEFd6UJNLPlQ?= =?utf-8?q?erIYnDiU85Jw6DBRW70e//1jyWhE+e5iirfr722KapQtP4Y5CFnMWjwZpfkBigaVn?= =?utf-8?q?vbdekg9JO8ZSdJlE+gPBELqnIBFzEOc0xeMys6nuzSIPm3qr87IvJApLBv5kOP840?= =?utf-8?q?GAvI8tZa5QWIJEhWVkg/i4y/QcWaPxP6aqtsIiWMgrT4N//f8R17aGPhDWXh7Sam/?= =?utf-8?q?k/puFZwCrfZi6/um5MPFrR2wE/JySU8oUkPZCiOCyHxpfJhRglEkijiQTXPeAxwkn?= =?utf-8?q?WX+rXCi/1eB6ZwrplrN3LKiV2ivRYwCzFfminpMTUD4fAcVVA1JrUJbeypkICYuSk?= =?utf-8?q?ucYYlxwMPf1iVr+1VkLpcWKKMCBSvXiVftxUa2kyrPqoQk0yEhn9PWYWJMwOG6xFs?= =?utf-8?q?QIfdEETIE62V3K3dBoLFk6c45/6tV6p3/7YVfdIEN+Ym+aCZQoRMd6u7co7eElrMY?= =?utf-8?q?FFi27MTmGQPOjoTo3CVGMoNd/+YJK6P3oDu5a5C7jll760MZYSygcxlsJeGc7j9WB?= =?utf-8?q?93/GWtxdBSUVKB+P/lvi4kR175ug4d1alopqr83n4h2f0F1l4YeDRPxwcHBMwrOZS?= =?utf-8?q?ySEBcpUtCWtxk2KGTCIIKoPc8GLOyhfe1JQeuhu+hpFSFADxssf0TQoiEIeywNA6C?= =?utf-8?q?3WAqsjj2DlDnETcnTTRr1mqhy4dP3f9hZFYx28aIAoOy5+tmiZbHImpEzvATs5LDV?= =?utf-8?q?REPrJo1x0v2/Xf88DZeby5O3sOdA7gOaM5YjDrm4XH6lWGfwRZm8EdYTndenlQu55?= =?utf-8?q?E6VAOTYQQp25am3JbKv4dV9C0LAxgiVxcU891yvpUnYoZ6HV2jsRAiZbIzeHjeKdy?= =?utf-8?q?8Vp98hfgOpPLDYA0EXrYoLs16sxWLKKx7iv+jbvrg0U9yIq8I9vy732cvbjBp7xrs?= =?utf-8?q?pIa/TV4GcbnPvtjxibOLsaVoZH6wc6ic2G+vohgGEPgB61oKINaL3S0AsDSFBXbmA?= =?utf-8?q?I6sBnbzky6w9XL55lDE1/3wzJNlKgL+xhWhSJPk1tCLDT0qWypie/I4GvVO7ETel+?= =?utf-8?q?mdBMGGRXIv3oFDZA0+9bLQVJyAW0EXwRO7Rg+jBedBHif4LQOGgnNIGr1eOjfWGv2?= =?utf-8?q?Zk+/0mc2IXplLLtjD1Qt8jhXDQvHJ3KfOhdBI4Jd7/QUQnoH44ZfvZyp5T5plD+tY?= =?utf-8?q?pakhFGecflkOjbUAi0uIU/K4nTglevwVCkJjVwOLKfXN4ZGPla4N8CqZL/PLDyrRL?= =?utf-8?q?Hm6CEN6MsKSUDWU0PPXHLxXKUxs/VRIFAA=3D=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2698f678-b027-4984-cf69-08da5a71dbce X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2022 08:23:49.3632 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AvpSPhxgA8qTtLtALqQPyq67qLP6ANBQN6S+gGXUP1T1a6/JVgektJWoREviMYYf4uNuzZSzGUkzN6aKy4HJ/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5421 Take the opportunity to convert the variable to read-only after init. No functional change intended. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich --- Changes since v1: - Fix help message about rounded boundary, do not round up the default value (will be done at runtime). - Use kiB instead of KB. --- xen/drivers/char/Kconfig | 10 ++++++++++ xen/drivers/char/serial.c | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig index e5f7b1d8eb..dec58bc993 100644 --- a/xen/drivers/char/Kconfig +++ b/xen/drivers/char/Kconfig @@ -74,3 +74,13 @@ config HAS_EHCI help This selects the USB based EHCI debug port to be used as a UART. If you have an x86 based system with USB, say Y. + +config SERIAL_TX_BUFSIZE + int "Size of the transmit serial buffer" + default 16384 + help + Controls the default size of the transmit buffer (in bytes) used by + the serial driver. Note the value provided will be rounded down to + the nearest power of 2. + + Default value is 16384 (16kiB). diff --git a/xen/drivers/char/serial.c b/xen/drivers/char/serial.c index 5ecba0af33..f6c944bd30 100644 --- a/xen/drivers/char/serial.c +++ b/xen/drivers/char/serial.c @@ -16,7 +16,7 @@ /* Never drop characters, even if the async transmit buffer fills. */ /* #define SERIAL_NEVER_DROP_CHARS 1 */ -unsigned int __read_mostly serial_txbufsz = 16384; +unsigned int __ro_after_init serial_txbufsz = CONFIG_SERIAL_TX_BUFSIZE; size_param("serial_tx_buffer", serial_txbufsz); #define mask_serial_rxbuf_idx(_i) ((_i)&(serial_rxbufsz-1)) From patchwork Thu Jun 30 08:23:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 12901408 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76CE7CCA47B for ; Thu, 30 Jun 2022 08:24:11 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.358299.587446 (Exim 4.92) (envelope-from ) id 1o6pSz-0000d7-JM; Thu, 30 Jun 2022 08:24:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358299.587446; Thu, 30 Jun 2022 08:24:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o6pSz-0000d0-Ec; Thu, 30 Jun 2022 08:24:01 +0000 Received: by outflank-mailman (input) for mailman id 358299; Thu, 30 Jun 2022 08:23:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o6pSx-0008UT-4L for xen-devel@lists.xenproject.org; Thu, 30 Jun 2022 08:23:59 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fbd90a7f-f84d-11ec-bd2d-47488cf2e6aa; Thu, 30 Jun 2022 10:23:57 +0200 (CEST) Received: from mail-mw2nam12lp2045.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.45]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 30 Jun 2022 04:23:55 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB5421.namprd03.prod.outlook.com (2603:10b6:a03:289::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Thu, 30 Jun 2022 08:23:53 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534%7]) with mapi id 15.20.5395.015; Thu, 30 Jun 2022 08:23:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fbd90a7f-f84d-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1656577437; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=z2tFs+C+vki8dV3dWic/vRVXguDBXQHxTduVL37e4ng=; b=B9QfIwgz4iXIrZYjwJDTdAApz6JR3XMH0NL9dZ54RM/b2ruQpatb4xLK PmnVNefIxmbZCDBRBbBUgHLR8h5i1CMswCntnm3NyTzUydhb5YTsAiFSu JVI5ny4Ru1mKhcTmTKotmZytKPJ37IF3AtU6nAgqQZq+AZeS1BN7tqI5L A=; X-IronPort-RemoteIP: 104.47.66.45 X-IronPort-MID: 75193007 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:xjf6Y6lvCemz2TCG+HBl2gHo5gycJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIZWG6Dbq3cYzH8etAibt+18E9X6JGBm9A3Tldv+CBhRCMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EgLd9IR2NYy24DnWFvV4 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYSjg2bpDNnPkkFEdXSwA9BfJNobD8Pi3q2SCT5xWun3rE5dxLVRtzGLJCv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOUu5kEgV/chegXdRraT 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IF8QPO/fJoi4TV5CZK1r73bP6MQNGPYO5SnGKkr VLF4HusV3n2M/Tak1Jp6EmEluLJ2C/2Ro8WPLm57eJxxk2ewHQJDx8bXkf9puO24ma8Ud9CL 00f+gI1sLM/skesS7HVXQC8oXOClg4RXZxXCeJSwBqW1qPe7gKdB24FZj1MctorsIkxXzNC/ kCNt8PkA3poqrL9dJ6G3rKdrDf3PDdPK2YHPHUAVVFdv4Slp5wvhBXSSNolCLSyktD+BTD3x XaNsTQ6gLIQy8UM0s1X4Gz6vt5lnbCRJiZd2+kddjjNAt9RDGJ9W7GV1A== IronPort-HdrOrdr: A9a23:FUnsEqlHGoVPFfL13Dt9BJnpElbpDfO3imdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0msl6KdhrNhR4tKPTOWw1dASbsP0WKM+UyFJ8STzI5gPO JbAtFD4b7LfCdHZLjBkW6F+r8bqbHokZxAx92ut0uFJTsaF52IhD0JbzpzfHcGJzWvUvECZe ehD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInty6IZn1V KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXkIidDqzGxvvM jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6W9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI pWwmOwrfNsfF/9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmc0a+d FVfY/hDcttABKnhyizhBgu/DXsZAV4Iv6+eDlMhiTPuAIm30yQzCMjtb4idzk7hdAAoqJ/lp X525RT5c9zp/AtHNJA7Z86MK2K40z2MGbx2TGpUCPaPZBCHU7xgLjKx5hwzN2WWfUzvegPcd L6IRhliVI= X-IronPort-AV: E=Sophos;i="5.92,233,1650945600"; d="scan'208";a="75193007" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T/SVSQ2ceycmWN9p4hcHDX0G2FDAqcH25Fj5s7xzYz7QFAxcasikpwb7WTFBft4wVQmiRqMYeIchouH6q8CRbmJ77UsBGt2/diYqFSfHzyG0K7kTx4YqGrQya1fyQTn5TD3jYRrlYL3oRNN96wS2lE8RzTv+qI7TH/aog1rSBtAacUwcOAy+SGdSk9kcrZT/6cXYgUcmz92rYr7mfokr0lBJ6MZmjNpymfzeoyynrc7m3a1ZnceTuvjtk4sn0fyjmLI3p8mCNfzLISM51mpfaEXg6kVJRzzjYbILA0OdTg6y4KRaf1wzpDq13ob44AUQoSXC5xYDhzCQR+3iWGUKBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gXm89G8vAtrVKhjl6bu6e02BU+tlRuND+6XDnIkID2A=; b=Ip80s8+gaUfzYau+c45AZOSLE2mDDwCjztSnpPBiRPBkKvc0Wa2jWNwfm9NvPnInj3po/foh4pOn9/wGE9d95K/OEunLtX6dhLC6c6lVTWglrRNqTv+R7LG1KLw4S+LO6vDxEfmZRBzJcnIjaFEMSSdvS9Zr2heqw7TPA1mbV2fdBURERJFF3dU10lv+9zx1637+48lprF58Ul0NP++YJPp9GRkv0P0VJRzzHyUQOzzg4d0NQNYNVsEZjthXpUZ3m9UVZuMVbeE0UpdiUDz2mjiKH1xCy78Ns6x9aolAojGcUVgE9lK4P9rNbA0fB+PbkqmPN0kF190O94Kcba4xZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gXm89G8vAtrVKhjl6bu6e02BU+tlRuND+6XDnIkID2A=; b=A8bZ1LL226036O3GFrBT6upp+Mg7OFJrEZqndJD3Sr6s+RJRKLWg4Mik/3aqDIdQSDIDgD40Kzbr7EtCwAQYMS6upkyIqj4lAFf9X416N6vkgmBPKjGzuBgoaTg28c3wvizdaY/la9tJgwZE3ib0RZlSanaiYCt5zQq8zaiHQoo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 2/2] console/serial: bump buffer from 16K to 32K Date: Thu, 30 Jun 2022 10:23:30 +0200 Message-Id: <20220630082330.82706-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220630082330.82706-1-roger.pau@citrix.com> References: <20220630082330.82706-1-roger.pau@citrix.com> X-ClientProxiedBy: LO4P123CA0555.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:33b::8) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9969ede9-eb63-4543-25e8-08da5a71de61 X-MS-TrafficTypeDiagnostic: SJ0PR03MB5421:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MFob2LEnNzxfGbYMRLYq4wKGIo1iurxim+j9xiOFX7M81Zlj7J9v8TmtdoWH6P6132HrYoiic8jSCa3dGnMoe/oYa/dU70iNrJtPUce18dBKh+/vmT5bvvGP31aTs1wII0hVG2Tsn9NolIpt9QF8eaY54fY0foyLpQ0ncJebVmv4wJ4ju7Kyr5if9gJ6duuBtcn/XnlIljSxAYtZoZIhS5gJXSmJdc7+oa+EaxJCDfoYhbMkhrzFkSbIb4n3fXGBvaY7rPYFLQWloiyk6XUhiILqQzE2UEs2DKjn1JdVxqa86FJIES/pe5cN50UdMtT8TnITK9i+raLG2kqhsUVYbMQEaQWoUcZ2C/A83oJlr4Zaeis/czo40pJTNrmO7lce2OuPr4YE7laUgIZq60gFjbSRfvDVca//jbLL2FO+Etyb4ooecGewMSNaCxUOhNQWP8IOWQh0bUQ9gg7vDiV4BlqBHAnBgELFBW6ycxYxAL5TazQPw8GvEJcTnEPV4qZeABRC87AbXo29YhPCavu4a1ibtvodYo3MatnyEZwAnAU0xY+R8ph9L5ixX61V+ycjjHcjIjMn9/A5pB8fXZlUtFM1as8KDDFbYRdDArTXu/Yxl0vvceIDiTBCMM9VtPUPc+Y5mknQVNR+pQ/BHwS7fl9wqp2xiuw16HDnNaHdVmDC6RkhnLrj9L+ZDGdba0m/XM5G3CLmvRiVEmh26GMmQqp5PqfG3DusY4ifQXXvnjA0dv+osfR0vFdhugjsXYIoEE072UTFqER8Om8Nm5v9bg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(366004)(376002)(346002)(396003)(2906002)(86362001)(6666004)(478600001)(6506007)(2616005)(1076003)(5660300002)(8936002)(186003)(6916009)(82960400001)(38100700002)(6512007)(41300700001)(316002)(26005)(66946007)(6486002)(4326008)(36756003)(8676002)(66476007)(54906003)(66556008)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?bPwapWuPai+8Oi5xfq4IZ45sEu3c?= =?utf-8?q?3BcQhHEyF5UbmaY5SeGVgji6L//kENoZ8Ja06RMUj25Lhi4ROXxaMqO5sjor31pdy?= =?utf-8?q?QnEDoa7L3Q6n6dgJjoV03kmNemQXuwCakmZnPtK/aRDVQ+iSUdKOIy5q+QAyvVPyR?= =?utf-8?q?AGvfTnLSpD2woBSa5/m8d3sHaolShhzsu2L08PkpoMpUmGGrl7TfPyQczhawP3BF7?= =?utf-8?q?BcE+L/XJ/UEezT1imHZV4xJK8zVLBY9rYRrIP/54xVGD8UrCB0begWRHPmK3ikiSH?= =?utf-8?q?xgFECFJJ3zMJlf47S7nsQQxEULRdRSFzX/dPw6ePMEefihu61Wzl0lV34IQs4h6hZ?= =?utf-8?q?5GzfrzV5DWUu2TQWoK1eqmW7zHeFEtAXYEg1Azf3K+dNlndgmEL3r3zciRucmg3J0?= =?utf-8?q?KEwUlUl92HY0AO2G8DWDsEO945IzapdBadluGEmOtIbap/Yp3o3w/KgxAj8hh73oY?= =?utf-8?q?m+iw/rrhllT3JliqxCKm2pNHgT6t1S38VpjhJA5Tylbx6pzZLVF5hdw5Ba7rViQdh?= =?utf-8?q?qAY7Z0eet2YZp4gr6B0jikhUeldA8a4+e6bYgHnPEmfsWzkNAka8GE/GaYkIFfKf6?= =?utf-8?q?L6ShTkWLcQakMWHUa1wm3z6ndumlb3nL+s+btAU5Ooil/gZAMLlljBKEreRY+CU2K?= =?utf-8?q?6ZWv7b/l/tDXcdcZcTbZzv4KfNGtXCf/cQnN+bcfGhw/oeGOwf+RtIKMJbqwLOX7n?= =?utf-8?q?b9Su2+uQzR2mqidoaCMdcOI9LZhtw7w7dHULH0tLwcCIjZm2eX3avNyiFOXC6dwBU?= =?utf-8?q?+faskmf2SwrmJqgySBFyAhfDEzzTv5+naNPoaDYxbX7OjM6WWodKPf35cvHwkibTg?= =?utf-8?q?XwV3ssPgwHxKAbaXry5/E0CkgO8Ie6gHI1xnXbrmMYG1qFa233UfKCNAHkz/ILcb5?= =?utf-8?q?6seKrVE4f/MLCtgTiwXu6S1Hx4o2lvSGs8/CZNQ4VJ/yqgicTWra7ARmQfcvt0WiA?= =?utf-8?q?Xd4osDEOtCP6yp76VeTSukMz7gF/q9ORsAG5t9smDwOj1I6LrEWEINSF/rvu4klHb?= =?utf-8?q?6GzkahkKPBMCgWaoGvAAXPoo4T4D1aOMUtkcxhHsGR3fF5yGLncoVPzRdeRKZ77Hb?= =?utf-8?q?1vUtUWBqnz2ipbOm256c+b1EEDXPE5EE0cfHHLwZ2zCDeA94cktzKFjwVpY34ay0P?= =?utf-8?q?eBiO5ZMG35uqJVE4GMkyQ5aQQKA8iaWDP6RbHHImmRAOb4g2r09EbfVTYAPBkrhCs?= =?utf-8?q?dvPcqPNwiKFZbalMQ+z+PzRftAF44jnJcMVdtcBfzZkwlAG4MqMTBPNlh62ZEmnE/?= =?utf-8?q?mO6m0ImukoONKOWErEqH9VqAc5hgzqlbb/Yl0p+KyGSBSTbIREQvhM90f8EojYPKD?= =?utf-8?q?YgJpI/wkt+6z5LbcCX5NtJx5atAyTHs6U9g9SMJxq0KUOfnRpZayEvMaSLqY7+Oo9?= =?utf-8?q?bM2EBD8w2GB09O3HdQ12E3Q47eeR/iGFWWGnKpx6wUFdNGxA9HrUt5uoKAfRbB0S0?= =?utf-8?q?/ySAxkHE7rn1decS/QzPqE3TLxPaScN3KuM6BeWF3upQBhN9ym4hMU92MD3JTWmd/?= =?utf-8?q?JCSuCcWdHvwIgtHOGwZYvhyL4Y9xmQ82Lw=3D=3D?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9969ede9-eb63-4543-25e8-08da5a71de61 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2022 08:23:53.6777 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sZ2IanK843qJ6RlMPbQtqYTY9x+t9PMXV3O8dVojLvSX8d9xYv0uTVgMnQAp6iBl3hndMX6hVkl9bxoiwQOffw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5421 Testing on a Kaby Lake box with 8 CPUs leads to the serial buffer being filled halfway during dom0 boot, and thus a non-trivial chunk of Linux boot messages are dropped. Increasing the buffer to 32K does fix the issue and Linux boot messages are no longer dropped. There's no justification either on why 16K was chosen, and hence bumping to 32K in order to cope with current systems generating output faster does seem appropriate to have a better user experience with the provided defaults. Signed-off-by: Roger Pau Monné --- xen/drivers/char/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig index dec58bc993..294b3509c7 100644 --- a/xen/drivers/char/Kconfig +++ b/xen/drivers/char/Kconfig @@ -77,10 +77,10 @@ config HAS_EHCI config SERIAL_TX_BUFSIZE int "Size of the transmit serial buffer" - default 16384 + default 32768 help Controls the default size of the transmit buffer (in bytes) used by the serial driver. Note the value provided will be rounded down to the nearest power of 2. - Default value is 16384 (16kiB). + Default value is 32768 (32kiB).