From patchwork Sat Jul 2 15:39:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 12904036 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 988A4C43334 for ; Sat, 2 Jul 2022 15:39:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 440961128FD; Sat, 2 Jul 2022 15:39:20 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 016DD10EB34 for ; Sat, 2 Jul 2022 15:39:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656776357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=W8c1SlBUxYM10s99ei02CiGdLvmIh2XzeBEOuTV4Qx0=; b=h4N0nmHaSEW+szFcC/zw/PEbBmR6J6mp5oMfzDtmHOMujLWliAdiHjq3DpJAkuhQh4/lii i+Z9DWNn15z0Zs6jZoMVwTr02iUrih2W1dBecnCgvNpWm0rQ3sACn4wR487Z0o/xryuk+0 17PIF9C6KYRldL6xFZe+jMqe/bbXxGo= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-341-rnaKSkJ2NO-LWVPfCVrW0w-1; Sat, 02 Jul 2022 11:39:14 -0400 X-MC-Unique: rnaKSkJ2NO-LWVPfCVrW0w-1 Received: by mail-qt1-f198.google.com with SMTP id q21-20020ac84115000000b0031bf60d9b35so2832343qtl.4 for ; Sat, 02 Jul 2022 08:39:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=W8c1SlBUxYM10s99ei02CiGdLvmIh2XzeBEOuTV4Qx0=; b=BRAb1orMQFKD0sgvXBJF4rAYgt1qa0zLIqy4ge+yLQlo9fFQn5ZcwGVrfHH8XL8Unc tU6DRqgFFirMG5r06ENxzIiMKeNKiyl/49ZsUHueXUVAMWpCeJCOS8Bq0B8KmaLFQ57/ axxA78tX2jD0auPKzLLiuYuF74jjzVgzW1VR8CmHAUXb7mDmkgGs46yGRuqo4qxAFeuh yzicCSfxO+rruSVpkHe1MUaydtW6N2mtHA/uxDKHu11IouwWIXmZskaZtljh5Z2gvqjK bOzvEyZMmJfwnMAWxzB/cKn8hgelaIVBD9eBE0hVNywOVmfQTzVH05KRAilcw2W31Acy iokw== X-Gm-Message-State: AJIora/wK+LzObSdJkeMijAoXKc+e2gQ5WhdnqC5ld8AgJCKLLqzpvqp e1jvdfqLnINck8Qxo6YBdLgg1VKg8CMxnTLWDnDR+L+++cG0Li2riRRsfRf0xMpMBCGSg7coGvM x88B1wjYxE2EbryBJoVQeDcOSXAnu X-Received: by 2002:a37:4549:0:b0:69f:556c:4e38 with SMTP id s70-20020a374549000000b0069f556c4e38mr13936458qka.202.1656776353565; Sat, 02 Jul 2022 08:39:13 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s4kMDCJkO3l6rc/tzkcDONaBzbN/O5Ul2p3pH701RTsQYUDroNVnzGAdCYv5GPNqp46q1+Vw== X-Received: by 2002:a37:4549:0:b0:69f:556c:4e38 with SMTP id s70-20020a374549000000b0069f556c4e38mr13936437qka.202.1656776353290; Sat, 02 Jul 2022 08:39:13 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id x9-20020a05620a448900b006a708baa069sm14569688qkp.101.2022.07.02.08.39.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Jul 2022 08:39:12 -0700 (PDT) From: Tom Rix To: bskeggs@redhat.com, kherbst@redhat.com, lyude@redhat.com, airlied@linux.ie, daniel@ffwll.ch, nathan@kernel.org, ndesaulniers@google.com Subject: [PATCH] drm/nouveau/bios: set info only when the return is not 0 Date: Sat, 2 Jul 2022 11:39:04 -0400 Message-Id: <20220702153904.1696595-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tom Rix Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" clang static analysis reports drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c:68:17: warning: The right operand of '*' is a garbage value [core.UndefinedBinaryOperatorResult] switch (!!data * *ver) { ^ ~~~~ A switch statement with only a default should be reduced to an if. If nvbios_pmuEp() returns 0, via the data variable, the output info parameter is not used. So set info only when data is not 0. The struct nvbios_pmuE only has the type and data elements. Since both of these are explicitly set, memset is not needed. So remove it. Signed-off-by: Tom Rix Reviewed-by: Lyude Paul --- drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c index b4a308f3cf7b..49e2664a734c 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/pmu.c @@ -64,12 +64,9 @@ nvbios_pmuEp(struct nvkm_bios *bios, int idx, u8 *ver, u8 *hdr, struct nvbios_pmuE *info) { u32 data = nvbios_pmuEe(bios, idx, ver, hdr); - memset(info, 0x00, sizeof(*info)); - switch (!!data * *ver) { - default: + if (data) { info->type = nvbios_rd08(bios, data + 0x00); info->data = nvbios_rd32(bios, data + 0x02); - break; } return data; }