From patchwork Mon Jul 4 11:36:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marek_Beh=C3=BAn?= X-Patchwork-Id: 12905169 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9DE3CCA479 for ; Mon, 4 Jul 2022 11:46:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=aZFp6+/UZ7WZjk2GdhmgvUTMX/A2wzULK9kRq3pWJmQ=; b=GX9ShSUh14mrhk 0gT3W83nuFMHo6FAZd62rgzPPPg3EcnubSq7Kk4sYMNvv6HRhgoS8QwnqKvtyMAy8a2AIe3meDypC 95rFR7XxUEOel8bae3jsBFFBQdUg1xSdo9jPpGvdgHFDd1C9aKwa/hxAvUMzPEyIbDwfdkrRXziKs l90atqnnivZgtGRdSEs5TD1i/qROAVNq0bzIe+kNtDWEGxsmcEQ5z3AyxZWyJr3rIPhkfa0UtwWwQ 9dlc1R3eLVfEfDADt3+Hmuoy0DxYzQOqUpZdjKa9RzVol/vSqqESKym6yzTy4lc2LrC4NAPKxsvHb scqVMBhnPwF7y8IXzyaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8KW7-0080Bi-N2; Mon, 04 Jul 2022 11:45:28 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8KNR-007quj-Qd for linux-arm-kernel@lists.infradead.org; Mon, 04 Jul 2022 11:36:31 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 855E961668; Mon, 4 Jul 2022 11:36:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34BB8C3411E; Mon, 4 Jul 2022 11:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656934587; bh=SXkjN9CWfiqquTLIQjLUPOKjVrOT/0zfW6DxQ4qhKPc=; h=From:To:Cc:Subject:Date:From; b=b07u89ll767XfnXtfATRsYlJLWCSS1/b6UhSoc9HbbZqpGbPPf39qL2FQcdNTLZ5D drRDR5a7D/iM/kSAtranwr5VYniLkUQj9PWEIrTT1Kg/WiVhRAPyKv/e+e4s2RGzYU YGy+tUC45Yj3fFbWghAq4uyvtpHnFGojiL7XoLDjeVm3CKO+KgaqM0l2sjEbGpg0ZZ eVydJ5d9X/zmFs0M9VHP6iCgWJkFDUDhKcO6jBsytK0DhV4/IkyvRB3rfwlcTKpHJT YuWsv/xDSdnoRFzWPBcpUDFKFH1GaWlEUurSp+8b6zvsts78xTDpNKywBZ+/PHrivF Z6zF2P3RKQiXw== From: =?utf-8?q?Marek_Beh=C3=BAn?= To: Gregory Clement , linux-arm-kernel@lists.infradead.org Cc: pali@kernel.org, Josef Schlehofer , =?utf-8?q?M?= =?utf-8?q?arek_Beh=C3=BAn?= Subject: [PATCH mvebu/dt 1/2] ARM: dts: turris-omnia: configure LED[0] pin function to link/activity Date: Mon, 4 Jul 2022 13:36:21 +0200 Message-Id: <20220704113622.18887-1-kabel@kernel.org> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220704_043629_935268_B0C0E7AE X-CRM114-Status: GOOD ( 12.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The marvell PHY driver changes the LED[0] pin function to "On - 1000 Mbps Link, Off - Else". Turris Omnia expects that the function is "On - Link, Blink - Activity, Off - No link". Use the `marvell,reg-init` DT property to change the function. In the future, once netdev trigger will support HW offloading, we will be able to have this configured via the combination of PHY driver and leds-turris-omnia driver. Signed-off-by: Marek Behún --- arch/arm/boot/dts/armada-385-turris-omnia.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts index f4878df39753..1583c4b14ae8 100644 --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts @@ -397,7 +397,8 @@ &mdio { phy1: ethernet-phy@1 { compatible = "ethernet-phy-ieee802.3-c22"; reg = <1>; - marvell,reg-init = <3 18 0 0x4985>; + marvell,reg-init = <3 18 0 0x4985>, + <3 16 0xfff0 0x0001>; /* irq is connected to &pcawan pin 7 */ }; From patchwork Mon Jul 4 11:36:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marek_Beh=C3=BAn?= X-Patchwork-Id: 12905170 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80F66C43334 for ; Mon, 4 Jul 2022 11:47:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YJ+t5rZg7LBYISmFIsoDechI6fMAKxB7SF3sVnla+Vc=; b=cvumSRa74oY+VI EkRs8cpM3Qn+whKLs3/SbSiT8eUNr/hRB4u8fY/MRxIUH9RbnxGqVeZyVcJq4F9jrUDFmkzEvVd3o op3hWJe/us2Et9vLiAt4Anw33DSG/wOjNijFkdebBb73+pv2UOf9m8rUReof+7hCisktOuHhopuBD 0TubVkbnuUYE+3PU6C9p2EIax3klEJflz5CeuOaHb/MgzjI4ji1xLwWUYHoJcrNHKB9NJIHp7mB1L CksLp9hoL+JSuLZw9b1ZkkOoKUAGMqQCoRKgNdpkUq3SeU+rLCzy3heYI0EwvW3+JUWYz3pEdh+ov pqgOpS8UaGNuQT04jGrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8KWg-008198-FG; Mon, 04 Jul 2022 11:46:03 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8KNS-007qvL-6a for linux-arm-kernel@lists.infradead.org; Mon, 04 Jul 2022 11:36:31 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1722F6165D; Mon, 4 Jul 2022 11:36:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF014C341D2; Mon, 4 Jul 2022 11:36:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656934588; bh=cIWFN2BYA+GeJRHUsN7ar1E+hsDPwDmlfLw92eHiFuc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ERnS77HT4ZqBDmoVmx39s024+P23ty39wLOUkciUtuWOOd4Px6Mp+78ND7nOimPuI KPUCZseqSUpP6Z5ML7ZQIxIhkn8e5uexKei073GqBM2s//AMmwRaM8LKyuO9Z3STWE YNQFSzwpaHuOHTTa/ZmFxkysUO7OYCSBQiNCy49iyicdKWCPK0jJ2hbLxYoqQWAszq PaKQvR9Byz0ofzmSReleRivOva0s0JVGzdYuJAZvsXKaFTklyugnALxed4omG+bA5b WSP/w8rN5Nyyg6F5IHrATxnCYlDQ2EUX5oq35EMtdrzRes1WgzfWDTj6qGDC1PPAMT Pxok6CIl1enXw== From: =?utf-8?q?Marek_Beh=C3=BAn?= To: Gregory Clement , linux-arm-kernel@lists.infradead.org Cc: pali@kernel.org, Josef Schlehofer , =?utf-8?q?M?= =?utf-8?q?arek_Beh=C3=BAn?= Subject: [PATCH mvebu/dt 2/2] ARM: dts: turris-omnia: enable LED controller node Date: Mon, 4 Jul 2022 13:36:22 +0200 Message-Id: <20220704113622.18887-2-kabel@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220704113622.18887-1-kabel@kernel.org> References: <20220704113622.18887-1-kabel@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220704_043630_404609_32D82451 X-CRM114-Status: GOOD ( 15.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The LED controller node is disabled because the leds-turris-omnia driver does not support setting the LED blinking to be controlled by the MCU. The patches for that have now been sent [1], so let's enable the node. [1] https://lore.kernel.org/linux-leds/20220704105955.15474-1-kabel@kernel.org/T/ Signed-off-by: Marek Behún --- arch/arm/boot/dts/armada-385-turris-omnia.dts | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts index 1583c4b14ae8..d1e0db6e5730 100644 --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts @@ -191,15 +191,13 @@ led-controller@2b { reg = <0x2b>; #address-cells = <1>; #size-cells = <0>; + status = "okay"; /* * LEDs are controlled by MCU (STM32F0) at * address 0x2b. * - * The driver does not support HW control mode - * for the LEDs yet. Disable the LEDs for now. - * - * Also LED functions are not stable yet: + * LED functions are not stable yet: * - there are 3 LEDs connected via MCU to PCIe * ports. One of these ports supports mSATA. * There is no mSATA nor PCIe function. @@ -210,7 +208,6 @@ led-controller@2b { * B. Again there is no such function defined. * For now we use LED_FUNCTION_INDICATOR */ - status = "disabled"; multi-led@0 { reg = <0x0>;