From patchwork Tue Jul 5 09:41:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906236 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68346CCA47B for ; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231280AbiGEJtE (ORCPT ); Tue, 5 Jul 2022 05:49:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229972AbiGEJtE (ORCPT ); Tue, 5 Jul 2022 05:49:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE52438A1; Tue, 5 Jul 2022 02:49:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6AD7361919; Tue, 5 Jul 2022 09:49:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 311AAC341D5; Tue, 5 Jul 2022 09:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014542; bh=Vc4R/y9mBKNiS8vedJbz+BXjfJtt2YyS5z6mX/z//hg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Afj5P0paU3YpfxgARnGWfWsYUTPCDSiRtwOuY6FrgR4Nlnn4dqDfypytdrb3xtaW9 wYq56e6bYXXo0pFHlbm7z8CAJeaLAbCjgcqB8YQpTQQEXmzYCZbtGMhOFpgSjg9/2i t9kchhKGDu7t3WBG1P4Zg/L1DvtbjP2MRAQAst20AS57duMtPUzebjcYOT6hSB0FPe JqcEpUZ02JMH0QdOhc9+odl3Zz62+yEGNWQcUOUuoBP8o42QeOrL5iDKWGfOBgH1Qk 0XEPGvAc308gPAj8j6wYbqDigo3rgMkddGlj45zryD6vUoV0fXtcqpljE3PbxuwnII 1XVXE96bfbncA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB0-0004Wt-Jl; Tue, 05 Jul 2022 11:49:02 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 01/43] dt-bindings: phy: qcom,qmp: fix bogus clock-cells property Date: Tue, 5 Jul 2022 11:41:57 +0200 Message-Id: <20220705094239.17174-2-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The QMP PHY wrapper node is not a clock provider so drop the bogus '#clock-cells' property that was added when converting to DT schema. Fixes: ccf51c1cedfd ("dt-bindings: phy: qcom,qmp: Convert QMP PHY bindings to yaml") Signed-off-by: Johan Hovold Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml index 8b850c5ab116..f74b3bf34a23 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml @@ -66,9 +66,6 @@ properties: - description: Address and length of PHY's common serdes block. - description: Address and length of PHY's DP_COM control block. - "#clock-cells": - enum: [ 1, 2 ] - "#address-cells": enum: [ 1, 2 ] @@ -116,7 +113,6 @@ patternProperties: required: - compatible - reg - - "#clock-cells" - "#address-cells" - "#size-cells" - ranges @@ -468,7 +464,6 @@ examples: usb_2_qmpphy: phy-wrapper@88eb000 { compatible = "qcom,sdm845-qmp-usb3-uni-phy"; reg = <0x088eb000 0x18c>; - #clock-cells = <1>; #address-cells = <1>; #size-cells = <1>; ranges = <0x0 0x088eb000 0x2000>; From patchwork Tue Jul 5 09:41:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906265 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18C01C43334 for ; Tue, 5 Jul 2022 09:49:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231834AbiGEJta (ORCPT ); Tue, 5 Jul 2022 05:49:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231614AbiGEJtU (ORCPT ); Tue, 5 Jul 2022 05:49:20 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B4821277E; Tue, 5 Jul 2022 02:49:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id B5914CE1ABE; Tue, 5 Jul 2022 09:49:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F5D8C341CB; Tue, 5 Jul 2022 09:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014542; bh=1ywPuUGGmVk88S12Lk0XJfL/+Jy0pPRKtjm1IVstW78=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c6KZVuLfU3aIE/1QuMLiqqYH1Zkodqo3a9BBQvcecMYItrVqRyyj5npEVkwaTOfjN 2UoZAJUyrT6/ZAkZUs5I4WRXWkqEvEYKV1bX43mpsCEMNIPhGDaW7w2TcR0PFHk/hW 0KbmfsY8AZIkGDzOvCbrv+yzyW+L+OZtjzVUgVP5MliHCFhthh83u2zWhpl4nrO5R3 z5cKmi+4hXBMIPbx6gCcgZnAKwFCLiwISIBaLIz6Mx5QuJFBTuKMCOlCtcwqvSi8ef d7Ac1LSLKZ5iluof8MUzJjCzbXBfv6KmCRkxcO67QHK/ZEtCd6xdjOzuRo5qse/AaI G9IOu60LIkXyQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB0-0004Wv-Mv; Tue, 05 Jul 2022 11:49:02 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 02/43] dt-bindings: phy: qcom,qmp: sort compatible strings Date: Tue, 5 Jul 2022 11:41:58 +0200 Message-Id: <20220705094239.17174-3-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Sort the compatible strings alphabetically to make it easier to look up entries and add new ones. Signed-off-by: Johan Hovold Acked-by: Krzysztof Kozlowski --- .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml index f74b3bf34a23..38e0ade01687 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml @@ -38,15 +38,18 @@ properties: - qcom,sdm845-qmp-ufs-phy - qcom,sdm845-qmp-usb3-phy - qcom,sdm845-qmp-usb3-uni-phy + - qcom,sdx55-qmp-pcie-phy + - qcom,sdx55-qmp-usb3-uni-phy + - qcom,sdx65-qmp-usb3-uni-phy - qcom,sm6115-qmp-ufs-phy - qcom,sm6350-qmp-ufs-phy - qcom,sm8150-qmp-ufs-phy - qcom,sm8150-qmp-usb3-phy - qcom,sm8150-qmp-usb3-uni-phy - - qcom,sm8250-qmp-ufs-phy - qcom,sm8250-qmp-gen3x1-pcie-phy - qcom,sm8250-qmp-gen3x2-pcie-phy - qcom,sm8250-qmp-modem-pcie-phy + - qcom,sm8250-qmp-ufs-phy - qcom,sm8250-qmp-usb3-phy - qcom,sm8250-qmp-usb3-uni-phy - qcom,sm8350-qmp-ufs-phy @@ -56,9 +59,6 @@ properties: - qcom,sm8450-qmp-gen4x2-pcie-phy - qcom,sm8450-qmp-ufs-phy - qcom,sm8450-qmp-usb3-phy - - qcom,sdx55-qmp-pcie-phy - - qcom,sdx55-qmp-usb3-uni-phy - - qcom,sdx65-qmp-usb3-uni-phy reg: minItems: 1 @@ -277,12 +277,12 @@ allOf: contains: enum: - qcom,msm8998-qmp-ufs-phy + - qcom,sc8180x-qmp-ufs-phy + - qcom,sc8280xp-qmp-ufs-phy - qcom,sdm845-qmp-ufs-phy - qcom,sm6350-qmp-ufs-phy - qcom,sm8150-qmp-ufs-phy - qcom,sm8250-qmp-ufs-phy - - qcom,sc8180x-qmp-ufs-phy - - qcom,sc8280xp-qmp-ufs-phy then: properties: clocks: From patchwork Tue Jul 5 09:41:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906256 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0DF3C43334 for ; Tue, 5 Jul 2022 09:49:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231689AbiGEJtV (ORCPT ); Tue, 5 Jul 2022 05:49:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230517AbiGEJtI (ORCPT ); Tue, 5 Jul 2022 05:49:08 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BD3512AC9; Tue, 5 Jul 2022 02:49:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 6B5E6CE1811; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23D1DC341CF; Tue, 5 Jul 2022 09:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014542; bh=7FwLRC+kaJKNAor2Em2HVLe0zohhBgTEt6rXgUIFLUg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UaJguFOMq3Vfr33WlA8A3NoNXHyeszzqG1TbiJfnDbvPTkut1oe0aIE9LPQWog7G/ xzsdtYoIPhhx2VaWBuX5iBg4Bm5KQZhDqH0Wkn4f03KS4+yDgfx4DX3LB962wSQzUp wMGX+0SbToYTJ6OcwWC5t+lPJMZ20Wgxg4uFDMReU4ZUG6xdfXWgNLC6v+1MMY1Xoi nRtrywYibb+ev2pcHjrmvlsXcb/wFZSBGpyjWfWunNhQUjnh0VdZNteuEPZYOAKXG5 YvQKThVycIkocjR/yWTVP1OgISMGcdWMv8gZ2iOA0nM1Czq5QZT8c45QJH52wYd43x G91HZcKt6P0tw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB0-0004Wx-PT; Tue, 05 Jul 2022 11:49:02 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 03/43] dt-bindings: phy: qcom,qmp: clean up descriptions Date: Tue, 5 Jul 2022 11:41:59 +0200 Message-Id: <20220705094239.17174-4-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Clean up the descriptions somewhat by using uppercase "PHY" consistently and spelling out "clock". Signed-off-by: Johan Hovold Reviewed-by: Krzysztof Kozlowski --- .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 102 +++++++++--------- 1 file changed, 51 insertions(+), 51 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml index 38e0ade01687..83f777b4636f 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml @@ -11,7 +11,7 @@ maintainers: - Vinod Koul description: - QMP phy controller supports physical layer functionality for a number of + QMP PHY controller supports physical layer functionality for a number of controllers on Qualcomm chipsets, such as, PCIe, UFS, and USB. properties: @@ -107,7 +107,7 @@ patternProperties: "^phy@[0-9a-f]+$": type: object description: - Each device node of QMP phy is required to have as many child nodes as + Each device node of QMP PHY is required to have as many child nodes as the number of lanes the PHY has. required: @@ -134,10 +134,10 @@ allOf: properties: clocks: items: - - description: Phy aux clock. - - description: Phy config clock. - - description: 19.2 MHz ref clk. - - description: Phy common block aux clock. + - description: PHY aux clock. + - description: PHY config clock. + - description: 19.2 MHz ref clock. + - description: PHY common block aux clock. clock-names: items: - const: aux @@ -146,8 +146,8 @@ allOf: - const: com_aux resets: items: - - description: reset of phy block. - - description: phy common block reset. + - description: Reset of PHY block. + - description: PHY common block reset. reset-names: items: - const: phy @@ -166,9 +166,9 @@ allOf: properties: clocks: items: - - description: Phy aux clock. - - description: Phy config clock. - - description: 19.2 MHz ref clk. + - description: PHY aux clock. + - description: PHY config clock. + - description: 19.2 MHz ref clock. clock-names: items: - const: aux @@ -176,8 +176,8 @@ allOf: - const: ref resets: items: - - description: reset of phy block. - - description: phy common block reset. + - description: Reset of PHY block. + - description: PHY common block reset. reset-names: items: - const: phy @@ -195,9 +195,9 @@ allOf: properties: clocks: items: - - description: Phy aux clock. - - description: Phy config clock. - - description: 19.2 MHz ref clk. + - description: PHY aux clock. + - description: PHY config clock. + - description: 19.2 MHz ref clock. clock-names: items: - const: aux @@ -205,9 +205,9 @@ allOf: - const: ref resets: items: - - description: reset of phy block. - - description: phy common block reset. - - description: phy's ahb cfg block reset. + - description: Reset of PHY block. + - description: PHY common block reset. + - description: PHY's ahb cfg block reset. reset-names: items: - const: phy @@ -229,9 +229,9 @@ allOf: properties: clocks: items: - - description: Phy aux clock. - - description: Phy config clock. - - description: 19.2 MHz ref clk. + - description: PHY aux clock. + - description: PHY config clock. + - description: 19.2 MHz ref clock. clock-names: items: - const: aux @@ -239,8 +239,8 @@ allOf: - const: ref resets: items: - - description: reset of phy block. - - description: phy common block reset. + - description: Reset of PHY block. + - description: PHY common block reset. reset-names: items: - const: phy @@ -258,7 +258,7 @@ allOf: properties: clocks: items: - - description: 19.2 MHz ref clk. + - description: 19.2 MHz ref clock. clock-names: items: - const: ref @@ -287,8 +287,8 @@ allOf: properties: clocks: items: - - description: 19.2 MHz ref clk. - - description: Phy reference aux clock. + - description: 19.2 MHz ref clock. + - description: PHY reference aux clock. clock-names: items: - const: ref @@ -313,16 +313,16 @@ allOf: properties: clocks: items: - - description: Phy aux clock. - - description: Phy config clock. + - description: PHY aux clock. + - description: PHY config clock. clock-names: items: - const: aux - const: cfg_ahb resets: items: - - description: reset of phy block. - - description: phy common block reset. + - description: Reset of PHY block. + - description: PHY common block reset. reset-names: items: - const: phy @@ -345,10 +345,10 @@ allOf: properties: clocks: items: - - description: Phy aux clock. - - description: Phy config clock. - - description: 19.2 MHz ref clk. - - description: Phy refgen clk. + - description: PHY aux clock. + - description: PHY config clock. + - description: 19.2 MHz ref clock. + - description: PHY refgen clock. clock-names: items: - const: aux @@ -357,7 +357,7 @@ allOf: - const: refgen resets: items: - - description: reset of phy block. + - description: Reset of PHY block. reset-names: items: - const: phy @@ -377,10 +377,10 @@ allOf: properties: clocks: items: - - description: Phy aux clock. - - description: 19.2 MHz ref clk source. - - description: 19.2 MHz ref clk. - - description: Phy common block aux clock. + - description: PHY aux clock. + - description: 19.2 MHz ref clock source. + - description: 19.2 MHz ref clock. + - description: PHY common block aux clock. clock-names: items: - const: aux @@ -389,8 +389,8 @@ allOf: - const: com_aux resets: items: - - description: reset of phy block. - - description: phy common block reset. + - description: Reset of PHY block. + - description: PHY common block reset. reset-names: items: - const: phy @@ -409,9 +409,9 @@ allOf: properties: clocks: items: - - description: Phy aux clock. - - description: 19.2 MHz ref clk. - - description: Phy common block aux clock. + - description: PHY aux clock. + - description: 19.2 MHz ref clock. + - description: PHY common block aux clock. clock-names: items: - const: aux @@ -419,8 +419,8 @@ allOf: - const: com_aux resets: items: - - description: reset of phy block. - - description: phy common block reset. + - description: Reset of PHY block. + - description: PHY common block reset. reset-names: items: - const: phy @@ -438,9 +438,9 @@ allOf: properties: clocks: items: - - description: Phy config clock. - - description: 19.2 MHz ref clk. - - description: Phy common block aux clock. + - description: PHY config clock. + - description: 19.2 MHz ref clock. + - description: PHY common block aux clock. clock-names: items: - const: cfg_ahb @@ -449,7 +449,7 @@ allOf: resets: items: - description: phy_phy reset. - - description: reset of phy block. + - description: reset of PHY block. reset-names: items: - const: phy_phy From patchwork Tue Jul 5 09:42:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906251 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52AEFC433EF for ; Tue, 5 Jul 2022 09:49:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231543AbiGEJtR (ORCPT ); Tue, 5 Jul 2022 05:49:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231162AbiGEJtH (ORCPT ); Tue, 5 Jul 2022 05:49:07 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B40B12777; Tue, 5 Jul 2022 02:49:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 0BA3ECE1AF8; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21808C341D0; Tue, 5 Jul 2022 09:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014542; bh=hOZdnrgEGFBVc2ds9Xi9MI9BeEk4FYW9RhPpXX4KXlg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XqNkofo+AaX1/AKivDAxrHFCS6fce32JK3UTXsYi9SsCjl28VMSfI6sxzEXEunkQV FVvw7qViIOT9WAWqwMTEuWust6QJiR0bN3eEKVP/SmcT8sqEsxCOpDEJulI6cVUrFU sGgx9ZLIHf8v+GqrNSXqCOK4asnqE6q7c74rk5NNVomVRD8kivj3n+I4AfS0GChRik ZgIjXdWEFqNtmjTATN43B6dJgRbu/L2vordtfORhHjS1CLePWGM7IWnoeS1nrl0jk6 zcASf9H8AZ2v7ZN14tqoHtRNHwDpVkb1L8/qrNeie4SejF6d9YI91/dpNsY3OYtnZo PngVpUdQl8wQA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB0-0004Wz-S4; Tue, 05 Jul 2022 11:49:02 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 04/43] dt-bindings: phy: qcom,qmp: clean up example Date: Tue, 5 Jul 2022 11:42:00 +0200 Message-Id: <20220705094239.17174-5-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Clean up the example node somewhat by grouping consumer and provider properties in the child node. Signed-off-by: Johan Hovold Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml index 83f777b4636f..e678d7d5f675 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml @@ -486,10 +486,13 @@ examples: <0x400 0x1fc>, <0x800 0x218>, <0x600 0x70>; - #clock-cells = <0>; - #phy-cells = <0>; + clocks = <&gcc GCC_USB3_SEC_PHY_PIPE_CLK>; clock-names = "pipe0"; + + #clock-cells = <0>; clock-output-names = "usb3_uni_phy_pipe_clk_src"; + + #phy-cells = <0>; }; }; From patchwork Tue Jul 5 09:42:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906252 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0513BCCA485 for ; Tue, 5 Jul 2022 09:49:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231561AbiGEJtS (ORCPT ); Tue, 5 Jul 2022 05:49:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230074AbiGEJtH (ORCPT ); Tue, 5 Jul 2022 05:49:07 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DD3412AFE; Tue, 5 Jul 2022 02:49:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id EF55ACE1AF7; Tue, 5 Jul 2022 09:49:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BF3AC341D4; Tue, 5 Jul 2022 09:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014542; bh=p3mr02cgG6LBw6uKHFUORY4E7Plh2e80DzO9eY0jrjY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=siJmP5GC30d2xtj3Kb3hqdhf7zj64JqJrLfzkxBYmC07SbtgPWGc5hCYfn8r1iuHc X97IkQYdoNN1YV9FHminpSHkd5DmUT9xUChgKkJGQ9TLHDwYnACcnTL2qceaOENNPA NdnIGt+PymemGBy9xQIAy1GoMVTyWc1nlBFATmSzXZc0Pfc+KbIRJ40JcC0jhIc9+a 4RRvS+o4Wwt1K8+KWISBWUns3W0oTxgdY/ZCsdImfZNygF9DdhqO1gTLPiip47V6Us 2rOmHc5rNaG4CsCpt7HMcRPDbcq9D7oBvUpKrxy2My8aNv3qNRymTKCqPo07ei9L9T 7OBA5c7JRQ6IQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB0-0004X2-Uc; Tue, 05 Jul 2022 11:49:02 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 05/43] dt-bindings: phy: qcom,qmp: drop child-node comment Date: Tue, 5 Jul 2022 11:42:01 +0200 Message-Id: <20220705094239.17174-6-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Drop the redundant comment about child nodes being required that was copied from the old binding documentation. Signed-off-by: Johan Hovold Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml index e678d7d5f675..bca006e41821 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml @@ -102,7 +102,6 @@ properties: description: Phandle to a regulator supply to any specific refclk pll block. -#Required nodes: patternProperties: "^phy@[0-9a-f]+$": type: object From patchwork Tue Jul 5 09:42:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906249 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12E75CCA47F for ; Tue, 5 Jul 2022 09:49:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231303AbiGEJtQ (ORCPT ); Tue, 5 Jul 2022 05:49:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231356AbiGEJtG (ORCPT ); Tue, 5 Jul 2022 05:49:06 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4147266B; Tue, 5 Jul 2022 02:49:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7A498B816CA; Tue, 5 Jul 2022 09:49:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27361C341D2; Tue, 5 Jul 2022 09:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014542; bh=FQcNecU5EN3xvEBaRrDBNhVj2QdH74mRC4IAq8Yjrog=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DGlfmyCGrxx0Bsgsr3Vho2ChSD5Ptb1KUzM+seaZ+hyhCC/2EZ/T1ykQyQx2lGqQy 3+VwfNHui4wJoqPynUjzjuyv6Qws0EG3vGkYctg9KVrbO3ht/8tySaiNRNSSx0aDQh d5CMvjj8T6917jYpmSKK9e2T/ypakDQFE44xto4T2gl/o8OHqx6Gv3cvClz/FoPnLv waWOnyVUbT1yYENexm2zEudDB3+/tjwStpfthXV9yCQMXWwZxCjdX4s8GV1En0Cntb 0HblG+PpCdFzxiLXeqO0bCMdPnmaiXnrAg81m0sqJMjzF85ExIxUZATqK8z3s0W16T 9L3kJLu/pOPUg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB1-0004X6-1Z; Tue, 05 Jul 2022 11:49:03 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 06/43] dt-bindings: phy: qcom,qmp: split out msm8996-qmp-pcie-phy Date: Tue, 5 Jul 2022 11:42:02 +0200 Message-Id: <20220705094239.17174-7-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The QMP PHY DT schema is getting unwieldy. Break out the odd-bird msm8996-qmp-pcie-phy which is the only QMP PHY that uses separate "per-lane" nodes. Signed-off-by: Johan Hovold --- .../phy/qcom,msm8996-qmp-pcie-phy.yaml | 114 ++++++++++++++++++ .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 32 ----- 2 files changed, 114 insertions(+), 32 deletions(-) create mode 100644 Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml new file mode 100644 index 000000000000..14fd86fd91ec --- /dev/null +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml @@ -0,0 +1,114 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) + +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/qcom,msm8996-qmp-pcie-phy.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Qualcomm QMP PHY controller (MSM8996 PCIe) + +maintainers: + - Vinod Koul + +description: + QMP PHY controller supports physical layer functionality for a number of + controllers on Qualcomm chipsets, such as, PCIe, UFS, and USB. + +properties: + compatible: + const: qcom,msm8996-qmp-pcie-phy + + reg: + minItems: 1 + items: + - description: Address and length of PHY's common serdes block. + - description: Address and length of PHY's DP_COM control block. + + "#address-cells": + enum: [ 1, 2 ] + + "#size-cells": + enum: [ 1, 2 ] + + ranges: true + + clocks: + minItems: 1 + maxItems: 4 + + clock-names: + minItems: 1 + maxItems: 4 + + resets: + minItems: 1 + maxItems: 3 + + reset-names: + minItems: 1 + maxItems: 3 + + vdda-phy-supply: + description: + Phandle to a regulator supply to PHY core block. + + vdda-pll-supply: + description: + Phandle to 1.8V regulator supply to PHY refclk pll block. + + vddp-ref-clk-supply: + description: + Phandle to a regulator supply to any specific refclk pll block. + +patternProperties: + "^phy@[0-9a-f]+$": + type: object + description: + Each device node of QMP PHY is required to have as many child nodes as + the number of lanes the PHY has. + +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + - ranges + - clocks + - clock-names + - resets + - reset-names + +additionalProperties: false + +allOf: + - if: + properties: + compatible: + contains: + enum: + - qcom,msm8996-qmp-pcie-phy + then: + properties: + clocks: + items: + - description: PHY aux clock. + - description: PHY config clock. + - description: 19.2 MHz ref clock. + clock-names: + items: + - const: aux + - const: cfg_ahb + - const: ref + resets: + items: + - description: Reset of PHY block. + - description: PHY common block reset. + - description: PHY's ahb cfg block reset. + reset-names: + items: + - const: phy + - const: common + - const: cfg + required: + - vdda-phy-supply + - vdda-pll-supply diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml index bca006e41821..7a76fd286cee 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml @@ -21,7 +21,6 @@ properties: - qcom,ipq6018-qmp-usb3-phy - qcom,ipq8074-qmp-pcie-phy - qcom,ipq8074-qmp-usb3-phy - - qcom,msm8996-qmp-pcie-phy - qcom,msm8996-qmp-ufs-phy - qcom,msm8996-qmp-usb3-phy - qcom,msm8998-qmp-pcie-phy @@ -184,37 +183,6 @@ allOf: required: - vdda-phy-supply - vdda-pll-supply - - if: - properties: - compatible: - contains: - enum: - - qcom,msm8996-qmp-pcie-phy - then: - properties: - clocks: - items: - - description: PHY aux clock. - - description: PHY config clock. - - description: 19.2 MHz ref clock. - clock-names: - items: - - const: aux - - const: cfg_ahb - - const: ref - resets: - items: - - description: Reset of PHY block. - - description: PHY common block reset. - - description: PHY's ahb cfg block reset. - reset-names: - items: - - const: phy - - const: common - - const: cfg - required: - - vdda-phy-supply - - vdda-pll-supply - if: properties: compatible: From patchwork Tue Jul 5 09:42:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906237 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB078CCA47F for ; Tue, 5 Jul 2022 09:49:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231332AbiGEJtF (ORCPT ); Tue, 5 Jul 2022 05:49:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231154AbiGEJtE (ORCPT ); Tue, 5 Jul 2022 05:49:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E8DADFB9; Tue, 5 Jul 2022 02:49:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9EBB56191C; Tue, 5 Jul 2022 09:49:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D140C341E1; Tue, 5 Jul 2022 09:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014542; bh=5IEFwvykKWpluWYXuOvfZ01fDmcJ5NrUbb4Qf56H6+g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fvKR8YLNh6OgoPX2GLks3m2adddWQtdVdc/rNcRL0ZkIEzfSO0DHlLGw/fGPEM4AC Qc7Thw9QZhHLpEAVo7pCxBFHAb70VESP6/F+vDykawvtTudUwOVIDIRrNaZJsWGvhS 7ml2Ug1lQzFexSGVHeZTfGeR+8DO7twQm57/Z6Ic+f1Qx3n5DXwWuFEXsMUmaQ8kLK YD1RI/Bl8MYxgzwrwFmAPD0bLa2ZR+OyeU5kCuzdZ8Evbk6GMV5/vLdqUvFhfhF+9N iw+7RI9FpJNDocQYt4twpUoYbWrvPBdLItla/zVqosHlX3tEJqLwk+HZD3V6no1iSs 7/tMu+eL9tQaA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB1-0004X9-46; Tue, 05 Jul 2022 11:49:03 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 07/43] dt-bindings: phy: qcom,msm8996-qmp-pcie: clean up constraints Date: Tue, 5 Jul 2022 11:42:03 +0200 Message-Id: <20220705094239.17174-8-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Drop the compatible conditional and tighten the property constraints. Signed-off-by: Johan Hovold --- .../phy/qcom,msm8996-qmp-pcie-phy.yaml | 65 +++++-------------- 1 file changed, 18 insertions(+), 47 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml index 14fd86fd91ec..b73bf5c06358 100644 --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml @@ -19,10 +19,8 @@ properties: const: qcom,msm8996-qmp-pcie-phy reg: - minItems: 1 items: - description: Address and length of PHY's common serdes block. - - description: Address and length of PHY's DP_COM control block. "#address-cells": enum: [ 1, 2 ] @@ -33,20 +31,28 @@ properties: ranges: true clocks: - minItems: 1 - maxItems: 4 + items: + - description: PHY aux clock. + - description: PHY config clock. + - description: 19.2 MHz ref clock. clock-names: - minItems: 1 - maxItems: 4 + items: + - const: aux + - const: cfg_ahb + - const: ref resets: - minItems: 1 - maxItems: 3 + items: + - description: Reset of PHY block. + - description: PHY common block reset. + - description: PHY's ahb cfg block reset. reset-names: - minItems: 1 - maxItems: 3 + items: + - const: phy + - const: common + - const: cfg vdda-phy-supply: description: @@ -56,10 +62,6 @@ properties: description: Phandle to 1.8V regulator supply to PHY refclk pll block. - vddp-ref-clk-supply: - description: - Phandle to a regulator supply to any specific refclk pll block. - patternProperties: "^phy@[0-9a-f]+$": type: object @@ -77,38 +79,7 @@ required: - clock-names - resets - reset-names + - vdda-phy-supply + - vdda-pll-supply additionalProperties: false - -allOf: - - if: - properties: - compatible: - contains: - enum: - - qcom,msm8996-qmp-pcie-phy - then: - properties: - clocks: - items: - - description: PHY aux clock. - - description: PHY config clock. - - description: 19.2 MHz ref clock. - clock-names: - items: - - const: aux - - const: cfg_ahb - - const: ref - resets: - items: - - description: Reset of PHY block. - - description: PHY common block reset. - - description: PHY's ahb cfg block reset. - reset-names: - items: - - const: phy - - const: common - - const: cfg - required: - - vdda-phy-supply - - vdda-pll-supply From patchwork Tue Jul 5 09:42:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906260 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A58C9CCA481 for ; Tue, 5 Jul 2022 09:49:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231787AbiGEJt0 (ORCPT ); Tue, 5 Jul 2022 05:49:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231465AbiGEJtJ (ORCPT ); Tue, 5 Jul 2022 05:49:09 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F82B11460; Tue, 5 Jul 2022 02:49:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DF6FDB8171A; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BD84C341E5; Tue, 5 Jul 2022 09:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014542; bh=NMxyyY5EOHfjt1+lyrJz2Sw7j5+cVRS+u/94icaLdxk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fc0zByHa8OBPw8ZPM3aEkjaODp1ACGATqXRzqG/DX8fu/t/gpsp5+LgQcupn/nghK 6fql2kkMWoYp/Q+FjrsmvGCrW851LtsziS3NxWDxcMMHOVt2T53ADzXzb1qj6bbcTh WFsXLP2eCaiAsWpSN2Pl7vnCbvmMR6OaWVYf40PNcXOMziit732qGIge7lL7vcInLP ymtsIWrGsNDlIV6SbXTj6CI9MXj2eQyWvulfBZ4+Hs4S0g/bCjFUEKGbCyE063Xqx8 KHlPl/4yLGe47B5u1KCzK0id67EmDXgHVbr3Zo2/HTScldI6nbuylM4IkGxjAQGMFV Rdi4RfmRMEk7g== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB1-0004XC-7O; Tue, 05 Jul 2022 11:49:03 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 08/43] dt-bindings: phy: qcom,msm8996-qmp-pcie: add missing child node schema Date: Tue, 5 Jul 2022 11:42:04 +0200 Message-Id: <20220705094239.17174-9-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Add the missing the description of the PHY-provider child nodes which were ignored when converting to DT schema. Also fix up the description that claimed that one child node per lane (rather than PHY) was required. Fixes: ccf51c1cedfd ("dt-bindings: phy: qcom,qmp: Convert QMP PHY bindings to yaml") Signed-off-by: Johan Hovold Reviewed-by: Krzysztof Kozlowski --- .../phy/qcom,msm8996-qmp-pcie-phy.yaml | 51 ++++++++++++++++++- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml index b73bf5c06358..8aadb25686b2 100644 --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml @@ -66,8 +66,55 @@ patternProperties: "^phy@[0-9a-f]+$": type: object description: - Each device node of QMP PHY is required to have as many child nodes as - the number of lanes the PHY has. + One child node per PHY provided by this block. + properties: + reg: + items: + - description: TX + - description: RX + - description: PCS + + clocks: + items: + - description: PIPE clock + + clock-names: + items: + - enum: + - pipe0 + - pipe1 + - pipe2 + + resets: + items: + - description: PHY (lane) reset + + reset-names: + items: + - enum: + - lane0 + - lane1 + - lane2 + + "#clock-cells": + const: 0 + + clock-output-names: true + + "#phy-cells": + const: 0 + + required: + - reg + - clocks + - clock-names + - resets + - reset-names + - "#clock-cells" + - clock-output-names + - "#phy-cells" + + additionalProperties: false required: - compatible From patchwork Tue Jul 5 09:42:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906266 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA03DC433EF for ; Tue, 5 Jul 2022 09:49:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231843AbiGEJtb (ORCPT ); Tue, 5 Jul 2022 05:49:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231601AbiGEJtU (ORCPT ); Tue, 5 Jul 2022 05:49:20 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 451FF101EA; Tue, 5 Jul 2022 02:49:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C9A48B81716; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BCBFC341E4; Tue, 5 Jul 2022 09:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014542; bh=VVg4jZIiDuyCLFuPo+TMMEfePD6ymiFC4L/Ctad/WPs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dROh7zTIa22ghKI7OeYe/tQhjZzeHn8RhtWh+0xm2EqgxBAc53e6+tDXsCX5UIWuq brXYfB/UXBYThFwm2Sdlf1a+SsD8bqZ6kGh4bWFCgHU45G8bmNSaVYvUgm/e06SwNp 964UVhYofNEO1IZqThhHOMHcefnDxh91DQtaB3VSciqfn24l7WbIXMP616MAzI6Rh0 Thct2wGQM/OfZw6kvq9TDuUDheP3vu95S1Rg3CMWAeXmYp/eJX6yW3vRM41yJqHogR vaFkYD7dgMAno5wRI1H+0jaXAo9RFQNb/RMikF+1gd4d1UDNrPTCMinkoWgzvpr4hK gFx7Vu1xiDacQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB1-0004XF-Ac; Tue, 05 Jul 2022 11:49:03 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 09/43] dt-bindings: phy: qcom,msm8996-qmp-pcie: add example node Date: Tue, 5 Jul 2022 11:42:05 +0200 Message-Id: <20220705094239.17174-10-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Add an example node based on a cleaned up version of msm8996.dtsi. Signed-off-by: Johan Hovold --- .../phy/qcom,msm8996-qmp-pcie-phy.yaml | 72 +++++++++++++++++++ 1 file changed, 72 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml index 8aadb25686b2..45f7bb7a632a 100644 --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml @@ -130,3 +130,75 @@ required: - vdda-pll-supply additionalProperties: false + +examples: + - | + #include + pcie_phy: phy-wrapper@34000 { + compatible = "qcom,msm8996-qmp-pcie-phy"; + reg = <0x34000 0x488>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x34000 0x4000>; + + clocks = <&gcc GCC_PCIE_PHY_AUX_CLK>, + <&gcc GCC_PCIE_PHY_CFG_AHB_CLK>, + <&gcc GCC_PCIE_CLKREF_CLK>; + clock-names = "aux", "cfg_ahb", "ref"; + + resets = <&gcc GCC_PCIE_PHY_BCR>, + <&gcc GCC_PCIE_PHY_COM_BCR>, + <&gcc GCC_PCIE_PHY_COM_NOCSR_BCR>; + reset-names = "phy", "common", "cfg"; + + vdda-phy-supply = <&vreg_l28a_0p925>; + vdda-pll-supply = <&vreg_l12a_1p8>; + + pciephy_0: phy@1000 { + reg = <0x1000 0x130>, + <0x1200 0x200>, + <0x1400 0x1dc>; + + clocks = <&gcc GCC_PCIE_0_PIPE_CLK>; + clock-names = "pipe0"; + resets = <&gcc GCC_PCIE_0_PHY_BCR>; + reset-names = "lane0"; + + #clock-cells = <0>; + clock-output-names = "pcie_0_pipe_clk_src"; + + #phy-cells = <0>; + }; + + pciephy_1: phy@2000 { + reg = <0x2000 0x130>, + <0x2200 0x200>, + <0x2400 0x1dc>; + + clocks = <&gcc GCC_PCIE_1_PIPE_CLK>; + clock-names = "pipe1"; + resets = <&gcc GCC_PCIE_1_PHY_BCR>; + reset-names = "lane1"; + + #clock-cells = <0>; + clock-output-names = "pcie_1_pipe_clk_src"; + + #phy-cells = <0>; + }; + + pciephy_2: phy@3000 { + reg = <0x3000 0x130>, + <0x3200 0x200>, + <0x3400 0x1dc>; + + clocks = <&gcc GCC_PCIE_2_PIPE_CLK>; + clock-names = "pipe2"; + resets = <&gcc GCC_PCIE_2_PHY_BCR>; + reset-names = "lane2"; + + #clock-cells = <0>; + clock-output-names = "pcie_2_pipe_clk_src"; + + #phy-cells = <0>; + }; + }; From patchwork Tue Jul 5 09:42:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906238 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98443CCA47B for ; Tue, 5 Jul 2022 09:49:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231375AbiGEJtG (ORCPT ); Tue, 5 Jul 2022 05:49:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231303AbiGEJtE (ORCPT ); Tue, 5 Jul 2022 05:49:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49167FD3E; Tue, 5 Jul 2022 02:49:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D085B61926; Tue, 5 Jul 2022 09:49:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 969DAC341CE; Tue, 5 Jul 2022 09:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014542; bh=6PIq6E5IaCm16IQAMjZXZR5xejvClm6y5jWgrc0y/xs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P3awIUsbzmwLD6QRDlPOJcqT6OrDahzk0Vn6MaJ97hWJlBQ7SKd+ZRpS0mWhWrmJI mdZPyVYcW/omzwhYAFJ0dWiCo/AgWRqX3+QR2eF7xq6z0qmmKfHpCCuKlFga6uL/Nq /dLEODfwmoWqY99TEDLAh7DVgdEr87HxzQzNC5GRAXSkM6bxBzHOLxfT+3/HCrel1s ALScvVzCltHuwEXgP5MFEqEDLEUJVZhRDuqlN8IzKSEhrQmobP/8t7bYiYdtL5Wv8u wKVPQjFnmP3uJnRChsF30O6UsrjuLl52r7M5Qk9TOpTW5E432q8AlYPShwxq2jRgDl 54ZdtQIz/i1Jw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB1-0004XJ-Dt; Tue, 05 Jul 2022 11:49:03 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 10/43] dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate PIPE clock names Date: Tue, 5 Jul 2022 11:42:06 +0200 Message-Id: <20220705094239.17174-11-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Drop the unnecessary "lane" suffix from the PHY PIPE clock names and mark the old names as deprecated. Signed-off-by: Johan Hovold Reviewed-by: Krzysztof Kozlowski --- .../phy/qcom,msm8996-qmp-pcie-phy.yaml | 20 +++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml index 45f7bb7a632a..7931b1fd1476 100644 --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml @@ -79,11 +79,15 @@ patternProperties: - description: PIPE clock clock-names: - items: - - enum: - - pipe0 - - pipe1 - - pipe2 + oneOf: + - items: + - const: pipe + - items: + - enum: + - pipe0 + - pipe1 + - pipe2 + deprecated: true resets: items: @@ -160,7 +164,7 @@ examples: <0x1400 0x1dc>; clocks = <&gcc GCC_PCIE_0_PIPE_CLK>; - clock-names = "pipe0"; + clock-names = "pipe"; resets = <&gcc GCC_PCIE_0_PHY_BCR>; reset-names = "lane0"; @@ -176,7 +180,7 @@ examples: <0x2400 0x1dc>; clocks = <&gcc GCC_PCIE_1_PIPE_CLK>; - clock-names = "pipe1"; + clock-names = "pipe"; resets = <&gcc GCC_PCIE_1_PHY_BCR>; reset-names = "lane1"; @@ -192,7 +196,7 @@ examples: <0x3400 0x1dc>; clocks = <&gcc GCC_PCIE_2_PIPE_CLK>; - clock-names = "pipe2"; + clock-names = "pipe"; resets = <&gcc GCC_PCIE_2_PHY_BCR>; reset-names = "lane2"; From patchwork Tue Jul 5 09:42:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906270 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AC03CCA47F for ; Tue, 5 Jul 2022 09:49:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231922AbiGEJte (ORCPT ); Tue, 5 Jul 2022 05:49:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231668AbiGEJtV (ORCPT ); Tue, 5 Jul 2022 05:49:21 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AADFC25C3; Tue, 5 Jul 2022 02:49:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E331CB8171E; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96A04C341EC; Tue, 5 Jul 2022 09:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014542; bh=aA6pajJ5L/dtpPo1Rt6dHR4KQMCmecjywy0+jWwynWo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AaAvgydX5jn9wkq3FKkJcT0kQdHTL0XkAvTfGY3NPO27XtIfm/Y60Van1YWO/shz3 cmfHUnAJ/Pf9VFP5remsO3MvCop2ijhCR7KIQ0z0UBpDEpSvvzI+Dsx7ITLTFrVnno dwVNiqoUYVeAtnjQAwABUCdQ+mSnVX33E2s1IhDtRt4Q2vAedvYWKLilUJLTp2PkTy I+rgL2qjhZm26ZtXgY3+oOZgp7e9VGfFEsu+jFMI8Qtf2llFollqwHa8RKD+VQ5X9U 5gRmnUskCpbkHZCr9Si+CLgGkLZYiR1SoB/NgvhgQJT9z3+BWQ/vDGCXBhjoDlEgX0 yI+uexoDLFU7Q== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB1-0004XL-Gn; Tue, 05 Jul 2022 11:49:03 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 11/43] dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate reset names Date: Tue, 5 Jul 2022 11:42:07 +0200 Message-Id: <20220705094239.17174-12-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Drop the unnecessary "lane" suffix from the PHY reset names and mark the old names as deprecated. Signed-off-by: Johan Hovold --- .../phy/qcom,msm8996-qmp-pcie-phy.yaml | 20 +++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml index 7931b1fd1476..0bea8270b37e 100644 --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml @@ -94,11 +94,15 @@ patternProperties: - description: PHY (lane) reset reset-names: - items: - - enum: - - lane0 - - lane1 - - lane2 + oneOf: + - items: + - const: lane + - items: + - enum: + - lane0 + - lane1 + - lane2 + deprecated: true "#clock-cells": const: 0 @@ -166,7 +170,7 @@ examples: clocks = <&gcc GCC_PCIE_0_PIPE_CLK>; clock-names = "pipe"; resets = <&gcc GCC_PCIE_0_PHY_BCR>; - reset-names = "lane0"; + reset-names = "lane"; #clock-cells = <0>; clock-output-names = "pcie_0_pipe_clk_src"; @@ -182,7 +186,7 @@ examples: clocks = <&gcc GCC_PCIE_1_PIPE_CLK>; clock-names = "pipe"; resets = <&gcc GCC_PCIE_1_PHY_BCR>; - reset-names = "lane1"; + reset-names = "lane"; #clock-cells = <0>; clock-output-names = "pcie_1_pipe_clk_src"; @@ -198,7 +202,7 @@ examples: clocks = <&gcc GCC_PCIE_2_PIPE_CLK>; clock-names = "pipe"; resets = <&gcc GCC_PCIE_2_PHY_BCR>; - reset-names = "lane2"; + reset-names = "lane"; #clock-cells = <0>; clock-output-names = "pcie_2_pipe_clk_src"; From patchwork Tue Jul 5 09:42:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906241 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08C75CCA47F for ; Tue, 5 Jul 2022 09:49:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231461AbiGEJtI (ORCPT ); Tue, 5 Jul 2022 05:49:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229972AbiGEJtF (ORCPT ); Tue, 5 Jul 2022 05:49:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B74538A1; Tue, 5 Jul 2022 02:49:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0F28661923; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE5E7C341F5; Tue, 5 Jul 2022 09:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014542; bh=2VcuM8Vri842hdse/qdcecrlmVet6SIPn9+HK5HWkgs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uCfFqFVgBky6NWH8beKPRZlWoXpu41m9QvxPuLSVLK8LR6C39bAYoIToUPibuIL7p 0r4nInVxw6oNStV1NqXFNlNqqJ1Th7pw1foVOfvyzhNfcO2glMtQHvDvkI4BOqq6Ph 6lMR7qPYKlvQ7M+GYhIHIgDhsRbaiSWVzI9Jl/oT3+GbRTgkNlcZuORhPZqnzYwjqU aF6OjK5Vv+fnOj4gH1K/P3IH7NMCl7fuv3wDllhPHhc1wmTtjjEeOlJLWwnFeoAzvU 0HTzyFoiNSmmy2meKaQ0W39CdhhTr67NC/2h870BV8ylxdtX4XBsfR6S13TlBFp5m1 MZnh5J2GA9k/Q== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB1-0004XO-K3; Tue, 05 Jul 2022 11:49:03 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 12/43] dt-bindings: phy: qcom,qmp: split out PCIe PHY binding Date: Tue, 5 Jul 2022 11:42:08 +0200 Message-Id: <20220705094239.17174-13-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The QMP PHY DT schema is getting unwieldy. Break out the PCIe PHY binding in a separate file. Signed-off-by: Johan Hovold --- .../bindings/phy/qcom,qmp-pcie-phy.yaml | 188 ++++++++++++++++++ .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 75 ------- 2 files changed, 188 insertions(+), 75 deletions(-) create mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml new file mode 100644 index 000000000000..d1d4a468acc3 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml @@ -0,0 +1,188 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) + +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/qcom,qmp-pcie-phy.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Qualcomm QMP PHY controller (PCIe) + +maintainers: + - Vinod Koul + +description: + QMP PHY controller supports physical layer functionality for a number of + controllers on Qualcomm chipsets, such as, PCIe, UFS, and USB. + +properties: + compatible: + enum: + - qcom,ipq6018-qmp-pcie-phy + - qcom,ipq8074-qmp-pcie-phy + - qcom,msm8998-qmp-pcie-phy + - qcom,sc8180x-qmp-pcie-phy + - qcom,sdm845-qhp-pcie-phy + - qcom,sdm845-qmp-pcie-phy + - qcom,sdx55-qmp-pcie-phy + - qcom,sm8250-qmp-gen3x1-pcie-phy + - qcom,sm8250-qmp-gen3x2-pcie-phy + - qcom,sm8250-qmp-modem-pcie-phy + - qcom,sm8450-qmp-gen3x1-pcie-phy + - qcom,sm8450-qmp-gen4x2-pcie-phy + + reg: + minItems: 1 + items: + - description: Address and length of PHY's common serdes block. + - description: Address and length of PHY's DP_COM control block. + + "#address-cells": + enum: [ 1, 2 ] + + "#size-cells": + enum: [ 1, 2 ] + + ranges: true + + clocks: + minItems: 1 + maxItems: 4 + + clock-names: + minItems: 1 + maxItems: 4 + + resets: + minItems: 1 + maxItems: 3 + + reset-names: + minItems: 1 + maxItems: 3 + + vdda-phy-supply: + description: + Phandle to a regulator supply to PHY core block. + + vdda-pll-supply: + description: + Phandle to 1.8V regulator supply to PHY refclk pll block. + + vddp-ref-clk-supply: + description: + Phandle to a regulator supply to any specific refclk pll block. + +patternProperties: + "^phy@[0-9a-f]+$": + type: object + description: + Each device node of QMP PHY is required to have as many child nodes as + the number of lanes the PHY has. + +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + - ranges + - clocks + - clock-names + - resets + - reset-names + +additionalProperties: false + +allOf: + - if: + properties: + compatible: + contains: + enum: + - qcom,msm8998-qmp-pcie-phy + then: + properties: + clocks: + items: + - description: PHY aux clock. + - description: PHY config clock. + - description: 19.2 MHz ref clock. + clock-names: + items: + - const: aux + - const: cfg_ahb + - const: ref + resets: + items: + - description: Reset of PHY block. + - description: PHY common block reset. + reset-names: + items: + - const: phy + - const: common + required: + - vdda-phy-supply + - vdda-pll-supply + + - if: + properties: + compatible: + contains: + enum: + - qcom,ipq6018-qmp-pcie-phy + - qcom,ipq8074-qmp-pcie-phy + then: + properties: + clocks: + items: + - description: PHY aux clock. + - description: PHY config clock. + clock-names: + items: + - const: aux + - const: cfg_ahb + resets: + items: + - description: Reset of PHY block. + - description: PHY common block reset. + reset-names: + items: + - const: phy + - const: common + + - if: + properties: + compatible: + contains: + enum: + - qcom,sc8180x-qmp-pcie-phy + - qcom,sdm845-qhp-pcie-phy + - qcom,sdm845-qmp-pcie-phy + - qcom,sdx55-qmp-pcie-phy + - qcom,sm8250-qmp-gen3x1-pcie-phy + - qcom,sm8250-qmp-gen3x2-pcie-phy + - qcom,sm8250-qmp-modem-pcie-phy + - qcom,sm8450-qmp-gen3x1-pcie-phy + - qcom,sm8450-qmp-gen4x2-pcie-phy + then: + properties: + clocks: + items: + - description: PHY aux clock. + - description: PHY config clock. + - description: 19.2 MHz ref clock. + - description: PHY refgen clock. + clock-names: + items: + - const: aux + - const: cfg_ahb + - const: ref + - const: refgen + resets: + items: + - description: Reset of PHY block. + reset-names: + items: + - const: phy + required: + - vdda-phy-supply + - vdda-pll-supply diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml index 7a76fd286cee..f416a1a53a3f 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml @@ -17,27 +17,20 @@ description: properties: compatible: enum: - - qcom,ipq6018-qmp-pcie-phy - qcom,ipq6018-qmp-usb3-phy - - qcom,ipq8074-qmp-pcie-phy - qcom,ipq8074-qmp-usb3-phy - qcom,msm8996-qmp-ufs-phy - qcom,msm8996-qmp-usb3-phy - - qcom,msm8998-qmp-pcie-phy - qcom,msm8998-qmp-ufs-phy - qcom,msm8998-qmp-usb3-phy - qcom,qcm2290-qmp-usb3-phy - qcom,sc7180-qmp-usb3-phy - - qcom,sc8180x-qmp-pcie-phy - qcom,sc8180x-qmp-ufs-phy - qcom,sc8180x-qmp-usb3-phy - qcom,sc8280xp-qmp-ufs-phy - - qcom,sdm845-qhp-pcie-phy - - qcom,sdm845-qmp-pcie-phy - qcom,sdm845-qmp-ufs-phy - qcom,sdm845-qmp-usb3-phy - qcom,sdm845-qmp-usb3-uni-phy - - qcom,sdx55-qmp-pcie-phy - qcom,sdx55-qmp-usb3-uni-phy - qcom,sdx65-qmp-usb3-uni-phy - qcom,sm6115-qmp-ufs-phy @@ -45,17 +38,12 @@ properties: - qcom,sm8150-qmp-ufs-phy - qcom,sm8150-qmp-usb3-phy - qcom,sm8150-qmp-usb3-uni-phy - - qcom,sm8250-qmp-gen3x1-pcie-phy - - qcom,sm8250-qmp-gen3x2-pcie-phy - - qcom,sm8250-qmp-modem-pcie-phy - qcom,sm8250-qmp-ufs-phy - qcom,sm8250-qmp-usb3-phy - qcom,sm8250-qmp-usb3-uni-phy - qcom,sm8350-qmp-ufs-phy - qcom,sm8350-qmp-usb3-phy - qcom,sm8350-qmp-usb3-uni-phy - - qcom,sm8450-qmp-gen3x1-pcie-phy - - qcom,sm8450-qmp-gen4x2-pcie-phy - qcom,sm8450-qmp-ufs-phy - qcom,sm8450-qmp-usb3-phy @@ -190,7 +178,6 @@ allOf: enum: - qcom,ipq8074-qmp-usb3-phy - qcom,msm8996-qmp-usb3-phy - - qcom,msm8998-qmp-pcie-phy - qcom,msm8998-qmp-usb3-phy then: properties: @@ -269,68 +256,6 @@ allOf: required: - vdda-phy-supply - vdda-pll-supply - - if: - properties: - compatible: - contains: - enum: - - qcom,ipq6018-qmp-pcie-phy - - qcom,ipq8074-qmp-pcie-phy - then: - properties: - clocks: - items: - - description: PHY aux clock. - - description: PHY config clock. - clock-names: - items: - - const: aux - - const: cfg_ahb - resets: - items: - - description: Reset of PHY block. - - description: PHY common block reset. - reset-names: - items: - - const: phy - - const: common - - if: - properties: - compatible: - contains: - enum: - - qcom,sc8180x-qmp-pcie-phy - - qcom,sdm845-qhp-pcie-phy - - qcom,sdm845-qmp-pcie-phy - - qcom,sdx55-qmp-pcie-phy - - qcom,sm8250-qmp-gen3x1-pcie-phy - - qcom,sm8250-qmp-gen3x2-pcie-phy - - qcom,sm8250-qmp-modem-pcie-phy - - qcom,sm8450-qmp-gen3x1-pcie-phy - - qcom,sm8450-qmp-gen4x2-pcie-phy - then: - properties: - clocks: - items: - - description: PHY aux clock. - - description: PHY config clock. - - description: 19.2 MHz ref clock. - - description: PHY refgen clock. - clock-names: - items: - - const: aux - - const: cfg_ahb - - const: ref - - const: refgen - resets: - items: - - description: Reset of PHY block. - reset-names: - items: - - const: phy - required: - - vdda-phy-supply - - vdda-pll-supply - if: properties: compatible: From patchwork Tue Jul 5 09:42:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906264 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2F52CCA47C for ; Tue, 5 Jul 2022 09:49:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231824AbiGEJt2 (ORCPT ); Tue, 5 Jul 2022 05:49:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231631AbiGEJtU (ORCPT ); Tue, 5 Jul 2022 05:49:20 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AB8F266B; Tue, 5 Jul 2022 02:49:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E30C7B8171C; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B49D7C341F2; Tue, 5 Jul 2022 09:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014542; bh=p1mQzE9YzRv1TmEiNJ1vRrzITwgEKyTWEASrGpAbf38=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FcZVI/NKW1xpx6eoaa2h5/Kg581nkinvgRRpK7KTcwi5ZWXnVMHTnzpFUkhUdyijh p0AtYLlq8w3qk+1putIzjB0JYIdWBsmKLgc+hGQBddK4OYhLPq6WeYvojwhaWV/Ch9 5Y9LgtM15ED7bpRyXv9W03wFrJCNdrhqonO1VZdEsiU1/SeRfIweLcYVxQWi1xh7pN IbYYcZz0XaMmfr2/EzjYGz6oVDWD/MwlhONQ9PpLQXq07CnkFdvB/lRb+w1x+T95+E HahedK+l5eE2FhN/eDt1RvhsYcyr0kN2pJ/S6ogDYjZK9Ig1k7GgvliJfJhU8Ce/k1 e4jUqpZvr7FXQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB1-0004XR-MX; Tue, 05 Jul 2022 11:49:03 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 13/43] dt-bindings: phy: qcom,qmp-pcie: clean up register constraints Date: Tue, 5 Jul 2022 11:42:09 +0200 Message-Id: <20220705094239.17174-14-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Only some USB and combo PHYs have a second dp_com control block. Signed-off-by: Johan Hovold --- Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml index d1d4a468acc3..7cdc1cce06cf 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml @@ -31,10 +31,8 @@ properties: - qcom,sm8450-qmp-gen4x2-pcie-phy reg: - minItems: 1 items: - description: Address and length of PHY's common serdes block. - - description: Address and length of PHY's DP_COM control block. "#address-cells": enum: [ 1, 2 ] From patchwork Tue Jul 5 09:42:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906271 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 619A9C43334 for ; Tue, 5 Jul 2022 09:49:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231948AbiGEJtf (ORCPT ); Tue, 5 Jul 2022 05:49:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231670AbiGEJtV (ORCPT ); Tue, 5 Jul 2022 05:49:21 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D725713CCB; Tue, 5 Jul 2022 02:49:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 39EC9B81717; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE814C341F8; Tue, 5 Jul 2022 09:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014542; bh=VVkT3WcSuYWVhQCR5RYlLLnDzsESZO8fObMK2FSVjIw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n1j6b08PGs9riVz6Uho/gf8VDJURhfQhgNoAt0IC24NPR6pPpOg76DjNhuZj87gqP fPkA9kLDgD0vwqcjfHy0A5E/jDIthd99ZcpbR9uXxbNhV9gtcVNS6DTq+qb3nScIP2 +2ba23ZN72lqJ8fsjOaQTotNkQ9RMvlmiX/ZH6O09bkcWueFd41HqOENr3JrAujrF2 oKCMZBzy1GoZeH8mIIAy7oPhXXluEx361bTP/INi+66L5ZCQHbeBDUgqs2bpO7I3vb +getCMVp853N34x/DAA4ge3l4vZb1cx/AQyYA+hV7YCVeW0dpn6p0ImP+2wtWoJhZM B1hOHRC2ofQlw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB1-0004XU-P4; Tue, 05 Jul 2022 11:49:03 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 14/43] dt-bindings: phy: qcom,qmp-pcie: clean up clock constraints Date: Tue, 5 Jul 2022 11:42:10 +0200 Message-Id: <20220705094239.17174-15-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The PCIe PHY binding requires two, three or four clocks. Signed-off-by: Johan Hovold --- Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml index 7cdc1cce06cf..0486b2b48d72 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml @@ -43,11 +43,11 @@ properties: ranges: true clocks: - minItems: 1 + minItems: 2 maxItems: 4 clock-names: - minItems: 1 + minItems: 2 maxItems: 4 resets: From patchwork Tue Jul 5 09:42:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906240 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A251C433EF for ; Tue, 5 Jul 2022 09:49:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231436AbiGEJtH (ORCPT ); Tue, 5 Jul 2022 05:49:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231341AbiGEJtF (ORCPT ); Tue, 5 Jul 2022 05:49:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6964DFB9; Tue, 5 Jul 2022 02:49:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6F74C618EC; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE74FC341CD; Tue, 5 Jul 2022 09:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014542; bh=+lRInMhIruR0OwlIKudAUTFxtNBmuvC62exzVnl3McY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Dpg6vMEnC5XGbzAdFslHv9GqI4rkDpB9t9km9Sq15c3FAi22kc8bD8J5WOPZs2eD7 sVzOiun8ja3vYhhjRiSi3d6I7FQF/0qnAckrFK11OxWk7uBWeUIKFDFO/oQvEZdam8 m65k1M7th3K3pvepFmu8ow+4a0rfN/hqf3LVWMx88cg2AL/KWPPwTNQAhnftstVGGI xszRwIkiFd8mC88JbnHDqxWKvBMmPDL7thrtPBw9fFihdCYW5lhcAJiPEPunVROXjT sQOhyCv9HI4HXo7s/VQh1JOFT94V5GleFBV/StkbZ1bOR0pkDWFKfLuhMfwXDGjdbB bQMBE6LHBsuXw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB1-0004XW-Ry; Tue, 05 Jul 2022 11:49:03 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 15/43] dt-bindings: phy: qcom,qmp-pcie: clean up reset constraints Date: Tue, 5 Jul 2022 11:42:11 +0200 Message-Id: <20220705094239.17174-16-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The PCIe PHY binding requires one or two resets. Signed-off-by: Johan Hovold --- Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml index 0486b2b48d72..557cccc8f4dd 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml @@ -52,11 +52,11 @@ properties: resets: minItems: 1 - maxItems: 3 + maxItems: 2 reset-names: minItems: 1 - maxItems: 3 + maxItems: 2 vdda-phy-supply: description: From patchwork Tue Jul 5 09:42:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906242 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56BE4CCA481 for ; Tue, 5 Jul 2022 09:49:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230356AbiGEJtJ (ORCPT ); Tue, 5 Jul 2022 05:49:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231352AbiGEJtG (ORCPT ); Tue, 5 Jul 2022 05:49:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11A3811460; Tue, 5 Jul 2022 02:49:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7C8E86192D; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E9FEC36B0B; Tue, 5 Jul 2022 09:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014543; bh=CJy5PzmZIQMxdMJt0IU3pXmVjYFdTGTu/yQaUEBydtQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PEmUxLO+b3acnmVdDrzz9Ev/hWQM7iR2l+/7/N5/8TmmTJe+nbuccKEIpKPP47Zz2 pc6OdY5JpGEYy3kBE+ocsvP8wa5Chv6hykibwJ+iVmLpu7YfGrelUZ5MGUlXc2uGLX TGwjWO55j/6eY8hebMFSLXoagzwfUL9BkYuk+nohBW9LXoWoQjci0G3ELN4H56I1Zo AG0emK+fTQkBmVQlAPbogS53Z18yR+mdOJTeB1WbxKmXcLEmEom7NZ27M/jEwpkn2/ OIyfd1gw5KLGhpuIYw2kXMlOouTXY2fSjdfBdHmK6SVWv+ZZkcUb6GPpwE5NlXDgnX rNa+GRhceJcWw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB1-0004Xa-Ur; Tue, 05 Jul 2022 11:49:03 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 16/43] dt-bindings: phy: qcom,qmp-pcie: drop unused vddp-ref-clk supply Date: Tue, 5 Jul 2022 11:42:12 +0200 Message-Id: <20220705094239.17174-17-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Only UFS PHY nodes in mainline have a vddp-ref-clk supply. Drop it from the PCIe PHY binding. Signed-off-by: Johan Hovold --- Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml index 557cccc8f4dd..ff1577f68a00 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml @@ -66,10 +66,6 @@ properties: description: Phandle to 1.8V regulator supply to PHY refclk pll block. - vddp-ref-clk-supply: - description: - Phandle to a regulator supply to any specific refclk pll block. - patternProperties: "^phy@[0-9a-f]+$": type: object From patchwork Tue Jul 5 09:42:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906239 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35E34CCA480 for ; Tue, 5 Jul 2022 09:49:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231402AbiGEJtH (ORCPT ); Tue, 5 Jul 2022 05:49:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231338AbiGEJtF (ORCPT ); Tue, 5 Jul 2022 05:49:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7F0C101EA; Tue, 5 Jul 2022 02:49:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 53C7861919; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E43AC36B0D; Tue, 5 Jul 2022 09:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014543; bh=O9KkrHVAnzuQAnWNP5LQhMy3imM3btu6fVBNuFDOHhY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N13QWXPnsai1JxPCWabuUFUO8LdKjY+j+9WaMSySHoZwnRFzKm+XLZc5oXacl1+Jg 52NCvoGaBouaqt4RFZUtIpK7YVIOR+cOoxqEd5I62v9Q4ejT49nKw7FrkX9ylmB7hs rM1skunEounUXKTWQM0z4cHhJ8zlprBwzZMClw4yIyBa/Tl726kTXVe68B26mZapiC nIPpUNw16+hw1ezGy79dqkbZ/J0pnrHyflv2TGoau97EPTEoSsjlXrqg+jaByu/qeL bSnSonxfRQfmzUjSvbp+H1dpb/Vc1fYT8PWywpe+cLNHi14snGv1dyr9X6/qcFFxam lfOUCWvhjg96A== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB2-0004Xe-1m; Tue, 05 Jul 2022 11:49:04 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 17/43] dt-bindings: phy: qcom,qmp-pcie: add missing child node schema Date: Tue, 5 Jul 2022 11:42:13 +0200 Message-Id: <20220705094239.17174-18-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Add the missing the description of the PHY-provider child node which was ignored when converting to DT schema. Also fix up the incorrect description that claimed that one child node per lane was required. Fixes: ccf51c1cedfd ("dt-bindings: phy: qcom,qmp: Convert QMP PHY bindings to yaml") Signed-off-by: Johan Hovold --- .../bindings/phy/qcom,qmp-pcie-phy.yaml | 88 ++++++++++++++++++- 1 file changed, 85 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml index ff1577f68a00..5a1ebf874559 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml @@ -69,9 +69,37 @@ properties: patternProperties: "^phy@[0-9a-f]+$": type: object - description: - Each device node of QMP PHY is required to have as many child nodes as - the number of lanes the PHY has. + description: Single PHY-provider child node. + properties: + reg: + minItems: 3 + maxItems: 6 + + clocks: + items: + - description: PIPE clock + + clock-names: + items: + - const: pipe0 + + "#clock-cells": + const: 0 + + clock-output-names: true + + "#phy-cells": + const: 0 + + required: + - reg + - clocks + - clock-names + - "#clock-cells" + - clock-output-names + - "#phy-cells" + + additionalProperties: false required: - compatible @@ -180,3 +208,57 @@ allOf: required: - vdda-phy-supply - vdda-pll-supply + + - if: + properties: + compatible: + contains: + enum: + - qcom,sm8250-qmp-gen3x2-pcie-phy + - qcom,sm8250-qmp-modem-pcie-phy + - qcom,sm8450-qmp-gen4x2-pcie-phy + then: + patternProperties: + "^phy@[0-9a-f]+$": + properties: + reg: + items: + - description: TX lane 1 + - description: RX lane 1 + - description: PCS + - description: TX lane 2 + - description: RX lane 2 + - description: PCS_MISC + else: + patternProperties: + "^phy@[0-9a-f]+$": + properties: + reg: + minItems: 3 + maxItems: 4 + items: + - description: TX + - description: RX + - description: PCS + - description: PCS_MISC + if: + properties: + compatible: + contains: + enum: + - qcom,ipq6018-qmp-pcie-phy + - qcom,ipq8074-qmp-pcie-phy + - qcom,msm8998-qmp-pcie-phy + - qcom,sdm845-qhp-pcie-phy + then: + patternProperties: + "^phy@[0-9a-f]+$": + properties: + reg: + maxItems: 3 + else: + patternProperties: + "^phy@[0-9a-f]+$": + properties: + reg: + minItems: 4 From patchwork Tue Jul 5 09:42:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906277 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C4BFCCA47B for ; Tue, 5 Jul 2022 09:49:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232126AbiGEJtr (ORCPT ); Tue, 5 Jul 2022 05:49:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231721AbiGEJtV (ORCPT ); Tue, 5 Jul 2022 05:49:21 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7BE913D39; Tue, 5 Jul 2022 02:49:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id DAD41CE1AFA; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EBD4C36B0E; Tue, 5 Jul 2022 09:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014543; bh=rhNsOHQahugNBTZT3MMRtc7ithk9F73meRh37KBt6SU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tyQz+Wgym2AuX6jhwblsZldHtml7BDtJLxw2NcC+GDqXof0E1X5EBrvteaFpWZ921 jheWa3VyJ8cfhSlx8fSXG2TcnJSlzRZJQDJx2NXTzexUmwsXkASJBGwh1GdR9Gss8+ OkMBuaAPA0Z9vAtI9Ivp6hFCXgKp1w3gfB8BCxmisjM1M2L9mDoS7ci8tD/DEKHyN+ RfT7gJTZb0wPTJ6rtPO2Ky5PXJ6WDLfGSwEsbH7yU2SjA3m6Zgo79Ax1wgbtDxvpdq pA56yVKZ8aJ2YZ5FNrpP0R03YgIlphTDAcbJuXbnVYLYqIg7xhKSdk+HQi1qzc+QjV O/XUzoEt3G40A== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB2-0004Xg-4g; Tue, 05 Jul 2022 11:49:04 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 18/43] dt-bindings: phy: qcom,qmp-pcie: add example node Date: Tue, 5 Jul 2022 11:42:14 +0200 Message-Id: <20220705094239.17174-19-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Add an example node based on a cleaned up version of sm8250.dtsi. Signed-off-by: Johan Hovold --- .../bindings/phy/qcom,qmp-pcie-phy.yaml | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml index 5a1ebf874559..3fc08af41144 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml @@ -262,3 +262,44 @@ allOf: properties: reg: minItems: 4 + +examples: + - | + #include + phy-wrapper@1c0e000 { + compatible = "qcom,sm8250-qmp-gen3x2-pcie-phy"; + reg = <0x01c0e000 0x1c0>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x01c0e000 0x1000>; + + clocks = <&gcc GCC_PCIE_PHY_AUX_CLK>, + <&gcc GCC_PCIE_1_CFG_AHB_CLK>, + <&gcc GCC_PCIE_WIGIG_CLKREF_EN>, + <&gcc GCC_PCIE1_PHY_REFGEN_CLK>; + + clock-names = "aux", "cfg_ahb", "ref", "refgen"; + + resets = <&gcc GCC_PCIE_1_PHY_BCR>; + reset-names = "phy"; + + vdda-phy-supply = <&vreg_l10c_0p88>; + vdda-pll-supply = <&vreg_l6b_1p2>; + + phy@200 { + reg = <0x200 0x170>, + <0x400 0x200>, + <0xa00 0x1f0>, + <0x600 0x170>, + <0x800 0x200>, + <0xe00 0xf4>; + + clocks = <&gcc GCC_PCIE_1_PIPE_CLK>; + clock-names = "pipe0"; + + #clock-cells = <0>; + clock-output-names = "pcie_1_pipe_clk"; + + #phy-cells = <0>; + }; + }; From patchwork Tue Jul 5 09:42:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906272 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BAD7CCA481 for ; Tue, 5 Jul 2022 09:49:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231969AbiGEJtg (ORCPT ); Tue, 5 Jul 2022 05:49:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231659AbiGEJtV (ORCPT ); Tue, 5 Jul 2022 05:49:21 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9491010FD3; Tue, 5 Jul 2022 02:49:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7FF42B81729; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D495C36B1D; Tue, 5 Jul 2022 09:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014543; bh=wTKx6W4Z5/SzoW6B7e1sclkQeLott98hZJzN8+cbLRE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a1UDkjhpJ1LiiTnUQPuLSaqHWqYQFRlsJGrzkibKBYJ4jCreF8eurpVYBJjp3nTv2 W75AZYLhkemjAHPBqoDHSiFkCNiWyq6jpB2+9KYWXC9VWd1oOBW1ieA0SbOYOa2OaM 5eGBgE45DC2Y+B1I4X4XNPZhtiQEOso3CPRUSI/txEWXQiZ5752KB4+xnJ78Spove5 pZpUDaKBDPA2/HRzgYQTF9JNl96Stzrlc1nzYe0Ww1HzSiBUjHoBH4YH2jChjg6VLV trwQFK8BszFRFovHoIg3DBS9QP5ZyeM7YPw5qzlB+wQ7lVdrXyy31arMbk+ceHriVh DT/JFSbh3mhNw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB2-0004Xj-7H; Tue, 05 Jul 2022 11:49:04 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 19/43] dt-bindings: phy: qcom,qmp-pcie: deprecate PIPE clock name Date: Tue, 5 Jul 2022 11:42:15 +0200 Message-Id: <20220705094239.17174-20-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Drop the bogus "lane" suffix from the PHY PIPE clock name and mark the old name as deprecated. Signed-off-by: Johan Hovold --- .../devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml index 3fc08af41144..32f872de8f4b 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml @@ -80,8 +80,12 @@ patternProperties: - description: PIPE clock clock-names: - items: - - const: pipe0 + oneOf: + - items: + - const: pipe + - items: + - const: pipe0 + deprecated: true "#clock-cells": const: 0 @@ -295,7 +299,7 @@ examples: <0xe00 0xf4>; clocks = <&gcc GCC_PCIE_1_PIPE_CLK>; - clock-names = "pipe0"; + clock-names = "pipe"; #clock-cells = <0>; clock-output-names = "pcie_1_pipe_clk"; From patchwork Tue Jul 5 09:42:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906259 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7A79CCA47F for ; Tue, 5 Jul 2022 09:49:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231774AbiGEJtZ (ORCPT ); Tue, 5 Jul 2022 05:49:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231588AbiGEJtT (ORCPT ); Tue, 5 Jul 2022 05:49:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 591C812D26; Tue, 5 Jul 2022 02:49:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DD92D61926; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C11BC36B16; Tue, 5 Jul 2022 09:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014543; bh=UOvgIt68/j0BXReTfByF9D0uM5TktGkUFQmmNBsctqk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p1x0H5uW3YjeOMaRVvDxzSB9awWtwLtO0hLCgNcKXaf+GSfvv0b74qzug73eAW9/p fmWIakJGJ6CDe7gAnwGfwtoMHEjppVAnkWnZ5GecV3pyt4mF8lCOaWi17JD2wOeIjV Bj6W8eSrYMNesKhvG32keynjw2FRhakWbBUTyd0TponsMHJAolFWaBMt+Er52uG53d PpLQ6nJv/mnxzddlz3ajzPNdNMwNshJH7cQ1bdky4QUEur1N/uPjmF77Kpm7c8p/nm 9MHoDz8YtH3zRjudiwo8JRPHr1Kmeu2AIJnAIhtHCVzSRjDB59ovInvN9w23w0/9bi Eyd9caIItJB2w== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB2-0004Xm-9r; Tue, 05 Jul 2022 11:49:04 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 20/43] dt-bindings: phy: qcom,qmp: split out UFS PHY binding Date: Tue, 5 Jul 2022 11:42:16 +0200 Message-Id: <20220705094239.17174-21-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The QMP PHY DT schema is getting unwieldy. Break out the UFS PHY binding in a separate file. Signed-off-by: Johan Hovold --- .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 65 -------- .../bindings/phy/qcom,qmp-ufs-phy.yaml | 149 ++++++++++++++++++ 2 files changed, 149 insertions(+), 65 deletions(-) create mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml index f416a1a53a3f..04c24f8e4526 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml @@ -19,32 +19,21 @@ properties: enum: - qcom,ipq6018-qmp-usb3-phy - qcom,ipq8074-qmp-usb3-phy - - qcom,msm8996-qmp-ufs-phy - qcom,msm8996-qmp-usb3-phy - - qcom,msm8998-qmp-ufs-phy - qcom,msm8998-qmp-usb3-phy - qcom,qcm2290-qmp-usb3-phy - qcom,sc7180-qmp-usb3-phy - - qcom,sc8180x-qmp-ufs-phy - qcom,sc8180x-qmp-usb3-phy - - qcom,sc8280xp-qmp-ufs-phy - - qcom,sdm845-qmp-ufs-phy - qcom,sdm845-qmp-usb3-phy - qcom,sdm845-qmp-usb3-uni-phy - qcom,sdx55-qmp-usb3-uni-phy - qcom,sdx65-qmp-usb3-uni-phy - - qcom,sm6115-qmp-ufs-phy - - qcom,sm6350-qmp-ufs-phy - - qcom,sm8150-qmp-ufs-phy - qcom,sm8150-qmp-usb3-phy - qcom,sm8150-qmp-usb3-uni-phy - - qcom,sm8250-qmp-ufs-phy - qcom,sm8250-qmp-usb3-phy - qcom,sm8250-qmp-usb3-uni-phy - - qcom,sm8350-qmp-ufs-phy - qcom,sm8350-qmp-usb3-phy - qcom,sm8350-qmp-usb3-uni-phy - - qcom,sm8450-qmp-ufs-phy - qcom,sm8450-qmp-usb3-phy reg: @@ -202,60 +191,6 @@ allOf: required: - vdda-phy-supply - vdda-pll-supply - - if: - properties: - compatible: - contains: - enum: - - qcom,msm8996-qmp-ufs-phy - then: - properties: - clocks: - items: - - description: 19.2 MHz ref clock. - clock-names: - items: - - const: ref - resets: - items: - - description: PHY reset in the UFS controller. - reset-names: - items: - - const: ufsphy - required: - - vdda-phy-supply - - vdda-pll-supply - - if: - properties: - compatible: - contains: - enum: - - qcom,msm8998-qmp-ufs-phy - - qcom,sc8180x-qmp-ufs-phy - - qcom,sc8280xp-qmp-ufs-phy - - qcom,sdm845-qmp-ufs-phy - - qcom,sm6350-qmp-ufs-phy - - qcom,sm8150-qmp-ufs-phy - - qcom,sm8250-qmp-ufs-phy - then: - properties: - clocks: - items: - - description: 19.2 MHz ref clock. - - description: PHY reference aux clock. - clock-names: - items: - - const: ref - - const: ref_aux - resets: - items: - - description: PHY reset in the UFS controller. - reset-names: - items: - - const: ufsphy - required: - - vdda-phy-supply - - vdda-pll-supply - if: properties: compatible: diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml new file mode 100644 index 000000000000..4471f1b4fb7a --- /dev/null +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml @@ -0,0 +1,149 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) + +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/qcom,qmp-ufs-phy.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Qualcomm QMP PHY controller (UFS) + +maintainers: + - Vinod Koul + +description: + QMP PHY controller supports physical layer functionality for a number of + controllers on Qualcomm chipsets, such as, PCIe, UFS, and USB. + +properties: + compatible: + enum: + - qcom,msm8996-qmp-ufs-phy + - qcom,msm8998-qmp-ufs-phy + - qcom,sc8180x-qmp-ufs-phy + - qcom,sc8280xp-qmp-ufs-phy + - qcom,sdm845-qmp-ufs-phy + - qcom,sm6115-qmp-ufs-phy + - qcom,sm6350-qmp-ufs-phy + - qcom,sm8150-qmp-ufs-phy + - qcom,sm8250-qmp-ufs-phy + - qcom,sm8350-qmp-ufs-phy + - qcom,sm8450-qmp-ufs-phy + + reg: + minItems: 1 + items: + - description: Address and length of PHY's common serdes block. + - description: Address and length of PHY's DP_COM control block. + + "#address-cells": + enum: [ 1, 2 ] + + "#size-cells": + enum: [ 1, 2 ] + + ranges: true + + clocks: + minItems: 1 + maxItems: 4 + + clock-names: + minItems: 1 + maxItems: 4 + + resets: + minItems: 1 + maxItems: 3 + + reset-names: + minItems: 1 + maxItems: 3 + + vdda-phy-supply: + description: + Phandle to a regulator supply to PHY core block. + + vdda-pll-supply: + description: + Phandle to 1.8V regulator supply to PHY refclk pll block. + + vddp-ref-clk-supply: + description: + Phandle to a regulator supply to any specific refclk pll block. + +patternProperties: + "^phy@[0-9a-f]+$": + type: object + description: + Each device node of QMP PHY is required to have as many child nodes as + the number of lanes the PHY has. + +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + - ranges + - clocks + - clock-names + - resets + - reset-names + +additionalProperties: false + +allOf: + - if: + properties: + compatible: + contains: + enum: + - qcom,msm8996-qmp-ufs-phy + then: + properties: + clocks: + items: + - description: 19.2 MHz ref clock. + clock-names: + items: + - const: ref + resets: + items: + - description: PHY reset in the UFS controller. + reset-names: + items: + - const: ufsphy + required: + - vdda-phy-supply + - vdda-pll-supply + + - if: + properties: + compatible: + contains: + enum: + - qcom,msm8998-qmp-ufs-phy + - qcom,sc8180x-qmp-ufs-phy + - qcom,sc8280xp-qmp-ufs-phy + - qcom,sdm845-qmp-ufs-phy + - qcom,sm6350-qmp-ufs-phy + - qcom,sm8150-qmp-ufs-phy + - qcom,sm8250-qmp-ufs-phy + then: + properties: + clocks: + items: + - description: 19.2 MHz ref clock. + - description: PHY reference aux clock. + clock-names: + items: + - const: ref + - const: ref_aux + resets: + items: + - description: PHY reset in the UFS controller. + reset-names: + items: + - const: ufsphy + required: + - vdda-phy-supply + - vdda-pll-supply From patchwork Tue Jul 5 09:42:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906246 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11FC7C433EF for ; Tue, 5 Jul 2022 09:49:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229602AbiGEJtM (ORCPT ); Tue, 5 Jul 2022 05:49:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231389AbiGEJtG (ORCPT ); Tue, 5 Jul 2022 05:49:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 779BCDFEF; Tue, 5 Jul 2022 02:49:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C27D46191C; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 576A3C36B1C; Tue, 5 Jul 2022 09:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014543; bh=73Ko1hdObvK4P8nQePVdDkrJQMSlxC4Gjr2GN4baZCw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LAqys4M36Jle5JGDW9ZjZ4TJrAFyTgnRhGow44MPh9K7hUqKHr8KE7Nk+bY24gKln IiyQEkoO+oB40OStFsWCg7RWCmdzvRif1B14yqAx0JTg4T7A98do1ExeYK0ST7X/uM +h7Tz1Qse+6C7BMyxjgQueU/3rjr1FCODioVfIKdmidnDJla5KhcaZyzs0/BhIQ1rn WVe/YzNEkOV94BSWHT0hRCLTonM1YKTLx81MGoB+Zo4tRdqaML2/UOx7S/3wmVa2ep l/N9hZd3pUYrwmn2+RJTgBkh3hWkmsbtA9M6eawC0sh4/T31DW+4DZ7FLHVDlPbv1M ewDrEMFGnU9tA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB2-0004Xp-CK; Tue, 05 Jul 2022 11:49:04 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 21/43] dt-bindings: phy: qcom,qmp-ufs: clean up supplies Date: Tue, 5 Jul 2022 11:42:17 +0200 Message-Id: <20220705094239.17174-22-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The UFS PHY binding requires the vdda-phy and vdd-pll supplies. Signed-off-by: Johan Hovold --- .../devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml index 4471f1b4fb7a..c4458d90d8b7 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml @@ -88,6 +88,8 @@ required: - clock-names - resets - reset-names + - vdda-phy-supply + - vdda-pll-supply additionalProperties: false @@ -112,9 +114,6 @@ allOf: reset-names: items: - const: ufsphy - required: - - vdda-phy-supply - - vdda-pll-supply - if: properties: @@ -144,6 +143,3 @@ allOf: reset-names: items: - const: ufsphy - required: - - vdda-phy-supply - - vdda-pll-supply From patchwork Tue Jul 5 09:42:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906254 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 118F5CCA487 for ; Tue, 5 Jul 2022 09:49:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231641AbiGEJtU (ORCPT ); Tue, 5 Jul 2022 05:49:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231425AbiGEJtH (ORCPT ); Tue, 5 Jul 2022 05:49:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B3951209E; Tue, 5 Jul 2022 02:49:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DF4CC6192E; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D763C341EE; Tue, 5 Jul 2022 09:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014543; bh=2mTzUOp7tdPQMM7Xc9YC7rFHgcOOSo/32RHu2yNuMEU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QmLRZ09r97aAxUAe7aAEHwhG0MQCHv9ZOlPsm8H1h1xuhgV/uYUCKD9M7aXBjWpFh sv+vQlMjzxJhy+Oy8JDoueLwU3L4/zvgiINNjNGMINSk/4CDYTEiMzrqfM50yySZ7e vE2pu2WbUNduriouHKna7F50M7f0Oc1/IAjNi15BpR26Swl8FdoZooGJkYdy++yjrj a6h4F5EAgv+rfXcW8NBs6UEf9/vR69E6iAlo1qX8JeX2inBCQk0Sox+M7eFl6I1lqs OjT0DYgSBNlyR0k8ZMNukr2L5woRMoSoOznptW5XeubJqzOBTiz6iiCzu8pSavahVI RS1i1k9z9NvHw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB2-0004Xs-Fb; Tue, 05 Jul 2022 11:49:04 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 22/43] dt-bindings: phy: qcom,qmp-ufs: clean up reset providers Date: Tue, 5 Jul 2022 11:42:18 +0200 Message-Id: <20220705094239.17174-23-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The UFS binding requires a single PHY reset. Signed-off-by: Johan Hovold --- .../bindings/phy/qcom,qmp-ufs-phy.yaml | 20 ++++--------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml index c4458d90d8b7..b84511f02221 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml @@ -52,12 +52,12 @@ properties: maxItems: 4 resets: - minItems: 1 - maxItems: 3 + items: + - description: PHY reset in the UFS controller. reset-names: - minItems: 1 - maxItems: 3 + items: + - const: ufsphy vdda-phy-supply: description: @@ -108,12 +108,6 @@ allOf: clock-names: items: - const: ref - resets: - items: - - description: PHY reset in the UFS controller. - reset-names: - items: - - const: ufsphy - if: properties: @@ -137,9 +131,3 @@ allOf: items: - const: ref - const: ref_aux - resets: - items: - - description: PHY reset in the UFS controller. - reset-names: - items: - - const: ufsphy From patchwork Tue Jul 5 09:42:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906257 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F4AFCCA47C for ; Tue, 5 Jul 2022 09:49:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231680AbiGEJtX (ORCPT ); Tue, 5 Jul 2022 05:49:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231448AbiGEJtI (ORCPT ); Tue, 5 Jul 2022 05:49:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B04612D03; Tue, 5 Jul 2022 02:49:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ED3B861922; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2090C53FCA; Tue, 5 Jul 2022 09:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014543; bh=b/KbY0N+WoeNCbG0GvZvLkXdY81Ccwg9+JZzrfr1k9U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oBtDTv5/Am4jEJ35H02D41V4KHT+KZCSChQ5ANQ7jMPaIP63a9KUGcmdMi5Cpfve6 sQJH7QjIwEyytzrjZCU7nDmtJ6de4XgAgwQl7c6X3u6uJYKIur+6P5So3BHp5a56rA AyZPd7I0TcPhgKhrbQ8alCuDvvGy/PGYQozaS8VDwi3Cq6FlkHlbHl0Cue/RlExvk0 gLDYaycIVo+bYqOqrlH5EyL76sEdCuHOkWG1Q3JwbZWNdm1H0on6+K/uGD9z54iS/W J+dcru77Js1o5I0Tb2CJwdNZmhKsa7QOteizUmPjrftgfAEfU5V2mVePcC4cdY0J9A 6a2VgcDgvsrhg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB2-0004Xw-IT; Tue, 05 Jul 2022 11:49:04 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 23/43] dt-bindings: phy: qcom,qmp-ufs: clean up clock constraints Date: Tue, 5 Jul 2022 11:42:19 +0200 Message-Id: <20220705094239.17174-24-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The UFS PHY binding requires one or two clocks. Signed-off-by: Johan Hovold --- Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml index b84511f02221..732518d0427c 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml @@ -45,11 +45,11 @@ properties: clocks: minItems: 1 - maxItems: 4 + maxItems: 2 clock-names: minItems: 1 - maxItems: 4 + maxItems: 2 resets: items: From patchwork Tue Jul 5 09:42:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906245 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67955CCA481 for ; Tue, 5 Jul 2022 09:49:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229730AbiGEJtL (ORCPT ); Tue, 5 Jul 2022 05:49:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231365AbiGEJtG (ORCPT ); Tue, 5 Jul 2022 05:49:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11FD511A3C; Tue, 5 Jul 2022 02:49:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8610C61932; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DEF3C53FCE; Tue, 5 Jul 2022 09:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014543; bh=/6wfFPBZsyDjbG2stokCCa2g61srZC+CXkOdBy6Lgrk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EQR+Gyk9opEzwg4ZZYmy27jhxZJ6nr7RIdVL+uo6lp/JDy0bE7JvlB4GzMEeWCCpp g4juIBz6pbprEMP7dgK8T9zwnVo3jqYygIcGkGS8/rZ5MHb/DNmgF2L5uSQO+fXqZS GqeHhHQ1P+/CSRgGygJcWnUieH/zjLuhha8ZNAcbJy8bmsy8qV+Qge2PYytvTYu98Y PZ+Ho4X/AI5rIC8ZgTYBf3y1d4LxeXBd3rdvfEkeYHm+/pMRSxOZp0tywFQglC1vuG QX2ePknrntnrQjbgPzIJ6Xg3eedQoSvnS7/N3TOs8iIFt/OHQOQfJtZ23u061xLIEy InZBAa+BwIA5A== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB2-0004Xz-Li; Tue, 05 Jul 2022 11:49:04 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 24/43] dt-bindings: phy: qcom,qmp-ufs: clean up register constraints Date: Tue, 5 Jul 2022 11:42:20 +0200 Message-Id: <20220705094239.17174-25-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Only some USB and combo PHYs have a second dp_com control block. Signed-off-by: Johan Hovold --- Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml index 732518d0427c..af3ed5601d21 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml @@ -30,10 +30,8 @@ properties: - qcom,sm8450-qmp-ufs-phy reg: - minItems: 1 items: - description: Address and length of PHY's common serdes block. - - description: Address and length of PHY's DP_COM control block. "#address-cells": enum: [ 1, 2 ] From patchwork Tue Jul 5 09:42:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906243 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22DF0CCA47C for ; Tue, 5 Jul 2022 09:49:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230043AbiGEJtK (ORCPT ); Tue, 5 Jul 2022 05:49:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231372AbiGEJtG (ORCPT ); Tue, 5 Jul 2022 05:49:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3290725C3; Tue, 5 Jul 2022 02:49:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9DE1E61931; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA357C53FCF; Tue, 5 Jul 2022 09:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014543; bh=9GXGSYtsWSG+8jc9OQeAMpIATOnmAAaERp119+1qcAE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VSBDruXmW8fAtKjDDHoHGbMlaTrHI5h9tOT9ef+h0/9nQGK+Xm/6urZK1k/ToG8Pz NlYC7K7h0Uvsdorl/ZrgCm6ASUJn49AvJnYAE93d4p0hkh8GUiqI+MzXDUqhh/O6Ac B+IEPw0z9MSQ4IYNeofy5GZDzE+ISl1B4/IeNH3ndrpZ8xb2deFzzd/Y9EEZe+fCuB vin+5+UX8NMQgTPJDBuB+Fi2cPi0T+uVMc7zxyZlDMoT32uWibqgncRkYEghNgi6+J vi0za58i06BL2E3XAUqDWIjTb9l+Qn5DGg9A2NfQhDlpNRM1pDVbrryq5LHmHlVtdZ GFsahs9k++41g== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB2-0004Y2-Oy; Tue, 05 Jul 2022 11:49:04 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 25/43] dt-bindings: phy: qcom,qmp-ufs: add missing SM8450 clock Date: Tue, 5 Jul 2022 11:42:21 +0200 Message-Id: <20220705094239.17174-26-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Add the missing "qref" clock used by the SM8450 UFS QMP PHY to the binding. Fixes: e04121ba1b08 ("dt-bindings: phy: qcom,qmp: Add SM8450 UFS phy compatible") Fixes: 07fa917a335e ("arm64: dts: qcom: sm8450: add ufs nodes") Signed-off-by: Johan Hovold --- .../bindings/phy/qcom,qmp-ufs-phy.yaml | 23 +++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml index af3ed5601d21..d04cdb85f005 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml @@ -43,11 +43,11 @@ properties: clocks: minItems: 1 - maxItems: 2 + maxItems: 3 clock-names: minItems: 1 - maxItems: 2 + maxItems: 3 resets: items: @@ -129,3 +129,22 @@ allOf: items: - const: ref - const: ref_aux + + - if: + properties: + compatible: + contains: + enum: + - qcom,sm8450-qmp-ufs-phy + then: + properties: + clocks: + items: + - description: 19.2 MHz ref clock. + - description: PHY reference aux clock. + - description: qref clock. + clock-names: + items: + - const: ref + - const: ref_aux + - const: qref From patchwork Tue Jul 5 09:42:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906279 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB387C433EF for ; Tue, 5 Jul 2022 09:49:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232152AbiGEJtt (ORCPT ); Tue, 5 Jul 2022 05:49:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231736AbiGEJtW (ORCPT ); Tue, 5 Jul 2022 05:49:22 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D3CE13D70; Tue, 5 Jul 2022 02:49:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B5000B81733; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2DCBC56749; Tue, 5 Jul 2022 09:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014543; bh=R6jQILHm1jgsSX2k7E2oYI//6NUmG3lm+PysvTkC4Ks=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Rbn/VUmjCJ3W7cBSnwYj9z8zsd4XBSrFwHtU89O013XdMMEFwdrUJoJaqc8w5hJU8 7FNkeEv9xpd9p2DkVXpCWWSyCh+KB/5iXRHCneZBnJRVM8V3PWj/P2bT0jRf2nqHrn dAMHyO0ochFy3PbM3nY07r8mKjGfAeQmnvkND1uHVmuW4mYuxtcbsWa7QpVGKXnpaO jdg4QcPlzdycMR98/uwmYcJ46ocVlWO9phJRXXIi+9Joc+mODnbf2rHT2ujU/QvJiE scw1GDvbIJNomMlr1hynAi31sEnmLRFC3YLX/38tlw04ARoROYyHi3OaMGcIJPF7mn Id72eHh46NdSw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB2-0004Y5-RV; Tue, 05 Jul 2022 11:49:04 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 26/43] dt-bindings: phy: qcom,qmp-ufs: add missing SM8150 power domain Date: Tue, 5 Jul 2022 11:42:22 +0200 Message-Id: <20220705094239.17174-27-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Add the missing optional power-domains property used by the SM8150 UFS QMP PHY to the binding. Fixes: fe75b0c4a691 ("arm64: dts: qcom: sm8150: Add ufs power-domain entries") Signed-off-by: Johan Hovold --- Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml index d04cdb85f005..f1e3d70eb73d 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml @@ -49,6 +49,9 @@ properties: minItems: 1 maxItems: 3 + power-domains: + maxItems: 1 + resets: items: - description: PHY reset in the UFS controller. From patchwork Tue Jul 5 09:42:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906248 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DA0AC43334 for ; Tue, 5 Jul 2022 09:49:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231469AbiGEJtP (ORCPT ); Tue, 5 Jul 2022 05:49:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231378AbiGEJtG (ORCPT ); Tue, 5 Jul 2022 05:49:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 340DFFD3E; Tue, 5 Jul 2022 02:49:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AB59761927; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D617CC5831C; Tue, 5 Jul 2022 09:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014543; bh=j0qtr/Xaydd2eOG004qp/hks1Cdng+e5jtPGk71O+6U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TSsVyuXPio1/0k4red7oBCNyopZN4Vojhb+GGJ0puPV3snUDKbnndLDX0nePqqPod TU12HS+2tCVpDVS9utJWbyaGIvWW8WkmGlLhjzGqTPa7qqagh6SLOdrKEBZ1u+blZe 7kmgJR2lLIB6fjBqqJCKGZ2+++84697W214yopz6s+pf/2PbffCvsFUTLem2uhFsVG 7AtEm8yWgb3ws1VZ2u9uQtImbHpbjCWsreTRB4GelTQkaaXQzZ6di7qHihr3rFWW/e ICJUfK/9t5l90GkL8GpeSXlSBM5NwngGsxI+2vyHXOSOqC9GOWi270axCy6ynJDlVw S6pywKDp4P5Mw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB2-0004Y8-U6; Tue, 05 Jul 2022 11:49:04 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 27/43] dt-bindings: phy: qcom,qmp-ufs: add missing child node schema Date: Tue, 5 Jul 2022 11:42:23 +0200 Message-Id: <20220705094239.17174-28-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Add the missing the description of the PHY-provider child node which was ignored when converting to DT schema. Also fix up the incorrect description that claimed that one child node per lane was required. Fixes: ccf51c1cedfd ("dt-bindings: phy: qcom,qmp: Convert QMP PHY bindings to yaml") Signed-off-by: Johan Hovold --- .../bindings/phy/qcom,qmp-ufs-phy.yaml | 72 ++++++++++++++++++- 1 file changed, 69 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml index f1e3d70eb73d..9124b60eb9a7 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml @@ -75,9 +75,20 @@ properties: patternProperties: "^phy@[0-9a-f]+$": type: object - description: - Each device node of QMP PHY is required to have as many child nodes as - the number of lanes the PHY has. + description: Single PHY-provider child node. + properties: + reg: + minItems: 3 + maxItems: 6 + + "#phy-cells": + const: 0 + + required: + - reg + - "#phy-cells" + + additionalProperties: false required: - compatible @@ -151,3 +162,58 @@ allOf: - const: ref - const: ref_aux - const: qref + + - if: + properties: + compatible: + contains: + enum: + - qcom,msm8998-qmp-ufs-phy + - qcom,sc8280xp-qmp-ufs-phy + - qcom,sdm845-qmp-ufs-phy + - qcom,sm6350-qmp-ufs-phy + - qcom,sm8150-qmp-ufs-phy + - qcom,sm8250-qmp-ufs-phy + - qcom,sm8350-qmp-ufs-phy + - qcom,sm8450-qmp-ufs-phy + then: + patternProperties: + "^phy@[0-9a-f]+$": + properties: + reg: + items: + - description: TX lane 1 + - description: RX lane 1 + - description: PCS + - description: TX lane 2 + - description: RX lane 2 + else: + patternProperties: + "^phy@[0-9a-f]+$": + properties: + reg: + minItems: 3 + maxItems: 4 + items: + - description: TX + - description: RX + - description: PCS + - description: PCS_MISC + if: + properties: + compatible: + contains: + enum: + - qcom,msm8996-qmp-ufs-phy + then: + patternProperties: + "^phy@[0-9a-f]+$": + properties: + reg: + maxItems: 3 + else: + patternProperties: + "^phy@[0-9a-f]+$": + properties: + reg: + minItems: 4 From patchwork Tue Jul 5 09:42:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906275 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A402CCA480 for ; Tue, 5 Jul 2022 09:49:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232012AbiGEJtj (ORCPT ); Tue, 5 Jul 2022 05:49:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231703AbiGEJtV (ORCPT ); Tue, 5 Jul 2022 05:49:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8A35FD3E; Tue, 5 Jul 2022 02:49:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2053C618F2; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1ACDEC341D3; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014544; bh=CSIhE4qibW7M+quZjw+ixus1xzmNavFM5ZRwlurXMxg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M1onH2qP5smWWkwJgCwbPePhxlqCGk4pSAfyUaeN+ivRccr2Vav3nNif7ydVjnLxG 98rlmhO8Czl+x6/VjxGPVFYHee6/uluFT2bmiipPGxeCRWQevwQP8aKoueti53gIdb XFtja7QomX+53oVDA4qUQCqJdBccdhfMmsesMInut5r+CSliIdzCdhnWL79xWf8bfS gF+bHeBz755XRHxJwjGJz4BzLSa9xCZps2DwjEqjNRL3X13fouqT1sTuL39kN96/N1 L5j+o2SELLkibYBjDM/aZTmNSkwKrPbu29Ys3kz9H3R335z6y+DSsCAyfyEXXYjc5L Ira7Op8PPT5sg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB3-0004YB-0K; Tue, 05 Jul 2022 11:49:05 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 28/43] dt-bindings: phy: qcom,qmp-ufs: add example node Date: Tue, 5 Jul 2022 11:42:24 +0200 Message-Id: <20220705094239.17174-29-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Add an example node based on a cleaned up version of sc8280xp.dtsi. Signed-off-by: Johan Hovold --- .../bindings/phy/qcom,qmp-ufs-phy.yaml | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml index 9124b60eb9a7..24272cdde9a1 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml @@ -217,3 +217,33 @@ allOf: properties: reg: minItems: 4 + +examples: + - | + #include + #include + phy-wrapper@1d87000 { + compatible = "qcom,sc8280xp-qmp-ufs-phy"; + reg = <0x01d87000 0xe10>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x01d87000 0x1000>; + + clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_UFS_PHY_PHY_AUX_CLK>; + clock-names = "ref", "ref_aux"; + + resets = <&ufs_mem_hc 0>; + reset-names = "ufsphy"; + + vdda-phy-supply = <&vreg_l6b>; + vdda-pll-supply = <&vreg_l3b>; + + phy@400 { + reg = <0x400 0x108>, + <0x600 0x1e0>, + <0xc00 0x1dc>, + <0x800 0x108>, + <0xa00 0x1e0>; + #phy-cells = <0>; + }; + }; From patchwork Tue Jul 5 09:42:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906247 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F6F5CCA47F for ; Tue, 5 Jul 2022 09:49:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231152AbiGEJtN (ORCPT ); Tue, 5 Jul 2022 05:49:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231390AbiGEJtG (ORCPT ); Tue, 5 Jul 2022 05:49:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DCA611C06; Tue, 5 Jul 2022 02:49:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B7FA06192F; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 333B5C341D2; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014544; bh=NMdG3JQTVZQsmBPHe3nFjQ3nKf9PlrIsuO3XSeSbWNk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iV7OLkbQdT6Ro/Fo2D/UxQpfbNQVNh9IUhZXxtF8aYC0t3s+0iBr8AjYIXoZUHJYf 73i6jzRiDlqSWt4BUZbvbd+IkVFI8awE0mU77vfxHBrUNkr4R8GuvCExnVX1L7YcRq VGAiOn0tpg4hwfotXATUW1L774+r4ycWBntv1pb9vZ36YsdHBCSgSWezYHMxz0Tmq3 6ai/mrxU5mLuOQKAh5GojmkYZmK4zELgJwv43ZiHUrlhkm9ktZWteye/0iqMu/0GGm jQ7A6W0bdyRMFxpZyKm3K4/SNTRUqovnnavOAibaKnWmk6gGYYBwz0NI2kdY52eg2q fhUb5gKG64zLw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB3-0004YE-3D; Tue, 05 Jul 2022 11:49:05 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 29/43] dt-bindings: phy: qcom,qmp: split out USB binding Date: Tue, 5 Jul 2022 11:42:25 +0200 Message-Id: <20220705094239.17174-30-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The QMP PHY DT schema is getting unwieldy. Break out the USB PHY binding in a separate file. Signed-off-by: Johan Hovold --- .../phy/{qcom,qmp-phy.yaml => qcom,qmp-usb-phy.yaml} | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) rename Documentation/devicetree/bindings/phy/{qcom,qmp-phy.yaml => qcom,qmp-usb-phy.yaml} (98%) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml similarity index 98% rename from Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml rename to Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml index 04c24f8e4526..8343e24b669a 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml @@ -2,10 +2,10 @@ %YAML 1.2 --- -$id: "http://devicetree.org/schemas/phy/qcom,qmp-phy.yaml#" +$id: "http://devicetree.org/schemas/phy/qcom,qmp-usb-phy.yaml#" $schema: "http://devicetree.org/meta-schemas/core.yaml#" -title: Qualcomm QMP PHY controller +title: Qualcomm QMP PHY controller (USB) maintainers: - Vinod Koul @@ -130,6 +130,7 @@ allOf: required: - vdda-phy-supply - vdda-pll-supply + - if: properties: compatible: @@ -160,6 +161,7 @@ allOf: required: - vdda-phy-supply - vdda-pll-supply + - if: properties: compatible: @@ -191,6 +193,7 @@ allOf: required: - vdda-phy-supply - vdda-pll-supply + - if: properties: compatible: @@ -225,6 +228,7 @@ allOf: required: - vdda-phy-supply - vdda-pll-supply + - if: properties: compatible: @@ -255,6 +259,7 @@ allOf: required: - vdda-phy-supply - vdda-pll-supply + - if: properties: compatible: From patchwork Tue Jul 5 09:42:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906261 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1C84CCA47B for ; Tue, 5 Jul 2022 09:49:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231807AbiGEJt0 (ORCPT ); Tue, 5 Jul 2022 05:49:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231590AbiGEJtT (ORCPT ); Tue, 5 Jul 2022 05:49:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5466212D16; Tue, 5 Jul 2022 02:49:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 24AC26193E; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 339CCC341F9; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014544; bh=TyTxeiPGGyT7aa4zhB7OAEq1HFM+F+bckgKphFzdOcM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OOoiKt80Qz1yiEY3O2Kcama7//cxkl0TtxvTSncJUKJx//fy60H1HAllfTjKRew4L P17r/awIv1GuNBevQqBAvh07t8N5DnaJscD95RwVFJRFOFIuUJ6WkH3GUrCelk1tYL T39jLQ5xExltq6LZVmWjWG0g+TKW77CmUOHdDpDlLneMk4mcr7OA+dMtogwSyJhuB+ +OerusRlehiUdw0zMuM160LyLaWnREpkFFijFMMA8nejoG12wCA8s3o2as7GfZq7/0 BJwwrqsx23+e8ti5Zdu+ON6ehNL4z6zA+hwYlKQU30GJHdc/waHrDbKi+dgukZDY2z AUX+aCxMKooeA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB3-0004YH-6S; Tue, 05 Jul 2022 11:49:05 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 30/43] dt-bindings: phy: qcom,qmp-usb: clean up clock constraints Date: Tue, 5 Jul 2022 11:42:26 +0200 Message-Id: <20220705094239.17174-31-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The USB PHY binding uses three or four clocks. Signed-off-by: Johan Hovold --- Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml index 8343e24b669a..2f7043503ca0 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml @@ -51,11 +51,11 @@ properties: ranges: true clocks: - minItems: 1 + minItems: 3 maxItems: 4 clock-names: - minItems: 1 + minItems: 3 maxItems: 4 resets: From patchwork Tue Jul 5 09:42:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906274 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25840C433EF for ; Tue, 5 Jul 2022 09:49:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231998AbiGEJti (ORCPT ); Tue, 5 Jul 2022 05:49:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231666AbiGEJtV (ORCPT ); Tue, 5 Jul 2022 05:49:21 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C248C11A3C; Tue, 5 Jul 2022 02:49:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 06669CE1AFB; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41659C5832B; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014544; bh=Uy3ubjYoX5YJYX58mI9UPoE9fqVXua8OSCQpJb2PU1s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Azmpn8cgQxvEZAv6C7gZhDSRXXzBhLvdrM9syVpU7MwqQ0BoGarnkbKg5y3FnCCq4 4g0XK7pwzQ+fI2lg/WjWR1bj7NO5s1An+Z1tMzYPn6Rh4unbjEo8s20FoxQ+VPzaYM TE2gt2fQWPce2XaDObPbqB5l4UyDARwGSGGtoDnLJECeueCHFjifnfMiePiCJI198W kcajFc/72X/6jNI3i9kFZyQXTSGhh1qvOkfnLw6iw2VNKFe+yx9y5owL0XYH/nWB9Y Rfj/5Oay1bk8hxdFiy/Wg1rLyhk8hbt9fJ7EWjC1/dDBG+/aqGJTgXKkJMTaIle963 rX/fgvl6zpnTg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB3-0004YK-9N; Tue, 05 Jul 2022 11:49:05 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 31/43] dt-bindings: phy: qcom,qmp-usb: clean up supplies Date: Tue, 5 Jul 2022 11:42:27 +0200 Message-Id: <20220705094239.17174-32-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The USB PHY binding requires the vdda-phy and vdd-pll supplies. Signed-off-by: Johan Hovold --- .../bindings/phy/qcom,qmp-usb-phy.yaml | 20 ++----------------- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml index 2f7043503ca0..3404ad7fc6db 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml @@ -95,6 +95,8 @@ required: - clock-names - resets - reset-names + - vdda-phy-supply + - vdda-pll-supply additionalProperties: false @@ -127,9 +129,6 @@ allOf: items: - const: phy - const: common - required: - - vdda-phy-supply - - vdda-pll-supply - if: properties: @@ -158,9 +157,6 @@ allOf: items: - const: phy - const: common - required: - - vdda-phy-supply - - vdda-pll-supply - if: properties: @@ -190,9 +186,6 @@ allOf: items: - const: phy - const: common - required: - - vdda-phy-supply - - vdda-pll-supply - if: properties: @@ -225,9 +218,6 @@ allOf: items: - const: phy - const: common - required: - - vdda-phy-supply - - vdda-pll-supply - if: properties: @@ -256,9 +246,6 @@ allOf: items: - const: phy - const: common - required: - - vdda-phy-supply - - vdda-pll-supply - if: properties: @@ -286,9 +273,6 @@ allOf: items: - const: phy_phy - const: phy - required: - - vdda-phy-supply - - vdda-pll-supply examples: - | From patchwork Tue Jul 5 09:42:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906278 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FAB0CCA481 for ; Tue, 5 Jul 2022 09:49:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232147AbiGEJtr (ORCPT ); Tue, 5 Jul 2022 05:49:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231740AbiGEJtV (ORCPT ); Tue, 5 Jul 2022 05:49:21 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7640B13D6B; Tue, 5 Jul 2022 02:49:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E0816B8172E; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68A89C341DB; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014544; bh=tuoEnZLbKbLZ+g2dIuP0Vqx9Bsaroi5FmYSfg9SAq5Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I5hOA2wdu3ATaSbt8tsgCkVgPJCHome5X3T3x8JfKjPNJnrvXw4ggO/m8pEeDhVmo iolqHCVYQc/cEzItSL8Z9Y/e13T9s/0r6wZWJiDHV7+VBizGf8ysGehUhVtx9kc4bl ym/jTPZfQ81nWHPZ7Cd4uA/YNLrq0TlTjUUPFR8blJYR7ymJXYUiEz/9d9Lwh2G/gA uK++S7KDVwvevVCixyt24gjOt56kxv8HNDT4h/Il2ws2+SMXLYcm49eLM1bv+JEqxV DhIkqjN7q2ZKGbAtDikr889euW34FOQ+FHmqmPLAgcerbHcDzzyThyf8nCo8UHdnbF KfzN5NdE4GulQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB3-0004YN-Cd; Tue, 05 Jul 2022 11:49:05 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 32/43] dt-bindings: phy: qcom,qmp-usb: drop unused vddp-ref-clk supply Date: Tue, 5 Jul 2022 11:42:28 +0200 Message-Id: <20220705094239.17174-33-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Only UFS PHY nodes in mainline have a vddp-ref-clk supply. Drop it from the USB PHY binding. Signed-off-by: Johan Hovold --- Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml index 3404ad7fc6db..76979aff086f 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml @@ -74,10 +74,6 @@ properties: description: Phandle to 1.8V regulator supply to PHY refclk pll block. - vddp-ref-clk-supply: - description: - Phandle to a regulator supply to any specific refclk pll block. - patternProperties: "^phy@[0-9a-f]+$": type: object From patchwork Tue Jul 5 09:42:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906250 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 577D4CCA482 for ; Tue, 5 Jul 2022 09:49:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231520AbiGEJtR (ORCPT ); Tue, 5 Jul 2022 05:49:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231416AbiGEJtH (ORCPT ); Tue, 5 Jul 2022 05:49:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9500F585; Tue, 5 Jul 2022 02:49:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CA7B761938; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BC3BC341D6; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014544; bh=PhRApFCiLUdWRFq6zUYswP6+UOMNazeUw4UHcVq05YM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HLwEVNJP1YH32Op6UM5LA7QVD/1K8gi/npvChWyrRU+Q6M0M7w6IXB9Wcio30yEmh GLinPMlSpraNXLGgXPf6Ti5c0F54Pi8kCaqZxzKgkSO5/MLdb/ygjmh6X/+MMgfka7 YoxZPPnFUS3QQDzsTwXml+Z20aXxvMMZ18tgOJDfBucKOjVgZD1eeG6uabadqiiW8j +V/H+csGowyTiIJSRlNTAhYDHG6ARI7Vy9u3twow3+VVbtx4L2dEnOvnT1l+WJTzlw c3TFzvHpJUXMkwtK2tIFgtVgTPvD98n2A/sV7guHlVuqDSDUbUPSh26+l9eKQoVL8L eScQfCXoO4Knw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB3-0004YQ-F8; Tue, 05 Jul 2022 11:49:05 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 33/43] dt-bindings: phy: qcom,qmp-usb: clean up reset providers Date: Tue, 5 Jul 2022 11:42:29 +0200 Message-Id: <20220705094239.17174-34-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The USB PHY binding requires two resets. Signed-off-by: Johan Hovold --- .../devicetree/bindings/phy/qcom,qmp-usb-phy.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml index 76979aff086f..21744bbe1764 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml @@ -59,12 +59,12 @@ properties: maxItems: 4 resets: - minItems: 1 - maxItems: 3 + minItems: 2 + maxItems: 2 reset-names: - minItems: 1 - maxItems: 3 + minItems: 2 + maxItems: 2 vdda-phy-supply: description: From patchwork Tue Jul 5 09:42:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906258 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CF08C43334 for ; Tue, 5 Jul 2022 09:49:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231768AbiGEJtX (ORCPT ); Tue, 5 Jul 2022 05:49:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231460AbiGEJtI (ORCPT ); Tue, 5 Jul 2022 05:49:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FC5212D08; Tue, 5 Jul 2022 02:49:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3CE5461943; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BD55C341DC; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014544; bh=jIYm/pfJJnHX7kIpyfA/95SToflZxqcjCruxOMG9gVs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PWxxWM/k1TSzpaNgqhuFMK6+XczPU+25wK9G52gPhW9vEhtgyomnXrByImBOL0U+B uyfy8mYYt1tOFt01lsYwPqnPnblF9mGcopwDofvyrn8CfnJb4KeuW+oCfn8CkM+DZI OcR2iXbLwDVY0NChXXHPJqg+5N3/zruUwBU1JMXJoibOPQXDUd69ZR8ixzGDhNF07L FRWoBnF1nnMN5f40LOwD64QQ4zzQ0FWJqA2643iFSHU5pMaFjoEIB59cJLVRXEiYd/ 7x+uDQaa+8irLWyOJ2sQ/K7gV1J2DU2sMYn1kD+MMjAaAZ/zDYbO2/XoH9XGT0niHj dMfNPQw3zZBdQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB3-0004YT-He; Tue, 05 Jul 2022 11:49:05 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 34/43] dt-bindings: phy: qcom,qmp-usb: add missing child node schema Date: Tue, 5 Jul 2022 11:42:30 +0200 Message-Id: <20220705094239.17174-35-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Add the missing the description of the PHY-provider child node which was ignored when converting to DT schema. Also fix up the incorrect description that claimed that one child node per lane was required. Fixes: ccf51c1cedfd ("dt-bindings: phy: qcom,qmp: Convert QMP PHY bindings to yaml") Signed-off-by: Johan Hovold --- .../bindings/phy/qcom,qmp-usb-phy.yaml | 109 +++++++++++++++++- 1 file changed, 106 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml index 21744bbe1764..c9a6765708cc 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml @@ -77,9 +77,37 @@ properties: patternProperties: "^phy@[0-9a-f]+$": type: object - description: - Each device node of QMP PHY is required to have as many child nodes as - the number of lanes the PHY has. + description: Single PHY-provider child node. + properties: + reg: + minItems: 3 + maxItems: 6 + + clocks: + items: + - description: PIPE clock + + clock-names: + items: + - const: pipe0 + + "#clock-cells": + const: 0 + + clock-output-names: true + + "#phy-cells": + const: 0 + + required: + - reg + - clocks + - clock-names + - "#clock-cells" + - clock-output-names + - "#phy-cells" + + additionalProperties: false required: - compatible @@ -270,6 +298,81 @@ allOf: - const: phy_phy - const: phy + - if: + properties: + compatible: + contains: + enum: + - qcom,msm8998-qmp-usb3-phy + - qcom,sdm845-qmp-usb3-phy + - qcom,sm8150-qmp-usb3-phy + - qcom,sm8350-qmp-usb3-phy + - qcom,sm8450-qmp-usb3-phy + then: + patternProperties: + "^phy@[0-9a-f]+$": + properties: + reg: + minItems: 5 + maxItems: 6 + items: + - description: TX lane 1 + - description: RX lane 1 + - description: PCS + - description: TX lane 2 + - description: RX lane 2 + - description: PCS_MISC + if: + properties: + compatible: + contains: + enum: + - qcom,msm8998-qmp-usb3-phy + then: + patternProperties: + "^phy@[0-9a-f]+$": + properties: + reg: + maxItems: 5 + else: + patternProperties: + "^phy@[0-9a-f]+$": + properties: + reg: + minItems: 6 + else: + patternProperties: + "^phy@[0-9a-f]+$": + properties: + reg: + minItems: 3 + maxItems: 4 + items: + - description: TX + - description: RX + - description: PCS + - description: PCS_MISC + if: + properties: + compatible: + contains: + enum: + - qcom,msm8996-qmp-usb3-phy + - qcom,sm8250-qmp-usb3-uni-phy + - qcom,sm8350-qmp-usb3-uni-phy + then: + patternProperties: + "^phy@[0-9a-f]+$": + properties: + reg: + maxItems: 3 + else: + patternProperties: + "^phy@[0-9a-f]+$": + properties: + reg: + minItems: 4 + examples: - | #include From patchwork Tue Jul 5 09:42:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906255 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B716CCA482 for ; Tue, 5 Jul 2022 09:49:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231756AbiGEJtW (ORCPT ); Tue, 5 Jul 2022 05:49:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231450AbiGEJtI (ORCPT ); Tue, 5 Jul 2022 05:49:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45054DFB9; Tue, 5 Jul 2022 02:49:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D807661912; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 877B0C36AED; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014544; bh=UrYmxKcokEnipCFXZY2m8O/HJdO0TM/Sq4azmTPuAaU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iQqjtqPny9cqTsIHgU4mHdOGRQJ7xcomfXr5Wuwp50wD/izzGcRLFD0pGmrXX7S7s pVfmOcDMj+VIo5A2UyaHPKWUbm/uh5AKQQbxiOq4DjSQEJ1fRlliGkdvYvAPteWfiV h2i24xDDWmDMJ76wJ1XLOvpZGurmBOQgHmIck2qFf9DXis7Zqf4QPkaIAr0MMyoEPk 1oygL4rf6KCb0LzBz9ZLqm3ZVigxgokB8v9Y9rHh4q8Z5Y9oHg3viAmH6x4bKIBrYJ vFv06/s9qHUR77oOOWL1lRzH4k3BLeTClL623+yHkyOiwiaismjEeR5rNwgnDOFhoJ UQEKqeqrAR3rw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB3-0004YV-KC; Tue, 05 Jul 2022 11:49:05 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 35/43] dt-bindings: phy: qcom,qmp-usb: deprecate PIPE clock name Date: Tue, 5 Jul 2022 11:42:31 +0200 Message-Id: <20220705094239.17174-36-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Drop the bogus "lane" suffix from the PHY PIPE clock name and mark the old name as deprecated. Signed-off-by: Johan Hovold --- .../devicetree/bindings/phy/qcom,qmp-usb-phy.yaml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml index c9a6765708cc..279b8823bc17 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml @@ -88,8 +88,12 @@ patternProperties: - description: PIPE clock clock-names: - items: - - const: pipe0 + oneOf: + - items: + - const: pipe + - items: + - const: pipe0 + deprecated: true "#clock-cells": const: 0 @@ -403,7 +407,7 @@ examples: <0x600 0x70>; clocks = <&gcc GCC_USB3_SEC_PHY_PIPE_CLK>; - clock-names = "pipe0"; + clock-names = "pipe"; #clock-cells = <0>; clock-output-names = "usb3_uni_phy_pipe_clk_src"; From patchwork Tue Jul 5 09:42:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906269 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40AB3CCA47C for ; Tue, 5 Jul 2022 09:49:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231909AbiGEJtd (ORCPT ); Tue, 5 Jul 2022 05:49:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231657AbiGEJtV (ORCPT ); Tue, 5 Jul 2022 05:49:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72DC412D32; Tue, 5 Jul 2022 02:49:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F3F1F618E8; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3CC0C341D5; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014544; bh=u94lrqzZCL2U43fE56CPQFg5fcc+j1jnnHfeDdjY1bQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sEcPHR1fafaGuuSHPAN8Q9f/p7OizsdAqSQRUHErXbjMdDUbelggFIZseBwPhyNQd kzD11j9q4fV73chYFoGfYEKWj0Kjd9e77T4K/SHlX8B8Vm0OLSYnX1KzuaftSDL9eC O0AQQYKg2vvkFyut0RZitBMkPpPDNDoxPtRJT9J3MkIWe/F/ElsZH/lfzjkAoTrdhD CnGqEQdgd9ZHqtCnOTXgCoz7VEZDdiZNqj08FA3cjt+jODyK7fLGK/eocEBmAC2k3U oO4AByecJW4mi+WTyQs8pHFDraelyiQ9KvUm2XWbhbssp9EPngEifmPBb29WNXhB0h a9Ve4urwdLXTg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB3-0004YY-NT; Tue, 05 Jul 2022 11:49:05 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 36/43] dt-bindings: phy: qcom,qmp-usb3-dp: fix bogus clock-cells property Date: Tue, 5 Jul 2022 11:42:32 +0200 Message-Id: <20220705094239.17174-37-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The QMP PHY wrapper node is not a clock provider so drop the bogus '#clock-cells' property that was added when converting to DT schema. Fixes: 59351049ad15 ("dt-bindings: phy: qcom,qmp-usb3-dp: Add dt bindings for USB3 DP PHY") Signed-off-by: Johan Hovold --- .../devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml index 60dc27834e1d..86d64c61bca3 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml @@ -30,9 +30,6 @@ properties: - const: dp_com - const: dp - "#clock-cells": - enum: [ 1, 2 ] - "#address-cells": enum: [ 1, 2 ] @@ -147,7 +144,6 @@ patternProperties: required: - compatible - reg - - "#clock-cells" - "#address-cells" - "#size-cells" - ranges @@ -169,7 +165,6 @@ examples: <0x088e8000 0x10>, <0x088ea000 0x40>; reg-names = "usb", "dp_com", "dp"; - #clock-cells = <1>; #address-cells = <1>; #size-cells = <1>; ranges = <0x0 0x088e9000 0x2000>; From patchwork Tue Jul 5 09:42:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906253 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 209F3CCA47B for ; Tue, 5 Jul 2022 09:49:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231578AbiGEJtT (ORCPT ); Tue, 5 Jul 2022 05:49:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231135AbiGEJtH (ORCPT ); Tue, 5 Jul 2022 05:49:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44D6C38A1; Tue, 5 Jul 2022 02:49:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 124F86192C; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6E32C341CF; Tue, 5 Jul 2022 09:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014544; bh=eIr/QiwdfHR3bGr/CfGRxxEsPkmmFmBqkyN0cb2r2go=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pLXWfSuRRmkPEShhbmW6ADTTGuRWjP+vrn8cPOlB2OXF2REy8BzB3zwPuL9dhgtZH Lw/m34jJUdFEHqu3VAvK96/fZF6UEmbBs1vNDP+29wsaVMOHbIU6n8OBjKo4GTRwsO gEiHzO04C3Izw9lc3iqBUijCACrJ1qF/xMDPm56g6w2C3BP0dPrG1wul6qEzcX9xuX PJP6AoqpZYO3oEpKv/ayX2t8ShRloXHdp0eY3dYPxO8I9V712Mm2nw3s01i4PSmTPc lmQ1tW+/5zqZ/e8KjogSSMD7seLtdrHytYjkhrrzCO019QamO5AWKEWS2Hz7hmjZ13 uIq8kpU7XXldA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB3-0004Yc-Qg; Tue, 05 Jul 2022 11:49:05 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 37/43] dt-bindings: phy: qcom,qmp-usb3-dp: deprecate USB PIPE clock name Date: Tue, 5 Jul 2022 11:42:33 +0200 Message-Id: <20220705094239.17174-38-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Drop the bogus "lane" suffix from the USB PHY PIPE clock name and mark the old name as deprecated. Signed-off-by: Johan Hovold --- .../devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml index 86d64c61bca3..09d7708158bb 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml @@ -96,8 +96,12 @@ patternProperties: - description: pipe clock clock-names: - items: - - const: pipe0 + oneOf: + - items: + - const: pipe + - items: + - const: pipe0 + deprecated: true clock-output-names: items: @@ -192,7 +196,7 @@ examples: #clock-cells = <0>; #phy-cells = <0>; clocks = <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>; - clock-names = "pipe0"; + clock-names = "pipe"; clock-output-names = "usb3_phy_pipe_clk_src"; }; From patchwork Tue Jul 5 09:42:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906276 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D87CCCA47B for ; Tue, 5 Jul 2022 09:49:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232021AbiGEJtk (ORCPT ); Tue, 5 Jul 2022 05:49:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231709AbiGEJtV (ORCPT ); Tue, 5 Jul 2022 05:49:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C912F11C06; Tue, 5 Jul 2022 02:49:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 33D4261941; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 053BFC36AFB; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014545; bh=wcigz9eclfSlWhiIkb00jJF/UDQ56QYbAzKSS2z1YZ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kS5qxQ0WIivvIBz1ZT5ed8ga5vBNVzH0vvcvbnikOB18zbQ3Ahg89WGoDp2Hbe4Bk DGXYq6wRxTa2OW0akV/vfoO28WjOHOmlTA9HKtJWfEJYE82znjn8ptSypyWH4gaV9O 4ja90ZV6zmc10StWi9rbSP2aV5t/ukUBE19BnvwtHn0fr6X+uhd5A1EYbzC9MWSUtV 64hcgg4ReNdLJvCj/HOhAAIyOptEZ9tfnwcy/pZG0tI3pKjiibuTHSskFguML9Cnbv p7ZTot6duCOe1YhBYJaA3pO/44+4Ww+hZJWLCFeCm+bpUW4eNT0Zg/dZ5j7WqBsou/ JXo2cVUL8Md1Q== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB3-0004Yf-TZ; Tue, 05 Jul 2022 11:49:05 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 38/43] phy: qcom-qmp-pcie: drop pipe clock lane suffix Date: Tue, 5 Jul 2022 11:42:34 +0200 Message-Id: <20220705094239.17174-39-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The pipe clock is defined in the "lane" node so there's no need to keep adding a redundant lane-number suffix to the clock name. Drop the lane suffix from the pipe clock name, but continue supporting the legacy name as a fall back. Signed-off-by: Johan Hovold --- drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c index 385ea3d8de08..254ad25591b9 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c @@ -2210,8 +2210,12 @@ int qcom_qmp_phy_pcie_create(struct device *dev, struct device_node *np, int id, if (!qphy->pcs_misc) dev_vdbg(dev, "PHY pcs_misc-reg not used\n"); - snprintf(prop_name, sizeof(prop_name), "pipe%d", id); - qphy->pipe_clk = devm_get_clk_from_child(dev, np, prop_name); + qphy->pipe_clk = devm_get_clk_from_child(dev, np, "pipe"); + if (IS_ERR(qphy->pipe_clk) && PTR_ERR(qphy->pipe_clk) != -EPROBE_DEFER) { + /* Fall back to the legacy pipe clock name. */ + snprintf(prop_name, sizeof(prop_name), "pipe%d", id); + qphy->pipe_clk = devm_get_clk_from_child(dev, np, prop_name); + } if (IS_ERR(qphy->pipe_clk)) { return dev_err_probe(dev, PTR_ERR(qphy->pipe_clk), "failed to get lane%d pipe clock\n", id); From patchwork Tue Jul 5 09:42:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906268 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87149CCA481 for ; Tue, 5 Jul 2022 09:49:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231904AbiGEJtd (ORCPT ); Tue, 5 Jul 2022 05:49:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231658AbiGEJtV (ORCPT ); Tue, 5 Jul 2022 05:49:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5528A12D38; Tue, 5 Jul 2022 02:49:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4AB4C61947; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CB63C36AFD; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014545; bh=RBWMNafFLJ5+9XGEW3FH8+PBc/s5o4Lq0hQU1zm8vLg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E/s9WnG6vT5+QzoAu2WPfG3LnnSg2GPTdpGHJrm8xye4O2IEA145Ql/1nSZyhMBwM BJ8hJ+Yb5OXD9stqdk+sSo+UIoLyHaOAerzyoM66/a4wctqMNI+JE/u9ROu+a6tYWp tNN26KjbWuP5xNiwfFL4Aq1ihAay2cRwvd6NsXkKrwNqCURM6okopd/t4OcqzkLZLt bTu9RNWWjiD/X6iqjMoQEtfVtdSdlyS3hrjsuBb/cwJzVn63+O72DyWEWtL7jJwg/f nUolDSTc7XwtGKYb7KaAxJh+26AW3LYJGAAYB/PQzwCnUN/355oHkLAvpxklcVe6tk uvVD8aBtni7ig== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB4-0004ZQ-21; Tue, 05 Jul 2022 11:49:06 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 39/43] phy: qcom-qmp-combo: drop unused lane reset Date: Tue, 5 Jul 2022 11:42:35 +0200 Message-Id: <20220705094239.17174-40-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Drop the unused lane reset pointer which isn't used by any combo PHY. Signed-off-by: Johan Hovold Reviewed-by: Dmitry Baryshkov --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c index c18cd3b93c30..b266514ae9ee 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -818,7 +818,6 @@ struct qmp_phy_combo_cfg { * @pipe_clk: pipe clock * @index: lane index * @qmp: QMP phy to which this lane belongs - * @lane_rst: lane's reset controller * @mode: current PHY mode * @dp_aux_cfg: Display port aux config * @dp_opts: Display port optional config @@ -837,7 +836,6 @@ struct qmp_phy { struct clk *pipe_clk; unsigned int index; struct qcom_qmp *qmp; - struct reset_control *lane_rst; enum phy_mode mode; unsigned int dp_aux_cfg; struct phy_configure_opts_dp dp_opts; From patchwork Tue Jul 5 09:42:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906263 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69DF8CCA47B for ; Tue, 5 Jul 2022 09:49:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231818AbiGEJt2 (ORCPT ); Tue, 5 Jul 2022 05:49:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231648AbiGEJtU (ORCPT ); Tue, 5 Jul 2022 05:49:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4AB712777; Tue, 5 Jul 2022 02:49:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 888CC61940; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 565A7C36B03; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014545; bh=YMvAOoxj66wx3vQtLy6RtQ77bhpRxfXPIBlYHFKEAkM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DWSSxYGX2Rou1bXKSrmfSI3NcuE0Gv7nf1rQSkHzkSpx+XvreYDTiSCG9p1nQuTQ0 cttp0E9RR0tnw4KK1AJCG/oE2fIDw8ZZODUpiTfWjsFUx71ph6PICFImzxPEXxPvh2 kj9jxmaDD0tBYr9uBRzz+dIOfm017deDchFFQ+cOTL75+mzrIYMeRD1lorVC8RQOuV Uow4IDe61D7+JHm5wVizd8vHUpj7xJAcnCIgdYHrV1r18/imE3pCOeI58syf9TcWeu d2ISrjBxRsV7THQsVtiSfIr3mtdvUtO+N9R4p7ChHjWFr+HlwBeEKvIthlSJs7V4sY e2RftCF6M3jlQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB4-0004aC-7o; Tue, 05 Jul 2022 11:49:06 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 40/43] phy: qcom-qmp-combo: drop pipe clock lane suffix Date: Tue, 5 Jul 2022 11:42:36 +0200 Message-Id: <20220705094239.17174-41-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The pipe clock is defined in the "lane" node so there's no need to keep adding a redundant lane-number suffix to the clock name. Drop the lane suffix from the pipe clock name, but continue supporting the legacy name as a fall back. Signed-off-by: Johan Hovold --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c index b266514ae9ee..7b2eb234cfc2 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -2558,8 +2558,12 @@ int qcom_qmp_phy_combo_create(struct device *dev, struct device_node *np, int id * Otherwise, we initialize pipe clock to NULL for * all phys that don't need this. */ - snprintf(prop_name, sizeof(prop_name), "pipe%d", id); - qphy->pipe_clk = devm_get_clk_from_child(dev, np, prop_name); + qphy->pipe_clk = devm_get_clk_from_child(dev, np, "pipe"); + if (IS_ERR(qphy->pipe_clk) && PTR_ERR(qphy->pipe_clk) != -EPROBE_DEFER) { + /* Fall back to the legacy pipe clock name. */ + snprintf(prop_name, sizeof(prop_name), "pipe%d", id); + qphy->pipe_clk = devm_get_clk_from_child(dev, np, prop_name); + } if (IS_ERR(qphy->pipe_clk)) { if (cfg->type == PHY_TYPE_USB3) { ret = PTR_ERR(qphy->pipe_clk); From patchwork Tue Jul 5 09:42:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906267 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66B33CCA480 for ; Tue, 5 Jul 2022 09:49:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231876AbiGEJtc (ORCPT ); Tue, 5 Jul 2022 05:49:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231665AbiGEJtV (ORCPT ); Tue, 5 Jul 2022 05:49:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A48F012D34; Tue, 5 Jul 2022 02:49:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8E8666194F; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 603CAC36B04; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014545; bh=NnKadBX0uQiTIGEQh4rkH/Llkp6mA0RpNtPji7zBpeU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tlyS9sOoQRO/kQ5ohVioxfNPSqVrgkdSTSkqipO3BMGqGkAyNzvhUy2RLhT2VaAw8 yRTYtOUjtA9fuI4A/t07/JC8vnzKERS1h5JNxD/p7jTJWS9jErckovwRzHRyP+Ci1U zntmJpOijWSWR0cWXOGZMn46MDJi3ncF1xpbTzvkMeaSYpAR91E6rFNzCDjL6inQTo exr41COcpMTUhdbGtjMKOY9jBXQUYKrmPmfy18YceI/QkavQJP85WPfY/VI4IaA4Rx DRPYsQ+iz3aosmh2F/UjrAE6WQ33w6giN5qeiEas68mSxxf0TT27pvmyCiQYxUowzu 3Uy1VXzKzkETg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB4-0004aa-CD; Tue, 05 Jul 2022 11:49:06 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 41/43] phy: qcom-qmp-pcie-msm8996: drop pipe clock lane suffix Date: Tue, 5 Jul 2022 11:42:37 +0200 Message-Id: <20220705094239.17174-42-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The pipe clock is defined in the "lane" node so there's no need to keep adding a redundant lane-number suffix to the clock name. Drop the lane suffix from the pipe clock name, but continue supporting the legacy name as a fall back. Signed-off-by: Johan Hovold --- drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c index 812d14afb5ec..b8481dab54db 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c @@ -904,8 +904,12 @@ int qcom_qmp_phy_pcie_msm8996_create(struct device *dev, struct device_node *np, if (!qphy->pcs_misc) dev_vdbg(dev, "PHY pcs_misc-reg not used\n"); - snprintf(prop_name, sizeof(prop_name), "pipe%d", id); - qphy->pipe_clk = devm_get_clk_from_child(dev, np, prop_name); + qphy->pipe_clk = devm_get_clk_from_child(dev, np, "pipe"); + if (IS_ERR(qphy->pipe_clk) && PTR_ERR(qphy->pipe_clk) != -EPROBE_DEFER) { + /* Fall back to the legacy pipe clock name. */ + snprintf(prop_name, sizeof(prop_name), "pipe%d", id); + qphy->pipe_clk = devm_get_clk_from_child(dev, np, prop_name); + } if (IS_ERR(qphy->pipe_clk)) { return dev_err_probe(dev, PTR_ERR(qphy->pipe_clk), "failed to get lane%d pipe clock\n", id); From patchwork Tue Jul 5 09:42:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906262 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86095CCA485 for ; Tue, 5 Jul 2022 09:49:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229972AbiGEJt1 (ORCPT ); Tue, 5 Jul 2022 05:49:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231626AbiGEJtU (ORCPT ); Tue, 5 Jul 2022 05:49:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F90DDFEF; Tue, 5 Jul 2022 02:49:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A98D261919; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 793F2C341ED; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014545; bh=qN2MBS4iXGKTp1LW3/dBfjDQA+8VCN1gORTM4XGT/iM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DWmeq/gYfSAg1ikbfrLtH3CMfWj9qsAoxOQQhIn+zQtPFlk6MJX1xvHNNRWYo0lML fucZakFMVgY/ggoVfswqb0HwlzPxnzoRtURtVfUw/qDH8oOkRdumR+d+FJF36ERF0I 49vBVpfGADAhp7VYNfXfcJZpgd6DxGEYbcV42aroyPQDDVF/bfSW71nWXGT5wUOeWM tGP6qLNv6zfSDYmHjx+NFmIXzAEHTWKOO6DtNtQI+nAbK58l9d1jxWwdSKE3e4rQJ+ Qjrlo035l9tGAb0ardpolr0Tf1NcGUAKdJnJmzHcjjDaVrKyW1ehbiFQscF/+a5iom Xk9Gxg5SQXfvQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB4-0004az-Fq; Tue, 05 Jul 2022 11:49:06 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 42/43] phy: qcom-qmp-pcie-msm8996: drop reset lane suffix Date: Tue, 5 Jul 2022 11:42:38 +0200 Message-Id: <20220705094239.17174-43-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The lane reset is defined in the "lane" node so there's no need to keep adding a redundant lane-number suffix to the reset name. Drop the lane-number suffix from the lane reset name, but continue supporting the legacy name as a fall back. Signed-off-by: Johan Hovold --- drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c index b8481dab54db..9ddb42fa5f7a 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c @@ -915,9 +915,12 @@ int qcom_qmp_phy_pcie_msm8996_create(struct device *dev, struct device_node *np, "failed to get lane%d pipe clock\n", id); } - /* Get lane reset, if any */ - snprintf(prop_name, sizeof(prop_name), "lane%d", id); - qphy->lane_rst = of_reset_control_get_exclusive(np, prop_name); + qphy->lane_rst = of_reset_control_get_exclusive(np, "lane"); + if (IS_ERR(qphy->lane_rst) && PTR_ERR(qphy->lane_rst) != -EPROBE_DEFER) { + /* Fall back to the legacy lane reset name. */ + snprintf(prop_name, sizeof(prop_name), "lane%d", id); + qphy->lane_rst = of_reset_control_get_exclusive(np, prop_name); + } if (IS_ERR(qphy->lane_rst)) { dev_err(dev, "failed to get lane%d reset\n", id); return PTR_ERR(qphy->lane_rst); From patchwork Tue Jul 5 09:42:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 12906273 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A224BCCA47B for ; Tue, 5 Jul 2022 09:49:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231972AbiGEJth (ORCPT ); Tue, 5 Jul 2022 05:49:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231682AbiGEJtV (ORCPT ); Tue, 5 Jul 2022 05:49:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E547F585; Tue, 5 Jul 2022 02:49:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id ACEE06191A; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C8F6C341E6; Tue, 5 Jul 2022 09:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657014545; bh=piYlAksvw7TqXfZQBtDopHCTzi1zuCK2raNHXyFhjds=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UvDyJrBDF+nnK4WRhAi9c7EzJ6yH+8+ULJkW6bBBSzWTT+IJQ6IXqSuZ3ysOWiSzi sAqfFk5Se02vo1SZc3BhY3M3V8e1ZRBk5f4rVZ7UNk2P+/N97pgaCR3XJOiR4oH9F8 PqAEoDXY88IrHCAKxJGILlxuO36OAbvPI4j/Y2piIC8S+cKha+8GlgwMYMv40aeBm/ C3Px2/jUYm86vQ6aAB0hDrLOBNwW1QVyPYyMM29R757bav9OWA5ajasu4k9T1GU8am eKnYdRVrBEDAj9PHwhQR+nSbrZl0dZNrHDwsQQHw/8QPBaxvLkzBpniHUsZgasZiUD yXKIN1Y7XZv8A== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o8fB4-0004bD-J5; Tue, 05 Jul 2022 11:49:06 +0200 From: Johan Hovold To: Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 43/43] phy: qcom-qmp-usb: drop pipe clock lane suffix Date: Tue, 5 Jul 2022 11:42:39 +0200 Message-Id: <20220705094239.17174-44-johan+linaro@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220705094239.17174-1-johan+linaro@kernel.org> References: <20220705094239.17174-1-johan+linaro@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The pipe clock is defined in the "lane" node so there's no need to keep adding a redundant lane-number suffix to the clock name. Drop the lane suffix from the pipe clock name, but continue supporting the legacy name as a fall back. Signed-off-by: Johan Hovold --- drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c index 994a8232be7b..dfe7294a589f 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c @@ -2665,8 +2665,12 @@ int qcom_qmp_phy_usb_create(struct device *dev, struct device_node *np, int id, if (!qphy->pcs_misc) dev_vdbg(dev, "PHY pcs_misc-reg not used\n"); - snprintf(prop_name, sizeof(prop_name), "pipe%d", id); - qphy->pipe_clk = devm_get_clk_from_child(dev, np, prop_name); + qphy->pipe_clk = devm_get_clk_from_child(dev, np, "pipe"); + if (IS_ERR(qphy->pipe_clk) && PTR_ERR(qphy->pipe_clk) != -EPROBE_DEFER) { + /* Fall back to the legacy pipe clock name. */ + snprintf(prop_name, sizeof(prop_name), "pipe%d", id); + qphy->pipe_clk = devm_get_clk_from_child(dev, np, prop_name); + } if (IS_ERR(qphy->pipe_clk)) { return dev_err_probe(dev, PTR_ERR(qphy->pipe_clk), "failed to get lane%d pipe clock\n", id);