From patchwork Fri Jul 8 03:55:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiao Yang X-Patchwork-Id: 12910516 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62A8EC43334 for ; Fri, 8 Jul 2022 03:55:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230333AbiGHDz6 (ORCPT ); Thu, 7 Jul 2022 23:55:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236471AbiGHDz5 (ORCPT ); Thu, 7 Jul 2022 23:55:57 -0400 Received: from esa10.fujitsucc.c3s2.iphmx.com (esa10.fujitsucc.c3s2.iphmx.com [68.232.159.247]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EFB874DE2 for ; Thu, 7 Jul 2022 20:55:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=fujitsu.com; i=@fujitsu.com; q=dns/txt; s=fj1; t=1657252556; x=1688788556; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=osY7demwA/7Kb4EgSQ7PDTDRfuEeaIyloiu9i+C+9/Q=; b=b2RSoUuM+s6PomsrLyq7sR4dWroyTz/bVBp/VOeICB5o3vCBnDESPvmu ggNzexOS4iRpwy2mYCWXmKxndrJ1DrZgQSLG3H0LFrpynY+zsdYyJpjwD GWo6UT2NQjUfhmZLNkD7pkdJ6tlUEzohjauVW509U91AQvngGN6+XhGEt J9KxhElIpipTmJgWy+VUKS3piLKetcVsrDXrv3pNDRC9W/SpsEwTYJCLU JI3PprQNmDOp5Px1RYvV4D6iqyOIJ8fXfFVBcx3x7m3GDZcVnwToxMIqL s1ubbyKhoX43xLqQzPNXPzw9QEee/l7WT+eH/Shtk83jH/bMnD3XcEoEL A==; X-IronPort-AV: E=McAfee;i="6400,9594,10401"; a="60037383" X-IronPort-AV: E=Sophos;i="5.92,254,1650898800"; d="scan'208";a="60037383" Received: from mail-os0jpn01lp2112.outbound.protection.outlook.com (HELO JPN01-OS0-obe.outbound.protection.outlook.com) ([104.47.23.112]) by ob1.fujitsucc.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2022 12:55:52 +0900 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h/e2JaRPgelgobMxHefIgelNMjNGCtzD9uJ4BbYYdv3wDICYiOlUDy3C7WmN/6EkkNZj9TTtMbj868EHs6Ln6YM0SvSaz7wD0NtDkLiFtjUeFSrcf4S9ttU1DmQRogPOWwxXwa0JG4EXH4wFyXlVmb++rKOFot3Jc9iG71jpXrV7Bck8FKG22ikM5ntV9d8L+dyj8dd5pCj1P6Essjbjz5JBoSwGBHN+VoA/dPiA5fgCtN1flupj81fVpWiZ8HkXe5FDfle2qK+2M3goyLDxrrOhvp3m5ATcp8ODDJMVEC6NNX03KR16Kn9v/68J8b3SP0sOxb+35Pw7DilEWvBkmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=osY7demwA/7Kb4EgSQ7PDTDRfuEeaIyloiu9i+C+9/Q=; b=iEAZ6pJ0bRPjp0ZAMQGNrMGJn78iAawLfkIXEwPxXnZ342B20g3xhQ0JEFW/79gF7cd9plPRbB9sDYD2DupA7yoTCUzk0PLqIKVhkyWL2B//86C5WwcVSY1mquQNSJDCEh1DVrrFL/2sJz9JRmu/4gb4ds0PRmMorP5wq1d+hUbMMaXfppTs+29b87RA/XQaGYo+5JtyQGnX5iSRlA3qNkFMVS+yoXfPqLiJj/Ow1rM4nlKldCmveLNDp3dCBNESsAxO8QWzJnIP6i2rLwH2gcNqT3qjoLMnaWrKp9RF65s5SGUtCgCahO69tXxoNqbW754j/2UkUiWGSt4TF7usRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fujitsu.com; dmarc=pass action=none header.from=fujitsu.com; dkim=pass header.d=fujitsu.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fujitsu.onmicrosoft.com; s=selector2-fujitsu-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=osY7demwA/7Kb4EgSQ7PDTDRfuEeaIyloiu9i+C+9/Q=; b=HBqkStrSv4vlef+B9zCsCTkSkNWKDf2kZ+nPisyCm7b5c4JiWbsmflrZGQi7k3eSp68Kt34NqTqkI14GQz+lDyPNdMZ4o2UiI0ZNIVJe+LVkdLypIOAfA6V0vkVV9GZAGWhmU0y97kJsAap58bEhqirvYSQqmzUM8jKFnh5yER8= Received: from OS3PR01MB9499.jpnprd01.prod.outlook.com (2603:1096:604:1c8::5) by TYCPR01MB9861.jpnprd01.prod.outlook.com (2603:1096:400:20c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Fri, 8 Jul 2022 03:55:50 +0000 Received: from OS3PR01MB9499.jpnprd01.prod.outlook.com ([fe80::d8d2:d66f:2f3:846c]) by OS3PR01MB9499.jpnprd01.prod.outlook.com ([fe80::d8d2:d66f:2f3:846c%7]) with mapi id 15.20.5395.022; Fri, 8 Jul 2022 03:55:50 +0000 From: "yangx.jy@fujitsu.com" To: "linux-rdma@vger.kernel.org" CC: "leon@kernel.org" , "jgg@ziepe.ca" , "rpearsonhpe@gmail.com" , "zyjzyj2000@gmail.com" , "lizhijian@fujitsu.com" , "yangx.jy@fujitsu.com" Subject: [RESEND PATCH] RDMA/rxe: Remove unused qp parameter Thread-Topic: [RESEND PATCH] RDMA/rxe: Remove unused qp parameter Thread-Index: AQHYkn6c+nf9xkj1KUiqbqr8TyUl7A== Date: Fri, 8 Jul 2022 03:55:50 +0000 Message-ID: <20220708035547.6592-1-yangx.jy@fujitsu.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.34.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=fujitsu.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 34d04e8c-4217-43b0-0a28-08da6095bf3f x-ms-traffictypediagnostic: TYCPR01MB9861:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cE4z1BkbUVj0FGbbXHBIvIgKTIbAJEeG2mhd1vTBd9DTn0VWWeOPkA3T3CfVndCNw7RSuB/OCT7RzUOc/D9v5zyl/Ks8d0gCS+Nt5yE7ZkBquNfLRnxX4Py4vvfMLILW9NQ+rbZfJhhys1rREVnmwa9El2MO65N49b/8+Gyv4dUmH7vOlPBorObf83yX1R969iSDU++gLjAiUCvTYcZe4iaChBcbPYaKsyiBdm9UWAhQaWPNEfxiusJPBiPAOkgfETrgshk+7DXn4z0gc3cmEKbTOPbqL+touJMgXtkggZET13hO+XUqB24CgPouJN34/s2f8FdAqJ4fFUU17dOFukXQNMbDw+CXL4rFSW6Sy1n/OgiP9dGzGksPn9AjwjhSMfvBjpxJ+CtXzqvrwuOih0/DOLlU50MsAbNWlvxOKnNDWjxP5LdlAN2HNXwroF+sEbyZ0lgESUXKP7ZWzG5jvx83ABsTrZAsXt5UlKyZE9TAhFtcQWgIn+MmNxtwyDZMn5a1nAQd8ysqpDSq2EyyVHKikva5s37wfGnuKCQptah9EkyWw/H9rtu9wnmBQyg+5/9xSocjd1Y6i7jvKkasKa4E+/Fb6Y5prnlTbf5GTassAg5tfrscyXzDAl2+9ImlP+e81B6l7ZvBZz+TzJ6O2AKrcPjzrV/gvZ2eoofbg1iRagWR4VoBPXX9y2dusSLVd0PZaEiqk+L61XjFlUg5CZ7Xwfjf/nK2BtqiJr2T8BU98EneFdxdGO1BWESvTQ0OgvJCMDbetNYwR71G1U6IbD6Knkqw7QBtS6EqypURDDEw57s577bK5OxCKrZuU0wU x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OS3PR01MB9499.jpnprd01.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(366004)(346002)(376002)(136003)(66556008)(66476007)(1076003)(83380400001)(86362001)(2616005)(186003)(107886003)(38070700005)(38100700002)(82960400001)(8676002)(85182001)(6916009)(64756008)(316002)(91956017)(478600001)(122000001)(8936002)(5660300002)(71200400001)(54906003)(4326008)(6486002)(2906002)(76116006)(26005)(66946007)(36756003)(6506007)(41300700001)(66446008)(6512007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?eucgb2312_cn?b?ZldWREh1eTBNcmNQb01FalpE?= =?eucgb2312_cn?b?SExJeTlWcGk3bzdiRUx6cURaRU5XV3k0RmdrQXgyR2Nyb3JZKzRrZ2QzRXdid1g2?= =?eucgb2312_cn?b?SWtRR1QyaVZSQkpoZGxtOUFXSFBxUGJHak9GL2VlSFRXQWlxcWNzbk9ZK3JKaHFO?= =?eucgb2312_cn?b?bXM4cDRtQzVRWUlNVmZ6ZjNJNnFJNGRTMzNjcytGZlRweWxZM21PUmZBcDdoVkpx?= =?eucgb2312_cn?b?dkN1RkdMU2JjdkgveitPWXMwOU0zc1VHZEcwS1JleXRRbDBMVnRTSTZRTElPNGhB?= =?eucgb2312_cn?b?RjRtaFR2SXQyVUdYY2t3TFBlNmp5VzVVMTlLUWc0TVA1Wk5QQmdQSERPTzhmUDZj?= =?eucgb2312_cn?b?RE1nb2duMC9kMExYd0NVV1RBeEhJOHp2c0dLOEczK1E1U1dzdDlwemZhNVJQMkx6?= =?eucgb2312_cn?b?N0VnSUhkSG1VTjBIa3dRakJUcHlrWDhldDJnV0JTSVF3T1VZSXptN09NUE1BMFVW?= =?eucgb2312_cn?b?MEJGelBCVlE3d2t0cityeEczV2dDOVpQQTZSYVNrU0xKNjRROU9nZnRJTlhNVFNy?= =?eucgb2312_cn?b?N3BGN3dDNGNWcU1pTTRURkZlTGtlOVpxUVJuYWdRWjV6U3MyOHJ4WHBXZndjVWZz?= =?eucgb2312_cn?b?andVM3VaTUxPZjFrN3pKN1Y1cXAzdXlQbVdiclNpMzlJNHJQNWtzVkJSQVdJTk0r?= =?eucgb2312_cn?b?amcrallDeDhwS1dlM1p1OXluejJIZXFYbTZ2TktIZkM2cEY5MGkzVXl1d1ZSbDRt?= =?eucgb2312_cn?b?OXpGY1VmQjFKY2VWWUlGNEg3aGRVTkJHYXVBNVp5cGYzbjl2UnNDT2Y1RjV6UkVx?= =?eucgb2312_cn?b?Wjg4Y284bjNEK0pLZytTcjgyTUV5QW02YzZMSlFrbmkwYlpZRWgwL2pRRXFHam5Z?= =?eucgb2312_cn?b?ckRQNFoxTTB4cS9KZTlzS3BFTWRwNURXMVFPSVFUaVFRY0w2Qzk4M0VLQ01BdDAv?= =?eucgb2312_cn?b?OG5wL0FsVFJoZjRVTGJGaU5mb3lwZzdJTDB3bWorT0FqTStqamZpcFBPSHBocXE5?= =?eucgb2312_cn?b?YnhBSDNPWmRwbGRtVjgzN3l4UzQ3NjJIWUlsQjFwV1BIRDFycGVCOXl4VkttY3pW?= =?eucgb2312_cn?b?WnVGWnBIMkhzeTN1QStqZVVqSk1QaWNRMTZUMDQ5OVdzSmo5NDRHNVJWajBsd2Vi?= =?eucgb2312_cn?b?S0hyTnBEdHlxei9oOFRwcWpIalk3d3hyZ2c2b0ZVa25KaldCN2V3eGtPellib29D?= =?eucgb2312_cn?b?UUZNOXNCbGxtRW1VZXJkYTI2OE45SXYrbjc1MG1kdytIVzQyTG5tMFNmNHJLNjE4?= =?eucgb2312_cn?b?V3p1NWFEUW1CWW5zeGtvRzVNVEE3RUt0Y1JnOWZDdmljTVRIU29mL3JKWTloS1ZO?= =?eucgb2312_cn?b?dmxKaEIyWnJHbEhWclZYNEYva1E3eVowRjhrZmlpaUxCZk5QQUd5RXZ2eGI3UU5W?= =?eucgb2312_cn?b?Q3JCLzhxYlJpcFpPVUFLeFlFREJUamt2MEZFVmtsVFppcTVycHJlTEtaS3Joc1dI?= =?eucgb2312_cn?b?cmpvai9Zd1ZXMURuY1h5dDBoMzduM3k4TnRFdXp6Z3cyRXhaYzlIR0VXUDNVYWJQ?= =?eucgb2312_cn?b?ZnViNzJNSVNCMkp4UTRSWjNSc2ZWUThnTkFMQTZ4cU0rY2UzdHdyTlkzSlJaMGpJ?= =?eucgb2312_cn?b?eGtRQlhwdk9OMlFRWkF3YldnU1JjTUFUN3k1Z3RTd2d6UVlnM015RzNTM1RsVzlZ?= =?eucgb2312_cn?b?dnprQWVWNmc3cmV5TWR0SFJhRm5kZjgzaUxNZXpDQktraDFmMjMzcUg3YStTeXBh?= =?eucgb2312_cn?b?QWRVVm9jODJiT2JFZFVmZlpOM1N2aW4rdGNHN0tkUXQxTjJmOVBObjZEeU91Qm5S?= =?eucgb2312_cn?b?RXlWZVROZ0Q3eWdGa0ZQZFp3VGNjWnYvNEsvSmRZcFIyRFZTb1ZzME15a3NoQlkx?= =?eucgb2312_cn?b?dytvTDljdExETjVxeVhUZ1BhSW1JMjEvL0RCQTMvNDM1QW1rOSsveE83Z3gxOTBh?= =?eucgb2312_cn?b?SVpWZmRvOHh5N0xhRlBHV0s0OVFuUDl6T2hwc2lVWWtqd1RTenZMY0doZCt0a3hm?= =?eucgb2312_cn?b?ZFlScmJLRklpU0ZPcGs3dUJGRzJFK0VDTkFnMGFoeFpmZkxVL3JaRU8xMFUxdUFo?= =?eucgb2312_cn?b?SEw4SXhDNG9tWmswN1N3c2x5VitEdkFWZElHS2svdEtDM0xXdFFVTWNGajV6MndE?= =?eucgb2312_cn?b?Y0FuS0lBdUVuSFhXcmdCQitJSmo1ZlVVQ0Z6SUp4bFlkU3F2Z1NFOU40cTB0eldh?= =?eucgb2312_cn?b?T2c3ZlV3azRBQk1pWHc5MGZRY1E9PQ==?= MIME-Version: 1.0 X-OriginatorOrg: fujitsu.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB9499.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34d04e8c-4217-43b0-0a28-08da6095bf3f X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2022 03:55:50.0851 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3RNNVqgObncRpQw4BjCJlhERH2ZAlIZVYWm257pIJs+v8oYxaFukLudcTb9ExFna+ippo7H+SFADXM9BqMjFqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB9861 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org The qp parameter in free_rd_atomic_resource() has become unused so remove it directly. Fixes: 15ae1375ea91 ("RDMA/rxe: Fix qp reference counting for atomic ops") Signed-off-by: Xiao Yang --- drivers/infiniband/sw/rxe/rxe_loc.h | 2 +- drivers/infiniband/sw/rxe/rxe_qp.c | 6 +++--- drivers/infiniband/sw/rxe/rxe_resp.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/sw/rxe/rxe_loc.h b/drivers/infiniband/sw/rxe/rxe_loc.h index 0e022ae1b8a5..336164843db4 100644 --- a/drivers/infiniband/sw/rxe/rxe_loc.h +++ b/drivers/infiniband/sw/rxe/rxe_loc.h @@ -145,7 +145,7 @@ static inline int rcv_wqe_size(int max_sge) max_sge * sizeof(struct ib_sge); } -void free_rd_atomic_resource(struct rxe_qp *qp, struct resp_res *res); +void free_rd_atomic_resource(struct resp_res *res); static inline void rxe_advance_resp_resource(struct rxe_qp *qp) { diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c index 8355a5b1cb60..9ecb98150e0e 100644 --- a/drivers/infiniband/sw/rxe/rxe_qp.c +++ b/drivers/infiniband/sw/rxe/rxe_qp.c @@ -120,14 +120,14 @@ static void free_rd_atomic_resources(struct rxe_qp *qp) for (i = 0; i < qp->attr.max_dest_rd_atomic; i++) { struct resp_res *res = &qp->resp.resources[i]; - free_rd_atomic_resource(qp, res); + free_rd_atomic_resource(res); } kfree(qp->resp.resources); qp->resp.resources = NULL; } } -void free_rd_atomic_resource(struct rxe_qp *qp, struct resp_res *res) +void free_rd_atomic_resource(struct resp_res *res) { res->type = 0; } @@ -140,7 +140,7 @@ static void cleanup_rd_atomic_resources(struct rxe_qp *qp) if (qp->resp.resources) { for (i = 0; i < qp->attr.max_dest_rd_atomic; i++) { res = &qp->resp.resources[i]; - free_rd_atomic_resource(qp, res); + free_rd_atomic_resource(res); } } } diff --git a/drivers/infiniband/sw/rxe/rxe_resp.c b/drivers/infiniband/sw/rxe/rxe_resp.c index 265e46fe050f..28033849d404 100644 --- a/drivers/infiniband/sw/rxe/rxe_resp.c +++ b/drivers/infiniband/sw/rxe/rxe_resp.c @@ -562,7 +562,7 @@ static struct resp_res *rxe_prepare_res(struct rxe_qp *qp, res = &qp->resp.resources[qp->resp.res_head]; rxe_advance_resp_resource(qp); - free_rd_atomic_resource(qp, res); + free_rd_atomic_resource(res); res->type = type; res->replay = 0;