From patchwork Tue Jul 12 15:35:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 12915226 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2941CCCA47C for ; Tue, 12 Jul 2022 15:36:50 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7033716C9; Tue, 12 Jul 2022 17:35:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7033716C9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657640208; bh=1wj1Gy8GF/XmQXmZM6ThKfzWjSdr3qtAlVHAsnysHN8=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=XcGIOGo11O3eBPt1cIhuBTi3UXhJfLQNiqExEkcKzvbuMuuAXLAEOwefSU6lsVtWr Al3+YSji9upgm8712/VTfsX8s5dq1Pjff0PWgLduy5Pmk+R3NJf04/Q8lfVogfxHSi iw7iLMgv+TnqWU/8c2YY0LbU1ey8ImqjCtqoK7Uo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 68712F800E8; Tue, 12 Jul 2022 17:35:29 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 546A5F802DB; Tue, 12 Jul 2022 17:35:27 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E401AF8023B for ; Tue, 12 Jul 2022 17:35:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E401AF8023B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="dT3OO4KK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657640125; x=1689176125; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=1wj1Gy8GF/XmQXmZM6ThKfzWjSdr3qtAlVHAsnysHN8=; b=dT3OO4KKcueHTnQrEjFEH5zX8WJEK3LRf/96P8i4zzGM2VwiRnGDif9o RDbVeuV7nen13HLCH0mZ/X+bFkNQgmKt2pBaC0JTfoL0E7nEzpo5vu9lU GP4onp4JJ6w7zP6//NJCxU7HqaAvBv8+2pZHeWEaHNjpSVXffeFBh4scp vWURIoiJi0+vgrRWuV2mXjSp0mZjG6+ZsPk/iwWC5YJVYI5ltFYr9M9Po NaLo+fadypO4MhJaDHh7X5QveatICLypG87D17PCGnJWZnrwsosvC/vDd 2q+y7udafzruWdJpjXI0ARyXbm9Cpz3001AR1pFekHP69IiR5ED8T5QZc w==; X-IronPort-AV: E=McAfee;i="6400,9594,10406"; a="268005825" X-IronPort-AV: E=Sophos;i="5.92,266,1650956400"; d="scan'208";a="268005825" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2022 08:35:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,266,1650956400"; d="scan'208";a="595326460" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 12 Jul 2022 08:35:14 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 1634CF1; Tue, 12 Jul 2022 18:35:19 +0300 (EEST) From: Andy Shevchenko To: Takashi Iwai , Lucas Tanure , Andy Shevchenko , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH v2 1/4] ALSA: hda: cs35l41: Don't dereference fwnode handle Date: Tue, 12 Jul 2022 18:35:16 +0300 Message-Id: <20220712153519.35692-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Cc: Richard Fitzgerald , James Schulman , David Rhodes , Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Use acpi_fwnode_handle() instead of dereferencing an fwnode handle directly, which is a better coding practice. Signed-off-by: Andy Shevchenko --- v2: new change sound/pci/hda/cs35l41_hda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c index 49b25432a9f5..1a1afa0725e0 100644 --- a/sound/pci/hda/cs35l41_hda.c +++ b/sound/pci/hda/cs35l41_hda.c @@ -347,7 +347,7 @@ static int cs35l41_hda_read_acpi(struct cs35l41_hda *cs35l41, const char *hid, i /* To use the same release code for all laptop variants we can't use devm_ version of * gpiod_get here, as CLSA010* don't have a fully functional bios with an _DSD node */ - cs35l41->reset_gpio = fwnode_gpiod_get_index(&adev->fwnode, "reset", cs35l41->index, + cs35l41->reset_gpio = fwnode_gpiod_get_index(acpi_fwnode_handle(adev), "reset", cs35l41->index, GPIOD_OUT_LOW, "cs35l41-reset"); property = "cirrus,speaker-position"; From patchwork Tue Jul 12 15:35:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 12915225 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62FB0C43334 for ; Tue, 12 Jul 2022 15:36:20 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DE10C1654; Tue, 12 Jul 2022 17:35:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DE10C1654 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657640178; bh=xg7I+m/llbJv+k3YKHZXCqCpZNq0T9G7xCJVVXuRPr8=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=bE3SP1a1SpBo3xV4OCt1wdj9Yg6roD7lEAVfV6+pVQHtlGpUnHGhcoz+7w2H8VGAE AGIilF8nSS/mrH0m4oGPXXCOvmFHvQ5SYk0ErxatLmHFDpay91GNPMxfbl9EhEvUZM h85I3JNNvimy5qyk4ccQ1+1ZjooEIv8lfdDAKBSE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1308CF80279; Tue, 12 Jul 2022 17:35:28 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2223AF80279; Tue, 12 Jul 2022 17:35:27 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 82EDFF800E8 for ; Tue, 12 Jul 2022 17:35:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 82EDFF800E8 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="kY/JKd0A" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657640121; x=1689176121; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xg7I+m/llbJv+k3YKHZXCqCpZNq0T9G7xCJVVXuRPr8=; b=kY/JKd0AlfoTu0sWcNDhZDN7nnTEMnA3ONTnH8pw9FSHSlfBqakcDOqp 5gkNWKVzXxmLvamn/xFmAj5W2vbKWJCOffJfrFgMKnwHxPmMEjq6KtcUm L79c9XL1BZk+GKG+668IzJLjxG3LBFQqYwmyyaiSsiWTswFkrFoCbICML OiCl8MMUqToj4E4U+vij6dKeXuE1iDOhjiQ6KXKhZVhH/c4Zwy5S3Wlcr wyVpr2+cGu5A8+M8ikjzz8TIevGFBUz81ULTfVCFNgCBOtiepkondA5lc UdKeWfG32FKjuVhXbBHUTe+8yAIVI+BNUT//ZswrNhp7RU8iFpO7x2yKE w==; X-IronPort-AV: E=McAfee;i="6400,9594,10406"; a="371278787" X-IronPort-AV: E=Sophos;i="5.92,266,1650956400"; d="scan'208";a="371278787" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2022 08:35:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,266,1650956400"; d="scan'208";a="698061904" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 12 Jul 2022 08:35:12 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 2662BD9; Tue, 12 Jul 2022 18:35:20 +0300 (EEST) From: Andy Shevchenko To: Takashi Iwai , Lucas Tanure , Andy Shevchenko , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH v2 2/4] ALSA: hda: cs35l41: Allow compilation test on non-ACPI configurations Date: Tue, 12 Jul 2022 18:35:17 +0300 Message-Id: <20220712153519.35692-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220712153519.35692-1-andriy.shevchenko@linux.intel.com> References: <20220712153519.35692-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Cc: Richard Fitzgerald , James Schulman , David Rhodes , Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" ACPI is needed only for functioning of this codec on some platforms, there is no compilation dependency, so make it optional Signed-off-by: Andy Shevchenko --- v2: no changes sound/pci/hda/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig index 79ade4787d95..e86cf80bdf96 100644 --- a/sound/pci/hda/Kconfig +++ b/sound/pci/hda/Kconfig @@ -97,7 +97,7 @@ config SND_HDA_SCODEC_CS35L41 config SND_HDA_SCODEC_CS35L41_I2C tristate "Build CS35L41 HD-audio side codec support for I2C Bus" depends on I2C - depends on ACPI + depends on ACPI || COMPILE_TEST depends on SND_SOC select SND_HDA_GENERIC select SND_SOC_CS35L41_LIB @@ -113,7 +113,7 @@ comment "Set to Y if you want auto-loading the side codec driver" config SND_HDA_SCODEC_CS35L41_SPI tristate "Build CS35L41 HD-audio codec support for SPI Bus" depends on SPI_MASTER - depends on ACPI + depends on ACPI || COMPILE_TEST depends on SND_SOC select SND_HDA_GENERIC select SND_SOC_CS35L41_LIB From patchwork Tue Jul 12 15:35:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 12915228 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8AD7C43334 for ; Tue, 12 Jul 2022 15:37:21 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DDB4016DF; Tue, 12 Jul 2022 17:36:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DDB4016DF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657640239; bh=S2GftDn+xorE6UM3YzlFwuDAbmRpEb7074YgFP8dxNY=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=gHB+lw0Vu7PWDGM6Elq9oXdMfeO6Ak3sleNJ1wX+s+XHgolReEoH87sbaQmDAFSNX T+YqT3GMy6iUbEk0AuDOy5ODcXX1lpkSL+DLjQJuYxc6DuIets4x7T7j0wZa4nrzny hL/o3ixBRNZ2r8tYAY6EGZ/4H90bAsYumOP0tUYE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B85E3F80548; Tue, 12 Jul 2022 17:35:35 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 438C8F8023B; Tue, 12 Jul 2022 17:35:34 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D94A4F8023B for ; Tue, 12 Jul 2022 17:35:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D94A4F8023B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XFL7yt+d" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657640128; x=1689176128; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=S2GftDn+xorE6UM3YzlFwuDAbmRpEb7074YgFP8dxNY=; b=XFL7yt+dOttuxK2oT5lwzxJEK+lzaIZLgAgC1WK9hkolXXLplHnEBLS2 bcOrWWUKV/KOAjPlZA+BLkPpTpqZuniZmMAm4hmx5dHYGQVzLGTJmV+HX TYJE7MWjek7bMcTCwJvo5L73FmQKEf6DP1aMGixrW8/M1Ru7yeX0LK4He uXKmNk6NInBdeRRTnntZChFtBJbHZI918nzVyDaGItrZTjeRYuHgbxMTx Nug4kjio+yv5KFemw6cVvLN5wgWpXTIU65ZoV4hxxPi8213FBQS1CW4a+ nQTMcwQCdJsZUK+MJhNX2VCu6UQiv3Uhl4SbNOmjWcHNabTI+8Svk/7dw Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10406"; a="346651821" X-IronPort-AV: E=Sophos;i="5.92,266,1650956400"; d="scan'208";a="346651821" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2022 08:35:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,266,1650956400"; d="scan'208";a="771922134" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 12 Jul 2022 08:35:12 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 3234E18E; Tue, 12 Jul 2022 18:35:20 +0300 (EEST) From: Andy Shevchenko To: Takashi Iwai , Lucas Tanure , Andy Shevchenko , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH v2 3/4] ALSA: hda: cs35l41: Drop wrong use of ACPI_PTR() Date: Tue, 12 Jul 2022 18:35:18 +0300 Message-Id: <20220712153519.35692-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220712153519.35692-1-andriy.shevchenko@linux.intel.com> References: <20220712153519.35692-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Cc: Richard Fitzgerald , James Schulman , David Rhodes , Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" ACPI_PTR() is more harmful than helpful. For example, in this case if CONFIG_ACPI=n, the ID table left unused which is not what we want. Instead of adding ifdeffery or attribute here and there, drop ACPI_PTR(). Signed-off-by: Andy Shevchenko --- v2: no changes sound/pci/hda/cs35l41_hda_i2c.c | 8 +++----- sound/pci/hda/cs35l41_hda_spi.c | 8 +++----- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/sound/pci/hda/cs35l41_hda_i2c.c b/sound/pci/hda/cs35l41_hda_i2c.c index ec626e0fbedc..df39fc76e6be 100644 --- a/sound/pci/hda/cs35l41_hda_i2c.c +++ b/sound/pci/hda/cs35l41_hda_i2c.c @@ -6,9 +6,9 @@ // // Author: Lucas Tanure +#include #include #include -#include #include "cs35l41_hda.h" @@ -43,19 +43,17 @@ static const struct i2c_device_id cs35l41_hda_i2c_id[] = { {} }; -#ifdef CONFIG_ACPI static const struct acpi_device_id cs35l41_acpi_hda_match[] = { {"CLSA0100", 0 }, {"CSC3551", 0 }, - { }, + {} }; MODULE_DEVICE_TABLE(acpi, cs35l41_acpi_hda_match); -#endif static struct i2c_driver cs35l41_i2c_driver = { .driver = { .name = "cs35l41-hda", - .acpi_match_table = ACPI_PTR(cs35l41_acpi_hda_match), + .acpi_match_table = cs35l41_acpi_hda_match, }, .id_table = cs35l41_hda_i2c_id, .probe = cs35l41_hda_i2c_probe, diff --git a/sound/pci/hda/cs35l41_hda_spi.c b/sound/pci/hda/cs35l41_hda_spi.c index 3a1472e1bc24..2f5afad3719e 100644 --- a/sound/pci/hda/cs35l41_hda_spi.c +++ b/sound/pci/hda/cs35l41_hda_spi.c @@ -6,7 +6,7 @@ // // Author: Lucas Tanure -#include +#include #include #include @@ -39,18 +39,16 @@ static const struct spi_device_id cs35l41_hda_spi_id[] = { {} }; -#ifdef CONFIG_ACPI static const struct acpi_device_id cs35l41_acpi_hda_match[] = { { "CSC3551", 0 }, - {}, + {} }; MODULE_DEVICE_TABLE(acpi, cs35l41_acpi_hda_match); -#endif static struct spi_driver cs35l41_spi_driver = { .driver = { .name = "cs35l41-hda", - .acpi_match_table = ACPI_PTR(cs35l41_acpi_hda_match), + .acpi_match_table = cs35l41_acpi_hda_match, }, .id_table = cs35l41_hda_spi_id, .probe = cs35l41_hda_spi_probe, From patchwork Tue Jul 12 15:35:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 12915227 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63907C43334 for ; Tue, 12 Jul 2022 15:37:11 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AD2E016E0; Tue, 12 Jul 2022 17:36:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AD2E016E0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657640229; bh=o0xWXv2hPnaq6dui+hkXkWYBLtudgtqDyCMY+iqKa4I=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=cw8ePhpD6q5uuL4zUEzuVCdNK5SBJX18Td6IIZ4hd/snLdcfwJgnGPJrTw73OpcRK T3wh5zcnG2QJ1T7yN4D6IGlBUVwpIZRt9GqlN3sTRQfITi+D8Uof3zjzmeIxk/mpwO WVZjii003kE575b/yBV0Vb928LPJRUxOKojyYE7c= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 40E37F80542; Tue, 12 Jul 2022 17:35:31 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5EC2BF8053D; Tue, 12 Jul 2022 17:35:29 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2E1EFF800E8 for ; Tue, 12 Jul 2022 17:35:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2E1EFF800E8 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MEfnz00Z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657640127; x=1689176127; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=o0xWXv2hPnaq6dui+hkXkWYBLtudgtqDyCMY+iqKa4I=; b=MEfnz00ZXkCuuj1xA169UbXK+I69Gn6Nt2d/vg5E/WuK9lw32Pn6rWHt XHjBoK7BZ+y6zQaqRqn7cvdCuaVoZZ01rdHswh3ge8jUBx4f6Q1+P+YrV dWqIRsScmjyWn1901HmZL+ed5pUh0ulJ4WIUuL8pc/aOwMFkcxoOZQQza pXZPsEQ/q9xVoPLhWsYnWFC2PDBBNP49thJd6U1Wege8+JPJ4NiSr3MFf EXW2aU7KAHIfuQ2VWtT8FFA45TKP1g9POdFATGhvpDl9cwCg+iOfmrK/7 NVDOzub3nwMrinAdhhJRH3JecCWAYjXVY50vQj4LOCFwvK2qftPtq1KcE A==; X-IronPort-AV: E=McAfee;i="6400,9594,10406"; a="310590178" X-IronPort-AV: E=Sophos;i="5.92,266,1650956400"; d="scan'208";a="310590178" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2022 08:35:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,266,1650956400"; d="scan'208";a="662994045" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 12 Jul 2022 08:35:12 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 3808916D; Tue, 12 Jul 2022 18:35:20 +0300 (EEST) From: Andy Shevchenko To: Takashi Iwai , Lucas Tanure , Andy Shevchenko , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH v2 4/4] ALSA: hda: cs35l41: Consolidate selections under SND_HDA_SCODEC_CS35L41 Date: Tue, 12 Jul 2022 18:35:19 +0300 Message-Id: <20220712153519.35692-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220712153519.35692-1-andriy.shevchenko@linux.intel.com> References: <20220712153519.35692-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Cc: Richard Fitzgerald , James Schulman , David Rhodes , Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Selections can be propagated via selections, while dependencies are not. Hence, consolidate selections under the SND_HDA_SCODEC_CS35L41 option. Signed-off-by: Andy Shevchenko --- v2: no changes sound/pci/hda/Kconfig | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig index e86cf80bdf96..8b73a12d356f 100644 --- a/sound/pci/hda/Kconfig +++ b/sound/pci/hda/Kconfig @@ -93,16 +93,16 @@ config SND_HDA_PATCH_LOADER config SND_HDA_SCODEC_CS35L41 tristate + select SND_HDA_GENERIC + select REGMAP_IRQ config SND_HDA_SCODEC_CS35L41_I2C tristate "Build CS35L41 HD-audio side codec support for I2C Bus" depends on I2C depends on ACPI || COMPILE_TEST depends on SND_SOC - select SND_HDA_GENERIC select SND_SOC_CS35L41_LIB select SND_HDA_SCODEC_CS35L41 - select REGMAP_IRQ help Say Y or M here to include CS35L41 I2C HD-audio side codec support in snd-hda-intel driver, such as ALC287. @@ -115,10 +115,8 @@ config SND_HDA_SCODEC_CS35L41_SPI depends on SPI_MASTER depends on ACPI || COMPILE_TEST depends on SND_SOC - select SND_HDA_GENERIC select SND_SOC_CS35L41_LIB select SND_HDA_SCODEC_CS35L41 - select REGMAP_IRQ help Say Y or M here to include CS35L41 SPI HD-audio side codec support in snd-hda-intel driver, such as ALC287.