From patchwork Tue Jul 19 20:38:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 12923030 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA796CCA47F for ; Tue, 19 Jul 2022 20:39:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8AFE614BB00; Tue, 19 Jul 2022 20:39:07 +0000 (UTC) Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by gabe.freedesktop.org (Postfix) with ESMTPS id EFD2B14BB00 for ; Tue, 19 Jul 2022 20:39:03 +0000 (UTC) Received: from notapiano.myfiosgateway.com (pool-98-113-53-228.nycmny.fios.verizon.net [98.113.53.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 81AFA6601A3D; Tue, 19 Jul 2022 21:39:01 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1658263142; bh=yOsyoTXecbnpR+05MoxtIppKOEPuY7CytKHIOjJLXrI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N0XMnIEyAk8gNYUxn57slek8jQfjqHtzk47gpqD22xdCI8YeTXc7n8wXnjoxAjQ6p gWgyIbLsWH+KwEkxm9CCAQTlParvg+kT7STLFl9Zzt4pc3NhMJRxr8JScpRRYJHAZ+ /S99eoMABwvqYp8ZWec+LT7OycnOLUUZ+LIZksv/ro6Uepqyyf3aeUx6LBU0sj5SGb d+dmvmMDr826ZZ7P15NZvKPmiE+h3q3wQsPCo34NSGWqfLFD1dwTiHJm+T5SBoZ0uH 8MuL60jA/9NmRYDkEVLt6ZAlluZM373OaEv+m57jt2jyrjAjLfgNY7P3mZpdFZaKV3 yXQzwOyaH7VkA== From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= To: Douglas Anderson Subject: [PATCH 1/3] drm/panel-edp: Add panel entry for R140NWF5 RH Date: Tue, 19 Jul 2022 16:38:54 -0400 Message-Id: <20220719203857.1488831-2-nfraprado@collabora.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220719203857.1488831-1-nfraprado@collabora.com> References: <20220719203857.1488831-1-nfraprado@collabora.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding , kernel@collabora.com, Sam Ravnborg , AngeloGioacchino Del Regno Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Add panel identification entry for the IVO R140NWF5 RH (product ID: 0x057d) panel. Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: Douglas Anderson Reviewed-by: AngeloGioacchino Del Regno --- The comments on the driver indicate that the T3 timing should be set on hpd_absent, while hpd_reliable would have a shorter time just while the HPD line stabilizes on low after power is supplied. But can we really assume that the HPD line will be reliable at all before the DDIC is done booting up, at which point the HPD line is brought up? IOW, shouldn't we always delay T3 (by setting hpd_reliable = T3), since only then we're really sure that the DDIC is done setting up and the HPD line is reliable? I've set the T3 delay to hpd_absent in this series, following what's instructed in the comments, but I'd like to discuss whether we shouldn't be setting T3 on hpd_reliable instead, for all panels, to be on the safer side. drivers/gpu/drm/panel/panel-edp.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 3626469c4cc2..675d793d925e 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -1854,6 +1854,12 @@ static const struct panel_delay delay_100_500_e200 = { .enable = 200, }; +static const struct panel_delay delay_200_500_e200 = { + .hpd_absent = 200, + .unprepare = 500, + .enable = 200, +}; + #define EDP_PANEL_ENTRY(vend_chr_0, vend_chr_1, vend_chr_2, product_id, _delay, _name) \ { \ .name = _name, \ @@ -1882,6 +1888,8 @@ static const struct edp_panel_entry edp_panels[] = { EDP_PANEL_ENTRY('C', 'M', 'N', 0x114c, &innolux_n116bca_ea1.delay, "N116BCA-EA1"), + EDP_PANEL_ENTRY('I', 'V', 'O', 0x057d, &delay_200_500_e200, "R140NWF5 RH"), + EDP_PANEL_ENTRY('K', 'D', 'B', 0x0624, &kingdisplay_kd116n21_30nv_a010.delay, "116N21-30NV-A010"), EDP_PANEL_ENTRY('K', 'D', 'B', 0x1120, &delay_200_500_e80_d50, "116N29-30NK-C007"), From patchwork Tue Jul 19 20:38:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 12923028 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73C5BC43334 for ; Tue, 19 Jul 2022 20:39:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 506B414BADB; Tue, 19 Jul 2022 20:39:07 +0000 (UTC) Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id 685D414BB1C for ; Tue, 19 Jul 2022 20:39:05 +0000 (UTC) Received: from notapiano.myfiosgateway.com (pool-98-113-53-228.nycmny.fios.verizon.net [98.113.53.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 103456601A84; Tue, 19 Jul 2022 21:39:02 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1658263144; bh=Q9hbBExLg9KRq/+2g8AAYdSvZTNWhYZ3sqhbn9GUO4U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bJc2CVF0j3Hr9olq489QoZAziNW0K9b/f23Vt0Xco0mAzvb4gXMXKCQg018jNwbiB SldxbD16dyaHBACmBXrM5VA3dsIlIJ+2koFnUN7SCeYiMuuuLxy4ZhDmPhs91/tKDu IO22fXmLAfYJ0hiiEo43YhrTkaoAkLLaAHo2fETEl97+RwzVIsFeb+V6R/1RXy1zHg UIQeU+HqmjSrEPlMPKhdtrVEEIszybQkiGStEig9Xbqc3g9pTsaDUWVJ0+crD2h0sa wBQZWe+iJ9TeL9kLjSbKJ8OUvky4+K7Bah+sGpvIwBaZmZOqDJHgz77uE15Wouv27O oC3sIU9RlyUuQ== From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= To: Douglas Anderson Subject: [PATCH 2/3] drm/panel-edp: Add panel entry for B120XAN01.0 Date: Tue, 19 Jul 2022 16:38:55 -0400 Message-Id: <20220719203857.1488831-3-nfraprado@collabora.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220719203857.1488831-1-nfraprado@collabora.com> References: <20220719203857.1488831-1-nfraprado@collabora.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding , kernel@collabora.com, Sam Ravnborg , AngeloGioacchino Del Regno Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Add panel identification entry for the AUO B120XAN01.0 (product ID: 0x1062) panel. Signed-off-by: Nícolas F. R. A. Prado --- drivers/gpu/drm/panel/panel-edp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 675d793d925e..152e00eb846f 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -1879,6 +1879,7 @@ static const struct edp_panel_entry edp_panels[] = { EDP_PANEL_ENTRY('A', 'U', 'O', 0x405c, &auo_b116xak01.delay, "B116XAK01"), EDP_PANEL_ENTRY('A', 'U', 'O', 0x615c, &delay_200_500_e50, "B116XAN06.1"), EDP_PANEL_ENTRY('A', 'U', 'O', 0x8594, &delay_200_500_e50, "B133UAN01.0"), + EDP_PANEL_ENTRY('A', 'U', 'O', 0x1062, &delay_200_500_e50, "B120XAN01.0"), EDP_PANEL_ENTRY('B', 'O', 'E', 0x0786, &delay_200_500_p2e80, "NV116WHM-T01"), EDP_PANEL_ENTRY('B', 'O', 'E', 0x07d1, &boe_nv133fhm_n61.delay, "NV133FHM-N61"), From patchwork Tue Jul 19 20:38:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 12923029 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44FB6C43334 for ; Tue, 19 Jul 2022 20:39:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9662814BB3A; Tue, 19 Jul 2022 20:39:07 +0000 (UTC) Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA19A14BADB for ; Tue, 19 Jul 2022 20:39:06 +0000 (UTC) Received: from notapiano.myfiosgateway.com (pool-98-113-53-228.nycmny.fios.verizon.net [98.113.53.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 8FAFB66019F4; Tue, 19 Jul 2022 21:39:04 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1658263145; bh=Aq5S2gkpJATVIFJkGq8D34wf45tOEaY6CNq3MR0BK0w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gZuUFo9Vy6cZQoonAOzTsCRvxxn2F+ic4Ay7DsNSAm1Q0HLQxF9C/s/43Fa1TRkyJ C0mSmFFyYBNtnVYvPQFvZgzF9Hs2RrbtIXE0TKmiX0RHIRK+EI1t8jPUoCvuGE6LcY 8TrGVP7AwDkOCUNu/bWwEgZBVN8DcqG39jzg2VkKLBdvX1JQbMH+3U+8jdq7atksab m6A07wpR1XcEsCxYYb5StPXHEdyR9mKlKCAoUlSzE2jFJ4qwN68sFPjGh1lSMFRWa6 p58epxBKKype+4S9oBmnK+F8/kO/GsUPzUwIITECtf+yyIGkwoNzTRzvh1flalhJxH +4nHrVfukDZbQ== From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= To: Douglas Anderson Subject: [PATCH 3/3] drm/panel-edp: Fix variable typo when saving hpd absent delay from DT Date: Tue, 19 Jul 2022 16:38:56 -0400 Message-Id: <20220719203857.1488831-4-nfraprado@collabora.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220719203857.1488831-1-nfraprado@collabora.com> References: <20220719203857.1488831-1-nfraprado@collabora.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding , kernel@collabora.com, Sam Ravnborg , AngeloGioacchino Del Regno Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The value read from the "hpd-absent-delay-ms" property in DT was being saved to the wrong variable, overriding the hpd_reliable delay. Fix the typo. Fixes: 5540cf8f3e8d ("drm/panel-edp: Implement generic "edp-panel"s probed by EDID") Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: André Almeida Reviewed-by: Douglas Anderson Reviewed-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/panel/panel-edp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 152e00eb846f..b3536d8600f4 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -738,7 +738,7 @@ static int generic_edp_panel_probe(struct device *dev, struct panel_edp *panel) of_property_read_u32(dev->of_node, "hpd-reliable-delay-ms", &reliable_ms); desc->delay.hpd_reliable = reliable_ms; of_property_read_u32(dev->of_node, "hpd-absent-delay-ms", &absent_ms); - desc->delay.hpd_reliable = absent_ms; + desc->delay.hpd_absent = absent_ms; /* Power the panel on so we can read the EDID */ ret = pm_runtime_get_sync(dev);