From patchwork Mon Jan 14 13:44:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 10762649 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1A2D913B4 for ; Mon, 14 Jan 2019 13:53:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 01877288B4 for ; Mon, 14 Jan 2019 13:53:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E9BF928BAF; Mon, 14 Jan 2019 13:53:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 289BE28BC2 for ; Mon, 14 Jan 2019 13:53:35 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id BA550266B98; Mon, 14 Jan 2019 14:46:01 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id F21CA266B98; Mon, 14 Jan 2019 14:45:58 +0100 (CET) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by alsa0.perex.cz (Postfix) with ESMTP id 03A4C266ABC for ; Mon, 14 Jan 2019 14:45:55 +0100 (CET) Received: by mail-wm1-f68.google.com with SMTP id n190so8977872wmd.0 for ; Mon, 14 Jan 2019 05:45:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eSHBro6jkuZgRF88rxThmvfL8PXduJEihRijUXbgQN4=; b=CsrEo/uJUfiY/yhKewL8SJyrD+mSyI9vQ5hR4ip+l8fH7imZ/n5u1l2mFgIgOJmIaT CLGzB1DFsfQ+LD0TWgG5KI9P+ixgpWiWaW8IldcliZ6LFPgAZayBd4QJpkewWd1XkU6B bCsrn+1AIUHxewPaSCiHqX+THm/66A3vjUQyU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eSHBro6jkuZgRF88rxThmvfL8PXduJEihRijUXbgQN4=; b=BBUb8KoVH0vW9S7LM7IFgqIG4DwyXOzCr/giada62PsGWs+ErA0GvzqNoaXKKSxS9i afExzPqAdSevQVim5wRo+kJuRg1CDYyJ+EuUDJysSFmsxUbYxVYw4JfuIbTybZS5tuj7 9kDvldZqw7MzUO1zCr8/ckowzlM9p97Wy9w48tE7Zo4NqTP5O3BIo1rlIyV0Wtd4q5U7 8GnZbwzNS/Ti+9h+j/dezi+fscSpCEgoKu0lVZ6dDZxz4Sl4AeUss4+H2u2TXvXgX6LV U4e5Nf74U3Ql6NkTqii5etATSP8LqFNhMM1KZQWwZ0w3/IQIPJ7ZPEjQOJibqZ1iQt2Z lU3g== X-Gm-Message-State: AJcUukcHgKxweZDfWUVn5po82k89R03bvEzTnYqL89Q0OT0AjdHF5v1Y 3yEBq6bqxJKcc/UzIsvyfJXb2g== X-Google-Smtp-Source: ALg8bN5Tu3CDY+htwXDCWVyW0b0gInxawViDsIS5SCsemKld1G35f3Y3cWCl0Wyrec0ZWCEf1dmfRA== X-Received: by 2002:a1c:4108:: with SMTP id o8mr11573993wma.91.1547473555389; Mon, 14 Jan 2019 05:45:55 -0800 (PST) Received: from srini-hackbox.lan (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.gmail.com with ESMTPSA id x10sm86766472wrn.29.2019.01.14.05.45.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 Jan 2019 05:45:54 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Date: Mon, 14 Jan 2019 13:44:46 +0000 Message-Id: <20190114134449.15367-2-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> References: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Cc: linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, broonie@kernel.org, Srinivas Kandagatla , linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH 1/4] slimbus: core: match full device id X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP match full slim device id instead of just product and manufacture code, this will allow drivers to be much more specific to that device. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 55eda5863a6b..9e4f3b21ba8c 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -21,7 +21,9 @@ static const struct slim_device_id *slim_match(const struct slim_device_id *id, { while (id->manf_id != 0 || id->prod_code != 0) { if (id->manf_id == sbdev->e_addr.manf_id && - id->prod_code == sbdev->e_addr.prod_code) + id->prod_code == sbdev->e_addr.prod_code && + id->dev_index == sbdev->e_addr.dev_index && + id->instance == sbdev->e_addr.instance) return id; id++; } From patchwork Mon Jan 14 13:44:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 10762647 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 59DA614E5 for ; Mon, 14 Jan 2019 13:53:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 437E12880C for ; Mon, 14 Jan 2019 13:53:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3757428BE6; Mon, 14 Jan 2019 13:53:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 227372880C for ; Mon, 14 Jan 2019 13:53:35 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 3A3DC2670A8; Mon, 14 Jan 2019 14:46:08 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 0E91E266B69; Mon, 14 Jan 2019 14:46:01 +0100 (CET) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by alsa0.perex.cz (Postfix) with ESMTP id 27A22266B57 for ; Mon, 14 Jan 2019 14:45:56 +0100 (CET) Received: by mail-wm1-f65.google.com with SMTP id f188so8879101wmf.5 for ; Mon, 14 Jan 2019 05:45:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wcq/BZjA1FXBmfYxzVF9/4lLVBugXEKEif9lDq84KTU=; b=WYgKve76AQapL96P//w9NBFMjzVpCPuV8TxBk81O+FXe5c9IK/zBEFrQmR4S2O09UR 6OqbSicCV3seQTILK21YiaU4XHBsbTV82pUDQjCB5AObNHnfxuBde8YbBvoZBhRgVhnw xberplgt88Z4je80I8tlQZ7v7o2XE7iOFxMTY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wcq/BZjA1FXBmfYxzVF9/4lLVBugXEKEif9lDq84KTU=; b=ow6v/fdXhT6i9FfkOnjqoCVJ1lla5alM4raIAMr/1gUHDm+3HRlUsdLatHWf12RPta mW3jVPOvbsUMNLKLqdAX9PiRLV2WQjOEWCDV1gGT127yQZQ71h7qx90Yc/0cDoVZGSy7 ISP7WG7cKHQj0PWtF4+hZDCuJ5xq0ip8hwz8DhLoL3iSqpwwQsXgDgRXzfIEWSBkzjgV WGJfgHTsieMHBD8hxbaNopdLM8HBOaPwRr4ZKlSsaOHf15dMQQC1ElxZek83WLc33Qa/ ccPGapi8MtPU5/4Mf+JGTuIeqJk6gkBZSPD3ZkUiT7fqpUMGNI6KHBYN1i7863myn5fT FFXg== X-Gm-Message-State: AJcUukcnVK397heJbtCMyALdPA5y0nTAxvHTmpuNpn/o8jJ9a63cgOkE BUki+EYA19glYL58YPVdFQIZ+eolwJE= X-Google-Smtp-Source: ALg8bN64kMU4Zn8sj96BtI9KdISTw1k7FD7k6jTQSUEXSzZQv0Ihl1I4aNOOo+S0/qTxrawQKPLjhA== X-Received: by 2002:a1c:bdc5:: with SMTP id n188mr12588988wmf.69.1547473556520; Mon, 14 Jan 2019 05:45:56 -0800 (PST) Received: from srini-hackbox.lan (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.gmail.com with ESMTPSA id x10sm86766472wrn.29.2019.01.14.05.45.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 Jan 2019 05:45:55 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Date: Mon, 14 Jan 2019 13:44:47 +0000 Message-Id: <20190114134449.15367-3-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> References: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Cc: linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, broonie@kernel.org, Srinivas Kandagatla , linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH 2/4] slimbus: core: do not call device_status under a lock X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Calling device_status callback under a lock would prevent drivers to do any slimbus trasactions which would invoke this lock like get_laddr(). Remove this unnecessary lock! Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 9e4f3b21ba8c..1ba08b5f2e78 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -466,6 +466,7 @@ static int slim_device_alloc_laddr(struct slim_device *sbdev, sbdev->laddr = laddr; sbdev->is_laddr_valid = true; + mutex_unlock(&ctrl->lock); slim_device_update_status(sbdev, SLIM_DEVICE_STATUS_UP); @@ -473,6 +474,8 @@ static int slim_device_alloc_laddr(struct slim_device *sbdev, laddr, sbdev->e_addr.manf_id, sbdev->e_addr.prod_code, sbdev->e_addr.dev_index, sbdev->e_addr.instance); + return 0; + err: mutex_unlock(&ctrl->lock); return ret; From patchwork Mon Jan 14 13:44:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 10762651 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D7F701390 for ; Mon, 14 Jan 2019 13:53:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C45432880C for ; Mon, 14 Jan 2019 13:53:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B82A128BAF; Mon, 14 Jan 2019 13:53:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 23602288B4 for ; Mon, 14 Jan 2019 13:53:35 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id F2D8A267129; Mon, 14 Jan 2019 14:46:10 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id C6F05266BD4; Mon, 14 Jan 2019 14:46:01 +0100 (CET) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by alsa0.perex.cz (Postfix) with ESMTP id A18EE26699F for ; Mon, 14 Jan 2019 14:45:58 +0100 (CET) Received: by mail-wr1-f65.google.com with SMTP id x10so22875570wrs.8 for ; Mon, 14 Jan 2019 05:45:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zhJfSAlmB/SXCyVXDRxBFTU7e7uygGHPig+jgFbUKkI=; b=Z3/wDbhzhopFmyHNBAS1GSnVi/sNKVPlp0oNbYpPLEEL4VqHsy+5ZLBt6oDYjcSO4T fSSE2zHTTQQ5i0sIelPEi9Kt/qThgXItG1JoSdo3gDZqGmDhbfP4J2MMFDebFOUdkHFt 0PH6bLo8xpAZlp4JFNkG55gMcPu3FtXIGRer0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zhJfSAlmB/SXCyVXDRxBFTU7e7uygGHPig+jgFbUKkI=; b=qCg8g4z0Veq/VMox0gTCQdr5xWSCOCkUvJkAQAgz3btR1jxpv8Yl/t7FIu9CDpXHnE FWEA/I4iZ1M17+361yMEb9e7lkd1ViEXBr8lpKF0g8BStAHDGFzex4m/7zuzFYXNpUTT z3M/3whVhgKaQ2gIJxZ8hicvohuS4cOT0RMFTlzov6XqjCTKV+DqhQOZ+5n/2QW72w8q 3aKzEzwCL9KcHQ9AlZey6ngHmTkn6OuwON/20jPPDL+rIOHRnCDrUdj6/TA1gdFpmmWJ x7+tShihasJpyP/u+LChkj0qqeRXHerF9dKmH1M+OQEZhU9DgP0ZR9MBZaNR/hLxZ1Z6 yKhg== X-Gm-Message-State: AJcUukcIfWTOlIJI/5MEP0FhWqZE8vJx1e3vIDaCzQy1AWQTgHrc+8/Y V34CeduQA15o6BUF01CJPk68Vg== X-Google-Smtp-Source: ALg8bN5IB0p3NXMh0MZIhvE5oOFk11LD0A8yEBKLDOoJcNBn079uF1rverXDFyN7EkSnLe1MzonW8A== X-Received: by 2002:adf:b201:: with SMTP id u1mr24126617wra.165.1547473558066; Mon, 14 Jan 2019 05:45:58 -0800 (PST) Received: from srini-hackbox.lan (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.gmail.com with ESMTPSA id x10sm86766472wrn.29.2019.01.14.05.45.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 Jan 2019 05:45:57 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Date: Mon, 14 Jan 2019 13:44:48 +0000 Message-Id: <20190114134449.15367-4-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> References: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Cc: linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, broonie@kernel.org, Srinivas Kandagatla , linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH 3/4] slimbus: core: use slim_device_update_status() to update status X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP use slim_device_update_status() instead of directly calling the device_status() callback. Move slim_device_update_status() before probe to avoid forward declaration too. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/core.c | 37 ++++++++++++++++++------------------- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 1ba08b5f2e78..8ffdc9876223 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -42,6 +42,23 @@ static int slim_device_match(struct device *dev, struct device_driver *drv) return !!slim_match(sbdrv->id_table, sbdev); } +static void slim_device_update_status(struct slim_device *sbdev, + enum slim_device_status status) +{ + struct slim_driver *sbdrv; + + if (sbdev->status == status) + return; + + sbdev->status = status; + if (!sbdev->dev.driver) + return; + + sbdrv = to_slim_driver(sbdev->dev.driver); + if (sbdrv->device_status) + sbdrv->device_status(sbdev, sbdev->status); +} + static int slim_device_probe(struct device *dev) { struct slim_device *sbdev = to_slim_device(dev); @@ -55,8 +72,7 @@ static int slim_device_probe(struct device *dev) /* try getting the logical address after probe */ ret = slim_get_logical_addr(sbdev); if (!ret) { - if (sbdrv->device_status) - sbdrv->device_status(sbdev, sbdev->status); + slim_device_update_status(sbdev, SLIM_DEVICE_STATUS_UP); } else { dev_err(&sbdev->dev, "Failed to get logical address\n"); ret = -EPROBE_DEFER; @@ -297,23 +313,6 @@ int slim_unregister_controller(struct slim_controller *ctrl) } EXPORT_SYMBOL_GPL(slim_unregister_controller); -static void slim_device_update_status(struct slim_device *sbdev, - enum slim_device_status status) -{ - struct slim_driver *sbdrv; - - if (sbdev->status == status) - return; - - sbdev->status = status; - if (!sbdev->dev.driver) - return; - - sbdrv = to_slim_driver(sbdev->dev.driver); - if (sbdrv->device_status) - sbdrv->device_status(sbdev, sbdev->status); -} - /** * slim_report_absent() - Controller calls this function when a device * reports absent, OR when the device cannot be communicated with From patchwork Mon Jan 14 13:44:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 10762653 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8064114E5 for ; Mon, 14 Jan 2019 13:53:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6F1AC28BAF for ; Mon, 14 Jan 2019 13:53:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6380D28BC2; Mon, 14 Jan 2019 13:53:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2CF7D28BD9 for ; Mon, 14 Jan 2019 13:53:35 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 86CFA26699F; Mon, 14 Jan 2019 14:46:09 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 4C02A266B63; Mon, 14 Jan 2019 14:46:01 +0100 (CET) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by alsa0.perex.cz (Postfix) with ESMTP id 8CC2A266ABC for ; Mon, 14 Jan 2019 14:45:59 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id v13so22909636wrw.5 for ; Mon, 14 Jan 2019 05:45:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O84mJPX8rC7OO4KioGFTyrv4Z9BLr8QwdnxN2Cr0+Iw=; b=Xv+mo420RQ7SowyXQw5AOCTKRj/czTkjlgmqK2fPHy5sIyzgCxajeFCQkYBrAPj+95 +Fju2rw+nA/0cRLQlXuiFPULIZJGWcF/j3Qyi5ZPa66gsosd/FfNWpVg0zplq66CTSxK GbBvRVkhYOhLZXsP85cjaruzTkBMzLR5qQUkQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=O84mJPX8rC7OO4KioGFTyrv4Z9BLr8QwdnxN2Cr0+Iw=; b=fr1trSILR8pukdvVaCRA5d67jfCZbLcTkELgbE2dqmQxKypMB6UVmfr/cfDQ15R5Nl ZhlEQLTZ+06qnhSAt9vQq9xmvVVE32ghmzNF+B3+ddGGIhlRgu3G66tggSlqEpQ9Ca/W 1uYbIsMHE2JZBQ2jeFjU0Cemq4ngZM9WH9wYT1IBacHzDUqqtJmdmIbijITDO1WvWS2e VOPPT40OeJftiK12OrrfwX+ZHUl21M0h0x45wsYigx+Yr9pY65jS1a4Dgt8E85uY9qF+ ibTyejC88U12L7joSjFlwcpaplvMzdL5fBMwwDxLXjToRO6zdgd3FyelEgNpLeTXdAqp U4Zg== X-Gm-Message-State: AJcUukcurT2RMowjDUwmKsfjMBlFJuDHDmnXJ1XCg9klAq5Gd0XydbJH 0i5ZXlDVvRIDl2YPhpD63bZ6Qg== X-Google-Smtp-Source: ALg8bN4MnerjFJwS814W3kl5XW6Mk6zbxqo8XNvKLGKMxT8Im17NTWIRM5DDeHIDp88gfaCzPytGIg== X-Received: by 2002:adf:b6a1:: with SMTP id j33mr24357526wre.55.1547473559036; Mon, 14 Jan 2019 05:45:59 -0800 (PST) Received: from srini-hackbox.lan (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.gmail.com with ESMTPSA id x10sm86766472wrn.29.2019.01.14.05.45.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 Jan 2019 05:45:58 -0800 (PST) From: Srinivas Kandagatla To: gregkh@linuxfoundation.org Date: Mon, 14 Jan 2019 13:44:49 +0000 Message-Id: <20190114134449.15367-5-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> References: <20190114134449.15367-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Cc: linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, broonie@kernel.org, Srinivas Kandagatla , linux-kernel@vger.kernel.org Subject: [alsa-devel] [PATCH 4/4] slimbus: core: add missing spin_lock_init on txn_lock X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Add missing spin lock intialization this also fixes the spinlock bad magic warning. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 8ffdc9876223..b2f07d2043eb 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -274,6 +274,7 @@ int slim_register_controller(struct slim_controller *ctrl) mutex_init(&ctrl->lock); mutex_init(&ctrl->sched.m_reconf); init_completion(&ctrl->sched.pause_comp); + spin_lock_init(&ctrl->txn_lock); dev_dbg(ctrl->dev, "Bus [%s] registered:dev:%p\n", ctrl->name, ctrl->dev);