From patchwork Tue Aug 2 00:37:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniil Lunev X-Patchwork-Id: 12934185 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CA4AC19F2C for ; Tue, 2 Aug 2022 00:37:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235441AbiHBAhR (ORCPT ); Mon, 1 Aug 2022 20:37:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235439AbiHBAhQ (ORCPT ); Mon, 1 Aug 2022 20:37:16 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAD0333E09 for ; Mon, 1 Aug 2022 17:37:12 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id 23so11036198pgc.8 for ; Mon, 01 Aug 2022 17:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xkSPJ1fGWKwnB6nfWJJpSabwLL8PeTkD8DzYOav9XOM=; b=jstM1DFtArIJE4r3dJgJmVB+/wkidSo+wxJa4lXqU5JQeQ1S0J5fiNv9yCe+DI25hp HzobHfGoDNXR/ZFg2DSuVTr0rCXMWOx3obERUgT4Ahv/JBGt5RJoPzK4NSMVhOb5+ks4 5tbSJ1j2DZN3JPAk3Uc5qT1GeI4GaFKf6LpyY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xkSPJ1fGWKwnB6nfWJJpSabwLL8PeTkD8DzYOav9XOM=; b=sGAU63lNFY/6iVZTFLOeSYP2Mc4PR4m1SjgXzBqGSVSK5FPq1ULSXMs9CxT6WQE4Ba Znt37+fzWwVlABq6MPd+SBEd+blOeeJgSxljIx7HjhKma11exW6XOG+vLAVm3ydodYVo OF9zqmIrXr+UrtkWVP1qqeA8x8Gp+GEW8wPxbk3MRh2HFqYT9n68Fb2V3zDgnByWMdjS j4giH3xarqJgJZTYyi4+Ve287UYELHps9XNiyQyBGXK+jRHfbuSQMSNv82nkGgUoooY3 583qbvlJ5l/1LDSRxaHg6tG5gDJYwktA1FtZJ0bpAnA17tTdThebe4+mAFBI5/C0el0/ kxNw== X-Gm-Message-State: ACgBeo0VFuIWil1EIBPeqEOWxU+9T1MN/21Br5zKWwvcd1c0VXFkrN6M wU6T2AXHloUG0NuwuTKBWLwy/g== X-Google-Smtp-Source: AA6agR6qACbTp/hM1PKV8p19nlC1Su2CQrDQDk7YaxKNHs5REHWX0QuwjnCCLkjuK3nX1wiOcQkhlQ== X-Received: by 2002:a62:cec9:0:b0:52d:414b:c70f with SMTP id y192-20020a62cec9000000b0052d414bc70fmr9893287pfg.20.1659400632174; Mon, 01 Aug 2022 17:37:12 -0700 (PDT) Received: from dlunevwfh.roam.corp.google.com (n122-107-196-14.sbr2.nsw.optusnet.com.au. [122.107.196.14]) by smtp.gmail.com with ESMTPSA id d10-20020a170902654a00b0016ef1e058e5sm2558806pln.295.2022.08.01.17.37.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Aug 2022 17:37:11 -0700 (PDT) From: Daniil Lunev To: Adrian Hunter , Bart Van Assche , Greg Kroah-Hartman Cc: Daniil Lunev , Alim Akhtar , Avri Altman , Bean Huo , "James E.J. Bottomley" , Keoseong Park , "Martin K. Petersen" , Mauro Carvalho Chehab , Sohaib Mohamed , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: [PATCH v5] ufs: core: print UFSHCD capabilities in controller's sysfs node Date: Tue, 2 Aug 2022 10:37:02 +1000 Message-Id: <20220802103643.v5.1.Ibf9efc9be50783eeee55befa2270b7d38552354c@changeid> X-Mailer: git-send-email 2.31.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Allows userspace to check if Clock Scaling and Write Booster are supported. Signed-off-by: Daniil Lunev --- Changes in v5: * Correct wording for clock scaling. * Correct wording for the commit message. Changes in v4: * Dropped crypto node per Eric Biggers mentioning it can be queried from disk's queue node Changes in v3: * Expose each capability individually. * Update documentation to represent new scheme. Changes in v2: * Add documentation entry for the new sysfs node. Documentation/ABI/testing/sysfs-driver-ufs | 26 ++++++++++++++++++ drivers/ufs/core/ufs-sysfs.c | 31 ++++++++++++++++++++++ 2 files changed, 57 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-driver-ufs b/Documentation/ABI/testing/sysfs-driver-ufs index 6b248abb1bd71..1750a9b84ce0f 100644 --- a/Documentation/ABI/testing/sysfs-driver-ufs +++ b/Documentation/ABI/testing/sysfs-driver-ufs @@ -1591,6 +1591,32 @@ Description: This entry shows the status of HPB. The file is read only. +What: /sys/bus/platform/drivers/ufshcd/*/capabilities/clock_scaling +What: /sys/bus/platform/devices/*.ufs/capabilities/clock_scaling +Date: July 2022 +Contact: Daniil Lunev +Description: Indicates status of clock scaling. + + == ============================ + 0 Clock scaling is not supported. + 1 Clock scaling is supported. + == ============================ + + The file is read only. + +What: /sys/bus/platform/drivers/ufshcd/*/capabilities/write_booster +What: /sys/bus/platform/devices/*.ufs/capabilities/write_booster +Date: July 2022 +Contact: Daniil Lunev +Description: Indicates status of Write Booster. + + == ============================ + 0 Write Booster can not be enabled. + 1 Write Booster can be enabled. + == ============================ + + The file is read only. + What: /sys/class/scsi_device/*/device/hpb_param_sysfs/activation_thld Date: February 2021 Contact: Avri Altman diff --git a/drivers/ufs/core/ufs-sysfs.c b/drivers/ufs/core/ufs-sysfs.c index 0a088b47d5570..5c53349337dd8 100644 --- a/drivers/ufs/core/ufs-sysfs.c +++ b/drivers/ufs/core/ufs-sysfs.c @@ -279,6 +279,36 @@ static const struct attribute_group ufs_sysfs_default_group = { .attrs = ufs_sysfs_ufshcd_attrs, }; +static ssize_t clock_scaling_show(struct device *dev, struct device_attribute *attr, + char *buf) +{ + struct ufs_hba *hba = dev_get_drvdata(dev); + + return sysfs_emit(buf, "%d\n", ufshcd_is_clkscaling_supported(hba)); +} + +static ssize_t write_booster_show(struct device *dev, struct device_attribute *attr, + char *buf) +{ + struct ufs_hba *hba = dev_get_drvdata(dev); + + return sysfs_emit(buf, "%d\n", ufshcd_is_wb_allowed(hba)); +} + +static DEVICE_ATTR_RO(clock_scaling); +static DEVICE_ATTR_RO(write_booster); + +static struct attribute *ufs_sysfs_capabilities_attrs[] = { + &dev_attr_clock_scaling.attr, + &dev_attr_write_booster.attr, + NULL +}; + +static const struct attribute_group ufs_sysfs_capabilities_group = { + .name = "capabilities", + .attrs = ufs_sysfs_capabilities_attrs, +}; + static ssize_t monitor_enable_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -1134,6 +1164,7 @@ static const struct attribute_group ufs_sysfs_attributes_group = { static const struct attribute_group *ufs_sysfs_groups[] = { &ufs_sysfs_default_group, + &ufs_sysfs_capabilities_group, &ufs_sysfs_monitor_group, &ufs_sysfs_device_descriptor_group, &ufs_sysfs_interconnect_descriptor_group,