From patchwork Tue Aug 2 07:10:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: CGEL X-Patchwork-Id: 12934275 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C87B5C00140 for ; Tue, 2 Aug 2022 07:10:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 430516B0073; Tue, 2 Aug 2022 03:10:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E0366B0074; Tue, 2 Aug 2022 03:10:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A78D8E0001; Tue, 2 Aug 2022 03:10:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1BA206B0073 for ; Tue, 2 Aug 2022 03:10:42 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E68DF1A0DFC for ; Tue, 2 Aug 2022 07:10:41 +0000 (UTC) X-FDA: 79753779882.17.AE98BA1 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf28.hostedemail.com (Postfix) with ESMTP id 8010BC00F5 for ; Tue, 2 Aug 2022 07:10:41 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id v16-20020a17090abb9000b001f25244c65dso17593687pjr.2 for ; Tue, 02 Aug 2022 00:10:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=9E5lubngFnwU28P2LAysppkLSVmPXiDzv5fdAZHb7/4=; b=XLtYTU18C5wyOeZr8YZlzSdYR5dw+KlaE0k8rGJuLZNkfCwUqBNRhCUhcYG51wj90b yviAalYmCQlc5eHIh2T+AklUtSVqIv9zCqTDfuYkrN5h4aWkzKNydTDIEVk2BVfdDzFJ f0IOT9gFMX7Gqh1N8GutPBipKjWmf6990DE7viKsVYqu+O3uVYHbaUK1h7rBwbJlzjae s0adNI5Z/HW8U/Yp0aZYm/eEkJBxGvLSU4DPBoiH/R0K6sHVj4rrPQQYjt5jkey4y7I5 lJkagyZeTXNblU1L1z5IrpP8hI1x9vXiyoD1iSdUQjOcWcSZhju+rKinLb5eIRLRHgDk GSnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=9E5lubngFnwU28P2LAysppkLSVmPXiDzv5fdAZHb7/4=; b=KWtoRhhERwUL8ZEk1blqVYMyiyO9l3jnpH9wn3mpfKqZd8bMugWgVa4rMTegjPPo17 4qDVqtpzGCTe8yN1WK7BInPBvwEcb5xkK06aHd7rMJPnzJ/daqPAwqjUECx0rQF4DO7o REAI9J2ZwIhjs+pXGPHVqO4UcQ5NVoMEyzzrSaVrYUTk1123q4GqV8MEjSMeSjcArtTl gPtrgPsLWDRB6JT0Z/zJy92m3Y5OMTFVsMLlp+Z77hFxb2Y4jYVY+rj2kPnVOyut3k1J 0Pz9H+jTlTbmdvq3leRMK7Dz5W9LYSd7xvyd6BpH1747dQxvHjOfvHeKyuaCeCfv6D5U BY4Q== X-Gm-Message-State: ACgBeo13wsJjo5zqDTb4Si+eYpKRDDzyBxQK8LjFu95mjgGtWUB2n7+G OcP4zWcBaaT4nKfwo52HiGc= X-Google-Smtp-Source: AA6agR4GtJqs9gHhi+JMWYNyqCs4GxCH3kfQQ3Ow39hVA0MxsJ8aXFkO8k54tF9PjJ9/CZk1edja4A== X-Received: by 2002:a17:902:d491:b0:16c:509a:ac3b with SMTP id c17-20020a170902d49100b0016c509aac3bmr20567282plg.103.1659424240410; Tue, 02 Aug 2022 00:10:40 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id p185-20020a6229c2000000b005251f4596f0sm9971318pfp.107.2022.08.02.00.10.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Aug 2022 00:10:39 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: yang.yang29@zte.com.cn To: akpm@linux-foundation.org, hannes@cmpxchg.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Yang , CGEL ZTE Subject: [PATCH] mm/vmscan: define macros for refaults in struct lruvec Date: Tue, 2 Aug 2022 07:10:13 +0000 Message-Id: <20220802071012.1648335-1-yang.yang29@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XLtYTU18; spf=pass (imf28.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659424241; a=rsa-sha256; cv=none; b=3zt/mICi+Zh2VnDsj2uGVTLsEPBb1/cuRHVkAiV0QRVGZ8xIJCqFVBsMUwfYJQ/tc6l4UZ w7wy8r4uxRD3gmrRUB8OQCrq4peJPvnIZjPWsLd/zttDrmsfIvh6Fw3T439pCNcTmFntww Ho+MvX9JalO14KLpEbnfrs083dv5Rg0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659424241; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=9E5lubngFnwU28P2LAysppkLSVmPXiDzv5fdAZHb7/4=; b=uOmVrnVfyjPV6f4Wr4lqZoPJ9jKUM+AfdOPNPoCv/7p9Au5NFxIDoasW78ECmvBSuS5yKS mhfLFnW9HM4pXv9+MGQ8FY8AHGN/YRWW1bu/WPvE2BZnGW4PR2iMwdQTN/iRBL8MTUV9lC MDrxnRPA0GV6mRms20d50JmdYOR8hEA= X-Stat-Signature: 9y6q5kucijyrxxjw9sn3x93x9ksxq9x5 X-Rspamd-Queue-Id: 8010BC00F5 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XLtYTU18; spf=pass (imf28.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1659424241-252227 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Yang Yang The magic number 0 and 1 are used in several places in vmscan.c. Define macros for them to improve code readability. Signed-off-by: Yang Yang Signed-off-by: CGEL ZTE Reported-by: kernel test robot --- include/linux/mmzone.h | 2 ++ mm/vmscan.c | 8 ++++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index e24b40c52468..795076c33163 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -306,6 +306,8 @@ static inline bool is_active_lru(enum lru_list lru) return (lru == LRU_ACTIVE_ANON || lru == LRU_ACTIVE_FILE); } +#define ANON 0 +#define FILE 1 #define ANON_AND_FILE 2 enum lruvec_flags { diff --git a/mm/vmscan.c b/mm/vmscan.c index b2b1431352dc..f6a54c25ac7d 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3230,7 +3230,7 @@ static void shrink_node(pg_data_t *pgdat, struct scan_control *sc) refaults = lruvec_page_state(target_lruvec, WORKINGSET_ACTIVATE_ANON); - if (refaults != target_lruvec->refaults[0] || + if (refaults != target_lruvec->refaults[ANON] || inactive_is_low(target_lruvec, LRU_INACTIVE_ANON)) sc->may_deactivate |= DEACTIVATE_ANON; else @@ -3243,7 +3243,7 @@ static void shrink_node(pg_data_t *pgdat, struct scan_control *sc) */ refaults = lruvec_page_state(target_lruvec, WORKINGSET_ACTIVATE_FILE); - if (refaults != target_lruvec->refaults[1] || + if (refaults != target_lruvec->refaults[FILE] || inactive_is_low(target_lruvec, LRU_INACTIVE_FILE)) sc->may_deactivate |= DEACTIVATE_FILE; else @@ -3559,9 +3559,9 @@ static void snapshot_refaults(struct mem_cgroup *target_memcg, pg_data_t *pgdat) target_lruvec = mem_cgroup_lruvec(target_memcg, pgdat); refaults = lruvec_page_state(target_lruvec, WORKINGSET_ACTIVATE_ANON); - target_lruvec->refaults[0] = refaults; + target_lruvec->refaults[ANON] = refaults; refaults = lruvec_page_state(target_lruvec, WORKINGSET_ACTIVATE_FILE); - target_lruvec->refaults[1] = refaults; + target_lruvec->refaults[FILE] = refaults; } /*