From patchwork Wed Aug 10 11:32:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 12940473 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CFDDC00140 for ; Wed, 10 Aug 2022 11:33:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229487AbiHJLdR (ORCPT ); Wed, 10 Aug 2022 07:33:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232134AbiHJLdG (ORCPT ); Wed, 10 Aug 2022 07:33:06 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89CA775FED; Wed, 10 Aug 2022 04:33:05 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id j3so8613315ljo.0; Wed, 10 Aug 2022 04:33:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=g2OJvOZZHZIxUC/pgYnk9p8BpXsVB+Oo8nJt9r6IY80=; b=NSGsGPyT4xwwMmbAE+M4xP1n8h/WRufFIaybXJLwRWeuynTXVnNFE9ZGER+xYFWZzr TX2PM8oTgJ0wo96tXegmpoHDHfmy1/l6BPF2xwjKj/y9gvMJJoxoSHxh82j2WlM1P6nn 5pCPWAdJ/Oko3EUHWbXtBkz3T5fiblQB4VW3pRt9zzCAHeItc6vh1MJ7m/LCV7RfPoST W8c68l23tBQlVRll49YKBbJkjiNgStsDLK9jWKsrfqKZEkcBe/zXUI8rYVB+AUqwZeSo i5jlIHxcn1JzYyXq3dwmDYoJ34C7LbSYRLwUgaLe7Yyom5jTN0Z8kJGUjG2H/EqEXnSv ukEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=g2OJvOZZHZIxUC/pgYnk9p8BpXsVB+Oo8nJt9r6IY80=; b=ezSwY5ok0KBJxiZNdSY3pv6ngMn4gx+OJfOOfatilgzQi7ip7z/2WRXIraXZATH877 d/tTUAB/BRgFeaVvV44GzX18o2bEgWEvpdCXy7LM3JnEPYWFil5pQ9reu/KzttrrG1ns XdWJTCVHBEQoB9iZ5LNXd5Pn4pHmoZ6fUHM29f2u5fqM4JkvXXPZJWRkIUSt+jWTleWY X1FlwQmS3b/PXH5nkWARhn4uDL6P/YdKWl5ETpEdrsLifRWMPuo/Rqx+Qr0GYDAw0TT2 LCizO5Ih/0Mgy1Loa9FhJVe0OMtRKKXDkxD4HOXGDT1jdNDIOxsuqzNiRFnYqUD0n8ML qj9A== X-Gm-Message-State: ACgBeo1sMIdAADUHMEU3ZqNHahel0jbEYpg7DFMX0HhB2ml70c5AMG97 nRnfQubnEXcB8PRHwen9NIQ= X-Google-Smtp-Source: AA6agR7ZMOfUoxveidPh6nF5e7B+hqw59U+fxlV00cwI92nJPJOyeF5w8Zat6EbqCptnPKDJiw+0kw== X-Received: by 2002:a2e:bf01:0:b0:25f:df1a:f39d with SMTP id c1-20020a2ebf01000000b0025fdf1af39dmr4312867ljr.365.1660131183928; Wed, 10 Aug 2022 04:33:03 -0700 (PDT) Received: from fedora ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id c6-20020a056512074600b0048b309aeb09sm306204lfs.226.2022.08.10.04.33.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Aug 2022 04:33:03 -0700 (PDT) Date: Wed, 10 Aug 2022 14:32:49 +0300 From: Matti Vaittinen To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com Cc: Alexandru Tachici , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH 7/7] adc: ad7192: simplify using devm_regulator_get_enable() Message-ID: <7ca58a7014a2149a3190336247b13e683fdf6e33.1660127865.git.mazziesaccount@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(), add_action_or_reset(regulator_disable)' and use the devm_regulator_get_enable_optional(). Also drop the seemingly unused struct member 'dvdd'. Signed-off-by: Matti Vaittinen --- drivers/iio/adc/ad7192.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c index d71977be7d22..8a52c0dec3f9 100644 --- a/drivers/iio/adc/ad7192.c +++ b/drivers/iio/adc/ad7192.c @@ -177,7 +177,6 @@ struct ad7192_chip_info { struct ad7192_state { const struct ad7192_chip_info *chip_info; struct regulator *avdd; - struct regulator *dvdd; struct clk *mclk; u16 int_vref_mv; u32 fclk; @@ -1015,19 +1014,9 @@ static int ad7192_probe(struct spi_device *spi) if (ret) return ret; - st->dvdd = devm_regulator_get(&spi->dev, "dvdd"); - if (IS_ERR(st->dvdd)) - return PTR_ERR(st->dvdd); - - ret = regulator_enable(st->dvdd); - if (ret) { - dev_err(&spi->dev, "Failed to enable specified DVdd supply\n"); - return ret; - } - - ret = devm_add_action_or_reset(&spi->dev, ad7192_reg_disable, st->dvdd); + ret = devm_regulator_get_enable(&spi->dev, "dvdd"); if (ret) - return ret; + return dev_err_probe(&spi->dev, ret, "Failed to enable specified DVdd supply\n"); ret = regulator_get_voltage(st->avdd); if (ret < 0) {