From patchwork Thu Aug 11 20:33:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Conor Dooley X-Patchwork-Id: 12941722 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14640C19F2D for ; Thu, 11 Aug 2022 20:33:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OiHNQN/noSo2I4TljvoIXsyn0H4wH2UiVJ9waHJ/sDI=; b=tVYEJ3mMtXqeLY 44oVeHirjvPnSDqB4yaiOsMhO0QU+xZz3RdRyI5IO1h5l1KR6ggY/qheX4dr0N8BgzKni8ZnBcCf8 tLpetDgZKDJyUl8lOKLlZEu04L0SOeYP6hWjKm9U4dxrKb0xEBm2jtmd0t50AeMXOXOLjUmR9w857 pFAsGdgNmkHep4Bcx1veWl1e4q6gVw7p5RIzvSOeRkkLZAwlpj+Lu9tK/aCr7Yd36f6+puE6TcX+H sHi5l2gQXhAw3omUt78UI7Cg53m2NC8xnsNnT510PAC+XFLttZSSSs6cWPc/VQgUhoplVchn6PhKt Bo1C8X4Q37OLqRsQyUkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMErp-0056Wq-I3; Thu, 11 Aug 2022 20:33:21 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMErm-0056UU-0i for linux-riscv@lists.infradead.org; Thu, 11 Aug 2022 20:33:19 +0000 Received: by mail-wm1-x32e.google.com with SMTP id p12-20020a7bcc8c000000b003a5360f218fso3261189wma.3 for ; Thu, 11 Aug 2022 13:33:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=conchuod.ie; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=44JZfQo8qBDZMgfCdrZJwZLuiR284QlmRSCfMxTvtpo=; b=Rg+2K2aUJR5EC4EzeEhjweVggh3LGAxXDW+n+myh6+YEfAOfixSRbOplNLuQc+hbCh k+KeOqNm6R7kogF4zChBu0vPRB6/t4pC7dpmsahLZa0MR1bkVO2XWKiYhLL+J8YqQUDk ZtKBGxLruXNAffh3BmuL+H6PQwULOjdofcVTtJDehPnCkEwCuYwFQvxMN+8on0EzLv0W 8hG4NzCnIC7nauXERnsjmeIsK9LpEBmZMluKZGrodeAYGFQJLpKQqnVMGITSegeShwjt CAS9qdr1VnbdcCuBIY3JiurrcquUlr5/UocbOVp2P97KWNRvHxATlrQBQ9jfvz51J/Lu zNfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=44JZfQo8qBDZMgfCdrZJwZLuiR284QlmRSCfMxTvtpo=; b=8AtKyWPwbSJkpvUGgcrM6rL9PlzOpkrCi3itUy2P63yvHAO1aLTQ9RIvuPnikJElCB ac00XK6bfiK8wML7N58DxNT7nDJ07/+cqtNM9kFiK+8lclZ90yQpDALHzR56xSHzoiSr AtPTsaTjYOlZMGxAjs6nczT5m+1UfOcz7A1yliMACA5hjokpmishn1QjMmnAkwv5ZCUb OLE7iS1d28hz7RXuRysP4cltlK5uT1ZA4EoaxgEOvQkoMzx5Y2p0TGKwHF7rXy+fgNPC ta10MyehZdfyxqHDsnyXXI1m1H+/QByj8xlt94Dg5cCOc4TZg3AvQov4N9Ifsu+ainDQ r/gw== X-Gm-Message-State: ACgBeo2DirTHSO8LtS2khvxoTFpbC+on2vPlh3hUOQmqcjFTSMZUDQC/ yvXGxnnhKpyPqRhFsKsfQNcs5w== X-Google-Smtp-Source: AA6agR5N8mHJgZv+snXP8haUdkqppQ+4312cBLsCj598n23ICeGirf1H5+hFJyDA92da/FyY+BkSUQ== X-Received: by 2002:a05:600c:3845:b0:3a3:19e8:829e with SMTP id s5-20020a05600c384500b003a319e8829emr6647580wmr.11.1660249996798; Thu, 11 Aug 2022 13:33:16 -0700 (PDT) Received: from henark71.. ([109.76.58.63]) by smtp.gmail.com with ESMTPSA id i12-20020adfefcc000000b0021f1ec8776fsm86643wrp.61.2022.08.11.13.33.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Aug 2022 13:33:16 -0700 (PDT) From: Conor Dooley To: Daire McNamara , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Greentime Hu , Palmer Dabbelt , Albert Ou , Lorenzo Pieralisi , Conor Dooley Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH 1/4] dt-bindings: PCI: fu740-pci: fix missing clock-names Date: Thu, 11 Aug 2022 21:33:04 +0100 Message-Id: <20220811203306.179744-2-mail@conchuod.ie> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220811203306.179744-1-mail@conchuod.ie> References: <20220811203306.179744-1-mail@conchuod.ie> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220811_133318_081431_B4C81B84 X-CRM114-Status: GOOD ( 12.04 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org From: Conor Dooley The commit in the fixes tag removed the clock-names property from the SiFive FU740 PCI Controller dt-binding, but it was already in the dts for the FU740. dtbs_check was not able to pick up on this at the time but v2022.08 of dt-schema now can: arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dtb: pcie@e00000000: Unevaluated properties are not allowed ('clock-names' was unexpected) From schema: linux/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml The Linux driver does not use this property, but outside of the kernel this property may have users. Re-add the property and its "clocks" dependency. Fixes: b92225b034c0 ("dt-bindings: PCI: designware: Fix 'unevaluatedProperties' warnings") Signed-off-by: Conor Dooley --- I went back and forth on removing the property from the dts, but this seems like the change that is more conservative.. --- .../devicetree/bindings/pci/sifive,fu740-pcie.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml b/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml index 195e6afeb169..c7a9a2dc0fa6 100644 --- a/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml @@ -51,6 +51,12 @@ properties: description: A phandle to the PCIe power up reset line. maxItems: 1 + clocks: + maxItems: 1 + + clock-names: + const: pcie_aux + pwren-gpios: description: Should specify the GPIO for controlling the PCI bus device power on. maxItems: 1 From patchwork Thu Aug 11 20:33:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Conor Dooley X-Patchwork-Id: 12941724 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79FDFC3F6B0 for ; Thu, 11 Aug 2022 20:33:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h6WBbmNlq6lO1pFqFn+iYpcgtrKVhRV7nCqLVYjESjU=; b=apsSWkotqhKJQZ 5cD0FCCxHqIfdvozZ69oItXH3zIDRKTk8HPdVsWCIezdk04UjvRQeK1oKbVf1xbB8kVUcbV6GaArv cCOW93Em1KmH8wp4m6wQqVH+gO0rO+tFaDwOSb+Iw/nYfZLG5viWAZsxEoL3UUQfGmQDLkyYoG8i6 sxjqJ9hkIcHdl/815Uo5ACXXblpaUJG4M3SZfsY3G0LBOBIMVlPA+OwkIr3lclMMNupmgvUPFQRHt wWUTGlUhWYziNt/vndMB5IVO897Kes52TiAZuTke9p/6skbEd6RcuImxNgKoP8oh+LbqOnQMlACJW n6nsjQKV9rKquvMd0E0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMErt-0056aa-8P; Thu, 11 Aug 2022 20:33:25 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMEro-0056V6-3k for linux-riscv@lists.infradead.org; Thu, 11 Aug 2022 20:33:21 +0000 Received: by mail-wr1-x432.google.com with SMTP id n4so20781349wrp.10 for ; Thu, 11 Aug 2022 13:33:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=conchuod.ie; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=QxkmtF8asgPVQHFJENq/ehachAsL+qmscZvCCu05yWc=; b=XaRcrphLz19LTNxZ0dzKwHA8K/MkiviSjiw49WVWXeVE5qRONAyZyq8QlcuzrvefVq DVNMQX04znal0vPNRmcNC3MbIYAUaAwumKVcp1t0JK2JWpjZ/cp5ve/O9xgtHIB9jYp1 a8nRH+Wy1LAZE51EqhGYykiH3KzE9PEX9dP0kwd3yenGFVrqs5lMmYFvz3ozZW8IIaAJ Bj4EyFhC9G2D5gf3y3F2K/Htv7ZqH11Y9ovKD1Bz7OjfH17QcK/dDGLuF9YkGgrMvCco 4DIJtEW+NiKBMz3o+dzkdKU5lyhNrWpghKTXW2kDbXlMfdJOmER6MuwSLRX/k4n+MNIT Ftcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=QxkmtF8asgPVQHFJENq/ehachAsL+qmscZvCCu05yWc=; b=sVzZArB0sl9SI4IzfNPpi105JzAtYG5AR5ztXKQYxx8M5OsjccaqsQq7GRkrvbtkyW KFhcWjhrHq7dmKmaP8n2kBLTZS9+LD4i54xB7TnPEJjReXDvp/R3hdg5JSkzD4HzmOJh ZKnqPGEAS0KksCYEBorL/KgwQHkmBZzXvelzNU+9SRVbGAcPMLm1nrOuktDHE3rL6Y1o bV1vQELkZkAZzgwjTocKf1TOE+NkqHD/dHEqufmMxkAim589j5I5w1H/QUlnYcu8dOj1 aa3PCgx7DWsP8t9hdpOmrPx07a8MNnLETke/SDYBmcyIEohd2/tO65+gARjX/Kh+WCUg PfGA== X-Gm-Message-State: ACgBeo0E0AZvSS9jFRa4UvVuvgypnwNgWDhCDSQQDCqHQD4+lecj868m jQMh7A8Cl4nO9o1s58mUoQo2bg== X-Google-Smtp-Source: AA6agR5//7v1W6BSWMIoYqn+Fu+wgEM3FNII37M+y/PlRKeC6C5AWj7949Ozxp/ApCOBEqaRSPZzpw== X-Received: by 2002:a5d:59a5:0:b0:222:c5a5:59c4 with SMTP id p5-20020a5d59a5000000b00222c5a559c4mr337239wrr.656.1660249997915; Thu, 11 Aug 2022 13:33:17 -0700 (PDT) Received: from henark71.. ([109.76.58.63]) by smtp.gmail.com with ESMTPSA id i12-20020adfefcc000000b0021f1ec8776fsm86643wrp.61.2022.08.11.13.33.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Aug 2022 13:33:17 -0700 (PDT) From: Conor Dooley To: Daire McNamara , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Greentime Hu , Palmer Dabbelt , Albert Ou , Lorenzo Pieralisi , Conor Dooley Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH 2/4] dt-bindings: PCI: microchip,pcie-host: fix missing clocks properties Date: Thu, 11 Aug 2022 21:33:05 +0100 Message-Id: <20220811203306.179744-3-mail@conchuod.ie> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220811203306.179744-1-mail@conchuod.ie> References: <20220811203306.179744-1-mail@conchuod.ie> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220811_133320_190245_27C566BD X-CRM114-Status: GOOD ( 10.13 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org From: Conor Dooley Upgrading dt-schema to v2022.08 reveals unevaluatedProperties issues that were not previously visible, such as the missing clocks and clock-names properties for PolarFire SoC's PCI controller: arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dtb: pcie@2000000000: Unevaluated properties are not allowed ('clock-names', 'clocks', 'legacy-interrupt-controller', 'microchip,axi-m-atr0' were unexpected) From schema: Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml The clocks are required to enable interfaces between the FPGA fabric and the core complex, so add them to the binding. Fixes: 6ee6c89aac35 ("dt-bindings: PCI: microchip: Add Microchip PolarFire host binding") Signed-off-by: Conor Dooley --- .../bindings/pci/microchip,pcie-host.yaml | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml b/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml index edb4f81253c8..2a2166f09e2c 100644 --- a/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml +++ b/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml @@ -25,6 +25,31 @@ properties: - const: cfg - const: apb + clocks: + description: + Fabric Interface Controllers, FICs, are the interface between the FPGA + fabric and the core complex on PolarFire SoC. The FICs require two clocks, + one from each side of the interface. The "FIC clocks" described by this + property are on the core complex side & communication through a FIC is not + possible unless it's corresponding clock is enabled. A clock must be + enabled for each of the interfaces the root port is connected through. + minItems: 1 + items: + - description: FIC0's clock + - description: FIC1's clock + - description: FIC2's clock + - description: FIC3's clock + + clock-names: + items: + enum: + - fic0 + - fic1 + - fic2 + - fic3 + minItems: 1 + maxItems: 4 + interrupts: minItems: 1 items: From patchwork Thu Aug 11 20:33:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Conor Dooley X-Patchwork-Id: 12941723 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE5CDC19F2A for ; Thu, 11 Aug 2022 20:33:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=91WlDesrH1XJ1MWUQFFadKw8XvdzUQ0I3tYcIY7ykn4=; b=yIg3uMO/3JIARr rIQx96ph+Z4UMprNFiIhLiE0+QTbgSyRs4XFXgmoGd1jAjETgnjGhtsDle2SLxIS28ZTF0zdiKnTt sF6OqZnjvRv88QkIjHbvHIheScBe7X4ZMbCojhO+Wn2AbY1iStQdKhQvTUNOr2NICg+txR83CV/2+ 6/Ow69DBL+LKnPt1pn+cJwSR+yguxeIBfUlwIMEA27MBI2mzKAPo8ujkRlHXFWObK4nv/qEpnPyom XtLXWGblHcx8qubMrnNSfCSjeupPU2koLXH/FVkSl/hlxPqLKwIu2/uWzU2YZJEt/XloD7xiIRtkH iQZQcklV8MgBBSQcB0/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMErr-0056Yw-IH; Thu, 11 Aug 2022 20:33:23 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMErn-0056U0-Ly for linux-riscv@lists.infradead.org; Thu, 11 Aug 2022 20:33:21 +0000 Received: by mail-wr1-x429.google.com with SMTP id z12so22544068wrs.9 for ; Thu, 11 Aug 2022 13:33:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=conchuod.ie; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=BMoCBhZDWFVbCIulovqGFO1GGwjU3Gb2EjVAgLDr/kM=; b=e1haM7gYHDueJmKbGFqDqB0CwdhTeSa2E4wt4JmEDSJbRCc95HOzVyhmhAR1aZMqqx WxkA1FzPGcrae9KDWdzDMQHZEb1i39i7aAL9rQ0/XQMl0cjzp27sbySRBMnLhzbUHVO9 p7YPgrN5/LQYBe6cKzpCPAwLYeTnzOked1Fp12KP22d+INh+NSfPUx4OvjJU/VCDd81U gwIKYZTkvJayzWTODqIsBm7Mc+j7idl/i5AbrnvDIsmPMmT2pRhWCHNWRNL/NjJQmAK3 REtDrCKW9kfVEhaxxP06EjHEUcaXvACDZ9Cu7GF6pF7rHNRdKy1UlQE0Abl+CgWbWCRX qlpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=BMoCBhZDWFVbCIulovqGFO1GGwjU3Gb2EjVAgLDr/kM=; b=U6gIJPN8aGZ/TgtNU7eGWDrWA+STbQahHEaeZ7NE5dvEjVpAnLeL/PG/FNEgVHC2WL v3JYAco1ciZkyeQeM64VYl7V/txtz2IFIMvn6Nv8PIxB7eRmIM2h3xWKgxsmX+tet1+K iSvSYM3d4qJYxNRM4UCKcbrUZXW0Js1oDb0Ma3Q410DszENslDZueDyvSFFoXL3kxJgP fWj24+glcE9CYFzzhngS5QSXPSeiYF57dLG398A3779MuDaacSxWob4X8MX8xMY8FSMW glh+TVdaE7sgVeCY/gUpUHucQaXQqID6uMgCSupVHDZ4fc6KqJNS/vvdZfCCzmALWET7 dNXA== X-Gm-Message-State: ACgBeo1J30UufDt2EEK30exe3Vw9cGE7b5nZsuon+uHAHtxoM1Rx4r4Q BuNkudcrX2VxmcyULZdih8EGbg== X-Google-Smtp-Source: AA6agR7XEt/HJ/k3HAKtCMICn0MmET4kycwS554nxvopStvc3/5uFdV66pz7zYk7eLXXULU8iWeBFw== X-Received: by 2002:a5d:44c8:0:b0:21e:b750:2bda with SMTP id z8-20020a5d44c8000000b0021eb7502bdamr351862wrr.338.1660249999075; Thu, 11 Aug 2022 13:33:19 -0700 (PDT) Received: from henark71.. ([109.76.58.63]) by smtp.gmail.com with ESMTPSA id i12-20020adfefcc000000b0021f1ec8776fsm86643wrp.61.2022.08.11.13.33.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Aug 2022 13:33:18 -0700 (PDT) From: Conor Dooley To: Daire McNamara , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Greentime Hu , Palmer Dabbelt , Albert Ou , Lorenzo Pieralisi , Conor Dooley Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH 3/4] dt-bindings: PCI: microchip,pcie-host: fix incorrect child node name Date: Thu, 11 Aug 2022 21:33:06 +0100 Message-Id: <20220811203306.179744-4-mail@conchuod.ie> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220811203306.179744-1-mail@conchuod.ie> References: <20220811203306.179744-1-mail@conchuod.ie> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220811_133319_765730_45CC9F44 X-CRM114-Status: GOOD ( 12.96 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org From: Conor Dooley v2022.08 of dt-schema improved checking of unevaluatedProperties, and exposed a previously unseen warning for the PCIe controller's interrupt controller node name: arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dtb: pcie@2000000000: Unevaluated properties are not allowed ('clock-names', 'clocks', 'legacy-interrupt-controller', 'microchip,axi-m-atr0' were unexpected) From schema: Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml Make the property in the binding match the node name actually used in the dts. Fixes: dcd49679fb3a ("dt-bindings: PCI: Fix 'unevaluatedProperties' warnings") Signed-off-by: Conor Dooley --- This is another one Rob where I feel like I'm doing the wrong thing. The Linux driver gets the child node without using the name, but another OS etc could in theory (or reality), right? --- .../devicetree/bindings/pci/microchip,pcie-host.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml b/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml index 2a2166f09e2c..9b123bcd034c 100644 --- a/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml +++ b/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml @@ -71,7 +71,7 @@ properties: msi-parent: description: MSI controller the device is capable of using. - interrupt-controller: + legacy-interrupt-controller: type: object properties: '#address-cells': @@ -125,7 +125,7 @@ examples: msi-controller; bus-range = <0x00 0x7f>; ranges = <0x03000000 0x0 0x78000000 0x0 0x78000000 0x0 0x04000000>; - pcie_intc0: interrupt-controller { + pcie_intc0: legacy-interrupt-controller { #address-cells = <0>; #interrupt-cells = <1>; interrupt-controller; From patchwork Thu Aug 11 20:33:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Conor Dooley X-Patchwork-Id: 12941725 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37F6BC19F2A for ; Thu, 11 Aug 2022 20:33:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H1k1GlFcz2645grfis68UHUXE8xqFAj6uV3C00Plw/Y=; b=DFkoAvFQKjGJRC AGpYLXt9m8qOlt9xbEcOd31x42UHbIk1IwKQ8phKlhV6CfTlLvOdEHcDRBF2GPBkN1reccf55Olae loAXfYXQftjdlJXC3LqXlX9LGbmbpafP+A8rP145Z5j/bZ0E64iTN/V55gvoUxfEmXkzQBcqOe2tl +GA6raVeYK96pkThTmKwbAlJ63WuBqOVLjLrcIxPlRk72TPxZLBnSr5zXTiP2uO5zlyeTXPL7Jxsz DqoD/OO+H1UMA5IVD1CE0RhyOHcY+xeLaLtd1UNaf7gb1J4jDbWh0xm8rO7svc0QzqKpjKe8GnvG9 wqatkjEMM0lDvXk32+oQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMErv-0056bv-1f; Thu, 11 Aug 2022 20:33:27 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMErp-0056WP-Dv for linux-riscv@lists.infradead.org; Thu, 11 Aug 2022 20:33:23 +0000 Received: by mail-wr1-x429.google.com with SMTP id n4so20781425wrp.10 for ; Thu, 11 Aug 2022 13:33:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=conchuod.ie; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=ClSH5MXXgUZguA19Coz32EYS83xElJy9jIFIyLAmeC4=; b=HHhe+yarKbkwIYZ1mXaOthZ0VXyo310D1cBk8s8PGKXtS+FAnYRo1gNG6ylVj/7gLo BD1+qLMXw3jHjaKmycrt6e1OAv4CCWriwslsnWnsihoR/ceQgpKaw/ZZ6agol8h0tpdV l02Ole49suUd2QEsa7+uNZY+ANEboqWovjQ41L3onQLVlcUDQTarQNGtsJLt8FArM1MM H2MDT+rXQSH4wqI56vlK6Bwt19CVBV2XqoaYwT8ClmSccYovi+z7rS+pap22DWMy7KMA jJBA8lhBOgEw9qEA4SepES7pXBFrOAfewHEorcKXkVi7YaO9c1U7I4skrO+n+EWweBdU rtFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=ClSH5MXXgUZguA19Coz32EYS83xElJy9jIFIyLAmeC4=; b=uzrXMi2WuyaMrfPigUmynb/MjEYBGttAeUoOuFCvKzHItg/3DL9OnzJ7zx/cJTmRVI gsk02N+7xz2Sv31EVGn9afCkUaPN0Fh+h4c+I6eNwlSW6Tij3+yWVROQfuABFXW7Sfdp G2+cHX8vq3a7KkeFhFQhAoTPl1wjZjbHeGJRrVRs8K2foXQqEELgL5jMxjDnsIrAnNGn RTma1lQ1a7dbRZTaYMyC1NuSCUfQtSCDKWOyc6gv46Br8gXo4plhXS3PDMgFlRJthjrp 9c0TdAERjS9YLj4eKIjynMhtDvYD9llW4nefIxEzWdqNWOEiFHNtHJ3B2VG7ir8Rbc8W eQew== X-Gm-Message-State: ACgBeo2JxDqIQZsqq73us/GQzlOI/5xOOzPywo3B9JiUqvlfN6EZcXTH VHEdigxyqQE+E5Hj2/OgPB8/ug== X-Google-Smtp-Source: AA6agR4uUqIg2eHjtpt4HwLt+LlA2AAP/WjAN+bsQ7P2wHGzFMVwBV3+ZG92fs39ZgDOkKMy3JKrZg== X-Received: by 2002:a5d:4345:0:b0:21a:3b82:ad57 with SMTP id u5-20020a5d4345000000b0021a3b82ad57mr361149wrr.176.1660250000231; Thu, 11 Aug 2022 13:33:20 -0700 (PDT) Received: from henark71.. ([109.76.58.63]) by smtp.gmail.com with ESMTPSA id i12-20020adfefcc000000b0021f1ec8776fsm86643wrp.61.2022.08.11.13.33.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Aug 2022 13:33:19 -0700 (PDT) From: Conor Dooley To: Daire McNamara , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Greentime Hu , Palmer Dabbelt , Albert Ou , Lorenzo Pieralisi , Conor Dooley Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH 4/4] dt-bindings: PCI: microchip,pcie-host: fix missing address translation property Date: Thu, 11 Aug 2022 21:33:07 +0100 Message-Id: <20220811203306.179744-5-mail@conchuod.ie> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220811203306.179744-1-mail@conchuod.ie> References: <20220811203306.179744-1-mail@conchuod.ie> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220811_133321_495097_4238CDE1 X-CRM114-Status: GOOD ( 13.84 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org From: Conor Dooley When the PCI controller node was added to the PolarFire SoC dtsi, dt-schema was not able to detect the presence of some undocumented properties due to how it handled unevaluatedProperties. v2022.08 introduces better validation, producing the following error: arch/riscv/boot/dts/microchip/mpfs-polarberry.dtb: pcie@2000000000: Unevaluated properties are not allowed ('clock-names', 'microchip,axi-m-atr0' were unexpected) From schema: Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml Fixes: 528a5b1f2556 ("riscv: dts: microchip: add new peripherals to icicle kit device tree") Signed-off-by: Conor Dooley --- I feel like there's a pretty good chance that this is not the way this should have been done and the property should be marked as deprecated but I don't know enough about PCI to answer that. --- .../devicetree/bindings/pci/microchip,pcie-host.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml b/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml index 9b123bcd034c..9ac34b33c4b2 100644 --- a/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml +++ b/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml @@ -71,6 +71,17 @@ properties: msi-parent: description: MSI controller the device is capable of using. + microchip,axi-m-atr0: + description: | + Depending on the FPGA bitstream, the AXIM address translation table in the + PCIe controllers bridge layer may need to be configured. Use this property + to set the address offset. For more information, see Section 1.3.3, + "PCIe/AXI4 Address Translation" of the PolarFire SoC PCIe User Guide: + https://www.microsemi.com/document-portal/doc_download/1245812-polarfire-fpga-and-polarfire-soc-fpga-pci-express-user-guide + $ref: /schemas/types.yaml#/definitions/uint32-matrix + minItems: 2 + maxItems: 2 + legacy-interrupt-controller: type: object properties: