From patchwork Fri Aug 12 00:03:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William McVicker X-Patchwork-Id: 12941822 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C164BC25B06 for ; Fri, 12 Aug 2022 00:03:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231131AbiHLADs (ORCPT ); Thu, 11 Aug 2022 20:03:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230006AbiHLADq (ORCPT ); Thu, 11 Aug 2022 20:03:46 -0400 Received: from mail-pg1-x549.google.com (mail-pg1-x549.google.com [IPv6:2607:f8b0:4864:20::549]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74FBFA1D3B for ; Thu, 11 Aug 2022 17:03:44 -0700 (PDT) Received: by mail-pg1-x549.google.com with SMTP id p36-20020a634f64000000b0041bd62cd236so7035123pgl.14 for ; Thu, 11 Aug 2022 17:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc; bh=NBT3CxRHX8GEU/qW00McBn9/Bm/D8SvEDLg7/zkxpnw=; b=R7ZBOxLh8e6jgoMZZNtBAodQik+Ybr/ajqMr8g5jPxUz1F7EXoTKKbgb35JjsIKvc/ Cn52mq3L72OevluvYstxPbxV/kiU3ZSKLORU1SzkbwxVslO6c//gNDPkN1qnLAeyvyzs EKXHtqc13rtvW5vBm9xLCPzYVyWacq+nM736HfQzAMBnh/JuAWbPz8gJ+HzkIQARWwsJ eQXffAvoiWvMGmbx8PwvOR1J034fQZaAX4AOJL/Ufw/I5GXTYA/IOluApYWTxClcoiI0 aCpm2QJzFUT6x6uH+W2Y9SaWT08GlwFefbbtFVnnpHwXfl4yJASZZfJrYK7h7Jm4gsY5 oGng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc; bh=NBT3CxRHX8GEU/qW00McBn9/Bm/D8SvEDLg7/zkxpnw=; b=YUa1wQka+wsDy2j+2zYNGMB4++dZQXF36CfzMY3vvx1buhRHJ4w3OwOOfEYWbvXqQ8 WM2GsmgMdhq4mIVeneJsvCXkd7bUUujLuouo62H52tW4+5HX9pE/8syqa6CbTrWFrjIa O1oHDVRO8AyLWM8PEJTfXT1JKtfbuFPO2hgMkZchviP7rvch1Wd1ETxr+Yr0BDRN1JHU koDF9v+8y7iot4XcJUjR3DpuzzNZ0wFgv89fjxA8WH3HIR8sAFpurVCPl/K7pTPiNBIK O7fzmPs+u10o5Vcho4qjXnLM8blf2dqhUwjI3c4vWgbcrl1oQ4We/bMX/UWzStziD89g ojLA== X-Gm-Message-State: ACgBeo0YJtwTZD+xNT6NE4PXDH2F0VKiAagaOkF5L8hRPO4lUU78ptE6 Ce6kIqebVJsr21mq75fLe0VKHqq2UomXcJYOfNk= X-Google-Smtp-Source: AA6agR5AnKp+odWvzlCE0vwdUDiPYLBrfL3ynOsCqZwRUi6mSYS4Ae8XqnhvfS7rcEltrdemQERuIMDNocwEywECrDg= X-Received: from wmcvicker.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5ebe]) (user=willmcvicker job=sendgmr) by 2002:a63:4566:0:b0:41d:353:46b4 with SMTP id u38-20020a634566000000b0041d035346b4mr1135013pgk.316.1660262623928; Thu, 11 Aug 2022 17:03:43 -0700 (PDT) Date: Fri, 12 Aug 2022 00:03:25 +0000 In-Reply-To: <20220812000327.3154251-1-willmcvicker@google.com> Message-Id: <20220812000327.3154251-2-willmcvicker@google.com> Mime-Version: 1.0 References: <20220812000327.3154251-1-willmcvicker@google.com> X-Mailer: git-send-email 2.37.1.559.g78731f0fdb-goog Subject: [PATCH v4 1/2] PCI: dwc: Drop dependency on ZONE_DMA32 From: Will McVicker To: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Rob Herring , " =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= " , Bjorn Helgaas , Will McVicker Cc: kernel-team@android.com, Vidya Sagar , Christoph Hellwig , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, "Isaac J . Manjarres" Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Re-work the msi_msg DMA allocation logic to use dmam_alloc_coherent() which uses the coherent DMA mask to try to return an allocation within the DMA mask limits. With that, we now can drop the msi_page parameter in struct dw_pcie_rp. This allows kernel configurations that disable ZONE_DMA32 to continue supporting a 32-bit DMA mask. Without this patch, the PCIe host device will fail to probe when ZONE_DMA32 is disabled. Fixes: 35797e672ff0 ("PCI: dwc: Fix MSI msi_msg DMA mapping") Reported-by: Isaac J. Manjarres Signed-off-by: Will McVicker Acked-by: Jingoo Han Reviewed-by: Rob Herring --- .../pci/controller/dwc/pcie-designware-host.c | 28 +++++-------------- drivers/pci/controller/dwc/pcie-designware.h | 1 - 2 files changed, 7 insertions(+), 22 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c index 7746f94a715f..39f3b37d4033 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -267,15 +267,6 @@ static void dw_pcie_free_msi(struct dw_pcie_rp *pp) irq_domain_remove(pp->msi_domain); irq_domain_remove(pp->irq_domain); - - if (pp->msi_data) { - struct dw_pcie *pci = to_dw_pcie_from_pp(pp); - struct device *dev = pci->dev; - - dma_unmap_page(dev, pp->msi_data, PAGE_SIZE, DMA_FROM_DEVICE); - if (pp->msi_page) - __free_page(pp->msi_page); - } } static void dw_pcie_msi_init(struct dw_pcie_rp *pp) @@ -336,6 +327,7 @@ static int dw_pcie_msi_host_init(struct dw_pcie_rp *pp) struct dw_pcie *pci = to_dw_pcie_from_pp(pp); struct device *dev = pci->dev; struct platform_device *pdev = to_platform_device(dev); + u64 *msi_vaddr; int ret; u32 ctrl, num_ctrls; @@ -375,22 +367,16 @@ static int dw_pcie_msi_host_init(struct dw_pcie_rp *pp) dw_chained_msi_isr, pp); } - ret = dma_set_mask(dev, DMA_BIT_MASK(32)); + ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32)); if (ret) dev_warn(dev, "Failed to set DMA mask to 32-bit. Devices with only 32-bit MSI support may not work properly\n"); - pp->msi_page = alloc_page(GFP_DMA32); - pp->msi_data = dma_map_page(dev, pp->msi_page, 0, - PAGE_SIZE, DMA_FROM_DEVICE); - ret = dma_mapping_error(dev, pp->msi_data); - if (ret) { - dev_err(pci->dev, "Failed to map MSI data\n"); - __free_page(pp->msi_page); - pp->msi_page = NULL; - pp->msi_data = 0; + msi_vaddr = dmam_alloc_coherent(dev, sizeof(u64), &pp->msi_data, + GFP_KERNEL); + if (!msi_vaddr) { + dev_err(dev, "Failed to alloc and map MSI data\n"); dw_pcie_free_msi(pp); - - return ret; + return -ENOMEM; } return 0; diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h index 09b887093a84..a871ae7eb59e 100644 --- a/drivers/pci/controller/dwc/pcie-designware.h +++ b/drivers/pci/controller/dwc/pcie-designware.h @@ -243,7 +243,6 @@ struct dw_pcie_rp { struct irq_domain *irq_domain; struct irq_domain *msi_domain; dma_addr_t msi_data; - struct page *msi_page; struct irq_chip *msi_irq_chip; u32 num_vectors; u32 irq_mask[MAX_MSI_CTRLS]; From patchwork Fri Aug 12 00:03:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William McVicker X-Patchwork-Id: 12941823 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4910C25B0F for ; Fri, 12 Aug 2022 00:03:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235278AbiHLADw (ORCPT ); Thu, 11 Aug 2022 20:03:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236336AbiHLADw (ORCPT ); Thu, 11 Aug 2022 20:03:52 -0400 Received: from mail-pg1-x549.google.com (mail-pg1-x549.google.com [IPv6:2607:f8b0:4864:20::549]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E16E6A1D64 for ; Thu, 11 Aug 2022 17:03:49 -0700 (PDT) Received: by mail-pg1-x549.google.com with SMTP id p36-20020a634f64000000b0041bd62cd236so7035189pgl.14 for ; Thu, 11 Aug 2022 17:03:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc; bh=m7527aFul0HrbbuBntbmDHrqSY870ZpVEAPOl+klW5o=; b=KIzkL7W7UcyQgNv7j41yw7gXPlbta5vSpM+sLv64+9h8DeJlVxAFUP4cNJqnkH7jiE fjD5f4ZAtMqMV36gCGWr64gjAYsHT6/5ZSj2aaESnktuYOn0CLmj1TUNuytsh/lqrLcr 3JD3LXT2HFLoGXq3gMVO5VkpFuhQ1U10zusjtdPPxfCLxAtz/UNW7O8GbYlIm8xkN2jW ommfgot9guR5ctGtIINhWDApgcjLbTopVtpHgvaA5u3AcugNDZ6Vt+Ru7RN2e9dsUQOg OqoJm7V46OXlZfilSW4vVe5nO+JqPu70Gs5c60X7c7L6nkh13HywJHWbO9w9Dfp0QiWN fR4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc; bh=m7527aFul0HrbbuBntbmDHrqSY870ZpVEAPOl+klW5o=; b=J2f5vnmmOxiieUMt+FCGlYGb/3HTTO6vC2y0SstZ3rUmVxM3/vIi+ZqgfZbaT0d4Wk Sn9jMJ9GB7k2/Yqass+nvf/hUjYM/mXMWq7jHtI0Q7PrwRloZkh8U4qKJAjfQeXp164X AXUqUPajsaEqNxR5bDqYAcW7PAyWOEd/fVIQbmEKy0TErwIR4WRdJem07HvcCmY0uhTK Sei875D114xYLrN4ovsAWrNm/Ld0CrYDmHmAzFPbvo6HzIHBpq1GsOKlw6y9wndcINli 9EPske7vtLqJ+t2PzR71YKF8QXaD8sGrRG5KsHy0SAynkUe6p1PfTLeYVDVEsmXqXMJ9 LZWw== X-Gm-Message-State: ACgBeo3U21odnBcJAoxFSKGviL7pJ8SE6f59Vt6xd8hUn/aiSCQwwjQD WkgVM2AdBqi5eyt7fZ21H6i6yP3ARtXF4UKKDcM= X-Google-Smtp-Source: AA6agR4FCxLHclqHp4BxLS20+HY/XXK8unbv97uKxD3lFIZ6owNRBOayEEByxcRkhZAknDX36DmOhm30IVxmS2LOV3E= X-Received: from wmcvicker.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5ebe]) (user=willmcvicker job=sendgmr) by 2002:a05:6a00:23d3:b0:52e:27c8:b8f3 with SMTP id g19-20020a056a0023d300b0052e27c8b8f3mr1476118pfc.43.1660262629361; Thu, 11 Aug 2022 17:03:49 -0700 (PDT) Date: Fri, 12 Aug 2022 00:03:26 +0000 In-Reply-To: <20220812000327.3154251-1-willmcvicker@google.com> Message-Id: <20220812000327.3154251-3-willmcvicker@google.com> Mime-Version: 1.0 References: <20220812000327.3154251-1-willmcvicker@google.com> X-Mailer: git-send-email 2.37.1.559.g78731f0fdb-goog Subject: [PATCH v4 2/2] PCI: dwc: Add support for 64-bit MSI target address From: Will McVicker To: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Rob Herring , " =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= " , Bjorn Helgaas , Will McVicker Cc: kernel-team@android.com, Vidya Sagar , Christoph Hellwig , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Since not all devices require a 32-bit MSI address, add support to the PCIe host driver to allow setting the DMA mask to 64-bits. This allows kernels to disable ZONE_DMA32 and bounce buffering (swiotlb) without risking not being able to get a 32-bit address during DMA allocation. Basically, in the slim chance that there are no 32-bit allocations available, the current PCIe host driver will fail to allocate the msi_msg page due to a DMA address overflow (seen in [1]). With this patch, the PCIe device can advertise 64-bit support via its MSI capabilities to hint to the PCIe host driver to set the DMA mask to 64-bits. [1] https://lore.kernel.org/all/Yo0soniFborDl7+C@google.com/ Reported-by: kernel test robot Signed-off-by: Will McVicker Reviewed-by: Rob Herring Acked-by: Jingoo Han --- drivers/pci/controller/dwc/pcie-designware-host.c | 14 ++++++++++++-- drivers/pci/controller/dwc/pcie-designware.c | 8 ++++++++ drivers/pci/controller/dwc/pcie-designware.h | 1 + 3 files changed, 21 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c index 39f3b37d4033..d7831040791b 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -330,6 +330,8 @@ static int dw_pcie_msi_host_init(struct dw_pcie_rp *pp) u64 *msi_vaddr; int ret; u32 ctrl, num_ctrls; + bool msi_64bit = false; + u16 msi_capabilities; for (ctrl = 0; ctrl < MAX_MSI_CTRLS; ctrl++) pp->irq_mask[ctrl] = ~0; @@ -367,9 +369,17 @@ static int dw_pcie_msi_host_init(struct dw_pcie_rp *pp) dw_chained_msi_isr, pp); } - ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32)); + msi_capabilities = dw_pcie_msi_capabilities(pci); + if (msi_capabilities & PCI_MSI_FLAGS_ENABLE) + msi_64bit = msi_capabilities & PCI_MSI_FLAGS_64BIT; + + dev_dbg(dev, "Setting MSI DMA mask to %s-bit.\n", + msi_64bit ? "64" : "32"); + ret = dma_set_mask_and_coherent(dev, msi_64bit ? + DMA_BIT_MASK(64) : DMA_BIT_MASK(32)); if (ret) - dev_warn(dev, "Failed to set DMA mask to 32-bit. Devices with only 32-bit MSI support may not work properly\n"); + dev_warn(dev, "Failed to set DMA mask to %s-bit.\n", + msi_64bit ? "64" : "32"); msi_vaddr = dmam_alloc_coherent(dev, sizeof(u64), &pp->msi_data, GFP_KERNEL); diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c index c6725c519a47..650a7f22f9d0 100644 --- a/drivers/pci/controller/dwc/pcie-designware.c +++ b/drivers/pci/controller/dwc/pcie-designware.c @@ -82,6 +82,14 @@ u8 dw_pcie_find_capability(struct dw_pcie *pci, u8 cap) } EXPORT_SYMBOL_GPL(dw_pcie_find_capability); +u16 dw_pcie_msi_capabilities(struct dw_pcie *pci) +{ + u8 offset; + + offset = dw_pcie_find_capability(pci, PCI_CAP_ID_MSI); + return dw_pcie_readw_dbi(pci, offset + PCI_MSI_FLAGS); +} + static u16 dw_pcie_find_next_ext_capability(struct dw_pcie *pci, u16 start, u8 cap) { diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h index a871ae7eb59e..45fcdfc8c035 100644 --- a/drivers/pci/controller/dwc/pcie-designware.h +++ b/drivers/pci/controller/dwc/pcie-designware.h @@ -332,6 +332,7 @@ void dw_pcie_version_detect(struct dw_pcie *pci); u8 dw_pcie_find_capability(struct dw_pcie *pci, u8 cap); u16 dw_pcie_find_ext_capability(struct dw_pcie *pci, u8 cap); +u16 dw_pcie_msi_capabilities(struct dw_pcie *pci); int dw_pcie_read(void __iomem *addr, int size, u32 *val); int dw_pcie_write(void __iomem *addr, int size, u32 val);