From patchwork Wed Aug 17 22:43:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sripada, Radhakrishna" X-Patchwork-Id: 12946549 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DECDBC25B08 for ; Wed, 17 Aug 2022 22:44:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 13CED8B686; Wed, 17 Aug 2022 22:43:53 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id BB634AF005 for ; Wed, 17 Aug 2022 22:43:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660776215; x=1692312215; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=pC6stzxX5sFmw5jRZ4YBWcV3Dx2qRscfF/Hrwl1u07g=; b=ju4cu6pPAjENUGJ4fVqz358mAhU1/q3jmuIP1Qwiaw8fJay0+tyzV+Rq CJX4K/J8Uy6tyyMDNjMxH47MWslS9hMoEp4tuEyMxXoNVwy5VZNO3Nogj KRrise9MS5H62okkeWr7rPLiJXVoLXvVVAfRmpbw7WL7rPzQdLK+rwpnE pvOeswMlu1oIsu1e03gRAZKGx8HjZ3VYvNSpTXeqD36VCt9p+qKMdneLB b6VYBB3tDrHQ4Q4tviLn0DietvqkK2CBtCBWOEPsKbDAl8RZ9Jf2GeRS6 jKw9aVGb0Hl5YsyH3j4Btw+BK3XTjF57CIDgqAuYEKsn6OArLlR+oJR7l Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10442"; a="318633549" X-IronPort-AV: E=Sophos;i="5.93,244,1654585200"; d="scan'208";a="318633549" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2022 15:43:33 -0700 X-IronPort-AV: E=Sophos;i="5.93,244,1654585200"; d="scan'208";a="583952520" Received: from invictus.jf.intel.com ([10.165.21.205]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2022 15:43:33 -0700 From: Radhakrishna Sripada To: intel-gfx@lists.freedesktop.org Date: Wed, 17 Aug 2022 15:43:04 -0700 Message-Id: <20220817224304.255767-1-radhakrishna.sripada@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH] drm/i915: Skip Bit12 fw domain reset for gen12+ X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Bit12 of the Forcewake request register should not be cleared post gen12. Do not touch this bit while clearing during fw domain reset. Bspec: 52542 Signed-off-by: Sushma Venkatesh Reddy Signed-off-by: Radhakrishna Sripada Reviewed-by: Matt Roper --- drivers/gpu/drm/i915/intel_uncore.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c index a852c471d1b3..c85e2b686c95 100644 --- a/drivers/gpu/drm/i915/intel_uncore.c +++ b/drivers/gpu/drm/i915/intel_uncore.c @@ -113,7 +113,10 @@ fw_domain_reset(const struct intel_uncore_forcewake_domain *d) * off in ICL+), so no waiting for acks */ /* WaRsClearFWBitsAtReset:bdw,skl */ - fw_clear(d, 0xffff); + if (GRAPHICS_VER(d->uncore->i915) >= 12) + fw_clear(d, 0xefff); + else + fw_clear(d, 0xffff); } static inline void