From patchwork Thu Aug 18 21:01:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 12947934 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C61F2C3F6B0 for ; Thu, 18 Aug 2022 21:11:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346404AbiHRVLQ (ORCPT ); Thu, 18 Aug 2022 17:11:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346061AbiHRVKO (ORCPT ); Thu, 18 Aug 2022 17:10:14 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD620D86EF for ; Thu, 18 Aug 2022 14:04:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=k1; bh=zNGcWev70U81AfNj3MHIhMt6tSn 8ybmmrIoMJ2Wbglw=; b=FSZcJs/QEO9ZGSTQUdwjb09kDFUNFxCsfyDzz04pabz gqu9qlKN4lidhikPy8qqLzTshZQuRCC0+pows9ElkJDy7IZl90ukCFgMhlffNclQ tF9SY2Fcp6iJLUprkWyyvS/NSl7QNR/XeXFd+vg/0PU+K2p1V2fSKIabM+7oaeM4 = Received: (qmail 3962382 invoked from network); 18 Aug 2022 23:01:47 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 18 Aug 2022 23:01:47 +0200 X-UD-Smtp-Session: l3s3148p1@pEEfSormjO0ucref From: Wolfram Sang To: linux-kernel@vger.kernel.org Cc: Wolfram Sang , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , linux-nfs@vger.kernel.org Subject: [PATCH] lockd: move from strlcpy with unused retval to strscpy Date: Thu, 18 Aug 2022 23:01:46 +0200 Message-Id: <20220818210146.7963-1-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ Signed-off-by: Wolfram Sang --- fs/lockd/host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/lockd/host.c b/fs/lockd/host.c index f802223e71ab..cdc8e12cdac4 100644 --- a/fs/lockd/host.c +++ b/fs/lockd/host.c @@ -164,7 +164,7 @@ static struct nlm_host *nlm_alloc_host(struct nlm_lookup_host_info *ni, host->h_addrbuf = nsm->sm_addrbuf; host->net = ni->net; host->h_cred = get_cred(ni->cred); - strlcpy(host->nodename, utsname()->nodename, sizeof(host->nodename)); + strscpy(host->nodename, utsname()->nodename, sizeof(host->nodename)); out: return host;