From patchwork Mon Aug 22 05:36:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: CGEL X-Patchwork-Id: 12950199 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73242C28D13 for ; Mon, 22 Aug 2022 05:37:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4C396B0073; Mon, 22 Aug 2022 01:37:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFAF06B0074; Mon, 22 Aug 2022 01:37:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC275940007; Mon, 22 Aug 2022 01:37:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ACDCB6B0073 for ; Mon, 22 Aug 2022 01:37:00 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 86E05120C34 for ; Mon, 22 Aug 2022 05:37:00 +0000 (UTC) X-FDA: 79826119800.07.8147D0B Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf26.hostedemail.com (Postfix) with ESMTP id 3286214009C for ; Mon, 22 Aug 2022 05:37:00 +0000 (UTC) Received: by mail-pl1-f182.google.com with SMTP id v23so3670860plo.9 for ; Sun, 21 Aug 2022 22:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=p9b3HF7NOO+RGMYMFh1iU6dTss0goYi3FrKED6tvlcI=; b=R4z8h19vGmoWgMalE+Csm4ISmIjwSwIFYcqGhUV1/f6isNdEiwlOuDT6pH1AAS0HkM UYxEDcnavfzk8uSEPZqxsLr9jy2yJ8xpGRnDtT271Nu0zJQ9a1NUbwmMwycLkHx0dEtT U7DPL8MdobB5I4vGacq2PKdeu7+RptHHNIAYAVI4ls2TlX8wvEw/TW6bBk0f4zWSncFV 1Ht+Oh0SDdUoYDkw4m9dCVpmSF8jnlhXkCz7z8PgESLnvoXEq/mkmKs33jDPExDj4LGm rHiTMQ0ZJSIvLIuNO+XrX3+QoIaeZPFegHC0gykFz2Sh3i1ipF00yejDsBtcGzZu5U0o hOgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=p9b3HF7NOO+RGMYMFh1iU6dTss0goYi3FrKED6tvlcI=; b=KatKsVM65wrf3uUWjCa0QNT0wMklfKNKTG7DIaxMJOjpLotbdsjX00iS+wqPCWZzdv BpT4u83+a/XXz7Hgy8Ulbtwqgn+GU5ePl3QKCMrnmtY4Lk8HebJ9E6xMXtHBhN60nY2v 3hp3W4MyzH28Gf149nXevjwP86l50AyS5fgOCnpRp1v3NGa815Y2Wm+QiMc7I4eEWfh0 k4A3tcAHWqrxtjq8j3/+VHKhs7XkWlL0NCeb4o3GMXDiopcbkXeAyuMAo2tasVoazSJc yDvYi2DO0Wvoo6s9gNfCajQI0qo1HWaRM5nmv+N/ET8bzowZpjVFzsLgB1aarpwejdQw LEjg== X-Gm-Message-State: ACgBeo3VBviCh2TLUvOtorRZtzdaRdpUwKxhFJwPq9Nq2ZRlRbu0gxOc vMx2iyze5WU8UbbRBaSQmwY= X-Google-Smtp-Source: AA6agR5Ww4o26uoqIbG6IVhMRsgZLAx2riNOYto8gOgOZcu6mYdhoN4+8wXvBPXZo+xpg2PT0f4M1Q== X-Received: by 2002:a17:90b:4a07:b0:1f5:1aff:4ab with SMTP id kk7-20020a17090b4a0700b001f51aff04abmr27387328pjb.216.1661146619187; Sun, 21 Aug 2022 22:36:59 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id a2-20020a170902ecc200b00172f3b76625sm435597plh.161.2022.08.21.22.36.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Aug 2022 22:36:58 -0700 (PDT) From: xu xin X-Google-Original-From: xu xin To: akpm@linux-foundation.org Cc: adobriyan@gmail.com, willy@infradead.org, hughd@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, xu xin , Xiaokai Ran , Yang Yang , CGEL ZTE Subject: [PATCH] ksm: count allocated ksm rmap_items for each process Date: Mon, 22 Aug 2022 05:36:53 +0000 Message-Id: <20220822053653.204150-1-xu.xin16@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661146620; a=rsa-sha256; cv=none; b=W94xE98xJc2CIHYFI5YiGP/qCGXJovfGoxjjLve8Fw3orYcisIZxkBQR3JXuL+apl1xcvj S5cLWtVsQQVA43nvc2rQKMmKkPY32rztOh/sabpIG8/yoBwshlj2mrI3TP7NQC2+EA7RsM CS9aVmB7jRxrLJbtk55lu7lgtHGW1yk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=R4z8h19v; spf=pass (imf26.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661146620; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=p9b3HF7NOO+RGMYMFh1iU6dTss0goYi3FrKED6tvlcI=; b=gPN50hKDUt0h+BgvbxX7BDdg8JHMvsSOzZB2kbKrHzFkJeKhhf0cao0Fa2+ebLnBDMi3vn 2wHzoxYtG08j/ntpaZkfCeJFwCeyCVC0VpM0g8ReVOalS/zhdJ748bPtmV+6RwFdkPl4A6 AVHy4vXQmIQ3HCOs0Lo1o16Kwv2yeHI= X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3286214009C X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=R4z8h19v; spf=pass (imf26.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: 96qy84qqh83kpqghd5kufepf8njt6r6o X-HE-Tag: 1661146620-701240 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: KSM can save memory by merging identical pages, but also can consume additional memory, because it needs to generate rmap_items to save each scanned page's brief rmap information. Some of these pages may be merged, but some may not be abled to be merged after being checked several times, which are unprofitable memory consumed. The information about whether KSM save memory or consume memory in system-wide range can be determined by the comprehensive calculation of pages_sharing, pages_shared, pages_unshared and pages_volatile. A simple approximate calculation: profit ≈ pages_sharing * sizeof(page) - (all_rmap_items) * sizeof(rmap_item); where all_rmap_items equals to the sum of pages_sharing, pages_shared, pages_unshared and pages_volatile. But we cannot calculate this kind of ksm profit inner single-process wide because the information of ksm rmap_item's number of a process is lacked. For user applications, if this kind of information could be obtained, it helps upper users know how beneficial the ksm-policy (like madvise) they are using brings, and then optimize their app code. For example, one application madvise 1000 pages as MERGEABLE, while only a few pages are really merged, then it's not cost-efficient. So we add a new interface /proc//ksm_alloced_items for each process to indicate the total allocated ksm rmap_items of this process. Signed-off-by: xu xin Reviewed-by: Xiaokai Ran Reviewed-by: Yang Yang Signed-off-by: CGEL ZTE --- fs/proc/base.c | 15 +++++++++++++++ include/linux/mm_types.h | 5 +++++ mm/ksm.c | 2 ++ 3 files changed, 22 insertions(+) diff --git a/fs/proc/base.c b/fs/proc/base.c index 93f7e3d971e4..b6317981492a 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -3196,6 +3196,19 @@ static int proc_pid_ksm_merging_pages(struct seq_file *m, struct pid_namespace * return 0; } +static int proc_pid_ksm_rmp_items(struct seq_file *m, struct pid_namespace *ns, + struct pid *pid, struct task_struct *task) +{ + struct mm_struct *mm; + + mm = get_task_mm(task); + if (mm) { + seq_printf(m, "%lu\n", mm->ksm_rmp_items); + mmput(mm); + } + + return 0; +} #endif /* CONFIG_KSM */ #ifdef CONFIG_STACKLEAK_METRICS @@ -3331,6 +3344,7 @@ static const struct pid_entry tgid_base_stuff[] = { #endif #ifdef CONFIG_KSM ONE("ksm_merging_pages", S_IRUSR, proc_pid_ksm_merging_pages), + ONE("ksm_rmp_items", S_IRUSR, proc_pid_ksm_rmp_items), #endif }; @@ -3668,6 +3682,7 @@ static const struct pid_entry tid_base_stuff[] = { #endif #ifdef CONFIG_KSM ONE("ksm_merging_pages", S_IRUSR, proc_pid_ksm_merging_pages), + ONE("ksm_rmp_items", S_IRUSR, proc_pid_ksm_rmp_items), #endif }; diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index cf97f3884fda..0b9e76275ea7 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -671,6 +671,11 @@ struct mm_struct { * merging. */ unsigned long ksm_merging_pages; + /* + * Represent how many pages are checked for ksm merging + * including merged and not merged. + */ + unsigned long ksm_rmp_items; #endif } __randomize_layout; diff --git a/mm/ksm.c b/mm/ksm.c index 478bcf26bfcd..fc9879d7049f 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -421,6 +421,7 @@ static inline struct rmap_item *alloc_rmap_item(void) static inline void free_rmap_item(struct rmap_item *rmap_item) { ksm_rmap_items--; + rmap_item->mm->ksm_rmp_items--; rmap_item->mm = NULL; /* debug safety */ kmem_cache_free(rmap_item_cache, rmap_item); } @@ -2265,6 +2266,7 @@ static struct rmap_item *get_next_rmap_item(struct mm_slot *mm_slot, if (rmap_item) { /* It has already been zeroed */ rmap_item->mm = mm_slot->mm; + rmap_item->mm->ksm_rmp_items++; rmap_item->address = addr; rmap_item->rmap_list = *rmap_list; *rmap_list = rmap_item;