From patchwork Fri Aug 26 09:20:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrice CHOTARD X-Patchwork-Id: 12955691 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA34CECAAA3 for ; Fri, 26 Aug 2022 09:21:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ojYUR5U5nS4dIj+8P/KMfstsQhfxvWS050CVirEUQ5A=; b=wjg+gzlSPMofEJ 2X35pakdus6d1gySUpNpCKI9EKR9T+XhTjUegYZ+RxeZ+04yousY6Brvrbjyfd71HZrEnCc/n+6/t gmwMGSJxhXDPBDk/S4W4RVglgTELrzJ08aaQrbmjKQRMAutp21pgXAFTxfcUM2vxF44afD11cEAhm yoTOjq58zVIVALDEbPaa7T4uDQcaZ3TWD8F/WaNMW+tl7MGfrgauX4lnmjGtmV6jWMMIHgr0iPCfE QBgcAgjvEvEZIu93Txc7YVd6j6fQBH14tLDK7Ff3o6pY+eE428PA3AHx68tivPzfCtCw/NttYP+VK STcopcDG6Lx9j3vi/gXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRVWC-000XoI-B7; Fri, 26 Aug 2022 09:20:48 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRVW8-000XZ5-Ba for linux-arm-kernel@lists.infradead.org; Fri, 26 Aug 2022 09:20:45 +0000 Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27Q8Zu33026109; Fri, 26 Aug 2022 11:20:37 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=selector1; bh=9gvdPpfWhML/QsrMl+pD+HweNQ2GBnbJdkoZ5Iv84OE=; b=ToHWX36CAKFH7oyw+nWMIgc2ZtUu86Ib9CXb1MMosmjcKgDsLygYEpnhVX+qyAN55yHg RHdycaPRDS290Lo87bCce91Q3XED7v1ha9Qb5pN5T+EGzueUFEe+T3LHKMPKRRGBauMX EdmmkRVj20OLpg+YLM93aOH+tHceAD6KF2aGFG8CCQLZRIsVe0YAqgnLOUo0kd1Qtzq5 zettMseds6zw08nPSM/p0JEdYqtXLLKonqIK+ipyDFHHtCKX0MTTEakbXNTzBX4ESckU JuY5KmgVX3/28OPT9SW+2yVE73VYYWa8XVfy1KL4F7186qZmo32d98Prz2r2ZdjL/jQ7 Cg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3j52b11hsu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Aug 2022 11:20:37 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 8068D10002A; Fri, 26 Aug 2022 11:20:36 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 7B403217B6D; Fri, 26 Aug 2022 11:20:36 +0200 (CEST) Received: from localhost (10.75.127.46) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Fri, 26 Aug 2022 11:20:36 +0200 From: To: Mark Brown CC: , , , , , , Dan Carpenter Subject: [PATCH] spi: stm32-qspi: Fix stm32_qspi_transfer_one_message() error path Date: Fri, 26 Aug 2022 11:20:31 +0200 Message-ID: <20220826092031.1393430-1-patrice.chotard@foss.st.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.75.127.46] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-26_04,2022-08-25_01,2022-06-22_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220826_022044_703954_F7E53FBA X-CRM114-Status: GOOD ( 15.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Patrice Chotard The patch a557fca630cc: "spi: stm32_qspi: Add transfer_one_message() spi callback" from Aug 23, 2022, leads to the following Smatch static checker warning: drivers/spi/spi-stm32-qspi.c:627 stm32_qspi_transfer_one_message() error: uninitialized symbol 'ret'.Fix the following Smatch static checker warning: Fixes: a557fca630cc ("spi: stm32_qspi: Add transfer_one_message() spi callback") Reported-by: Dan Carpenter Signed-off-by: Patrice Chotard --- drivers/spi/spi-stm32-qspi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index 92459daca95f..679fd1c34f7e 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -562,7 +562,7 @@ static int stm32_qspi_transfer_one_message(struct spi_controller *ctrl, struct spi_transfer *transfer; struct spi_device *spi = msg->spi; struct spi_mem_op op; - int ret; + int ret = 0; if (!spi->cs_gpiod) return -EOPNOTSUPP; @@ -592,8 +592,10 @@ static int stm32_qspi_transfer_one_message(struct spi_controller *ctrl, dummy_bytes = transfer->len; /* if happens, means that message is not correctly built */ - if (list_is_last(&transfer->transfer_list, &msg->transfers)) + if (list_is_last(&transfer->transfer_list, &msg->transfers)) { + ret = -EINVAL; goto end_of_transfer; + } transfer = list_next_entry(transfer, transfer_list); }