From patchwork Mon Sep 5 02:54:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neal Liu X-Patchwork-Id: 12966464 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86BAFECAAD3 for ; Mon, 5 Sep 2022 19:20:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=+XAetgXW1upyPOrkn2qxzQKEqP4Xd4/8OC10x620OYs=; b=UBdqWBOjBQcuwH oYIPD4W/ql06cUhfjvBWXbwtoRljL0o4roUWjh78Cp7LOBTLWTRcPxh10KyADlrxlJv3w/bNptkoA zkCNgIxbEhb1zTLOhyGXDt7oa7JmAnIjk8eqhNuXZkiZNuw8CvRb4Rm2xVY9Whp4nGQjCn8ZwKIFu +tjCEoi13HVIXKdYnwCz63zXxotE7uQ/psOmHPk9BBSz/fVoLDXdJIq1HYCiq6IOerJVXbTCA3nIO cd37XikfGaqRWQQPRHz6UZXgJaySXqj2pKU0SGfB+cGuWq5LLvUCJSgVzlnXYRsOfpNVfPVE8mvb1 g25eDE2BSZ+kDcg+dmfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVHcY-0097P7-Ga; Mon, 05 Sep 2022 19:18:59 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVGfB-008GWI-4O for linux-arm-kernel@bombadil.infradead.org; Mon, 05 Sep 2022 18:17:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Content-Transfer-Encoding :MIME-Version:Message-ID:Date:Subject:CC:To:From:Sender:Reply-To:Content-ID: Content-Description:In-Reply-To:References; bh=WKrML+bc0Oq0B8AiLXDlRM58wO8I9Wh3CXVXvpVA7sY=; b=LCU+3ky6pCpWMlzubV/sltPTV5 18lzx7ANIIgAXxT4EXC3IwPbfbKEEnSNcG6EgojSun1QgbJtvpjW5hjlhjh1LXZ7urrKS3EGidb7q boP8I2LeMNpC5RdKWgNAXHMaeedUVejH0vwzSnk037VdGjeKZ2aaMNsg94wfXRbUUPPHLTP9GUePC OM59KziPaGTP1fanqm2xLn/8jbJtvOlJGzdDja6b686LHaf3Pps1EMMfrtlyx9FiKfsc5pfAAPtJM 57GRuzgmCU+UqSgp9fCsqYH0XxBKfP286cS6P22r0y0scMC1uyT5dUh0LVjyCzPhbyQfEX0UlyXc9 RORi1a0g==; Received: from [211.20.114.71] (helo=twspam01.aspeedtech.com) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oV2Gt-009MbL-Mx for linux-arm-kernel@lists.infradead.org; Mon, 05 Sep 2022 02:55:39 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 2852YhcH045911; Mon, 5 Sep 2022 10:34:43 +0800 (GMT-8) (envelope-from neal_liu@aspeedtech.com) Received: from localhost.localdomain (192.168.10.10) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 5 Sep 2022 10:54:37 +0800 From: Neal Liu To: Herbert Xu , "David S . Miller" , Joel Stanley , Andrew Jeffery CC: , , , , , kernel test robot , Sudip Mukherjee Subject: [PATCH v2] crypto: aspeed: fix build module error Date: Mon, 5 Sep 2022 10:54:33 +0800 Message-ID: <20220905025433.1610696-1-neal_liu@aspeedtech.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [192.168.10.10] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 2852YhcH045911 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220905_035536_598973_5726C74C X-CRM114-Status: UNSURE ( 6.80 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If CONFIG_MODULES=y and CONFIG_CRYPTO_DEV_ASPEED=m, build modpost would be failed. Error messages: ERROR: modpost: "aspeed_register_hace_hash_algs" [drivers/crypto/aspeed/aspeed_crypto.ko] undefined! ERROR: modpost: "aspeed_unregister_hace_hash_algs" [drivers/crypto/aspeed/aspeed_crypto.ko] undefined! Change build sequence to fix this. Reported-by: kernel test robot Signed-off-by: Neal Liu Tested-by: Sudip Mukherjee --- v2: Remove redundant obj- lines. drivers/crypto/aspeed/Makefile | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/aspeed/Makefile b/drivers/crypto/aspeed/Makefile index 421e2ca9c53e..3be78cec0ecb 100644 --- a/drivers/crypto/aspeed/Makefile +++ b/drivers/crypto/aspeed/Makefile @@ -1,9 +1,6 @@ +hace-hash-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_HASH) := aspeed-hace.o aspeed-hace-hash.o +hace-crypto-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO) := aspeed-hace.o aspeed-hace-crypto.o + obj-$(CONFIG_CRYPTO_DEV_ASPEED) += aspeed_crypto.o -aspeed_crypto-objs := aspeed-hace.o \ - $(hace-hash-y) \ +aspeed_crypto-objs := $(hace-hash-y) \ $(hace-crypto-y) - -obj-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_HASH) += aspeed-hace-hash.o -hace-hash-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_HASH) := aspeed-hace-hash.o -obj-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO) += aspeed-hace-crypto.o -hace-crypto-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO) := aspeed-hace-crypto.o