From patchwork Fri Sep 23 10:38:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Westphal X-Patchwork-Id: 12986427 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9298FC6FA82 for ; Fri, 23 Sep 2022 10:39:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D52CE80008; Fri, 23 Sep 2022 06:39:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D02B080007; Fri, 23 Sep 2022 06:39:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF12A80008; Fri, 23 Sep 2022 06:39:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AC87B80007 for ; Fri, 23 Sep 2022 06:39:10 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8A1A3ABC95 for ; Fri, 23 Sep 2022 10:39:10 +0000 (UTC) X-FDA: 79943002860.04.0E9A1CE Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [193.142.43.52]) by imf01.hostedemail.com (Postfix) with ESMTP id 3495F40012 for ; Fri, 23 Sep 2022 10:39:10 +0000 (UTC) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1obg5L-0004UW-7n; Fri, 23 Sep 2022 12:39:07 +0200 From: Florian Westphal To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, vbabka@suse.cz, mhocko@suse.com, akpm@linux-foundation.org, urezki@gmail.com, , , Florian Westphal , Martin Zaharinov Subject: [PATCH mm] mm: fix BUG with kvzalloc+GFP_ATOMIC Date: Fri, 23 Sep 2022 12:38:58 +0200 Message-Id: <20220923103858.26729-1-fw@strlen.de> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663929550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=9aTLWLNRxI16i3MwOCEbhI3+St9uk9hU9MAKRL35DZ4=; b=5p2HfRgBC/thuEpAUOZKgkaLJy0c8AeJyvMdaWnV6ZhCQjcVtsC5ZlwQqFWZ8nzdKGK7SM 5dDNvaxKsek1txtPmb9Au4YR15ZlSah4Ugx1oeABr7o2FUjsiwpXTe5HA5EfOXaoz2emEr 5K5utWUZXCy8QO4tmdzJgUB/S5HaVuI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of fw@breakpoint.cc designates 193.142.43.52 as permitted sender) smtp.mailfrom=fw@breakpoint.cc ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663929550; a=rsa-sha256; cv=none; b=wqfsptUp1KXWZXFpyNvhJVWEKF0mHHyIzKsH4Ybawp5gBjh+nk2FFkau4goM/gkIZFyQqP XUkjV/EGMRQ3FA3ygi5GCK4MBwGjr/cvEXU64IpTzaEvS1cdjOrQLkTbNTr8RdKaLCjUbq pe50C/z7IEfpiqh19Fyx8i2ktJgGuN0= Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of fw@breakpoint.cc designates 193.142.43.52 as permitted sender) smtp.mailfrom=fw@breakpoint.cc X-Rspam-User: X-Stat-Signature: samt1dech5dqs9rz5txj18mpiup85jrr X-Rspamd-Queue-Id: 3495F40012 X-Rspamd-Server: rspam07 X-HE-Tag: 1663929549-906124 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Martin Zaharinov reports BUG() in mm land for 5.19.10 kernel: kernel BUG at mm/vmalloc.c:2437! invalid opcode: 0000 [#1] SMP CPU: 28 PID: 0 Comm: swapper/28 Tainted: G W O 5.19.9 #1 [..] RIP: 0010:__get_vm_area_node+0x120/0x130 __vmalloc_node_range+0x96/0x1e0 kvmalloc_node+0x92/0xb0 bucket_table_alloc.isra.0+0x47/0x140 rhashtable_try_insert+0x3a4/0x440 rhashtable_insert_slow+0x1b/0x30 [..] bucket_table_alloc uses kvzallocGPF_ATOMIC). If kmalloc fails, this now falls through to vmalloc and hits code paths that assume GFP_KERNEL. Revert the problematic change and stay with slab allocator. Reported-by: Martin Zaharinov Fixes: a421ef303008 ("mm: allow !GFP_KERNEL allocations for kvmalloc") Cc: Michal Hocko Link: https://lore.kernel.org/netdev/09BE0B8A-3ADF-458E-B75E-931B74996355@gmail.com/T/#u Signed-off-by: Florian Westphal --- mm/util.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/mm/util.c b/mm/util.c index c9439c66d8cf..ba7fe1cb6846 100644 --- a/mm/util.c +++ b/mm/util.c @@ -593,6 +593,13 @@ void *kvmalloc_node(size_t size, gfp_t flags, int node) gfp_t kmalloc_flags = flags; void *ret; + /* + * vmalloc uses GFP_KERNEL for some internal allocations (e.g page tables) + * so the given set of flags has to be compatible. + */ + if ((flags & GFP_KERNEL) != GFP_KERNEL) + return kmalloc_node(size, flags, node); + /* * We want to attempt a large physically contiguous block first because * it is less likely to fragment multiple larger blocks and therefore