From patchwork Sun Sep 25 23:08:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Le Moal X-Patchwork-Id: 12988145 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18D1BC04A95 for ; Sun, 25 Sep 2022 23:08:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231521AbiIYXI0 (ORCPT ); Sun, 25 Sep 2022 19:08:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229567AbiIYXIY (ORCPT ); Sun, 25 Sep 2022 19:08:24 -0400 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D8612982C for ; Sun, 25 Sep 2022 16:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1664147303; x=1695683303; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=l3JCm5qSZzb6ujJKtq3kEW3pKkqRShXgolJdPRSTV/o=; b=DQXv5DawfnknhUAMTwHkjdAZnKVRQjw1sBdNJIF2zfKGbHPhH4fPuB6a 4YA3CDAJxOWLMBdfZ872/LDgV6Yl47bFynjgvYZJfLZay2o9hJ/jRyDKZ kM5UoNbKAmYas3AkDJ03/q6GpORsJt7AVZFMWqBkpy4bGvlMV98i/44BZ YmFXb0K2GU/ht2ey6O4WV65gdFqVpFpRiQZ8B1N2KtaIuZg2QfpXEaWDD H7wo28CCVoRFR5BipLAn3o2oUU+okUdjKxyV6pUFpulJh5A/t/hehAn0k HwFh37rC4Lpqfr0u9IMCojRF3k1Hu97Z9hpD7CJRPEimotV/eZuBtFv9k A==; X-IronPort-AV: E=Sophos;i="5.93,345,1654531200"; d="scan'208";a="217414823" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 26 Sep 2022 07:08:22 +0800 IronPort-SDR: 64x8uLkog3I970x2CfA8D3hJWCHi72D3yFE8KAwWAxHlMJP1XArAM/r5Eh3N+kdZifm51hjQG5 WWNUTacO3S5iKCGhQsWJyyYcqhCqxdKkuBqA1z5BlpEzFfj7OSxAw3UhLAVwl1zZXYEkpw3JDZ MCrpmaxaE1STQgimCjfrIrnAautyt6AudZexmB+JJW2qwNs7vrkg5bOS+gimsXlyixxKR/rMPU +TjcWo4Nnp3gqZpj0m92d42132TR4Gwa8tsmbcb4LoYGRODU9Y0DxlogGSF1ATT4G1sgNJCmfF UoIVcpj8smTkR8dlb6N7tjuc Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 Sep 2022 15:22:50 -0700 IronPort-SDR: EX+O3i1AOFXb5Bz2lvOqR5ppcGQMUCktI7KdcxibH5P7Xkmrvy3pXQ+Q4mTeQhc5p9NyyMYqFV 1l9qw0hvAWWIuffiyZx9yHycYWvmAVbec1f51CSNgGEpTQXxpTb3wNWnYnsNEJoBUbHEq+3eqB k3y6GkfOxxDfJtvPcZOrujlbYZqiKYUf54+LAY9X/XvnL2scO8VISOO7eTYYYHi3GVjuvG6sFB zQy5wma4gZr0q76T+gzk5R+acjfpBel6eCblUQgLp8MvyazmE4hgoqw9kJaMTp5GDsMCq72UJS ObY= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 Sep 2022 16:08:23 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4MbM4j56Hzz1Rwrq for ; Sun, 25 Sep 2022 16:08:21 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:mime-version :references:in-reply-to:x-mailer:message-id:date:subject:to :from; s=dkim; t=1664147301; x=1666739302; bh=l3JCm5qSZzb6ujJKtq 3kEW3pKkqRShXgolJdPRSTV/o=; b=D7/U/R+W/p6DOuXn7a1u53K0vWbysOvJ/n cHUYppCcKyy60ASrVJHM4JhIe+w7aa4QyPTBRxKQhp5GoKG0h/cBP1TP8T3KFONq SV0gEXQDqfHURBuHBB3HxUVbFiunrvtnIfTfKy8jWx3HtOvfGN3t0xPe7cAyD95S E+5hb1q+jE+caQnYQLLhT/SYsPiWh2IVVXkjteHRYumkYgiFcv4uU/nNEy4vHA1r LQ+tNAdyQvR6z6XFGDWWVTPdwGuaa4l33Iw/9dsW4RfT/UKBxO7xu4Qu4ApXc64m kOtwxy0w4GiM5h64FDKSvLizUZvPjVSE2bPQegaZTBciQ9RK8/xw== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id QUDpm4s-t7DU for ; Sun, 25 Sep 2022 16:08:21 -0700 (PDT) Received: from washi.fujisawa.hgst.com (washi.fujisawa.hgst.com [10.149.53.254]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4MbM4h4ChZz1RvTp; Sun, 25 Sep 2022 16:08:20 -0700 (PDT) From: Damien Le Moal To: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, "Martin K . Petersen" , John Garry Subject: [PATCH v2 1/2] ata: libata-scsi: Fix initialization of device queue depth Date: Mon, 26 Sep 2022 08:08:16 +0900 Message-Id: <20220925230817.91542-2-damien.lemoal@opensource.wdc.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220925230817.91542-1-damien.lemoal@opensource.wdc.com> References: <20220925230817.91542-1-damien.lemoal@opensource.wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org For SATA devices supporting NCQ, drivers using libsas first initialize a scsi device queue depth based on the controller and device capabilities, leading to the scsi device queue_depth field being 32 (ATA maximum queue depth) for most setup. However, if libata was loaded using the force=[ID]]noncq argument, the default queue depth should be set to 1 to reflect the fact that queuable commands will never be used. This is consistent with manually setting a device queue depth to 1 through sysfs as that disables NCQ use for the device. Fix ata_scsi_dev_config() to honor the noncq parameter by sertting the device queue depth to 1 for devices that do not have the ATA_DFLAG_NCQ flag set. Signed-off-by: Damien Le Moal --- drivers/ata/libata-scsi.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 29e2f55c6faa..ff9602a0e54e 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -1055,6 +1055,7 @@ EXPORT_SYMBOL_GPL(ata_scsi_dma_need_drain); int ata_scsi_dev_config(struct scsi_device *sdev, struct ata_device *dev) { struct request_queue *q = sdev->request_queue; + int depth = 1; if (!ata_id_has_unload(dev->id)) dev->flags |= ATA_DFLAG_NO_UNLOAD; @@ -1100,13 +1101,10 @@ int ata_scsi_dev_config(struct scsi_device *sdev, struct ata_device *dev) if (dev->flags & ATA_DFLAG_AN) set_bit(SDEV_EVT_MEDIA_CHANGE, sdev->supported_events); - if (dev->flags & ATA_DFLAG_NCQ) { - int depth; - + if (dev->flags & ATA_DFLAG_NCQ) depth = min(sdev->host->can_queue, ata_id_queue_depth(dev->id)); - depth = min(ATA_MAX_QUEUE, depth); - scsi_change_queue_depth(sdev, depth); - } + depth = min(ATA_MAX_QUEUE, depth); + scsi_change_queue_depth(sdev, depth); if (dev->flags & ATA_DFLAG_TRUSTED) sdev->security_supported = 1; From patchwork Sun Sep 25 23:08:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Le Moal X-Patchwork-Id: 12988146 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BD58C6FA86 for ; Sun, 25 Sep 2022 23:08:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231727AbiIYXI1 (ORCPT ); Sun, 25 Sep 2022 19:08:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231462AbiIYXIY (ORCPT ); Sun, 25 Sep 2022 19:08:24 -0400 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A23CF29C87 for ; Sun, 25 Sep 2022 16:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1664147303; x=1695683303; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=rWNJcFnvuOopT48ualRZvSFCvO4CnoU/GS9dq6m/Kps=; b=lez3LFjmpALh6MxbpkkYlulL94U7HSfNhVWRtsE4mclYu1zuWvrmrBgL 1KTRZy2uY27MvEsAUcW28KKTB46oEy7JhUOXq6hHudNk1jCeKN9YWMejq hYc7RgWvp1+6emR2EJRVlCdQF7KJVi6SrCcLTB2BEnB71iGJzQd8DqKHO rwrxS/7fZ1f975sAAzXYhuUaIFyPB33FFlX/2eexza94FHfCP+h7inKlC VidLxOc8bwTjbVqx5pPLW1KrrKqXgpwDybGmvGupsyGdHPEzdvqvmlAgQ JTamt338wbBdKfqFWWRSDYbd4EJdyZRYpGJbCgb6RXcQpg7weSdlC3NL4 w==; X-IronPort-AV: E=Sophos;i="5.93,345,1654531200"; d="scan'208";a="217414825" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 26 Sep 2022 07:08:23 +0800 IronPort-SDR: 3M8M69CA+ctC7VQWURCDYHB+vYze0vTZjCGaOUmwN+/TAIppOUs3o4dVobEJv7y6KVv4EkjZbX whHrbUsX0uAunX2O5wjcopma7R4qZHc8UDQr2WPGPcxqVuJjuCjmibfKZxh2L9z20Vs+iSOarS TkswnSgxjRZ0xaQb6nPMzQixzaI9sSgpgPCC6tRHpjSmodxDS6qPhGgeLs2E0HdBCezBQgDQQB q2Qy/GFoEThGL6RY0+31TPkpQGYPbcV74aDaiNIEI1kVh1XlNN9z5lFguCfhAD9fsIycBOEdCv 4Jp5JQVRV72gn4Jx+OmpidgN Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 Sep 2022 15:22:51 -0700 IronPort-SDR: YS7E/KCSBNzrJZqjV8HyEkaOk8bdC4RpDuRKK2fyNK9NhEcD3Ed6+CqRvLp2AO9Fkh9fG9uSJz BazBTQmdeXE31GMzI3d3AjM+FL+WBejcmoIKJ56HIg/v/Mej9QDv1kq5SIN8CR7B6rCLuy8Pgn 4YbZ9aXEytMmZxZMnDARhw+651OR7MtN8MGeHk3UJQV9RX34+GVjXqpFj2IPemFPKL85Wsd1+v 79Cw3ag79MAdJGpFMRn58v8vZAnNOb+aA0ip356oeFAuDM0T0vtFhYgg6qbk40hhloYBJ8nmP3 8jc= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 Sep 2022 16:08:24 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4MbM4k5Y53z1RvTr for ; Sun, 25 Sep 2022 16:08:22 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:mime-version :references:in-reply-to:x-mailer:message-id:date:subject:to :from; s=dkim; t=1664147302; x=1666739303; bh=rWNJcFnvuOopT48ual RZvSFCvO4CnoU/GS9dq6m/Kps=; b=Z8NwqTg+eMOgvIVDPgqjHFHVIcdAAbnZx4 UztvSOa71TfiJCJeuVwizSDkdEf4k9t2Zc07NuAmze2ejMLaWXzObFoHqgukbiO2 oEyYcSOaczu7J4K/RV3intyGqZKLyduoMdM9vSj+930QlDptgz4kGty21Rx3JVN+ dTmMuPs6mtjBrvl+R4LFJ99MaF2AqaJHrc6MgOd8D6j/LBoZTrOsLjxKb0qyWTH3 FyrVmbmCmzsKrYAcFBNKn4mI6zz2v/THqPYQeGyP+1OchOpb68PQ9qxuiKS2d9Pf cXhYydzmzDM99AC6tE++mV4PR8VCqsfSJVyU3ycGEUjJdPWVRA/g== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id SB1Rmkgz2hqo for ; Sun, 25 Sep 2022 16:08:22 -0700 (PDT) Received: from washi.fujisawa.hgst.com (washi.fujisawa.hgst.com [10.149.53.254]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4MbM4j3zYvz1RvLy; Sun, 25 Sep 2022 16:08:21 -0700 (PDT) From: Damien Le Moal To: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, "Martin K . Petersen" , John Garry Subject: [PATCH v2 2/2] ata: libata-sata: Fix device queue depth control Date: Mon, 26 Sep 2022 08:08:17 +0900 Message-Id: <20220925230817.91542-3-damien.lemoal@opensource.wdc.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220925230817.91542-1-damien.lemoal@opensource.wdc.com> References: <20220925230817.91542-1-damien.lemoal@opensource.wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org The function __ata_change_queue_depth() uses the helper ata_scsi_find_dev() to get the ata_device structure of a scsi device and set that device maximum queue depth. However, when the ata device is managed by libsas, ata_scsi_find_dev() returns NULL, turning __ata_change_queue_depth() into a nop, which prevents the user from setting the maximum queue depth of ATA devices used with libsas based HBAs. Fix this by renaming __ata_change_queue_depth() to ata_change_queue_depth() and adding a pointer to the ata_device structure of the target device as argument. This pointer is provided by ata_scsi_change_queue_depth() using ata_scsi_find_dev() in the case of a libata managed device and by sas_change_queue_depth() using sas_to_ata_dev() in the case of a libsas managed ata device. Signed-off-by: Damien Le Moal Tested-by: John Garry --- drivers/ata/libata-sata.c | 24 ++++++++++++------------ drivers/scsi/libsas/sas_scsi_host.c | 3 ++- include/linux/libata.h | 4 ++-- 3 files changed, 16 insertions(+), 15 deletions(-) diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c index 7a5fe41aa5ae..13b9d0fdd42c 100644 --- a/drivers/ata/libata-sata.c +++ b/drivers/ata/libata-sata.c @@ -1018,26 +1018,25 @@ DEVICE_ATTR(sw_activity, S_IWUSR | S_IRUGO, ata_scsi_activity_show, EXPORT_SYMBOL_GPL(dev_attr_sw_activity); /** - * __ata_change_queue_depth - helper for ata_scsi_change_queue_depth - * @ap: ATA port to which the device change the queue depth + * ata_change_queue_depth - Set a device maximum queue depth + * @ap: ATA port of the target device + * @dev: target ATA device * @sdev: SCSI device to configure queue depth for * @queue_depth: new queue depth * - * libsas and libata have different approaches for associating a sdev to - * its ata_port. + * Helper to set a device maximum queue depth, usable with both libsas + * and libata. * */ -int __ata_change_queue_depth(struct ata_port *ap, struct scsi_device *sdev, - int queue_depth) +int ata_change_queue_depth(struct ata_port *ap, struct ata_device *dev, + struct scsi_device *sdev, int queue_depth) { - struct ata_device *dev; unsigned long flags; - if (queue_depth < 1 || queue_depth == sdev->queue_depth) + if (!dev || !ata_dev_enabled(dev)) return sdev->queue_depth; - dev = ata_scsi_find_dev(ap, sdev); - if (!dev || !ata_dev_enabled(dev)) + if (queue_depth < 1 || queue_depth == sdev->queue_depth) return sdev->queue_depth; /* NCQ enabled? */ @@ -1059,7 +1058,7 @@ int __ata_change_queue_depth(struct ata_port *ap, struct scsi_device *sdev, return scsi_change_queue_depth(sdev, queue_depth); } -EXPORT_SYMBOL_GPL(__ata_change_queue_depth); +EXPORT_SYMBOL_GPL(ata_change_queue_depth); /** * ata_scsi_change_queue_depth - SCSI callback for queue depth config @@ -1080,7 +1079,8 @@ int ata_scsi_change_queue_depth(struct scsi_device *sdev, int queue_depth) { struct ata_port *ap = ata_shost_to_port(sdev->host); - return __ata_change_queue_depth(ap, sdev, queue_depth); + return ata_change_queue_depth(ap, ata_scsi_find_dev(ap, sdev), + sdev, queue_depth); } EXPORT_SYMBOL_GPL(ata_scsi_change_queue_depth); diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c index 9c82e5dc4fcc..a36fa1c128a8 100644 --- a/drivers/scsi/libsas/sas_scsi_host.c +++ b/drivers/scsi/libsas/sas_scsi_host.c @@ -872,7 +872,8 @@ int sas_change_queue_depth(struct scsi_device *sdev, int depth) struct domain_device *dev = sdev_to_domain_dev(sdev); if (dev_is_sata(dev)) - return __ata_change_queue_depth(dev->sata_dev.ap, sdev, depth); + return ata_change_queue_depth(dev->sata_dev.ap, + sas_to_ata_dev(dev), sdev, depth); if (!sdev->tagged_supported) depth = 1; diff --git a/include/linux/libata.h b/include/linux/libata.h index 698032e5ef2d..20765d1c5f80 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h @@ -1136,8 +1136,8 @@ extern int ata_scsi_slave_config(struct scsi_device *sdev); extern void ata_scsi_slave_destroy(struct scsi_device *sdev); extern int ata_scsi_change_queue_depth(struct scsi_device *sdev, int queue_depth); -extern int __ata_change_queue_depth(struct ata_port *ap, struct scsi_device *sdev, - int queue_depth); +extern int ata_change_queue_depth(struct ata_port *ap, struct ata_device *dev, + struct scsi_device *sdev, int queue_depth); extern struct ata_device *ata_dev_pair(struct ata_device *adev); extern int ata_do_set_mode(struct ata_link *link, struct ata_device **r_failed_dev); extern void ata_scsi_port_error_handler(struct Scsi_Host *host, struct ata_port *ap);