From patchwork Fri Jan 18 14:26:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Baluta X-Patchwork-Id: 10770361 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 81F6113BF for ; Fri, 18 Jan 2019 14:26:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3DCC02E6CB for ; Fri, 18 Jan 2019 14:26:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 31ABC2E6F6; Fri, 18 Jan 2019 14:26:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 53F4D2E6CB for ; Fri, 18 Jan 2019 14:26:56 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id BBAAC266B63; Fri, 18 Jan 2019 15:26:54 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 86400266B98; Fri, 18 Jan 2019 15:26:52 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140045.outbound.protection.outlook.com [40.107.14.45]) by alsa0.perex.cz (Postfix) with ESMTP id 85FF62667E7 for ; Fri, 18 Jan 2019 15:26:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F1DUcBExEhT5x9ZivFh7odOu/WUQOknhLzeGY9EeJS8=; b=m0PXhGStajG2DwFQzDy+ilVDue30Vl3T+SE3l2t77viK4iadCV6BgqDRrm8hgppgiLR1qe3a8cs3Y6c0ALgJeWYlXpnhqHvKacFwf9j0XjXWTH90UH/PtGB0EhDi0736r1dqv/8Hlt3iXlrmRzBCnkQURs8pNJeIeSt+eriIho4= Received: from VI1PR0402MB3357.eurprd04.prod.outlook.com (52.134.1.18) by VI1PR0402MB3328.eurprd04.prod.outlook.com (52.134.8.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1516.18; Fri, 18 Jan 2019 14:26:46 +0000 Received: from VI1PR0402MB3357.eurprd04.prod.outlook.com ([fe80::a8aa:5f09:1d1c:7b57]) by VI1PR0402MB3357.eurprd04.prod.outlook.com ([fe80::a8aa:5f09:1d1c:7b57%3]) with mapi id 15.20.1516.019; Fri, 18 Jan 2019 14:26:46 +0000 From: Daniel Baluta To: "broonie@kernel.org" Thread-Topic: [PATCH] ASoC: fsl_sai: Remove expensive print in irq handler Thread-Index: AQHUrznXTXX0lP91Sk+Jz+FJngllxA== Date: Fri, 18 Jan 2019 14:26:46 +0000 Message-ID: <20190118142623.17720-1-daniel.baluta@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6P193CA0070.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::47) To VI1PR0402MB3357.eurprd04.prod.outlook.com (2603:10a6:803:2::18) authentication-results: spf=none (sender IP is ) smtp.mailfrom=daniel.baluta@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.76.156.53] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0402MB3328; 6:lYvFBzWd2CPJruKYWoKW2Qr6gNZGicPw/N1rjKooL6dyu8lA/oTZyl3teTCTFZRIf/R3tHoino973kWUsTtHxzHL8U68CdKh4wKLb0mlYOo+c42M3UNgrDnS0IBaOn1ied7rjgTIFaqpYjNVxiS7ihj6ZOw3lu9PHKLciE7on+YRRnSOa7yAfB+KjNmCcgVkp42h5IlOBAhY+cVMBll2IpHbZi4O/EXLtXobWITgppdNDRZDOQtRhRV14DuYuhqUZv18uijocabn+hFzr0I56DWvjoQtVqGyMTLxjiJ0gskp7WtF0EUQaGpBbSDr1pHE/pGo2sor+l1Fpi9nq0UtMNuzyll7Dv9K4druSpF5f3wiBHMGBKTl2R1qGx/BzEeqc3ar6YR0pekobDu4SpdMOIkscwjmmEMQU0CfbB066eTCZ66raVyUzRg9z61w/vFfiYvGK34NMmg+c+mdCUl4jw==; 5:keaVgb7W4rrB2Cy80KpuLJwCLxjIanPbwSSnkdTThB1c+pMwckl1mJLxTKgePCFLOMIiAZAuKG0ctrkmEU7XmitNxUkwwdVc+PedX3whWuW2cjQoHFr74NEFhpiwRJke5dADsQCzrUtkM3/jx8MsXSSVzCyOk7xqKPU+wrEOMvc7CadJ1ABNwDaWjNRUci6oLAkB7O1tiVuV2inKEs8WNg==; 7:ngmrNxJ3ikPFqy3WPJYUoDNC0ItPWfeeSm/nwGkaT2KoYVFxh6TDUd4o3RFMz96ra016QrBx3hVSZKEGOZ/jE9evS6D36Lg9SveQgr84EEVj0apYpY0hkldxy2ThHtqmW4ZRRAqH/wnPOtPRLAGl4A== x-ms-office365-filtering-correlation-id: f196bf2c-2fbe-45cf-8db9-08d67d50f9ed x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0402MB3328; x-ms-traffictypediagnostic: VI1PR0402MB3328: x-microsoft-antispam-prvs: x-forefront-prvs: 0921D55E4F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(39860400002)(396003)(366004)(346002)(376002)(199004)(189003)(52116002)(44832011)(478600001)(14454004)(6512007)(6916009)(6486002)(256004)(66066001)(5660300001)(6436002)(53936002)(5640700003)(39060400002)(386003)(6506007)(476003)(26005)(4326008)(2616005)(54906003)(186003)(99286004)(2906002)(316002)(102836004)(71200400001)(71190400001)(1076003)(2501003)(8936002)(8676002)(68736007)(486006)(25786009)(81166006)(86362001)(2351001)(305945005)(105586002)(1730700003)(97736004)(36756003)(50226002)(106356001)(6116002)(7736002)(81156014)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0402MB3328; H:VI1PR0402MB3357.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: XGNBzx+w8b/FF+X0ywmab16LkOBAHBTEJSCS5qIf1mJB/QjccS2D0qE1DHox0QY/kRZkvh5DbMdimety/NVtcoJJf9rTwFL1oaMv986+iir5QjVvu852R2I+GEBh1edlaQ+yEreBnnJSa2qqFoRBfq4rvNKauRMsGMLUbdIrrwZJFQcCnsAxyDAqaz9tooxIeLzQQGA9mot6tM3/Ug5HTQ84/Owr/WJvthJNgKQvOq2VtDQ5Vle7tB+mwmqkdHgOhGpQxKhDlNqllQPpvCeFm0DNZbxv3V8TQb/Cbq2R2B3fLRDwIaxSDDP2WZv3fbM+UxTyCg4uw1qswSLXD08TCtG/sefRpZSDCrtRK8HHtj9J7iaY1PGMt/Kb/VDUfZZdlfJeOjQLJghFHAP3KH+uiQ3+90cw4cePfTnLszsudpA= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f196bf2c-2fbe-45cf-8db9-08d67d50f9ed X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2019 14:26:45.5999 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3328 Cc: "alsa-devel@alsa-project.org" , "Xiubo.Lee@gmail.com" , "S.j. Wang" , "linux-kernel@vger.kernel.org" , "nicoleotsuka@gmail.com" , dl-linux-imx , Fabio Estevam , Daniel Baluta Subject: [alsa-devel] [PATCH] ASoC: fsl_sai: Remove expensive print in irq handler X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Shengjiu Wang When stopping audio, ASoC will first stop DMA then CPU DAI. Sometimes there is a delay between DMA stop and CPU DAI stop, which triggers an underrun error. Now, because of the delay introduced by dev_err another underrun error will occur causing a vicious circle making impossible to stop CPU DAI. Signed-off-by: Shengjiu Wang Signed-off-by: Daniel Baluta Acked-by: Nicolin Chen --- sound/soc/fsl/fsl_sai.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c index 4163f2cfc06f..db9e0872f73d 100644 --- a/sound/soc/fsl/fsl_sai.c +++ b/sound/soc/fsl/fsl_sai.c @@ -62,10 +62,10 @@ static irqreturn_t fsl_sai_isr(int irq, void *devid) dev_dbg(dev, "isr: Start of Tx word detected\n"); if (flags & FSL_SAI_CSR_SEF) - dev_warn(dev, "isr: Tx Frame sync error detected\n"); + dev_dbg(dev, "isr: Tx Frame sync error detected\n"); if (flags & FSL_SAI_CSR_FEF) { - dev_warn(dev, "isr: Transmit underrun detected\n"); + dev_dbg(dev, "isr: Transmit underrun detected\n"); /* FIFO reset for safety */ xcsr |= FSL_SAI_CSR_FR; } @@ -96,10 +96,10 @@ static irqreturn_t fsl_sai_isr(int irq, void *devid) dev_dbg(dev, "isr: Start of Rx word detected\n"); if (flags & FSL_SAI_CSR_SEF) - dev_warn(dev, "isr: Rx Frame sync error detected\n"); + dev_dbg(dev, "isr: Rx Frame sync error detected\n"); if (flags & FSL_SAI_CSR_FEF) { - dev_warn(dev, "isr: Receive overflow detected\n"); + dev_dbg(dev, "isr: Receive overflow detected\n"); /* FIFO reset for safety */ xcsr |= FSL_SAI_CSR_FR; }