From patchwork Mon Oct 24 13:15:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 13017596 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73C6BC38A2D for ; Mon, 24 Oct 2022 13:16:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=rn5q98PUVW402uiH63OPQtTu9im47EHSv7FEDXIDcE0=; b=qGWYJ6bWPDNJMV nTmM3QzyebX4iijoOpf5sYj7ROzfXZqHvYxoYXoiaAjFKD1nNlkpgg6rxUs3dc/G5ithi9BU/lt38 2xhyPwcZQ/vgot8bs7aQzwpHWhuCdKpgyEfWuX3KS58q+uTCV0178xi8iZJMsI+OUsjVALFuQfu9r SzIhb43IrzrsMOjvqRLID3fBCPa27C2Ld73gJ+zDJ3Hr/51WbCk4J+mMTr3UuExoHsf/XWBiQO1Oi uzs6UsiritIQCTdBvgZSXpuEz/Rj5RRZIdPD44n5WAzJ52rpiH63Zh13vMclWaSMg5daHUa9H35AO gwTAJRKXq88kQJzMZ9eg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1omxIm-001eXz-72; Mon, 24 Oct 2022 13:15:36 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1omxIi-001eVz-Fv for linux-arm-kernel@lists.infradead.org; Mon, 24 Oct 2022 13:15:34 +0000 Received: by mail-wm1-x333.google.com with SMTP id n14so2315252wmq.3 for ; Mon, 24 Oct 2022 06:15:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0vrMEaRTOwjPGYos2d/zehtmsU3IkMfRxjv+/1fbd3Q=; b=VKJ1G1o7+2+SQele4larDZ/2K25UrUVVp54Nrve6h20LExDBaKHIClcbBnpbrrzvyk WnWyToK5iRYdzsch3pSLsG9Hqwe8ZjdpZKvuIE33xS/WfWt+GK7OMY6gPqIJ7u/9X5es KxKivLyP7x9AmhjGc8iwzBixaN4zLaD6rREhMrdm84TnLUvF1dUgQv3nHZicWWEJWrwT soU1/txlsKhDtZwzOfy96JWzJn6olk6EIXZMh86SH0shMUspuBx5cS/xVRtlvye6uKiq 78fTBDDQfXkpdKrIZlsvgJOXcrQLaU6Nnz9OunF0l6uFeL6OR/y1cYRyclV8VLnXLK93 6btg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0vrMEaRTOwjPGYos2d/zehtmsU3IkMfRxjv+/1fbd3Q=; b=uysnvG/EqadAf/oOUlil9l/CLjmsWSQlwyEWQT48h/A9FJo2GXxsKOw4iOXL66Fp3h +/eSgDVQYIhkpIQxv/Kw5j371Y7AEka2XsQpXWyeQjHS8YMC7PmjW5LlOc50EgfkIZvK RFAA/FZlALLdMnD81gtAveA3PNNDdT4tpHkC4sy0BupqgTaO6oiLjajwPZmQrAFr4Ame St5+a9tXNxGMrHXsF9Xm2ZEMpE/r2NmFU5GWq72MscNOnhb9Lh3d6pauuISAiHnOsUQs yhB1MI9N/WEPwbZtXxyDgglf6/kaYisn6gc89c78e3QoFv43YXA9YF0QS3rDP8CoWpOH WQNg== X-Gm-Message-State: ACrzQf1VtbrrehVqQiMom6RQkKhKqF5zWaGg2OL1q2FM/GfaswUhufId FaLCKfPO52ZBJyPRUhvwwXY= X-Google-Smtp-Source: AMsMyM46DTJTSuuP9DKHEnco5O7iTBp1tIwmtk2u/tX203ZYgVIXhOZKuUbIOH6/cBGqYy2PNgPhfA== X-Received: by 2002:a05:600c:3b11:b0:3c6:c02d:babb with SMTP id m17-20020a05600c3b1100b003c6c02dbabbmr42613493wms.69.1666617328451; Mon, 24 Oct 2022 06:15:28 -0700 (PDT) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id b7-20020adfe307000000b0022cbf4cda62sm32201847wrj.27.2022.10.24.06.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 06:15:27 -0700 (PDT) From: Colin Ian King To: Krzysztof Kozlowski , Alim Akhtar , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: samsung: remove variable pin Date: Mon, 24 Oct 2022 14:15:27 +0100 Message-Id: <20221024131527.2156810-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221024_061532_563940_45354D10 X-CRM114-Status: GOOD ( 12.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Variable pin is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it. Signed-off-by: Colin Ian King --- drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c index 625cb1065eaf..78b7bd133566 100644 --- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c +++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c @@ -509,7 +509,6 @@ static int s3c24xx_eint_init(struct samsung_pinctrl_drv_data *d) struct s3c24xx_eint_domain_data *ddata; unsigned int mask; unsigned int irq; - unsigned int pin; if (bank->eint_type != EINT_TYPE_WKUP) continue; @@ -534,7 +533,7 @@ static int s3c24xx_eint_init(struct samsung_pinctrl_drv_data *d) irq = bank->eint_offset; mask = bank->eint_mask; - for (pin = 0; mask; ++pin, mask >>= 1) { + for (; mask; mask >>= 1) { if (irq >= NUM_EINT) break; if (!(mask & 1))