From patchwork Mon Jan 21 02:48:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 10772585 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4522C1390 for ; Mon, 21 Jan 2019 07:11:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 289C629F0A for ; Mon, 21 Jan 2019 07:11:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1BF3D29F0C; Mon, 21 Jan 2019 07:11:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 718D629F0A for ; Mon, 21 Jan 2019 07:11:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726068AbfAUHLQ (ORCPT ); Mon, 21 Jan 2019 02:11:16 -0500 Received: from condef-07.nifty.com ([202.248.20.72]:49348 "EHLO condef-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725871AbfAUHLQ (ORCPT ); Mon, 21 Jan 2019 02:11:16 -0500 Received: from conuserg-08.nifty.com ([10.126.8.71])by condef-07.nifty.com with ESMTP id x0L2nbWo000684; Mon, 21 Jan 2019 11:49:37 +0900 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-08.nifty.com with ESMTP id x0L2ms5g015717; Mon, 21 Jan 2019 11:48:54 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com x0L2ms5g015717 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1548038934; bh=1ScuhqJca0uj5wxaiMhHAqTBVV8LdYPNZ4+ByDc6o4o=; h=From:To:Cc:Subject:Date:From; b=a1TU2cKCVZcTtKz1/n9K4UZk/n8nAmkXhLP04ub/O3HMTi7ZxE2cWdij4PU/K6z6T 1jxabuQSRgJLf5skKBrcKX+zyVNvsgt+FZ46Vxl9Wa9SI/1a9cdkkwgTzGWI0sKGMb B8LzKnmvLyB8dqHBdUudd71KQtFyhczAL0YDLWv+H26qsTX9ST7aXr5bX+9WxTu8Sw 2Z31p/6GTtbohBMOdRoaJVh/ROY4Sj6TMTImhlhZLBhrrrZ9rM3r11Dd96K90/oNeD KiQOFn2ZgzKaMliOwfs5PPEXu8dwJpTZQtRy/c7DGp3TKRjzeKxRwH4ok5c+RZdKd3 9mzSDd22OnCFg== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Paul Burton , linux-mips@vger.kernel.org Cc: Masahiro Yamada , Ralf Baechle , James Hogan , linux-kernel@vger.kernel.org Subject: [PATCH] MIPS: remove meaningless generic-(CONFIG_GENERIC_CSUM) += checksum.h Date: Mon, 21 Jan 2019 11:48:49 +0900 Message-Id: <1548038929-11814-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This line is weird in multiple ways. (CONFIG_GENERIC_CSUM) might be a typo of $(CONFIG_GENERIC_CSUM). Even if you add '$' to it, $(CONFIG_GENERIC_CSUM) is never evaluated to 'y' because scripts/Makefile.asm-generic does not include include/config/auto.conf. So, the asm-generic wrapper of checksum.h is never generated. Even if you manage to generate it, it is never included by anyone because MIPS has the checkin header with the same file name: arch/mips/include/asm/checksum.h As you see in the top Makefile, the checkin headers are included before generated ones. LINUXINCLUDE := \ -I$(srctree)/arch/$(SRCARCH)/include \ -I$(objtree)/arch/$(SRCARCH)/include/generated \ ... Commit 4e0748f5beb9 ("MIPS: Use generic checksum functions for MIPS R6") already added the asm-generic fallback code in the checkin header: #ifdef CONFIG_GENERIC_CSUM #include #else ... #endif Signed-off-by: Masahiro Yamada --- arch/mips/include/asm/Kbuild | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/mips/include/asm/Kbuild b/arch/mips/include/asm/Kbuild index f15d5db..87b86cd 100644 --- a/arch/mips/include/asm/Kbuild +++ b/arch/mips/include/asm/Kbuild @@ -3,7 +3,6 @@ generated-y += syscall_table_32_o32.h generated-y += syscall_table_64_n32.h generated-y += syscall_table_64_n64.h generated-y += syscall_table_64_o32.h -generic-(CONFIG_GENERIC_CSUM) += checksum.h generic-y += current.h generic-y += device.h generic-y += dma-contiguous.h