From patchwork Mon Nov 7 18:01:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Desaulniers X-Patchwork-Id: 13035044 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55FC4C433FE for ; Mon, 7 Nov 2022 18:05:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232948AbiKGSFY (ORCPT ); Mon, 7 Nov 2022 13:05:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232986AbiKGSFD (ORCPT ); Mon, 7 Nov 2022 13:05:03 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F78429CAF for ; Mon, 7 Nov 2022 10:01:47 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id 205-20020a2503d6000000b006d2132f6f85so10197153ybd.16 for ; Mon, 07 Nov 2022 10:01:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=tS32EJHch/dBCbWB1L1GEsMMs2fsIbqQFe/97cUFWvM=; b=SQYIlLQKDlVnO9q4XFVS6JNGHFLzyXs2BBOTrJ3U2uoFJbz2V1TKCFigITFOkkCBsE P7yQEfNwhQDVnNt0lODX16Vj27w+OJsABLNwgNbT28C7yj0B7MRxu0LROLDNT0YKsV2H JtLo7sPWQ4n6uVNVn1LklyOZb4adAa+tyftuIUOIFc8ZIbd407jzLM9lVPMTITSIu3QB z+ijEaWLv3jAQQ3qeE5n4npuiVJSiDgovDpowJTDvxuAEeEvl5gsUaouodZ7uuTbA+f5 P4Jrw/KEVPN5Bt0BkSSedMJ32GuffqeJmr+qFlsHcZUirO7vanhPCmC7o4mKfdGCT6jn VLPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tS32EJHch/dBCbWB1L1GEsMMs2fsIbqQFe/97cUFWvM=; b=jAuc2SXRBAqUa4FkkE+cTDnvuaCWEcvcImhDMxNfvyNkIMwnlDy90gW1KmE0xdRLYN jO5aYHzFO56U13wZ21Rktg9jCdWnWD37Ua5uZ1JnjaUyfzi82/JZH+NeEjH2BhpyEWps PiE54gEzM6UFw7FhBWzyi5da5p31znaS8xSGUhITGbfwpx4f0sG5xHY+Hamrd3Cvyqgs jjQd2HtW5lAM1k20uQuxOLVb7LHyoX1SUQl6PqzcyeNGxtUmSn/i7kNEVKei2zJE+cwf 2a8ox7yDrqQwapkjw/cqJS+FxcN1nTmKOACJ93vmO2dlf0ZMJIcogYnhLr0qRHrFYUY9 MkJQ== X-Gm-Message-State: ACrzQf3AUTcU8hBZCh8wrnXelIfI7pSR0ol1ENQB340FaHGK4pEbyUIN J8Vmds+6vGBQJTkCTJyxbhj/kHPTB7ZVY+eZqq8= X-Google-Smtp-Source: AMsMyM43ETSncLgam+YPFOfqqMnPhR2b4p/E/JIxE9g3tkFOoKJwqElFbUb+Eh05NX1YCpgkMicQmG4tLxtVEWUKbzg= X-Received: from ndesaulniers-desktop.svl.corp.google.com ([2620:15c:2d1:203:a5cc:f0f5:1fc6:713]) (user=ndesaulniers job=sendgmr) by 2002:a25:a18a:0:b0:6cc:90d7:2494 with SMTP id a10-20020a25a18a000000b006cc90d72494mr44462663ybi.210.1667844106473; Mon, 07 Nov 2022 10:01:46 -0800 (PST) Date: Mon, 7 Nov 2022 10:01:33 -0800 In-Reply-To: Mime-Version: 1.0 References: X-Developer-Key: i=ndesaulniers@google.com; a=ed25519; pk=UIrHvErwpgNbhCkRZAYSX0CFd/XFEwqX3D0xqtqjNug= X-Developer-Signature: v=1; a=ed25519-sha256; t=1667844093; l=4727; i=ndesaulniers@google.com; s=20220923; h=from:subject; bh=ngUXhzx1TaUsWCpO5TJrX+dyZDEqf8GPaOtwJXhjBcI=; b=mh/Lzv9loBNdaHCrZfNBXOodUwGUUfOiCAZ00kw3hTNN2oumOkTD1WEv6uV6QH6fLPk2XynGvH1k Cqo9MNghBOERc78BQRWrFhcemifO4ZzhW5x8THu1yfxq7Ar1hk+U X-Mailer: git-send-email 2.38.1.431.g37b22c650d-goog Message-ID: <20221107180137.3634978-1-ndesaulniers@google.com> Subject: [PATCH v2] Makefile.debug: support for -gz=zstd From: Nick Desaulniers To: Masahiro Yamada Cc: Fangrui Song , Nick Desaulniers , Sedat Dilek , Nathan Chancellor , Michal Marek , Nick Terrell , Tom Rix , Andrew Morton , "Peter Zijlstra (Intel)" , Kees Cook , Josh Poimboeuf , Dan Williams , Miguel Ojeda , Isabella Basso , Vlastimil Babka , Rasmus Villemoes , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, llvm@lists.linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org Make DEBUG_INFO_COMPRESSED a choice; DEBUG_INFO_UNCOMPRESSED is the default, DEBUG_INFO_COMPRESSED uses zlib, DEBUG_INFO_COMPRESSED_ZSTD uses zstd. Some quick N=1 measurements with du, /usr/bin/time -v, and bloaty: clang-16, x86_64 defconfig plus CONFIG_DEBUG_INFO=y CONFIG_DEBUG_INFO_UNCOMPRESSED=y: Elapsed (wall clock) time (h:mm:ss or m:ss): 0:55.43 488M vmlinux 27.6% 136Mi 0.0% 0 .debug_info 6.1% 30.2Mi 0.0% 0 .debug_str_offsets 3.5% 17.2Mi 0.0% 0 .debug_line 3.3% 16.3Mi 0.0% 0 .debug_loclists 0.9% 4.62Mi 0.0% 0 .debug_str clang-16, x86_64 defconfig plus CONFIG_DEBUG_INFO=y CONFIG_DEBUG_INFO_COMPRESSED=y (zlib): Elapsed (wall clock) time (h:mm:ss or m:ss): 1:00.35 385M vmlinux 21.8% 85.4Mi 0.0% 0 .debug_info 2.1% 8.26Mi 0.0% 0 .debug_str_offsets 2.1% 8.24Mi 0.0% 0 .debug_loclists 1.9% 7.48Mi 0.0% 0 .debug_line 0.5% 1.94Mi 0.0% 0 .debug_str clang-16, x86_64 defconfig plus CONFIG_DEBUG_INFO=y CONFIG_DEBUG_INFO_COMPRESSED_ZSTD=y (zstd): Elapsed (wall clock) time (h:mm:ss or m:ss): 0:59.69 373M vmlinux 21.4% 81.4Mi 0.0% 0 .debug_info 2.3% 8.85Mi 0.0% 0 .debug_loclists 1.5% 5.71Mi 0.0% 0 .debug_line 0.5% 1.95Mi 0.0% 0 .debug_str_offsets 0.4% 1.62Mi 0.0% 0 .debug_str That's only a 3.11% overall binary size savings over zlib, but at no performance regression. This renames the existing KConfig options: * DEBUG_INFO_UNCOMPRESSED -> DEBUG_INFO_COMPRESSED_NONE * DEBUG_INFO_COMPRESSED -> DEBUG_INFO_COMPRESSED_ZLIB So users upgrading may need to reset the new Kconfigs. Link: https://maskray.me/blog/2022-09-09-zstd-compressed-debug-sections Link: https://maskray.me/blog/2022-01-23-compressed-debug-sections Suggested-by: Sedat Dilek (DHL Supply Chain) Reviewed-by: Nathan Chancellor Signed-off-by: Nick Desaulniers --- Changes v1 -> v2: * Remove `depends on DEBUG_KERNEL` as per Nathan. * Rename Kconfigs as per Sedat and Masahiro. * Add note about renamed Kconfigs to commit message. * Add more help text to DEBUG_INFO_COMPRESSED_ZSTD. lib/Kconfig.debug | 29 +++++++++++++++++++++++++++-- scripts/Makefile.debug | 4 ++++ 2 files changed, 31 insertions(+), 2 deletions(-) base-commit: f0c4d9fc9cc9462659728d168387191387e903cc diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 29280072dc0e..7c28a8fba02e 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -312,8 +312,21 @@ config DEBUG_INFO_REDUCED DEBUG_INFO build and compile times are reduced too. Only works with newer gcc versions. -config DEBUG_INFO_COMPRESSED - bool "Compressed debugging information" +choice + prompt "Compressed Debug information" + help + Compress the resulting debug info. Results in smaller debug info sections, + but requires that consumers are able to decompress the results. + + If unsure, choose DEBUG_INFO_COMPRESSED_NONE. + +config DEBUG_INFO_COMPRESSED_NONE + bool "Don't compress debug information" + help + Don't compress debug info sections. + +config DEBUG_INFO_COMPRESSED_ZLIB + bool "Compress debugging information with zlib" depends on $(cc-option,-gz=zlib) depends on $(ld-option,--compress-debug-sections=zlib) help @@ -327,6 +340,18 @@ config DEBUG_INFO_COMPRESSED preferable to setting $KDEB_COMPRESS to "none" which would be even larger. +config DEBUG_INFO_COMPRESSED_ZSTD + bool "Compress debugging information with zstd" + depends on $(cc-option,-gz=zstd) + depends on $(ld-option,--compress-debug-sections=zstd) + help + Compress the debug information using zstd. This may provide better + compression than zlib, for about the same time costs, but requires newer + toolchain support. Requires GCC 13.0+ or Clang 16.0+, binutils 2.40+, and + zstd. + +endchoice # "Compressed Debug information" + config DEBUG_INFO_SPLIT bool "Produce split debuginfo in .dwo files" depends on $(cc-option,-gsplit-dwarf) diff --git a/scripts/Makefile.debug b/scripts/Makefile.debug index 332c486f705f..8ac3379d2255 100644 --- a/scripts/Makefile.debug +++ b/scripts/Makefile.debug @@ -31,6 +31,10 @@ ifdef CONFIG_DEBUG_INFO_COMPRESSED DEBUG_CFLAGS += -gz=zlib KBUILD_AFLAGS += -gz=zlib KBUILD_LDFLAGS += --compress-debug-sections=zlib +else ifdef CONFIG_DEBUG_INFO_COMPRESSED_ZSTD +DEBUG_CFLAGS += -gz=zstd +KBUILD_AFLAGS += -gz=zstd +KBUILD_LDFLAGS += --compress-debug-sections=zstd endif KBUILD_CFLAGS += $(DEBUG_CFLAGS)