From patchwork Sun Nov 13 16:28:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13041575 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C450C433FE for ; Sun, 13 Nov 2022 16:29:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90B4C6B0073; Sun, 13 Nov 2022 11:29:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 79E7D8E0002; Sun, 13 Nov 2022 11:29:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A17E8E0003; Sun, 13 Nov 2022 11:29:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 435F78E0002 for ; Sun, 13 Nov 2022 11:29:25 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 118791A0907 for ; Sun, 13 Nov 2022 16:29:25 +0000 (UTC) X-FDA: 80128954290.03.6379FF1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP id E0E628000A for ; Sun, 13 Nov 2022 16:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=5b0HJs6BQQ2q0Kk5NRtkmifAYyqmzj66xADh1qM10M0=; b=KGgZVJw+zfxpaLBuhQjRpHNEYn 10b8xdf3xvPFTiPuWr1zXm+4e+1+9Milh54Dzt4O/GuaWAVilFEiAvWu+wkdn3bFwnb4Q11uSLIrd 0EuYf5pAvNmhIJN9X3+rcL9wzs8lBEAclVOfiFxKEmOp4hsxiMNcGoji1TeYzgaBo4kpirTcC02AZ Szw8ic2CR+yHIghaQGROTusREc56h/Ozn5JBc4l85U2JToj1xU53uwDNLe2NyNH+wLdZwzic2GQlA 5+pWB5gWan9ujAYVO57mZe/hVhpQrC+TwgbQhYX9n4citW6+c86b3rCQ459lmbZslOI02aUu19r6G /2FcORkA==; Received: from 213-225-8-167.nat.highway.a1.net ([213.225.8.167] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouFr4-00CJnJ-EB; Sun, 13 Nov 2022 16:29:11 +0000 From: Christoph Hellwig To: Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: [PATCH 1/9] extfat: remove ->writepage Date: Sun, 13 Nov 2022 17:28:54 +0100 Message-Id: <20221113162902.883850-2-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221113162902.883850-1-hch@lst.de> References: <20221113162902.883850-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668356963; a=rsa-sha256; cv=none; b=wGl7i8zz7vEYbeH4OYRrb2Wv+eaGWOxzeoNQCjNmdEsED/G71nHru6vq2kHEN1RWZ8eUNP KxkMdNBqvOsxtiGF9U6N/f7n5PMj3jqfCjmvHVlbFL98OoLyz6K7yOws6WZKhBhZna2yHD QtgQdsr4qO9faP2YdGUlAsYZqQpiyfE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=KGgZVJw+; dmarc=none; spf=none (imf02.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668356963; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5b0HJs6BQQ2q0Kk5NRtkmifAYyqmzj66xADh1qM10M0=; b=LLi3wAZ3cP55Dngp9PkR4oYFxpyZ6LNvU2WIZy6rqz7E9lptmEzqD6ijPvJlzIL55/GCTU U/ELJVhQJ2ddtZ8zE0/H0Xp+LW7bkdY5BEpXIS779fTAjlBnv92hUbl1wIh4vWQjw+bLMi wqblX5hwp666v8PbVM+awaW48LMvGoU= X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=KGgZVJw+; dmarc=none; spf=none (imf02.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam02 X-Stat-Signature: mog9eeeu11kf4fcf3xzs4c6478nqrekr X-Rspamd-Queue-Id: E0E628000A X-HE-Tag: 1668356962-17394 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and remove the ->writepage implementation. Signed-off-by: Christoph Hellwig Acked-by: Namjae Jeon --- fs/exfat/inode.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/fs/exfat/inode.c b/fs/exfat/inode.c index 5590a1e83126c..eac95bcd9a8aa 100644 --- a/fs/exfat/inode.c +++ b/fs/exfat/inode.c @@ -345,11 +345,6 @@ static void exfat_readahead(struct readahead_control *rac) mpage_readahead(rac, exfat_get_block); } -static int exfat_writepage(struct page *page, struct writeback_control *wbc) -{ - return block_write_full_page(page, exfat_get_block, wbc); -} - static int exfat_writepages(struct address_space *mapping, struct writeback_control *wbc) { @@ -473,12 +468,12 @@ static const struct address_space_operations exfat_aops = { .invalidate_folio = block_invalidate_folio, .read_folio = exfat_read_folio, .readahead = exfat_readahead, - .writepage = exfat_writepage, .writepages = exfat_writepages, .write_begin = exfat_write_begin, .write_end = exfat_write_end, .direct_IO = exfat_direct_IO, - .bmap = exfat_aop_bmap + .bmap = exfat_aop_bmap, + .migrate_folio = buffer_migrate_folio, }; static inline unsigned long exfat_hash(loff_t i_pos) From patchwork Sun Nov 13 16:28:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13041574 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9248C4332F for ; Sun, 13 Nov 2022 16:29:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DDD56B0072; Sun, 13 Nov 2022 11:29:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 667B68E0001; Sun, 13 Nov 2022 11:29:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 380556B0073; Sun, 13 Nov 2022 11:29:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 25D266B0071 for ; Sun, 13 Nov 2022 11:29:25 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id ECBE580783 for ; Sun, 13 Nov 2022 16:29:24 +0000 (UTC) X-FDA: 80128954248.25.10FCC3A Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf10.hostedemail.com (Postfix) with ESMTP id 0DF32C0007 for ; Sun, 13 Nov 2022 16:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=scMCwkPRF8Nb8DbgWIgHz66Xl/jY6KIfqEEGjQf+P/U=; b=dZaZtRFdFNTJOY1FQNyijDu7jO H93jBvSdtSrsZP6OEyZrMhY1VbI0CUpwlTsPpjDi+4lMAIL+Y4nj9p0RfOwK76YPLCYCt/1KwRRC3 mZ48JB/P7VnrTuDpgyoQX0CkNGnijcfT9NIM+zn4TAFb9MK+otp7w8IWEAt5belywKsJadLtrTwKC 5ogGIWtuIUx0hXNZbzkIc8f1O4z0MBzf1hvb0ROX8Xe+CQDlO7RbLOBqjH5j1gQ19+z+Zpat9BGDr FQac6xjD5NdZXpmfjfrNsG6sAx+Sj2tz3i+V05uvUNmWDZI7+6l9AoSFZwsUufAKr3RT/N5rfcils 92Ydrxtw==; Received: from 213-225-8-167.nat.highway.a1.net ([213.225.8.167] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouFr8-00CJnt-Dv; Sun, 13 Nov 2022 16:29:15 +0000 From: Christoph Hellwig To: Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: [PATCH 2/9] ext2: remove ->writepage Date: Sun, 13 Nov 2022 17:28:55 +0100 Message-Id: <20221113162902.883850-3-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221113162902.883850-1-hch@lst.de> References: <20221113162902.883850-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668356963; a=rsa-sha256; cv=none; b=Q3fqQG+jrBaGoB5iD12q0uYlhB8cHg6x10RoNjHaJFxGrQ1xxd4y16g2E53tOAvVwfWvFC ObH9djl5E3jclbf1Os37K9KfWl0gqN7CO2iuydzaegINhNya0DdWEhn6CaqC6LvDYiLBAG MWwBK5qQp2P2dzIT3uP1rdPmQfWlqt8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=dZaZtRFd; spf=none (imf10.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668356963; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=scMCwkPRF8Nb8DbgWIgHz66Xl/jY6KIfqEEGjQf+P/U=; b=UEVihzCbvqF2d5hQrIahIJha2miOQrwRYrVUZQImfCK4CbsxmXDoBCyxKx+KG+xtG1K5o7 2u84qa27Y/EgmS+0wVR1hJAhu3cQVJKfFhjNiYZL4DBpHIVdEUrPvhr2j/+ffgipF1wVWQ nC1usEc1dw3xzMjT/Qt1CE6DMWJuJPs= X-Stat-Signature: 7ked3773zfoqcqq67phwbmrtf5tb4c3c X-Rspamd-Queue-Id: 0DF32C0007 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=dZaZtRFd; spf=none (imf10.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1668356962-892015 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Signed-off-by: Christoph Hellwig Acked-by: Jan Kara --- fs/ext2/inode.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index 918ab2f9e4c05..3b2e3e1e0fa25 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c @@ -869,11 +869,6 @@ int ext2_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, return ret; } -static int ext2_writepage(struct page *page, struct writeback_control *wbc) -{ - return block_write_full_page(page, ext2_get_block, wbc); -} - static int ext2_read_folio(struct file *file, struct folio *folio) { return mpage_read_folio(folio, ext2_get_block); @@ -948,7 +943,6 @@ const struct address_space_operations ext2_aops = { .invalidate_folio = block_invalidate_folio, .read_folio = ext2_read_folio, .readahead = ext2_readahead, - .writepage = ext2_writepage, .write_begin = ext2_write_begin, .write_end = ext2_write_end, .bmap = ext2_bmap, From patchwork Sun Nov 13 16:28:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13041576 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FA19C4332F for ; Sun, 13 Nov 2022 16:29:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 271C58E0002; Sun, 13 Nov 2022 11:29:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D5ED8E0001; Sun, 13 Nov 2022 11:29:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 024E68E0002; Sun, 13 Nov 2022 11:29:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E1C058E0001 for ; Sun, 13 Nov 2022 11:29:26 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A432F40837 for ; Sun, 13 Nov 2022 16:29:26 +0000 (UTC) X-FDA: 80128954332.11.D06DAE9 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP id 512B7C000A for ; Sun, 13 Nov 2022 16:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=/xbu9xiQdaag/9GdE14AqAfcPfZ9nZ+wREMF3PN8ikU=; b=Zdpc2dMybytlRvYwON8XlABzCT ZMfpsLeusVZ3QKHsCMwKWFO9Kwn7VhCbwu2g9CJFiOBfB/nzdGc+nfgQ9xpO36CHzKpU6jM0cchyh pbaQsfIve7JTynTdwYGSBhgPZO0FafO0tSHF9tAYmPF3i8SqE6hX8HrPpqztnI3RRCUpK9DkD4VUr 1aj4zcLV/It6mFMhS5W+SfkPikRRlQ7xGOLE+wKOfXMk7dFIEhgNFSrOuVtOxWsgD767oZT9xMQXC cABDK5122PBv5+NWwmfZb9tVH4upC9nkFTq3ex30hA8xLr6rkvyv1S+XCEj+yyKm/6mT8eS+5ijTx pdomIdRQ==; Received: from 213-225-8-167.nat.highway.a1.net ([213.225.8.167] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouFrD-00CJp5-7o; Sun, 13 Nov 2022 16:29:20 +0000 From: Christoph Hellwig To: Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: [PATCH 3/9] fat: remove ->writepage Date: Sun, 13 Nov 2022 17:28:56 +0100 Message-Id: <20221113162902.883850-4-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221113162902.883850-1-hch@lst.de> References: <20221113162902.883850-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668356966; a=rsa-sha256; cv=none; b=F947l2HlaKP9yQBsEl4mmj5j92h42zAYtc2Dz6AbsoPhCfc8WKRb4xGVISQZnEqS+Qi1oD tsas+AjvqRV6Ju6W/N0pcfcjOF08PxPsgFzyvf5QvVqRY+dawT8+CuJ3nbdcpTYFk0x0Zi 3r0znVqasXFZutICfFLgfDGmlTTA37I= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Zdpc2dMy; dmarc=none; spf=none (imf28.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668356966; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/xbu9xiQdaag/9GdE14AqAfcPfZ9nZ+wREMF3PN8ikU=; b=o1MbaVRxZpo3w7//o85nOhJgxfAs/PUNu3DmbIGMlZ521aPEVbjgROQouSGDyLTbGzz/9y JOxWoGnmB+TOi5Jz4NJrHzsrR7m8pOWb6m1fGgc38zm/efFiVIlt44CNlbXjN8XzWQ75Ih N4DyD5sivBEJ1IaR+yRIyouElok8HW8= X-Rspamd-Queue-Id: 512B7C000A X-Rspam-User: Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Zdpc2dMy; dmarc=none; spf=none (imf28.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam06 X-Stat-Signature: k51ooyue7wiadqmhyh7ah6bdstttq1uh X-HE-Tag: 1668356966-236791 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and remove the ->writepage implementation. Signed-off-by: Christoph Hellwig --- fs/fat/inode.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 1cbcc4608dc78..d99b8549ec8f9 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c @@ -194,11 +194,6 @@ static int fat_get_block(struct inode *inode, sector_t iblock, return 0; } -static int fat_writepage(struct page *page, struct writeback_control *wbc) -{ - return block_write_full_page(page, fat_get_block, wbc); -} - static int fat_writepages(struct address_space *mapping, struct writeback_control *wbc) { @@ -346,12 +341,12 @@ static const struct address_space_operations fat_aops = { .invalidate_folio = block_invalidate_folio, .read_folio = fat_read_folio, .readahead = fat_readahead, - .writepage = fat_writepage, .writepages = fat_writepages, .write_begin = fat_write_begin, .write_end = fat_write_end, .direct_IO = fat_direct_IO, - .bmap = _fat_bmap + .bmap = _fat_bmap, + .migrate_folio = buffer_migrate_folio, }; /* From patchwork Sun Nov 13 16:28:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13041577 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2786C433FE for ; Sun, 13 Nov 2022 16:29:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D9AC80007; Sun, 13 Nov 2022 11:29:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 88B578E0001; Sun, 13 Nov 2022 11:29:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7781D80007; Sun, 13 Nov 2022 11:29:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 687778E0001 for ; Sun, 13 Nov 2022 11:29:31 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2AE5980978 for ; Sun, 13 Nov 2022 16:29:31 +0000 (UTC) X-FDA: 80128954542.09.696BAF7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id DE430C0006 for ; Sun, 13 Nov 2022 16:29:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=5EEi8cInv3ks31I/nmTl0wJaf2VmtmozgKaSoblZ/nw=; b=1SbIPs1iFU+7TJOgzkiJf2RvBs 2XzmwVKtUH+kZqH7A36H1Wbg+vKnJpDNlb6xKtvuTlKG0eGjPoQQYRvlscMAAocgvR6VMPofTIG2D C+y5XrFdah5UyaOY7msF15XC44ocxoaKSrFQ6FttO4KIK9nTS4cuGeLqvpIl9ulpzUdcM4c+JMwjM V8FaL9blLKhDvLC8WvpLfuXFxjXC9wudXB9FmyTMvzWE6wkwNl+IkzupEJSkEGn6t5dX2vBO8ZlRk HQdfmuqFBmta5GLulUNuImMueBME4ZGS+MBcQ/xhhfaXZ0G/j/xK5VJycJsTzRVisDdUNap2eB7Ql vz3UMr+A==; Received: from 213-225-8-167.nat.highway.a1.net ([213.225.8.167] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouFrH-00CJqO-HX; Sun, 13 Nov 2022 16:29:24 +0000 From: Christoph Hellwig To: Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: [PATCH 4/9] hfs: remove ->writepage Date: Sun, 13 Nov 2022 17:28:57 +0100 Message-Id: <20221113162902.883850-5-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221113162902.883850-1-hch@lst.de> References: <20221113162902.883850-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668356970; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5EEi8cInv3ks31I/nmTl0wJaf2VmtmozgKaSoblZ/nw=; b=E1dzWcPtBHixcIwEPIr67MuQO/DoIWkIb3q3FHfKaY0WNdZK5bXnA3Qu9p7oYItkqUfmUM ACWvhZrn3mgCqzlhpMy6rI53SYk4k3xia9qiE6YTi4mlXoRgxsujsNTfxQaYwJWlXxNL9F HhSpaxfdHqE4c0KV6UBchkYyjs7szuE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1SbIPs1i; dmarc=none; spf=none (imf22.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668356970; a=rsa-sha256; cv=none; b=EX7YIA5cquZFhC87UINpHRsMZzQ9XxIWwnpKE5aV9oDHCW7iuZ2IX7WrKXqbFm3Tg5Pj2v L8eQl2abR95/flJy0h+EaMHiMdzJMmwLq5Znyj1VAfEwAZmGkDRR921h9y3f6kyA+scJa8 KNG6oHtMZVq6DAwJf0MJKtFLf0lSbWk= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: DE430C0006 X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1SbIPs1i; dmarc=none; spf=none (imf22.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org X-Stat-Signature: 4z9yhkmhhbtf4hb485dy7zpy8xsi3uam X-HE-Tag: 1668356970-271343 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and stop wiring up ->writepage for hfs_aops. Signed-off-by: Christoph Hellwig --- fs/hfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/hfs/inode.c b/fs/hfs/inode.c index c4526f16355d5..16466a5e88b44 100644 --- a/fs/hfs/inode.c +++ b/fs/hfs/inode.c @@ -173,12 +173,12 @@ const struct address_space_operations hfs_aops = { .dirty_folio = block_dirty_folio, .invalidate_folio = block_invalidate_folio, .read_folio = hfs_read_folio, - .writepage = hfs_writepage, .write_begin = hfs_write_begin, .write_end = generic_write_end, .bmap = hfs_bmap, .direct_IO = hfs_direct_IO, .writepages = hfs_writepages, + .migrate_folio = buffer_migrate_folio, }; /* From patchwork Sun Nov 13 16:28:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13041578 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61A01C433FE for ; Sun, 13 Nov 2022 16:29:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0006F80008; Sun, 13 Nov 2022 11:29:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF17A8E0001; Sun, 13 Nov 2022 11:29:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E07F780008; Sun, 13 Nov 2022 11:29:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D191C8E0001 for ; Sun, 13 Nov 2022 11:29:34 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 72E211C5C0C for ; Sun, 13 Nov 2022 16:29:34 +0000 (UTC) X-FDA: 80128954668.22.83E61D7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 11DD320003 for ; Sun, 13 Nov 2022 16:29:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=MwWj9ekijv12iDbEn7vuZCjsvgidcmcKtSd/iPVo/3U=; b=sX+/TxS5zNNROlDDctzjyY/ZjS g7P6amhXAy3A8MTH2YivI6QAOzqoM4YVgs8bon154bEvl614EDxGvS2f3HDxjB7I6hMMGdMG6InpY xkKJw4QUdBwSO2h/Dq4l/Lrl9bljG5TKB1foSi9C6QjUZoA6e0u05s8pq5lAFvQU4f9MpKJqPc50q LRE4B0JVluK6OhlGeHkzpXprpb9lQag0JUEGY8odsXvbNBJuDM/Klzo6uXma3atSgB7lCPdC7eIgB j2kgdck8zIN/g0yA6fivbHDh17B+VYnKLv8frjkxP1MOvsOc+mjuES3PhtbINubHCyw4daLcEeNVz ffyH3KCg==; Received: from 213-225-8-167.nat.highway.a1.net ([213.225.8.167] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouFrK-00CJs5-Tj; Sun, 13 Nov 2022 16:29:27 +0000 From: Christoph Hellwig To: Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: [PATCH 5/9] hfsplus: remove ->writepage Date: Sun, 13 Nov 2022 17:28:58 +0100 Message-Id: <20221113162902.883850-6-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221113162902.883850-1-hch@lst.de> References: <20221113162902.883850-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668356974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MwWj9ekijv12iDbEn7vuZCjsvgidcmcKtSd/iPVo/3U=; b=lJWGxtldqUVgch0kaoOSTyua+QnZn5dbkeNFyX9JN3oRndrQz9WSky4pxvOi7J15Rq2Tge 1qnWWBy2DprGkf+MIaz6k5m/Joz2fIEQXqWDcXlLI6RAMJ/ZZHsOuoAwEJHQQFsRK5QsDu 8csI6XeC3xH3thAUFu8aR8s/SPQ9xXU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="sX+/TxS5"; dmarc=none; spf=none (imf03.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668356974; a=rsa-sha256; cv=none; b=uZ4W/xOL6XQOCKB73bNzk4aHeT7SsDKmvkx9YLqNOP5+rOZZrUwECjR7qowS23ZIPzBZaZ vXlU1z2mJalNnlb06UhS2QxjD11XD/NBWNapRFNrjHRqGG20SuVPNcfEmULMHzmvI9FWRo VjRiuIuYJnoD/B1WigO2HEqENa4L/bQ= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 11DD320003 X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="sX+/TxS5"; dmarc=none; spf=none (imf03.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org X-Stat-Signature: x75ndetepzx1izot3p66696djfgkg63k X-HE-Tag: 1668356973-358392 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and stop wiring up ->writepage for hfsplus_aops. Signed-off-by: Christoph Hellwig --- fs/hfsplus/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c index aeab83ed1c9c6..d6572ad2407a7 100644 --- a/fs/hfsplus/inode.c +++ b/fs/hfsplus/inode.c @@ -170,12 +170,12 @@ const struct address_space_operations hfsplus_aops = { .dirty_folio = block_dirty_folio, .invalidate_folio = block_invalidate_folio, .read_folio = hfsplus_read_folio, - .writepage = hfsplus_writepage, .write_begin = hfsplus_write_begin, .write_end = generic_write_end, .bmap = hfsplus_bmap, .direct_IO = hfsplus_direct_IO, .writepages = hfsplus_writepages, + .migrate_folio = buffer_migrate_folio, }; const struct dentry_operations hfsplus_dentry_operations = { From patchwork Sun Nov 13 16:28:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13041579 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46BEEC4332F for ; Sun, 13 Nov 2022 16:29:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E09C880009; Sun, 13 Nov 2022 11:29:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB8FF8E0001; Sun, 13 Nov 2022 11:29:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD15780009; Sun, 13 Nov 2022 11:29:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BECBF8E0001 for ; Sun, 13 Nov 2022 11:29:39 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 89DFE80783 for ; Sun, 13 Nov 2022 16:29:39 +0000 (UTC) X-FDA: 80128954878.08.CBA650B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf24.hostedemail.com (Postfix) with ESMTP id 02DC618000B for ; Sun, 13 Nov 2022 16:29:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=MEfXNy0oYvg+oByXyXaf2fLih3PRNTBnoHWoUbGvyo0=; b=1CYlSCKTrhaufOIQITLboWc3nv 5XP8UaQ6updySgkzvHd+U0qG7p63m8ky3bOXtD/C5Lv62v2DvM+6ycEE2NyriXXCT8GlQRzLkqwHl PjPioAVEb5Yi1VFqlE9lmvf0ARj8+YcM96t2AnpdL5Xial7ovi4MPfSFEzQBZMV/phYO54KwQiuAa jrzM3eetiPkSNibuVO6DW7XDWDELhJbeCrOOgoSz5vfvh2lTcMcq9ewYxCv8wljb/FihZUdKoZqRd /jeBjIMEvgKWGdgnNgGodWrmTB6NEAkqivpO9lhBFpdyHBPdRoYsNw6dKFJScAZk7eCy9QCvG7ZiI tKo1bOOw==; Received: from 213-225-8-167.nat.highway.a1.net ([213.225.8.167] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouFrP-00CJu6-H9; Sun, 13 Nov 2022 16:29:32 +0000 From: Christoph Hellwig To: Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: [PATCH 6/9] hpfs: remove ->writepage Date: Sun, 13 Nov 2022 17:28:59 +0100 Message-Id: <20221113162902.883850-7-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221113162902.883850-1-hch@lst.de> References: <20221113162902.883850-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668356979; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MEfXNy0oYvg+oByXyXaf2fLih3PRNTBnoHWoUbGvyo0=; b=EYfx1ZSV3YfKTnOumpMqYqJWL67c3gysMcuxoaIoJondVMU4IIvVn4oZKqJAtKp+24NNbm n5xLTon3buDGS57Hez50TqCf14fqO9jkcyHzY2DCwGKpvpltgeKuLvJYhLt5QUOkG1qAd1 +pNKm4Ovo6Kb+zlMFNYN12YJcv/iCh0= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1CYlSCKT; spf=none (imf24.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668356979; a=rsa-sha256; cv=none; b=ahhMxxRz3LCnbeUa6Sd3Fy/omZjxP8Vd+yOwJQR2uIPofMqaNX9T/3aMJykkGY+sBXa2bH 58YLRje//7t/KseqyqFHYYTMHd7c9FuGnC4zoply9dUNOyw18mkH44MrzV5U0Tb9j804H0 MNyXLTbO7usJMC3AQU88Kr5mvfRzwUs= X-Stat-Signature: fx9yrfmx56b1kz874mkqqdka4znxsr8u X-Rspamd-Queue-Id: 02DC618000B Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1CYlSCKT; spf=none (imf24.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1668356978-636201 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and remove the ->writepage implementation. Signed-off-by: Christoph Hellwig --- fs/hpfs/file.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/fs/hpfs/file.c b/fs/hpfs/file.c index f7547a62c81f6..88952d4a631e6 100644 --- a/fs/hpfs/file.c +++ b/fs/hpfs/file.c @@ -163,11 +163,6 @@ static int hpfs_read_folio(struct file *file, struct folio *folio) return mpage_read_folio(folio, hpfs_get_block); } -static int hpfs_writepage(struct page *page, struct writeback_control *wbc) -{ - return block_write_full_page(page, hpfs_get_block, wbc); -} - static void hpfs_readahead(struct readahead_control *rac) { mpage_readahead(rac, hpfs_get_block); @@ -248,12 +243,12 @@ const struct address_space_operations hpfs_aops = { .dirty_folio = block_dirty_folio, .invalidate_folio = block_invalidate_folio, .read_folio = hpfs_read_folio, - .writepage = hpfs_writepage, .readahead = hpfs_readahead, .writepages = hpfs_writepages, .write_begin = hpfs_write_begin, .write_end = hpfs_write_end, - .bmap = _hpfs_bmap + .bmap = _hpfs_bmap, + .migrate_folio = buffer_migrate_folio, }; const struct file_operations hpfs_file_ops = From patchwork Sun Nov 13 16:29:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13041580 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7631C43217 for ; Sun, 13 Nov 2022 16:29:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F6C28000A; Sun, 13 Nov 2022 11:29:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A69C8E0001; Sun, 13 Nov 2022 11:29:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BCF28000A; Sun, 13 Nov 2022 11:29:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1E5388E0001 for ; Sun, 13 Nov 2022 11:29:44 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F0E9F1A0865 for ; Sun, 13 Nov 2022 16:29:43 +0000 (UTC) X-FDA: 80128955046.27.F57277A Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP id A3E068000A for ; Sun, 13 Nov 2022 16:29:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=w51Gvl8Pnmlo1SbhqS+2F9D21dBv4WKLApDvNFY66GQ=; b=12jZrKibqe1Nhuji9ZkFAX7X7U zZRaAN35VMESX41fHQaIN3Y8uy3rvUKp558Q1qTZy7IH6vjy/+JY1DG/SyqYz0x7Vb/uNvgwuO58f CvLCcoK8mV/d7Iaqx80ikp/fP+MZy5kDdVxF3CQ3y5IXhBeY05lW4tc3Bg6CaHRfR2F5y5YJBeWwB wuYNoNFXOP2q3Vg6lbNRCrmU+s50dJFkLl6DHMkzRi/4sMhcDsupdlw/VCMKtF6w0vEbDsbfJ+QAc mK0uM1NdinJqK8frxy1ZOfQgGsg5ywHowa4wlWgn7MO53yUPZnSbKo/HQef/TmbMWXA3HCQX3kyrk CV+B6PAQ==; Received: from 213-225-8-167.nat.highway.a1.net ([213.225.8.167] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouFrU-00CJz6-4l; Sun, 13 Nov 2022 16:29:37 +0000 From: Christoph Hellwig To: Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: [PATCH 7/9] jfs: remove ->writepage Date: Sun, 13 Nov 2022 17:29:00 +0100 Message-Id: <20221113162902.883850-8-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221113162902.883850-1-hch@lst.de> References: <20221113162902.883850-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668356983; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w51Gvl8Pnmlo1SbhqS+2F9D21dBv4WKLApDvNFY66GQ=; b=FLR0roVevSkZaGm7Bw0pI9++b/XwE0cQ8pfDeuajeg3YbLz4BMSVQNXVzQijteJ/EiPmSx XhC/QdOXz8l4AWq+flaRcaOYmYL3G3Clu55HBuAxVHB6Lf2Gmj0qQnXrDkxYdI5xyobhAB SQmQzjSz25Xz//lVexC4hC5zAkiYMc8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=12jZrKib; dmarc=none; spf=none (imf02.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668356983; a=rsa-sha256; cv=none; b=YSeVGFL/SGa9cZloxDM3WMz5AwonlzGL7EPbYP0cOSkQz7dhTT834Ic8ZXR2fH6MMHIb2B hOj4G5gawAnVa8i2col6GibSdsS0J8Ej+5g0zqnZyThD+zip3fY7uHsQf2GKycmYVObIsd YWGXi+18SrAilVs+LKRR/iFPzo/Bl3w= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A3E068000A X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=12jZrKib; dmarc=none; spf=none (imf02.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org X-Stat-Signature: 1wd8mdee6tx7x787bc5mwkrgufqddi3w X-HE-Tag: 1668356983-490179 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and remove the ->writepage implementation. Signed-off-by: Christoph Hellwig Acked-by: Dave Kleikamp --- fs/jfs/inode.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c index d1ec920aa030a..8ac10e3960508 100644 --- a/fs/jfs/inode.c +++ b/fs/jfs/inode.c @@ -264,11 +264,6 @@ int jfs_get_block(struct inode *ip, sector_t lblock, return rc; } -static int jfs_writepage(struct page *page, struct writeback_control *wbc) -{ - return block_write_full_page(page, jfs_get_block, wbc); -} - static int jfs_writepages(struct address_space *mapping, struct writeback_control *wbc) { @@ -355,12 +350,12 @@ const struct address_space_operations jfs_aops = { .invalidate_folio = block_invalidate_folio, .read_folio = jfs_read_folio, .readahead = jfs_readahead, - .writepage = jfs_writepage, .writepages = jfs_writepages, .write_begin = jfs_write_begin, .write_end = jfs_write_end, .bmap = jfs_bmap, .direct_IO = jfs_direct_IO, + .migrate_folio = buffer_migrate_folio, }; /* From patchwork Sun Nov 13 16:29:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13041581 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0463C4332F for ; Sun, 13 Nov 2022 16:29:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 508CE8000B; Sun, 13 Nov 2022 11:29:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 491418E0001; Sun, 13 Nov 2022 11:29:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35A608000B; Sun, 13 Nov 2022 11:29:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 26EBA8E0001 for ; Sun, 13 Nov 2022 11:29:52 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E0B1C140206 for ; Sun, 13 Nov 2022 16:29:51 +0000 (UTC) X-FDA: 80128955382.14.9242A34 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf10.hostedemail.com (Postfix) with ESMTP id 6E85EC0007 for ; Sun, 13 Nov 2022 16:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=JwXtoXGkop9hD0FEm0hcYM7qnY+377I44KCoQqxQtJQ=; b=wUYRXq26nhv9xpe10rc5HsZITE lyn4MpFMto7QmgQTl2vzV7N0OM3s3fH/vVK2gc5+nQAg7RUdFqAQIHC9tXpykqfwdb/4vzmPQh+lH 2t+TwS1cXGwjpc8wmOruGdig1C1L6zUH3SJ6XYsmuv5SWrNO1SMwly55DS7CPWsvX0ZmHGGzQ+89Z O6uLnzEwgb9YwWHpR4qlN46nYLU9yI9eGZneYZOVFIVUHbMKNmX+cpGz/I3PZP1/4xb+KrGPBkfEY nzGNfI87UnslNJ6EK4QHPF6dLHI30feek9fYrI1OIbxl3VX/SF5ap3Hw14YmVPSAqOAuXL/6kRnxF jvSsVVYg==; Received: from 213-225-8-167.nat.highway.a1.net ([213.225.8.167] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouFrZ-00CK21-8R; Sun, 13 Nov 2022 16:29:42 +0000 From: Christoph Hellwig To: Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: [PATCH 8/9] omfs: remove ->writepage Date: Sun, 13 Nov 2022 17:29:01 +0100 Message-Id: <20221113162902.883850-9-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221113162902.883850-1-hch@lst.de> References: <20221113162902.883850-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668356991; a=rsa-sha256; cv=none; b=J2dXlWxNJwsLPSXuSUvgXnpmDhInoExUornUHlS37DI7SE/GQIBHKcvsFpFWVNZ/7c+mwk Cp4ZwAdkicf+QIOk47+kwpuYVfS0t57O8tUfTqbusKYloPXtG2mdqQp0bpX3HEHzqrST2v uto8Sl8QSFVkI2QP/i/srsUJawGmCME= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=wUYRXq26; dmarc=none; spf=none (imf10.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668356991; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JwXtoXGkop9hD0FEm0hcYM7qnY+377I44KCoQqxQtJQ=; b=CAbEgkH1+kXIGRy90h1ofun30Jwg39x2HkACrUrLPTSABXZ2X55eDcZpyUlONrSwkH7tuW WTdBpa9fCUppzobv5RWj/3pDXVsynmevmDtWp+lg4R76sN6CbY6lsBdLfgibXOymvQTNAK Zn4rrvdhyJzUAyIIkCI9MIIzbahtiPk= X-Rspam-User: X-Stat-Signature: g6brdu1fbnrxfffjfid9e3wruq7h7g98 X-Rspamd-Queue-Id: 6E85EC0007 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=wUYRXq26; dmarc=none; spf=none (imf10.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam03 X-HE-Tag: 1668356991-659964 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and remove the ->writepage implementation. Signed-off-by: Christoph Hellwig Acked-by: Bob Copeland --- fs/omfs/file.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/omfs/file.c b/fs/omfs/file.c index fa7fe2393ff68..3a5b4b88a5838 100644 --- a/fs/omfs/file.c +++ b/fs/omfs/file.c @@ -294,11 +294,6 @@ static void omfs_readahead(struct readahead_control *rac) mpage_readahead(rac, omfs_get_block); } -static int omfs_writepage(struct page *page, struct writeback_control *wbc) -{ - return block_write_full_page(page, omfs_get_block, wbc); -} - static int omfs_writepages(struct address_space *mapping, struct writeback_control *wbc) { @@ -375,10 +370,10 @@ const struct address_space_operations omfs_aops = { .invalidate_folio = block_invalidate_folio, .read_folio = omfs_read_folio, .readahead = omfs_readahead, - .writepage = omfs_writepage, .writepages = omfs_writepages, .write_begin = omfs_write_begin, .write_end = generic_write_end, .bmap = omfs_bmap, + .migrate_folio = buffer_migrate_folio, }; From patchwork Sun Nov 13 16:29:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 13041582 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BF7EC433FE for ; Sun, 13 Nov 2022 16:29:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBF608E0001; Sun, 13 Nov 2022 11:29:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B70C48000C; Sun, 13 Nov 2022 11:29:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A37998E0003; Sun, 13 Nov 2022 11:29:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 908DE8E0001 for ; Sun, 13 Nov 2022 11:29:53 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5C3901A090A for ; Sun, 13 Nov 2022 16:29:53 +0000 (UTC) X-FDA: 80128955466.05.92C0E3F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id 10ECA12000C for ; Sun, 13 Nov 2022 16:29:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=d1VC7GrQaMZNbkdOyDmdF6TZukkUpzM8YbBGwowHmIU=; b=vR2Urw0mBBapzzTe+ueUjxIcY0 Olt8+7T4BHw+h4YYCYE28AfjUTK6KSXgjUNvFMF/cmF0x/SDDKAKBik7JeJNB3hk5Ij/4zY/sb7gp yfsEo+ErnNnXsbVrPMQhy7zKjBT9bpHmYGUFOh/sFVFF0DAOWtuD+RUHdn5B80Ft2T/6v5qm15H/7 P0+sCUGI+u4iM+v5TLUgUFyeDIh426tTZEO/p/akvkKG1E21tuVTNqVxXFnDAcvN+N7dKSZfgpHoR B4oxYYk8vVaZcWWkAfypcY4RCswZTj1zxhrBiOcPSXylEvUYj0wdK5RVg/QvdvkPtJbdunpGgS+gb b3qp9j2Q==; Received: from 213-225-8-167.nat.highway.a1.net ([213.225.8.167] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouFrd-00CK5A-Ob; Sun, 13 Nov 2022 16:29:46 +0000 From: Christoph Hellwig To: Namjae Jeon , Sungjong Seo , Jan Kara , OGAWA Hirofumi , Mikulas Patocka , Dave Kleikamp , Bob Copeland Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-karma-devel@lists.sourceforge.net, linux-mm@kvack.org Subject: [PATCH 9/9] udf: remove ->writepage Date: Sun, 13 Nov 2022 17:29:02 +0100 Message-Id: <20221113162902.883850-10-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221113162902.883850-1-hch@lst.de> References: <20221113162902.883850-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668356993; a=rsa-sha256; cv=none; b=VD1M/qYplcA0izn90ySzrQhwVwCXW6vYbzin3377Ti7CUuG+C2Lgf43+MkPCxjB1MJS4cs QJqDfPKjvT830RQ2Df9ci3XgIg2bF9hD3GIZs5utl200YB8UaJYSJ3Eb2O+3GHrRTzvhUm fdt75Ph+IwsqjVPCd+lRVw0qzCg0ldY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=vR2Urw0m; dmarc=none; spf=none (imf29.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668356993; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d1VC7GrQaMZNbkdOyDmdF6TZukkUpzM8YbBGwowHmIU=; b=M1dVFLNEp81Fhn7q8uwoAt5F8hCSqvUDgfNVANHQ2O5IhkrKGG+MTSx5QlDgN61nkAyX2I A/B1AkU92MzBAqzCF8mCUpNXcyqkriUhpOPos16D6cPvS+8eP+92zep7FbD9EXh94kbkhM OCJlW0K5dNvbDVvgMpg2lpNWJyjr7YE= X-Rspamd-Queue-Id: 10ECA12000C X-Rspam-User: Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=vR2Urw0m; dmarc=none; spf=none (imf29.hostedemail.com: domain of BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+5e9d9a7f9455f7bb8c66+7021+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam06 X-Stat-Signature: 6mkxbxchiyjyjgt8dde3btn4b6k9f5fp X-HE-Tag: 1668356992-752461 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ->writepage is a very inefficient method to write back data, and only used through write_cache_pages or a a fallback when no ->migrate_folio method is present. Set ->migrate_folio to the generic buffer_head based helper, and remove the ->writepage implementation in extfat. Signed-off-by: Christoph Hellwig Acked-by: Jan Kara --- fs/udf/inode.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/udf/inode.c b/fs/udf/inode.c index dce6ae9ae306c..0246b1b86fb91 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c @@ -182,11 +182,6 @@ static void udf_write_failed(struct address_space *mapping, loff_t to) } } -static int udf_writepage(struct page *page, struct writeback_control *wbc) -{ - return block_write_full_page(page, udf_get_block, wbc); -} - static int udf_writepages(struct address_space *mapping, struct writeback_control *wbc) { @@ -239,12 +234,12 @@ const struct address_space_operations udf_aops = { .invalidate_folio = block_invalidate_folio, .read_folio = udf_read_folio, .readahead = udf_readahead, - .writepage = udf_writepage, .writepages = udf_writepages, .write_begin = udf_write_begin, .write_end = generic_write_end, .direct_IO = udf_direct_IO, .bmap = udf_bmap, + .migrate_folio = buffer_migrate_folio, }; /*