From patchwork Wed Nov 16 01:19:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13044308 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 241B4C4332F for ; Wed, 16 Nov 2022 01:10:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231642AbiKPBKz (ORCPT ); Tue, 15 Nov 2022 20:10:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229961AbiKPBKy (ORCPT ); Tue, 15 Nov 2022 20:10:54 -0500 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 066AC317F9 for ; Tue, 15 Nov 2022 17:10:54 -0800 (PST) Received: by mail-qk1-x733.google.com with SMTP id i9so10734473qki.10 for ; Tue, 15 Nov 2022 17:10:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dXQuLH03XzUYi6+WgpNrxfrW2ANmPdXWWQXUz58Src0=; b=pbVRgtdVlmQ6+ZnkkUeA+h62H1wicgMLv8OTs3EJoRp67w9M+muDcdp8mDdOKnajt+ BqG6UgRuoJnlfx9O3jvojS/9mNz9WbSxsiBWe0TMkOOt7bO+Lu9Ktqw2HF+7d09oRqGe SJqsyrgFdKdCacc3dimrWDsUiBn2u1lmu46uEwDwCEgHOcN+pzt+ns+ttFoMa4edwjjp r6aJcIUPuR8Y6BakuqgaG27pNahfFuNK1ss8RjzsMkkOP79IpVZ/zHXpswD7Wh+xVr5f 6ZGOoh1LDM+nX2XqIn9hJTZZWLclYt82H1w6JT6F32FwypHYlQDR5ulyAkBGkdfQjKM/ bY2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dXQuLH03XzUYi6+WgpNrxfrW2ANmPdXWWQXUz58Src0=; b=dY5RjGf4gc+YINU0T2L5Mnf4cnJYugujzBOodQXq1ZF2dEl9ymmY3/Xp0wxYxj054v sCUpmrEbHAtUybHX+bCOq0YjN/L5AzZ5pNk+e93Hpp2BMhKDR2F/W5FGq7dHUssztKnZ JwXW/lAoWkKk5XTTfBaUnSgPsTiyK6ZxoNv4zFyFuWVLH6L8GNCLzdlttKDHNbMxxKr3 3Cy4f98BXbfomua3dwhc/4rFIkizcXspZW19kgM8u0FUADGe+XIsUewFhY4YTiJjW6Ev 3WCZl3bxUsTQkvJ3Wrfp+NLxVm0NraANFcnJ1WTroB8XwKU8sQaSkrq5k+fldDelgDhl BVIQ== X-Gm-Message-State: ANoB5pkiw/VbQyBDC8XPMvDxXUDOBTDbuPAgwpJyhGK6VYI3SeBMTOlw sP8BIGjnC3q8t9I99WGmTi2nmzdNBYw= X-Google-Smtp-Source: AA0mqf7FbN6pScMCm957Qf2nw28A7eE+bi0vvsgprfvbIGoGGCu6wg1i3Eg2siX0HE6+mlpjoSZTjQ== X-Received: by 2002:a05:620a:1375:b0:6fa:ab2b:b78d with SMTP id d21-20020a05620a137500b006faab2bb78dmr17157557qkl.388.1668561053008; Tue, 15 Nov 2022 17:10:53 -0800 (PST) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id y12-20020ac8128c000000b00399b73d06f0sm7901966qti.38.2022.11.15.17.10.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Nov 2022 17:10:52 -0800 (PST) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, Justin Tee , Justin Tee Subject: [PATCH 1/6] lpfc: Fix WQ|CQ|EQ resource check Date: Tue, 15 Nov 2022 17:19:16 -0800 Message-Id: <20221116011921.105995-2-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221116011921.105995-1-justintee8345@gmail.com> References: <20221116011921.105995-1-justintee8345@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Adapter configurations with limited EQ resources may fail to initialize. Firmware resources are queried in lpfc_sli4_read_config(). The driver parameters cfg_irq_chann and cfg_hdw_queue are adjusted from defaults if constrained by firmware resources. The minimum resource check includes a special allocation for queues such as ELS, MBOX, NVME LS. However the additional reservation was also incorrectly applied to EQ resources. Reordered WQ|CQ|EQ resource checks to apply the special allocation adjustment to WQ and CQ resources only. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_init.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index b49c39569386..a6e32ecd4151 100644 --- a/drivers/scsi/lpfc/lpfc_init.c +++ b/drivers/scsi/lpfc/lpfc_init.c @@ -10092,17 +10092,15 @@ lpfc_sli4_read_config(struct lpfc_hba *phba) qmin = phba->sli4_hba.max_cfg_param.max_wq; if (phba->sli4_hba.max_cfg_param.max_cq < qmin) qmin = phba->sli4_hba.max_cfg_param.max_cq; - if (phba->sli4_hba.max_cfg_param.max_eq < qmin) - qmin = phba->sli4_hba.max_cfg_param.max_eq; /* - * Whats left after this can go toward NVME / FCP. - * The minus 4 accounts for ELS, NVME LS, MBOX - * plus one extra. When configured for - * NVMET, FCP io channel WQs are not created. + * Reserve 4 (ELS, NVME LS, MBOX, plus one extra) and + * the remainder can be used for NVME / FCP. */ qmin -= 4; + if (phba->sli4_hba.max_cfg_param.max_eq < qmin) + qmin = phba->sli4_hba.max_cfg_param.max_eq; - /* Check to see if there is enough for NVME */ + /* Check to see if there is enough for default cfg */ if ((phba->cfg_irq_chann > qmin) || (phba->cfg_hdw_queue > qmin)) { lpfc_printf_log(phba, KERN_ERR, LOG_TRACE_EVENT, From patchwork Wed Nov 16 01:19:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13044309 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1124C4332F for ; Wed, 16 Nov 2022 01:11:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231660AbiKPBLA (ORCPT ); Tue, 15 Nov 2022 20:11:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231638AbiKPBK5 (ORCPT ); Tue, 15 Nov 2022 20:10:57 -0500 Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDB2B317FF for ; Tue, 15 Nov 2022 17:10:56 -0800 (PST) Received: by mail-qk1-x72f.google.com with SMTP id k2so10748527qkk.7 for ; Tue, 15 Nov 2022 17:10:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=USbEUbJbcHadAUeL/lHg6Lme0QD4ZZZ671pCyBh9AIg=; b=FuRYAa/+LibKN1NRgfql/RnorZF4EEECnN/zzPo8uXtKlN+xZ5pTlWZJm1E7Ta7CgD nvQLtHrUaZq8V6brhCGsv5bE5fmoOfxbdw2HK92CkxZuCVCa2qHBmSTaxcsUbDLgOwtP riBPZoQ4FuyqCg5U7iQu6xwbVIJ99Akgp1sezhZUaYQQB2K4FEeVleko/YWsaBGSIgRk GqAkk9NWTJlGRUxuFHIhMF6guCpyxKZBsBYjWg3sKTkx7CeaFOq/Refd4ggyeBougQkU TOgIWcaTFUI3/aQaqXgI2WEdqw0N2CF0od/aYNejka197BO+GRC6q0Df6IwI2Lb4LeJG jqbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=USbEUbJbcHadAUeL/lHg6Lme0QD4ZZZ671pCyBh9AIg=; b=r8dWzeHlM93ZSqdRpK93+P1Ypry4zC0drK31euy+v8V7OrnRlDBk2xsz0QWPKT7R1S uGofiOUfKnqIVCKMKv5PSBFZ0F6A2hnor4DO7lJTKrAcr6BlG3WEr4JMio38tL8o6B1W YLOx+SJm8hiI0GBkcu9M9/+GfRC1ygB3l+JiXb3Edwr6abIE8+wuluT411x/EOOrF7fv 8JKiZihjq2ges1jnu/IQ9UyyNXdMb4k8pcC5EfscXQxF2OAhxlQ15H66k963/BZ5x2lc Ow+/2OdND9J4o2yCkR/deGWIIRN3/4aO1uPCiLy+fhpSRsqiRKoqbTXj5grgubOc5gQL +jgw== X-Gm-Message-State: ANoB5pnJuzITd7fvuvLmddjQWDzSKc7lEEUJ969VA6P+2ffSpEk25ppW X47SNm0Av3ewT+o7uODsH5Ul7RoiwY4= X-Google-Smtp-Source: AA0mqf6bsoS4O1HIlaJOo1BI7y4U66TkKEKGVN4bqWzP4tKZmAyxCBM8aFu30drbL6wZVDd0AXtvtw== X-Received: by 2002:a37:bb82:0:b0:6cf:4460:fdd2 with SMTP id l124-20020a37bb82000000b006cf4460fdd2mr17496905qkf.543.1668561055999; Tue, 15 Nov 2022 17:10:55 -0800 (PST) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id y12-20020ac8128c000000b00399b73d06f0sm7901966qti.38.2022.11.15.17.10.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Nov 2022 17:10:55 -0800 (PST) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, Justin Tee , Justin Tee Subject: [PATCH 2/6] lpfc: Correct bandwidth logging during receipt of congestion sync WCQE Date: Tue, 15 Nov 2022 17:19:17 -0800 Message-Id: <20221116011921.105995-3-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221116011921.105995-1-justintee8345@gmail.com> References: <20221116011921.105995-1-justintee8345@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org The lpfc_cmf_timer adjusts phba->cmf_link_byte_count periodically and can artifically inflate bandwidth percent. During bandwidth calculation, correct for this by setting a cap of logging a maximum of 100%. Bandwidth calculation is only used for display under LOG_CGN_MGMT so there is no expectation of impacts on performance. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_sli.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index d25afc9dde14..a66026432572 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -1848,6 +1848,12 @@ lpfc_cmf_sync_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, phba->cmf_link_byte_count); bwpcent = div64_u64(bw * 100 + slop, phba->cmf_link_byte_count); + /* Because of bytes adjustment due to shorter timer in + * lpfc_cmf_timer() the cmf_link_byte_count can be shorter and + * may seem like BW is above 100%. + */ + if (bwpcent > 100) + bwpcent = 100; if (phba->cmf_max_bytes_per_interval < bw && bwpcent > 95) From patchwork Wed Nov 16 01:19:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13044310 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5E06C433FE for ; Wed, 16 Nov 2022 01:11:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231669AbiKPBLG (ORCPT ); Tue, 15 Nov 2022 20:11:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231638AbiKPBLB (ORCPT ); Tue, 15 Nov 2022 20:11:01 -0500 Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31D143137B for ; Tue, 15 Nov 2022 17:11:00 -0800 (PST) Received: by mail-qt1-x82c.google.com with SMTP id cg5so9867077qtb.12 for ; Tue, 15 Nov 2022 17:11:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5IP2zZ0ikXwU/6tqJtqLv3xaAmM7FUpKnU+9266pdAo=; b=YWP+vArPap1tXdk/HQyhrjl2Oj1p/JbS1A+TMufYpIXg4ZikMgHtG/kxcC9+qxwXpO 56ix0CgLCuaQOTSnmmMfEWomEIqw+OyBOz7wQCt5oJHYuJOphi0EDpUer2qwCIGaPEDm hUFrXpS5jk5ERFnezw4841c5tocJaH5XrkNZFPuCJUyKC5BWCrjwoThzXXElRdK9EGRZ WXaFVjHYaGIk+4xg5AisfHq02xeY6sqgZMwXJtQi23ueCzXEEXyCf64gzsfsJovjHn1B Dbdf5GZ8CaOphhGjIyIaWZW8AbpkHETwMiahaOk15mf1s+kfz8rla1IZ5r8rHKfQdsvM CBIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5IP2zZ0ikXwU/6tqJtqLv3xaAmM7FUpKnU+9266pdAo=; b=6XYkQiTvTw6zS51iQyfEfP7sc6iCoP5lJ4UdM16teasiOpL3WTzuIheJIgOdSLJXrj QL0dQi+Z3t4JrmD1TFV8yfMSf4na88GHBblauDHDEjzzJOLnR/m8xjfCJCrphJrHwWaY ZSXNzuT0E+lULkL1LLir5/e+71mvNcuo0ApurUog/TOGB0NVYGZhS2o0nlQ6TZwtIFCy WKx2DIUa//F13BeP2Y1hbJ6mZu0lvh6OFuIS/1LYb+4JduGhJojsz86qUQc6L3yOaUjl tJHntE+JAMEh6fNT/cmI78I50f9/B7hJpsZhZGjKHn2ou74Btr0j/4TRJ0sr/yr8+qxh jLog== X-Gm-Message-State: ANoB5plToPbYms8cBIPZs1bsoAeQAw6UKb/vpiuJum7BEcxc9nkgCeFk +KQtw9mkRd8WeQUcokm9qJaebskWoIQ= X-Google-Smtp-Source: AA0mqf5tHFDthV6rGCIgUdWY+KmUNAC1DD8FjsptVU4lDwdlhJXvJe/iiyYrdcV9JdYSBfKR4LNonw== X-Received: by 2002:a05:622a:248c:b0:3a5:6005:7db6 with SMTP id cn12-20020a05622a248c00b003a560057db6mr19066934qtb.131.1668561059267; Tue, 15 Nov 2022 17:10:59 -0800 (PST) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id y12-20020ac8128c000000b00399b73d06f0sm7901966qti.38.2022.11.15.17.10.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Nov 2022 17:10:59 -0800 (PST) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, Justin Tee , Justin Tee Subject: [PATCH 3/6] lpfc: Fix MI capability display in cmf_info sysfs attribute Date: Tue, 15 Nov 2022 17:19:18 -0800 Message-Id: <20221116011921.105995-4-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221116011921.105995-1-justintee8345@gmail.com> References: <20221116011921.105995-1-justintee8345@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org The dynamic mi_ver value holds the currently configured MI setting. mi_ver was being displayed as part of the cmf_info sysfs attribute, when the output string meant to display MI capabilities instead. Add a mi_cap member in the lpfc_pc_sli4_params structure that will store MI capabilities during initialization so that cmf_info prints out capabilities instead of current configuration. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_attr.c | 2 +- drivers/scsi/lpfc/lpfc_init.c | 3 +++ drivers/scsi/lpfc/lpfc_sli4.h | 1 + 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index 030ad1d59cbd..77e1b2911cb4 100644 --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b/drivers/scsi/lpfc/lpfc_attr.c @@ -134,7 +134,7 @@ lpfc_cmf_info_show(struct device *dev, struct device_attribute *attr, scnprintf(tmp, sizeof(tmp), "Congestion Mgmt Info: E2Eattr %d Ver %d " "CMF %d cnt %d\n", - phba->sli4_hba.pc_sli4_params.mi_ver, + phba->sli4_hba.pc_sli4_params.mi_cap, cp ? cp->cgn_info_version : 0, phba->sli4_hba.pc_sli4_params.cmf, phba->cmf_timer_cnt); diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index a6e32ecd4151..a119c06742b8 100644 --- a/drivers/scsi/lpfc/lpfc_init.c +++ b/drivers/scsi/lpfc/lpfc_init.c @@ -699,6 +699,8 @@ lpfc_sli4_refresh_params(struct lpfc_hba *phba) return rc; } mbx_sli4_parameters = &mqe->un.get_sli4_parameters.sli4_parameters; + phba->sli4_hba.pc_sli4_params.mi_cap = + bf_get(cfg_mi_ver, mbx_sli4_parameters); /* Are we forcing MI off via module parameter? */ if (phba->cfg_enable_mi) @@ -13839,6 +13841,7 @@ lpfc_get_sli4_parameters(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq) mbx_sli4_parameters); phba->sli4_hba.extents_in_use = bf_get(cfg_ext, mbx_sli4_parameters); phba->sli4_hba.rpi_hdrs_in_use = bf_get(cfg_hdrr, mbx_sli4_parameters); + sli4_params->mi_cap = bf_get(cfg_mi_ver, mbx_sli4_parameters); /* Check for Extended Pre-Registered SGL support */ phba->cfg_xpsgl = bf_get(cfg_xpsgl, mbx_sli4_parameters); diff --git a/drivers/scsi/lpfc/lpfc_sli4.h b/drivers/scsi/lpfc/lpfc_sli4.h index cbb1aa1cf025..f927c2a25d54 100644 --- a/drivers/scsi/lpfc/lpfc_sli4.h +++ b/drivers/scsi/lpfc/lpfc_sli4.h @@ -556,6 +556,7 @@ struct lpfc_pc_sli4_params { #define LPFC_MIB3_SUPPORT 3 uint16_t mi_value; #define LPFC_DFLT_MIB_VAL 2 + uint8_t mi_cap; uint8_t mib_bde_cnt; uint8_t cmf; uint8_t cqv; From patchwork Wed Nov 16 01:19:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13044311 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7860EC4332F for ; Wed, 16 Nov 2022 01:11:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231665AbiKPBLH (ORCPT ); Tue, 15 Nov 2022 20:11:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231657AbiKPBLE (ORCPT ); Tue, 15 Nov 2022 20:11:04 -0500 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26BB231FB9 for ; Tue, 15 Nov 2022 17:11:03 -0800 (PST) Received: by mail-qk1-x732.google.com with SMTP id g10so10752226qkl.6 for ; Tue, 15 Nov 2022 17:11:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/1jMpunGh8qvSmxj3MMVrBO6QBce8gOCg1IYF8CofhI=; b=irN8HBcxtvB1JX6yPvaOhfW+ShtTtHJqE4BZUbaLDf/6u6wtiJDxfuMth2KVez5O3x xh2Hfi0L/8ZWDBXRYWikXWTMUqzwLIi1ogzqz1VZaZQE1vor9bdEU9QQ9GgHv6sYad+H vRlU6NA6OKzsnWW8Zm2gLiQfFyjDSHwK4F/Cm8IMJLJmpA4Tyze49VNWTEIRI/jUoQ6H 0fpodPoRkq9dCdY8AIHCD4TxPxyb4z+dFCW86Nc7QxCVqfUATEmYqWzirrH0mcNZF2dg 8eYvVmlBrfc+9yzX4AVlUCvIZ+8ijLYOpR2ee3MB5anTtMm4HS/3MqgKhrELygDvGIvF q9kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/1jMpunGh8qvSmxj3MMVrBO6QBce8gOCg1IYF8CofhI=; b=S0V0DTynq3kpNsxAO4uwJpJHIvkndoYFO3jT+/CXP/USFQPdo6rdnSqX+xSoNOnbmz PJpbdHd4zxkl7zvqHMFmyaS3grpbm8APksR3kM6JrR3fKO8wtsBHPLa4+zk7ouig51Y7 u0lFryLVxcL8plOqZVio8ww4zEXbzXbQQAtMXP8NkiGn267GnUaq2XiGrqv/hvsApK4A /QeBJ443qI+qMnSE5tXSWLY0Za85sbLucjENHAiKwod9GzKoqyuOVG1G62bTxuS9JDZj Yo5aX+1BTzbjO7naXuXOCv4Eb+ZK93oViI3ke2onB9oVIKZZAwCUde50IvKMqZDdck3H ziPw== X-Gm-Message-State: ANoB5plZ/XauSYg9KfCVpN5G1q5L+w0gs122BI5++X1YLID7c4LheJEr Fv4Xjpusj/UmVEB7inULUHymOzSAO1M= X-Google-Smtp-Source: AA0mqf6qzmxaXU361n9IfQ0vfLhgvrEXsKMcDXiEF4vb/VWlXG96ct3pjfzFOgoBilTwXwYSrVv7Mg== X-Received: by 2002:a05:620a:470a:b0:6ec:51cd:c376 with SMTP id bs10-20020a05620a470a00b006ec51cdc376mr17437409qkb.300.1668561062108; Tue, 15 Nov 2022 17:11:02 -0800 (PST) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id y12-20020ac8128c000000b00399b73d06f0sm7901966qti.38.2022.11.15.17.11.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Nov 2022 17:11:01 -0800 (PST) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, Justin Tee , Dietmar Hahn , Justin Tee Subject: [PATCH 4/6] lpfc: Fix crash involving race between FLOGI timeout and devloss handler Date: Tue, 15 Nov 2022 17:19:19 -0800 Message-Id: <20221116011921.105995-5-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221116011921.105995-1-justintee8345@gmail.com> References: <20221116011921.105995-1-justintee8345@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org When a FLOGI completes with a sequence timeout error, a freed kref ptr dereference crash can occur due to a timing race involving ndlp referencing in lpfc_dev_loss_tmo_callbk. Fix by ensuring the driver accounts for an outstanding FLOGI when dev_loss is active. Also, don't remove the HBA_FLOGI_OUTSTANDING flag when the FLOGI is retried to allow the driver to handle the reference counts correctly in lpfc_dev_loss_tmo_handler. Reported-by: Dietmar Hahn Tested-by: Dietmar Hahn Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_els.c | 36 +++++++++++++++++++++++++++----- drivers/scsi/lpfc/lpfc_hbadisc.c | 36 +++++++++++++++++++++++--------- 2 files changed, 57 insertions(+), 15 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 2b03210264bb..1b541d2cf827 100644 --- a/drivers/scsi/lpfc/lpfc_els.c +++ b/drivers/scsi/lpfc/lpfc_els.c @@ -952,6 +952,7 @@ lpfc_cmpl_els_flogi(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, uint16_t fcf_index; int rc; u32 ulp_status, ulp_word4, tmo; + bool flogi_in_retry = false; /* Check to see if link went down during discovery */ if (lpfc_els_chk_latt(vport)) { @@ -1022,8 +1023,23 @@ lpfc_cmpl_els_flogi(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, phba->hba_flag, phba->fcf.fcf_flag); /* Check for retry */ - if (lpfc_els_retry(phba, cmdiocb, rspiocb)) + if (lpfc_els_retry(phba, cmdiocb, rspiocb)) { + /* Address a timing race with dev_loss. If dev_loss + * is active on this FPort node, put the initial ref + * count back to stop premature node release actions. + */ + lpfc_check_nlp_post_devloss(vport, ndlp); + flogi_in_retry = true; goto out; + } + + /* The FLOGI will not be retried. If the FPort node is not + * registered with the SCSI transport, remove the initial + * reference to trigger node release. + */ + if (!(ndlp->nlp_flag & NLP_IN_DEV_LOSS) && + !(ndlp->fc4_xpt_flags & SCSI_XPT_REGD)) + lpfc_nlp_put(ndlp); lpfc_printf_vlog(vport, KERN_WARNING, LOG_TRACE_EVENT, "0150 FLOGI failure Status:x%x/x%x " @@ -1086,7 +1102,7 @@ lpfc_cmpl_els_flogi(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, spin_unlock_irq(shost->host_lock); /* - * The FLogI succeeded. Sync the data for the CPU before + * The FLOGI succeeded. Sync the data for the CPU before * accessing it. */ prsp = list_get_first(&pcmd->list, struct lpfc_dmabuf, list); @@ -1108,6 +1124,12 @@ lpfc_cmpl_els_flogi(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, vport->phba->pport->vmid_flag |= (LPFC_VMID_ISSUE_QFPA | LPFC_VMID_TYPE_PRIO); + /* + * Address a timing race with dev_loss. If dev_loss is active on + * this FPort node, put the initial ref count back to stop premature + * node release actions. + */ + lpfc_check_nlp_post_devloss(vport, ndlp); if (vport->port_state == LPFC_FLOGI) { /* * If Common Service Parameters indicate Nport @@ -1198,7 +1220,9 @@ lpfc_cmpl_els_flogi(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, lpfc_issue_clear_la(phba, vport); } out: - phba->hba_flag &= ~HBA_FLOGI_OUTSTANDING; + if (!flogi_in_retry) + phba->hba_flag &= ~HBA_FLOGI_OUTSTANDING; + lpfc_els_free_iocb(phba, cmdiocb); lpfc_nlp_put(ndlp); } @@ -1365,15 +1389,17 @@ lpfc_issue_els_flogi(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp, return 1; } + /* Avoid race with FLOGI completion and hba_flags. */ + phba->hba_flag |= (HBA_FLOGI_ISSUED | HBA_FLOGI_OUTSTANDING); + rc = lpfc_issue_fabric_iocb(phba, elsiocb); if (rc == IOCB_ERROR) { + phba->hba_flag &= ~(HBA_FLOGI_ISSUED | HBA_FLOGI_OUTSTANDING); lpfc_els_free_iocb(phba, elsiocb); lpfc_nlp_put(ndlp); return 1; } - phba->hba_flag |= (HBA_FLOGI_ISSUED | HBA_FLOGI_OUTSTANDING); - /* Clear external loopback plug detected flag */ phba->link_flag &= ~LS_EXTERNAL_LOOPBACK; diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c index d38ebd7281b9..80375d73b732 100644 --- a/drivers/scsi/lpfc/lpfc_hbadisc.c +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c @@ -426,10 +426,6 @@ lpfc_dev_loss_tmo_handler(struct lpfc_nodelist *ndlp) name = (uint8_t *)&ndlp->nlp_portname; phba = vport->phba; - spin_lock_irqsave(&ndlp->lock, iflags); - ndlp->nlp_flag &= ~NLP_IN_DEV_LOSS; - spin_unlock_irqrestore(&ndlp->lock, iflags); - if (phba->sli_rev == LPFC_SLI_REV4) fcf_inuse = lpfc_fcf_inuse(phba); @@ -451,22 +447,36 @@ lpfc_dev_loss_tmo_handler(struct lpfc_nodelist *ndlp) *name, *(name+1), *(name+2), *(name+3), *(name+4), *(name+5), *(name+6), *(name+7), ndlp->nlp_DID); + + spin_lock_irqsave(&ndlp->lock, iflags); + ndlp->nlp_flag &= ~NLP_IN_DEV_LOSS; + spin_unlock_irqrestore(&ndlp->lock, iflags); return fcf_inuse; } /* Fabric nodes are done. */ if (ndlp->nlp_type & NLP_FABRIC) { spin_lock_irqsave(&ndlp->lock, iflags); - /* In massive vport configuration settings, it's possible - * dev_loss_tmo fired during node recovery. So, check if - * fabric nodes are in discovery states outstanding. + + /* In massive vport configuration settings or when the FLOGI + * completes with a sequence timeout, it's possible + * dev_loss_tmo fired during node recovery. The driver has to + * account for this race to allow for recovery and keep + * the reference counting correct. */ switch (ndlp->nlp_DID) { case Fabric_DID: fc_vport = vport->fc_vport; - if (fc_vport && - fc_vport->vport_state == FC_VPORT_INITIALIZING) - recovering = true; + if (fc_vport) { + /* NPIV path. */ + if (fc_vport->vport_state == + FC_VPORT_INITIALIZING) + recovering = true; + } else { + /* Physical port path. */ + if (phba->hba_flag & HBA_FLOGI_OUTSTANDING) + recovering = true; + } break; case Fabric_Cntl_DID: if (ndlp->nlp_flag & NLP_REG_LOGIN_SEND) @@ -514,6 +524,9 @@ lpfc_dev_loss_tmo_handler(struct lpfc_nodelist *ndlp) return fcf_inuse; } + spin_lock_irqsave(&ndlp->lock, iflags); + ndlp->nlp_flag &= ~NLP_IN_DEV_LOSS; + spin_unlock_irqrestore(&ndlp->lock, iflags); lpfc_nlp_put(ndlp); return fcf_inuse; } @@ -552,6 +565,9 @@ lpfc_dev_loss_tmo_handler(struct lpfc_nodelist *ndlp) return fcf_inuse; } + spin_lock_irqsave(&ndlp->lock, iflags); + ndlp->nlp_flag &= ~NLP_IN_DEV_LOSS; + spin_unlock_irqrestore(&ndlp->lock, iflags); if (!(ndlp->fc4_xpt_flags & NVME_XPT_REGD)) lpfc_disc_state_machine(vport, ndlp, NULL, NLP_EVT_DEVICE_RM); From patchwork Wed Nov 16 01:19:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13044312 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16BA2C43219 for ; Wed, 16 Nov 2022 01:11:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231697AbiKPBLI (ORCPT ); Tue, 15 Nov 2022 20:11:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231675AbiKPBLG (ORCPT ); Tue, 15 Nov 2022 20:11:06 -0500 Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2BE63137B for ; Tue, 15 Nov 2022 17:11:05 -0800 (PST) Received: by mail-qt1-x82a.google.com with SMTP id s4so9880930qtx.6 for ; Tue, 15 Nov 2022 17:11:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=er0G09q8o36NMshGDrN680PITs1a8FejDsuIUwfURZs=; b=Y8JXH2xqMHccMowtJwQ+SbdjOay86OxX8Cn4stZFl74VEPDWzLerNAYFtPDj8aBp1o iif06LhPkkzZyt7jwY44kkqOroqFGLY+bkZK/8qir2+uww/DbD0Mg6V7Yta/zzLi0E93 ssX638yg/ZWr1SVV2HeGf+XXnS8kwM49wTYwTI+5jA9gPaM9nyxkmTRsgOyZYEPHjLMg +n0Aoa7j/n2/W0z7CFE72WsThhGGoY6A8w+OiA5rLwtwI9DFYiHEtaMkLWn4PVUOo2pH bq2dgVqxLz2rwfJaXR5+jfF+dJH1R+vT7Mj3QrjE+uBG/EqvWrKE/B1KyNtkvAyneB84 YCdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=er0G09q8o36NMshGDrN680PITs1a8FejDsuIUwfURZs=; b=3KI7g4rKUh5OgS3pF3yP+xG2WOsp/HnOKvK30hap+3ztuFfseIUAr3TQ9iVdcU5IfH W4GqhzGOj41K2zMiTY48OnQka1uTiioOxtbH0UPnARoE5/V/VxMvcBJ4WZYUyyF1aGLY /lBD2d2mXD8WkNkHQSyNvN70FRAoL7nG/zzzVZF/CtzW+oABZKX9Tuoqffer+zehL38E bo0vqGD6yrWZmvN+ngaH954rTofbamppDB0qwvzB9StDr1zwQymUVd8pjVVg8h8JZlTI TlsGJGAIvUpHLmTJQMPfObAxh22hwsHuf1iFS/ahIfH6izRGqCwZ4RTA02X4Sr0KbvZ2 yL8g== X-Gm-Message-State: ANoB5pn0F5xITKpnPvOBabJGtw7P4GD2PiC5rbfkBjfyLylMOF+QGIGO lGKJTSmnrqWFlWO3scDv9RYhShNdKho= X-Google-Smtp-Source: AA0mqf6Kxx2/ORn938DKGrI/lBZU5+vT7rvWjM9jzDs/kVsFI4idTA/fLVWs62ifP2ApXI4guE4DWw== X-Received: by 2002:a05:622a:15c3:b0:3a5:9672:a26e with SMTP id d3-20020a05622a15c300b003a59672a26emr19219904qty.587.1668561065037; Tue, 15 Nov 2022 17:11:05 -0800 (PST) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id y12-20020ac8128c000000b00399b73d06f0sm7901966qti.38.2022.11.15.17.11.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Nov 2022 17:11:04 -0800 (PST) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, Justin Tee , Justin Tee Subject: [PATCH 5/6] lpfc: Change default lpfc_suppress_rsp mode to off Date: Tue, 15 Nov 2022 17:19:20 -0800 Message-Id: <20221116011921.105995-6-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221116011921.105995-1-justintee8345@gmail.com> References: <20221116011921.105995-1-justintee8345@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org The suppress response feature is non-standard and causes difficulties when troubleshooting with analyzer wiretraces. At this time, diagnostic capabilities triumphs slight performance enhancements provided by this feature. Thus, turn it off by default. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_attr.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index 77e1b2911cb4..bf80b462f3a5 100644 --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b/drivers/scsi/lpfc/lpfc_attr.c @@ -3828,13 +3828,13 @@ lpfc_vport_param_store(devloss_tmo) static DEVICE_ATTR_RW(lpfc_devloss_tmo); /* - * lpfc_suppress_rsp: Enable suppress rsp feature is firmware supports it - * lpfc_suppress_rsp = 0 Disable - * lpfc_suppress_rsp = 1 Enable (default) + * lpfc_suppress_rsp: Enable suppress rsp feature if firmware supports it + * lpfc_suppress_rsp = 0 Disable (default) + * lpfc_suppress_rsp = 1 Enable * */ -LPFC_ATTR_R(suppress_rsp, 1, 0, 1, - "Enable suppress rsp feature is firmware supports it"); +LPFC_ATTR_R(suppress_rsp, 0, 0, 1, + "Enable suppress rsp feature if firmware supports it"); /* * lpfc_nvmet_mrq: Specify number of RQ pairs for processing NVMET cmds From patchwork Wed Nov 16 01:19:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13044313 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45D0DC433FE for ; Wed, 16 Nov 2022 01:11:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231714AbiKPBLM (ORCPT ); Tue, 15 Nov 2022 20:11:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231684AbiKPBLJ (ORCPT ); Tue, 15 Nov 2022 20:11:09 -0500 Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6396D32041 for ; Tue, 15 Nov 2022 17:11:08 -0800 (PST) Received: by mail-qt1-x82c.google.com with SMTP id jr19so9875962qtb.7 for ; Tue, 15 Nov 2022 17:11:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=va6z4skUjBuTA6wLqVS0c5wezs8fA2I6HL5Adpgt554=; b=Wzcs0mHslv64fkl63BLh+IEqGaaBywTcFYmqAnObUgx+SRbtJZW8WEVqfSAUyZfEcn mNe9gOmSmCQP138S6W3KLiYpQHi/biys8eDWRBq6aF956fUDRkfU5/JfvWuL0YKbVFUo 41Y8yLB6X4YMREQD8cG6V4TFq3DLsLr6uI+PSpRgGN8NteW+Vw8bK0cRuwEupZTMz3mf aw3ra3+nYb6UQWf5o0+8J8uP1abnZhUe0276WEnh5SmtnVRv6OdDwnoIPpxrwGKej1O0 s0JhOoqauAvzaMlQKa4IKOUMuYGXdZyQYq+L9RwAODVSWnJZkpwiUW2Bj/vVympCie8s 2evQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=va6z4skUjBuTA6wLqVS0c5wezs8fA2I6HL5Adpgt554=; b=uc72v484rRGJsHdMCIa/Qyx7OQQkoj1zLOkh1WaknJiYrxV5K7u6YBNX8E7bK4GKkN eqxsK8Ny4U/ajP9SxxRIfj3QWn6RPoqIumdklPX6U4MQ3O3baZUMsvi8VTJ29naXpXQg pSM+bkW7+T2arpZSHyKCrAO92TY9Ey7YXsgzduPJjDMUxYVP4XFc8wodp1xrlOhDYDWq S86DPW1qdYkxERYZTJrhX4t46f+XsEMK860yVSh3BKa7+tmkL36DDzgVd6wABH/Lb44B 4PGGywGSABq/wLwLRNmKfLqOxuQm8uWs7LxqL8iYFZ+3E3+JwPpvyYbX+XXAFIzMc6v8 7Ngg== X-Gm-Message-State: ANoB5pmKmYsGqoPS894755Jy7nvLisVpGQftJVsl7jHN92s3Fr2wgWpl lbxx7Qw25uCx4YWai1u0gMZHSZQ6jXc= X-Google-Smtp-Source: AA0mqf4/ZvH4GQ/ToF+UxflWddqIRGvusW7zJYz2TYEk8mCGA9HSPPx77dSFHiZcdWKrqivwNOoM9w== X-Received: by 2002:ac8:5455:0:b0:3a5:2fd6:cf82 with SMTP id d21-20020ac85455000000b003a52fd6cf82mr19194311qtq.62.1668561067369; Tue, 15 Nov 2022 17:11:07 -0800 (PST) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id y12-20020ac8128c000000b00399b73d06f0sm7901966qti.38.2022.11.15.17.11.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Nov 2022 17:11:07 -0800 (PST) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, Justin Tee , Justin Tee Subject: [PATCH 6/6] lpfc: Update lpfc version to 14.2.0.9 Date: Tue, 15 Nov 2022 17:19:21 -0800 Message-Id: <20221116011921.105995-7-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221116011921.105995-1-justintee8345@gmail.com> References: <20221116011921.105995-1-justintee8345@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Update lpfc version to 14.2.0.9 Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index 378eba7b09d9..41a1128f8651 100644 --- a/drivers/scsi/lpfc/lpfc_version.h +++ b/drivers/scsi/lpfc/lpfc_version.h @@ -20,7 +20,7 @@ * included with this package. * *******************************************************************/ -#define LPFC_DRIVER_VERSION "14.2.0.8" +#define LPFC_DRIVER_VERSION "14.2.0.9" #define LPFC_DRIVER_NAME "lpfc" /* Used for SLI 2/3 */