From patchwork Thu Nov 17 12:59:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13046859 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 916A2C433FE for ; Thu, 17 Nov 2022 13:01:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bd94TBVWk7Hvo1Sdcf7UDi3PlZB45u5Bur65b+yoiUs=; b=qPlQqswzmlhUj1 lxkHQQJtquLUznKiyEpfygRUMc/xSux7RcDOp1IrE2zThT2j6UhZhpOQS6jAmXe9eD/BGVIN2jhdR /lYBTjS/GBYpYs5WdOEEx74B7Rlb6pYGtrVJ7SFLahSGv+gVA7uoLAbpWitQW7a3LzhZwdIoohyUN PUvCpzjhZ4xUlGrotXQy0n7OZnsRGpy3TzaT/E+7R8Vs1lvS7eUiO9oEXQ5rm+26uipgFmyhbRv+e AFlzMmbHwMxJnYMB5HjVo8kYerZa0/FZwVw1p9m6TjqfPAuYXZBj+n4MRiOLRhymnWv/YN1IqsLxU +moqC78MXW4r1ANfl6YA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oveVQ-00E0bn-Eh; Thu, 17 Nov 2022 13:00:36 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oveV6-00E0SV-Uz; Thu, 17 Nov 2022 13:00:18 +0000 Received: from ideasonboard.com (unknown [103.251.226.79]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 40ED01056; Thu, 17 Nov 2022 14:00:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668690008; bh=L3iuePaXU3I9Th2qNYgsdcfyya4frF4sh5w4xXhH/fY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gVaArLR5O9TBGGuWPC3CfM1iuFvXyUKFVxxhv+yzpg3QVEQzWVwMpGl70m0102nK1 LdEaQNAkhfeFlHjsoe9Orw56peP3CKcNLFBuoqnBLNBpTM6HiAr+ie/sFR4ewIN7oK qvJsHRQ/ptgyN6FK0dJMrDUDw6nBJqsPslpJNsWI= From: Umang Jain To: Florian Fainelli , Broadcom internal kernel review list , Greg Kroah-Hartman , Stefan Wahren , Hans Verkuil , Dave Stevenson , Mauro Carvalho Chehab , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: kieran.bingham@ideasonboard.com, Umang Jain Subject: [PATCH 1/2] staging: vc04_services: mmal-vchiq: Do not assign bool to u32 Date: Thu, 17 Nov 2022 18:29:52 +0530 Message-Id: <20221117125953.88441-2-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221117125953.88441-1-umang.jain@ideasonboard.com> References: <20221117125953.88441-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221117_050017_160338_37C81EDD X-CRM114-Status: GOOD ( 10.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Dave Stevenson struct vchiq_mmal_component.enabled is a u32 type. Do not assign it a bool. Fixes: 640e77466e69 ("staging: mmal-vchiq: Avoid use of bool in structures") Signed-off-by: Dave Stevenson Signed-off-by: Umang Jain --- drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c index cb921c94996a..17f8ceda87ca 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c @@ -1773,7 +1773,7 @@ int vchiq_mmal_component_enable(struct vchiq_mmal_instance *instance, ret = enable_component(instance, component); if (ret == 0) - component->enabled = true; + component->enabled = 1; mutex_unlock(&instance->vchiq_mutex); From patchwork Thu Nov 17 12:59:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13046858 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B398C4332F for ; Thu, 17 Nov 2022 13:01:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DBYNc8MF1CKQ9ypsy4RHPWoLNd06zSEfJVicnXoIYXM=; b=p9jOLJsDZg9kn4 AKk+mACYnFbJH3QXY1jCiTMId1v6O9MHVSLtEHcK+HYK6b1iXBHIQTl1CaOnvPv3/Qr0Z9RUpoU4U nozmkEbCZUb7de19JHERsTrWzXowXfY9GtHgydAxSUnct1eQ7aTzcLUxX+dt5kMdI+ThQcDGPM8yp HdVy4HZaH+fdCZro/CYae6c/Rza2yNFZkIx5ASdQTHvNU6SNg9nRRezD/muKbmzch0Xw78gxJlOhN 1gqfuGilvHKtBQyB2CxW9T/BOeTLz8fTImDp72+efaHWfkGSRb/O1q0tsgyGoebE4s+wSeyTUHYUp TMZ56H0kBPbqkKf6bsxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oveVH-00E0Zf-DW; Thu, 17 Nov 2022 13:00:27 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oveV5-00E0UU-9t; Thu, 17 Nov 2022 13:00:17 +0000 Received: from ideasonboard.com (unknown [103.251.226.79]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7A522105A; Thu, 17 Nov 2022 14:00:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668690013; bh=7I4XZur3XWHa7tenurKlkHinu6BspwE8Zh84rEdNBW0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gOVzyTbYqueSEsWntTvaBO27iXxe2XQdULeguVvImsXSsUJAoDKgYtDJzaxC7m+0p 7JSC//J7tMX+ZBhtW5uBcyU13nByQQ/W/6J2OCImq91vJb3ax7RtE3Ym5MYDYZLTfH z9lHV0fUeg16Sd1FL0SghuUZDsRviYYLuGlJnzxY= From: Umang Jain To: Florian Fainelli , Broadcom internal kernel review list , Greg Kroah-Hartman , Stefan Wahren , Hans Verkuil , Dave Stevenson , Mauro Carvalho Chehab , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: kieran.bingham@ideasonboard.com, Umang Jain Subject: [PATCH 2/2] staging: vc04_services: mmal-common: Do not use bool in structures Date: Thu, 17 Nov 2022 18:29:53 +0530 Message-Id: <20221117125953.88441-3-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221117125953.88441-1-umang.jain@ideasonboard.com> References: <20221117125953.88441-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221117_050015_525996_89BA981C X-CRM114-Status: GOOD ( 12.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Do not use bool in structures, it already gets flagged by checkpatch: "Avoid using bool structure members because of possible alignment issues" Hence, modify struct mmal_fmt.remove_padding to use u32. No change in assignments as 0/1 are already being used with mmal_fmt.remove_padding. Signed-off-by: Umang Jain --- drivers/staging/vc04_services/vchiq-mmal/mmal-common.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-common.h b/drivers/staging/vc04_services/vchiq-mmal/mmal-common.h index b33129403a30..fd02440f41b2 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-common.h +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-common.h @@ -32,9 +32,9 @@ struct mmal_fmt { int depth; u32 mmal_component; /* MMAL component index to be used to encode */ u32 ybbp; /* depth of first Y plane for planar formats */ - bool remove_padding; /* Does the GPU have to remove padding, - * or can we do hide padding via bytesperline. - */ + u32 remove_padding; /* Does the GPU have to remove padding, + * or can we do hide padding via bytesperline. + */ }; /* buffer for one video frame */