From patchwork Fri Dec 2 10:57:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 13062632 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59BF0C4321E for ; Fri, 2 Dec 2022 10:58:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232068AbiLBK6P (ORCPT ); Fri, 2 Dec 2022 05:58:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232011AbiLBK6O (ORCPT ); Fri, 2 Dec 2022 05:58:14 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1EDC7062C for ; Fri, 2 Dec 2022 02:58:11 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id g7so6851296lfv.5 for ; Fri, 02 Dec 2022 02:58:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=asePIDAduz3wjwHekIjxIWyoaIECGFH8vErA/u3bLN4=; b=bWhJrmXjdq55NOaGcwX/Atz3vFl/oz3eIvphok+SzkjhWZydkEk9JsO4pC/rGw+HYG QfdTuTpMRYZ1UnLUhZhmULmAksl2y3p2hSV8ijlP/U58/H0R5fn5WeXxpnDVSq31K/5E Kvnnijeqp+AfgnM5QnHt/scqsVOJL/T7KmJgY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=asePIDAduz3wjwHekIjxIWyoaIECGFH8vErA/u3bLN4=; b=YFLeA7UnTNKvMsvO3gthR3uFO7XXlrmRVqXqMJ7Rbm+As5XkSOduotQ+j17dsBcnTS Ds8ndKsFAXH5NGEuusoQQmHehseOF64DdsnjB792tSc0GpQmA6kMXGoHoc5Ik1BbcuGD cVed6uwQ1Yl27jcwUTiulTP03MA1PN+CeUQNkf/AclfzNoJIyTlJFxl8IXuiA4PYWVs1 eKVtOH1Qwam61GLR3ln4Gry3U4OiMDIQBqVRDXFTYZXVizcha9jI9dRePjuctKnomH/n SElgBbccb8XGgETEcOJGJmQ/sFfxr9p7c/UbCYxdJtl6M4PYl+GHpt/wiNwzbnN81k/2 qYvQ== X-Gm-Message-State: ANoB5pmMhjsHyuT0r/bvz9Lm/YFsqAL9OIIEoesKa14R+qq/0EMI3n5e MZBVu/8FoGJUns6x2CSufJBsunsUp62YdLZVgVE= X-Google-Smtp-Source: AA0mqf6u8qX9oGcO0BTh42XYDDh2o/SjY3dXsfoJGAUXY/CS3GBafSO66+JXnzYW4msK5+vhPKVWAA== X-Received: by 2002:a05:6512:b8d:b0:4b4:ec87:ef9d with SMTP id b13-20020a0565120b8d00b004b4ec87ef9dmr15987504lfv.70.1669978690303; Fri, 02 Dec 2022 02:58:10 -0800 (PST) Received: from prevas-ravi.prevas.se ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id dw8-20020a0565122c8800b004998d9ccb62sm982682lfb.99.2022.12.02.02.58.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 02:58:09 -0800 (PST) From: Rasmus Villemoes To: Dmitry Torokhov Cc: Dario Binacchi , Oliver Graute , Rasmus Villemoes , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] Input: edt-ft5x06 - always do msleep(300) during initialization Date: Fri, 2 Dec 2022 11:57:59 +0100 Message-Id: <20221202105800.653982-1-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org We have a board with an FT5446, which is close enough to a FT5506 (i.e. it also supports up to 10 touch points and has similar register layout) for this driver to work. However, on our board the iovcc and vcc regulators are indeed controllable (so not always-on), but there is no reset or wakeup gpio hooked up. Without a large enough delay between the regulator_enable() calls and edt_ft5x06_ts_identify(), the first edt_ft5x06_ts_readwrite() call fails with -ENXIO and thus the device fails to probe. So unconditionally do an mdelay(300) instead of only when a reset-gpio is present. Signed-off-by: Rasmus Villemoes Reviewed-by: Jeff LaBundy --- drivers/input/touchscreen/edt-ft5x06.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c index 9ac1378610bc..8bafa123083c 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c @@ -1239,8 +1239,8 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client, if (tsdata->reset_gpio) { usleep_range(5000, 6000); gpiod_set_value_cansleep(tsdata->reset_gpio, 0); - msleep(300); } + msleep(300); input = devm_input_allocate_device(&client->dev); if (!input) {