From patchwork Mon Dec 19 15:49:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ammar Faizi X-Patchwork-Id: 13076775 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 154FBC10F1B for ; Mon, 19 Dec 2022 15:53:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232698AbiLSPxf (ORCPT ); Mon, 19 Dec 2022 10:53:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232589AbiLSPxC (ORCPT ); Mon, 19 Dec 2022 10:53:02 -0500 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B8E313D57 for ; Mon, 19 Dec 2022 07:50:30 -0800 (PST) Received: from localhost.localdomain (unknown [182.253.183.89]) by gnuweeb.org (Postfix) with ESMTPSA id 72BED81925; Mon, 19 Dec 2022 15:50:27 +0000 (UTC) X-GW-Data: lPqxHiMPbJw1wb7CM9QUryAGzr0yq5atzVDdxTR0iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1671465030; bh=Cw0C5upr2XllD76XKiRZusMKjtEuaaLqf5cZUW3MSU8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DTPQOFYPYsMvLELUtf29q2EYkentO0uh/gzrdHFJroZ7yQ/ImjsOG7ShlxoWRgchF EzNdOFRiO1FZ4lwO6Hnu3WnE89VwwuglFZ1CfgRqhUVWzUGO2sMachxVC5OBfIQrTK eEO+Kw9MUei3JQBtPO/qIwPXjNZ8rSeq2xJWy+Uy3TIhfMxyMVmb1NdKm+vTTX0bKH G1Z0RbC9JsJHw68mJHfGj7OLyTayKTaw9Hmw3ROil6QJEm2g9/N9KogpC70usx5vo/ OLwhyM4Ks7GkVl2OnyMadxuhrb3haG7kby0YeQbKNy34gyLn/JrLzz2gRCa6yRg7s2 rlAAaAwWKzcRw== From: Ammar Faizi To: Jens Axboe Cc: Ammar Faizi , Pavel Begunkov , Gilang Fachrezy , Muhammad Rizki , VNLX Kernel Department , GNU/Weeb Mailing List , io-uring Mailing List , Christian Mazakas Subject: [PATCH liburing v1 1/8] ffi: Add SPDX-License-Idetifier Date: Mon, 19 Dec 2022 22:49:53 +0700 Message-Id: <20221219155000.2412524-2-ammar.faizi@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221219155000.2412524-1-ammar.faizi@intel.com> References: <20221219155000.2412524-1-ammar.faizi@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Commit 9e2890d35e96 ("build: add liburing-ffi") didn't add "SPDX-LIcense-Identifier" in src/ffi.c. Add it. Cc: Christian Mazakas Signed-off-by: Ammar Faizi --- src/ffi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ffi.c b/src/ffi.c index fbca2a4..03e382e 100644 --- a/src/ffi.c +++ b/src/ffi.c @@ -1,10 +1,11 @@ +/* SPDX-License-Identifier: MIT */ #define IOURINGINLINE #ifdef __clang__ // clang doesn't seem to particularly like that we're including a header that // deliberately contains function definitions so we explicitly silence it #pragma clang diagnostic push #pragma clang diagnostic ignored "-Wmissing-prototypes" #endif #include "liburing.h" From patchwork Mon Dec 19 15:49:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ammar Faizi X-Patchwork-Id: 13076776 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C770C4167B for ; Mon, 19 Dec 2022 15:53:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231670AbiLSPxf (ORCPT ); Mon, 19 Dec 2022 10:53:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232601AbiLSPxF (ORCPT ); Mon, 19 Dec 2022 10:53:05 -0500 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEC9D13D64 for ; Mon, 19 Dec 2022 07:50:33 -0800 (PST) Received: from localhost.localdomain (unknown [182.253.183.89]) by gnuweeb.org (Postfix) with ESMTPSA id B799D81917; Mon, 19 Dec 2022 15:50:30 +0000 (UTC) X-GW-Data: lPqxHiMPbJw1wb7CM9QUryAGzr0yq5atzVDdxTR0iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1671465033; bh=wDhwh6SEWRdoxqFmz3sjSJiYXWiBiIzzspUZzIfk2m8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JxYDMf+5Ukbm1YFub2R2W3QPxRbSRJroyVmUV8vJMgITFKYcXwuXrh2juFyjDAw0d HySBipw/QOFwtLOz9t91rcwVuWUyD0ewGKyJnTqNOXsppHqf21RrI2tANt0n5yTktU CrtW8T7Xg92xZFOknI1jn9b+kWti+Oav+IuIimR2aWwyl3MxsohqfHsSV3lozrhgJY mw6/czzvmlCm2f6XYacC3bM/T9h5+7PRrv/9N83gCYJqSPppWW3ey7NRGAjdvigS7I XpGIYVzdLX8BRPIrUkbSnZeGeizcg+wGAjCXmTESrX2N4wxxCLjLbgCw3N7uvw0l7t EPA2XZdu2grUQ== From: Ammar Faizi To: Jens Axboe Cc: Ammar Faizi , Pavel Begunkov , Gilang Fachrezy , Muhammad Rizki , VNLX Kernel Department , GNU/Weeb Mailing List , io-uring Mailing List , Christian Hergert Subject: [PATCH liburing v1 2/8] Makefile: Add a '+' char to silence a Makefile warning Date: Mon, 19 Dec 2022 22:49:54 +0700 Message-Id: <20221219155000.2412524-3-ammar.faizi@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221219155000.2412524-1-ammar.faizi@intel.com> References: <20221219155000.2412524-1-ammar.faizi@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org When building with `make -jN` where `N` is greater than 1, it shows: make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule. make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule. This happens because since commit 0d55ea19ccf2 ("version: generate io_uring_version.h from Makefile.common"), the configure file executes make command. Add a '+' char in front of the configure command to silence this warning. Cc: Christian Hergert Fixes: 0d55ea19ccf2f34c5dd74f80846f9e5f133746ff ("version: generate io_uring_version.h from Makefile.common") Signed-off-by: Ammar Faizi --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 686be4f..4bd7e24 100644 --- a/Makefile +++ b/Makefile @@ -18,21 +18,21 @@ partcheck: all @echo "make partcheck => TODO add tests with out kernel support" runtests: all @$(MAKE) -C test runtests runtests-loop: all @$(MAKE) -C test runtests-loop runtests-parallel: all @$(MAKE) -C test runtests-parallel config-host.mak: configure - @if [ ! -e "$@" ]; then \ + +@if [ ! -e "$@" ]; then \ echo "Running configure ..."; \ ./configure; \ else \ echo "$@ is out-of-date, running configure"; \ sed -n "/.*Configured with/s/[^:]*: //p" "$@" | sh; \ fi ifneq ($(MAKECMDGOALS),clean) include config-host.mak endif From patchwork Mon Dec 19 15:49:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ammar Faizi X-Patchwork-Id: 13076777 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4D33C4332F for ; Mon, 19 Dec 2022 15:53:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232601AbiLSPxg (ORCPT ); Mon, 19 Dec 2022 10:53:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232633AbiLSPxH (ORCPT ); Mon, 19 Dec 2022 10:53:07 -0500 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B81A113D6A for ; Mon, 19 Dec 2022 07:50:36 -0800 (PST) Received: from localhost.localdomain (unknown [182.253.183.89]) by gnuweeb.org (Postfix) with ESMTPSA id 091AB8191C; Mon, 19 Dec 2022 15:50:33 +0000 (UTC) X-GW-Data: lPqxHiMPbJw1wb7CM9QUryAGzr0yq5atzVDdxTR0iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1671465036; bh=ms/xp3631C8/NzQzavvt9KMEMJkJxT0MXN4ilU9Nqsw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jPcLjS0qjYNIz8+ESvQZtjizU0J7473HYcKbjMEfl9JfGEaRqMYHfQ6ZtboSLsZPM eisppRhfOa9mzMkyFwOSJiSrNUWVK4atLke2hnKOZ1kI+g4TiTYZN3h6x4Mhab/vAm RkmdN8dPJVkhSbvUUoQfklXysiZuZKYiEOgRitmyZEsrqi8zEj8LCOOJYwxQyk7TIv C3CY5XeLvRY7gjWvHwHK05B7Npm+v6G3oaY394kMKJurpMqD+HcSYR7wp0Bka9QdFX imrJDjNCFjrxcbNbAvASfZgyszH49jhrLeNPjt9W1+gOme0pTjCcTFWPqanS/U4J/R 9tw6rbNEOPVxg== From: Ammar Faizi To: Jens Axboe Cc: Ammar Faizi , Pavel Begunkov , Gilang Fachrezy , Muhammad Rizki , VNLX Kernel Department , GNU/Weeb Mailing List , io-uring Mailing List Subject: [PATCH liburing v1 3/8] tests: Fix `-Wstrict-prototypes` warnings from Clang Date: Mon, 19 Dec 2022 22:49:55 +0700 Message-Id: <20221219155000.2412524-4-ammar.faizi@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221219155000.2412524-1-ammar.faizi@intel.com> References: <20221219155000.2412524-1-ammar.faizi@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org This is a preparation patch to integrate -Wstrict-prototypes flag to the GitHub CI robot. Clang says: warning: a function declaration without a prototype is \ deprecated in all versions of C [-Wstrict-prototypes] Make sure we put "void" in the argument list of the function declaration if the function doesn't accept any argument. Reproducer (with clang-16): ./configure --cc=clang --cxx=clang++; CFLAGS="-Wall -Wextra -Wstrict-prototypes" make -j8; Signed-off-by: Ammar Faizi --- test/35fa71a030ca.c | 2 +- test/a4c0b3decb33.c | 2 +- test/accept.c | 2 +- test/fc2a85cb02ef.c | 2 +- test/pollfree.c | 2 +- test/sqpoll-disable-exit.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/test/35fa71a030ca.c b/test/35fa71a030ca.c index fc1a419..5540d8d 100644 --- a/test/35fa71a030ca.c +++ b/test/35fa71a030ca.c @@ -169,21 +169,21 @@ static void kill_and_wait(int pid, int* status) close(fd); } closedir(dir); } else { } while (waitpid(-1, status, __WALL) != pid) { } } #define SYZ_HAVE_SETUP_TEST 1 -static void setup_test() +static void setup_test(void) { prctl(PR_SET_PDEATHSIG, SIGKILL, 0, 0, 0); setpgrp(); write_file("/proc/self/oom_score_adj", "1000"); } struct thread_t { int created, call; event_t ready, done; }; diff --git a/test/a4c0b3decb33.c b/test/a4c0b3decb33.c index eb9587c..626f60a 100644 --- a/test/a4c0b3decb33.c +++ b/test/a4c0b3decb33.c @@ -88,21 +88,21 @@ static void kill_and_wait(int pid, int* status) } close(fd); } closedir(dir); } else { } while (waitpid(-1, status, __WALL) != pid) { } } -static void setup_test() +static void setup_test(void) { prctl(PR_SET_PDEATHSIG, SIGKILL, 0, 0, 0); setpgrp(); write_file("/proc/self/oom_score_adj", "1000"); } static void execute_one(void); #define WAIT_FLAGS __WALL diff --git a/test/accept.c b/test/accept.c index 1821faa..61737fa 100644 --- a/test/accept.c +++ b/test/accept.c @@ -604,21 +604,21 @@ static int test_multishot_accept(int count, bool before, bool overflow) if (no_accept_multi) return T_EXIT_SKIP; ret = io_uring_queue_init(MAX_FDS + 10, &m_io_uring, 0); assert(ret >= 0); ret = test(&m_io_uring, args); io_uring_queue_exit(&m_io_uring); return ret; } -static int test_accept_multishot_wrong_arg() +static int test_accept_multishot_wrong_arg(void) { struct io_uring m_io_uring; struct io_uring_cqe *cqe; struct io_uring_sqe *sqe; int fd, ret; ret = io_uring_queue_init(4, &m_io_uring, 0); assert(ret >= 0); fd = start_accept_listen(NULL, 0, 0); diff --git a/test/fc2a85cb02ef.c b/test/fc2a85cb02ef.c index 6fd5fd8..c828f67 100644 --- a/test/fc2a85cb02ef.c +++ b/test/fc2a85cb02ef.c @@ -47,21 +47,21 @@ static int inject_fault(int nth) fd = open("/proc/thread-self/fail-nth", O_RDWR); if (fd == -1) exit(1); char buf[16]; sprintf(buf, "%d", nth + 1); if (write(fd, buf, strlen(buf)) != (ssize_t)strlen(buf)) exit(1); return fd; } -static int setup_fault() +static int setup_fault(void) { static struct { const char* file; const char* val; bool fatal; } files[] = { {"/sys/kernel/debug/failslab/ignore-gfp-wait", "N", true}, {"/sys/kernel/debug/failslab/verbose", "0", false}, {"/sys/kernel/debug/fail_futex/ignore-private", "N", false}, {"/sys/kernel/debug/fail_page_alloc/verbose", "0", false}, diff --git a/test/pollfree.c b/test/pollfree.c index d753ffe..ebd88b1 100644 --- a/test/pollfree.c +++ b/test/pollfree.c @@ -245,21 +245,21 @@ static void kill_and_wait(int pid, int* status) } close(fd); } closedir(dir); } else { } while (waitpid(-1, status, __WALL) != pid) { } } -static void setup_test() +static void setup_test(void) { prctl(PR_SET_PDEATHSIG, SIGKILL, 0, 0, 0); setpgrp(); } struct thread_t { int created, call; event_t ready, done; }; diff --git a/test/sqpoll-disable-exit.c b/test/sqpoll-disable-exit.c index 76b6cf5..5283702 100644 --- a/test/sqpoll-disable-exit.c +++ b/test/sqpoll-disable-exit.c @@ -129,21 +129,21 @@ static void kill_and_wait(int pid, int* status) } close(fd); } closedir(dir); } else { } while (waitpid(-1, status, __WALL) != pid) { } } -static void setup_test() +static void setup_test(void) { prctl(PR_SET_PDEATHSIG, SIGKILL, 0, 0, 0); setpgrp(); write_file("/proc/self/oom_score_adj", "1000"); } static void execute_one(void); #define WAIT_FLAGS __WALL From patchwork Mon Dec 19 15:49:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ammar Faizi X-Patchwork-Id: 13076778 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE088C4167B for ; Mon, 19 Dec 2022 15:53:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232699AbiLSPxh (ORCPT ); Mon, 19 Dec 2022 10:53:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232641AbiLSPxH (ORCPT ); Mon, 19 Dec 2022 10:53:07 -0500 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C307C1B4 for ; Mon, 19 Dec 2022 07:50:39 -0800 (PST) Received: from localhost.localdomain (unknown [182.253.183.89]) by gnuweeb.org (Postfix) with ESMTPSA id 12FD08191F; Mon, 19 Dec 2022 15:50:36 +0000 (UTC) X-GW-Data: lPqxHiMPbJw1wb7CM9QUryAGzr0yq5atzVDdxTR0iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1671465039; bh=FcFldO2XkCyGQk/T9GzZXEhIxtSmKQMGCrurrZHkRCM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mTLapAOBsnSvsIS0Cg9gLq4rO6KJqyL2m0ep2mHMfm9jYtNiVtxizCBtVH6zx+kgQ NTk4P1P3bym5JvnSo6Ur0LXh+Hg6ZdOujOzIE9njldWgfhIXSzQn7WrQcb7UT3xky1 dk53iA75hnPuJYrYzwKfjj7XPifjEgGni8A7olMq+IlQ0MRJ/gFNXna8h8FFqNIHqK JRb51LtvZ/rv8H+ntoSMbs9OqTDbk7M45HzzoHI8IpA9hrZVcqaymdyAUXUU5ZZB/5 H70URctkZnBsbQl7Mgu2r5QbvTWzWFQYBiTZUl+YGDzrXj+ComED+oX6PBPJf+Cfv+ rDLhDMRk01ZYg== From: Ammar Faizi To: Jens Axboe Cc: Ammar Faizi , Pavel Begunkov , Gilang Fachrezy , Muhammad Rizki , VNLX Kernel Department , GNU/Weeb Mailing List , io-uring Mailing List Subject: [PATCH liburing v1 4/8] test/ring-leak: Remove a "break" statement in a "for loop" Date: Mon, 19 Dec 2022 22:49:56 +0700 Message-Id: <20221219155000.2412524-5-ammar.faizi@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221219155000.2412524-1-ammar.faizi@intel.com> References: <20221219155000.2412524-1-ammar.faizi@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Clang says: ring-leak.c:235:21: warning: loop will run at most once \ (loop increment never executed) [-Wunreachable-code-loop-increment] for (i = 0; i < 2; i++) { ^~~ This "break" statement makes the "for loop" meaningless. Remove it. We are supposed to run the test function with 2 different arguments using this "for loop". Signed-off-by: Ammar Faizi --- test/ring-leak.c | 1 - 1 file changed, 1 deletion(-) diff --git a/test/ring-leak.c b/test/ring-leak.c index f2ba74f..97b5a3f 100644 --- a/test/ring-leak.c +++ b/test/ring-leak.c @@ -234,21 +234,20 @@ int main(int argc, char *argv[]) for (i = 0; i < 2; i++) { bool update = !!(i & 1); ret = test_scm_cycles(update); if (ret) { fprintf(stderr, "test_scm_cycles() failed %i\n", update); return 1; } - break; } if (socketpair(AF_UNIX, SOCK_DGRAM, 0, sp) != 0) { perror("Failed to create Unix-domain socket pair\n"); return 1; } ring_fd = get_ring_fd(); if (ring_fd < 0) return 1; From patchwork Mon Dec 19 15:49:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ammar Faizi X-Patchwork-Id: 13076779 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0FDBC3DA71 for ; Mon, 19 Dec 2022 15:53:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232641AbiLSPxi (ORCPT ); Mon, 19 Dec 2022 10:53:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232645AbiLSPxI (ORCPT ); Mon, 19 Dec 2022 10:53:08 -0500 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5347ABB4 for ; Mon, 19 Dec 2022 07:50:42 -0800 (PST) Received: from localhost.localdomain (unknown [182.253.183.89]) by gnuweeb.org (Postfix) with ESMTPSA id 1AE348191C; Mon, 19 Dec 2022 15:50:39 +0000 (UTC) X-GW-Data: lPqxHiMPbJw1wb7CM9QUryAGzr0yq5atzVDdxTR0iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1671465042; bh=CvUQd37G+LX9A5SN2izZvKT3GxHNSWIKrHqN3MCv2JY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LiakWzwqU27gQ7pxUxQEBH6PgCNwjO5HczJ+Zr7XSpQsuBvU5Bv5UxxRUhnRF/jhc 4CadGUPiFXwFPnq9btiovUfbM6uxm88xDkCxKIpfC5r768xjsBkjDYrpZSRjM5P19e 9nF3gOpuL6Ph4IiQkCczyJdyXsr7MSm0CPrcYZyaAjsJ3P9ajlfjfucpBVLDm49OKv GeY4mpDb4sbXozjXsBoDEFWWsC+KEajaJ5E6JCEXoPKT0Qr2nfWa6puQ+QTVyt/pXr zOoL4Zd/uiSJUy2sKq8ph5vl0AR8J7Qw1fbF090e6N1QLghIlFzT9j8i5f1XmVARqA mCyQuQhqP99Pg== From: Ammar Faizi To: Jens Axboe Cc: Ammar Faizi , Pavel Begunkov , Gilang Fachrezy , Muhammad Rizki , VNLX Kernel Department , GNU/Weeb Mailing List , io-uring Mailing List Subject: [PATCH liburing v1 5/8] tests: Fix clang `-Wunreachable-code` warning Date: Mon, 19 Dec 2022 22:49:57 +0700 Message-Id: <20221219155000.2412524-6-ammar.faizi@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221219155000.2412524-1-ammar.faizi@intel.com> References: <20221219155000.2412524-1-ammar.faizi@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Clang says: fadvise.c:190:3: warning: code will never be executed [-Wunreachable-code] fprintf(stderr, "Suspicious timings\n"); ^~~~~~~ fadvise.c:189:6: note: silence by adding parentheses to mark code as \ explicitly dead if (0 && bad > good) { ^ /* DISABLES CODE */ ( ) madvise.c:186:3: warning: code will never be executed [-Wunreachable-code] fprintf(stderr, "Suspicious timings (%u > %u)\n", bad, good); ^~~~~~~ madvise.c:185:6: note: silence by adding parentheses to mark code as \ explicitly dead if (0 && bad > good) ^ /* DISABLES CODE */ ( ) Add parentheses to silence the warning. Signed-off-by: Ammar Faizi --- test/fadvise.c | 2 +- test/madvise.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/fadvise.c b/test/fadvise.c index 889f447..4f4d85f 100644 --- a/test/fadvise.c +++ b/test/fadvise.c @@ -179,21 +179,21 @@ int main(int argc, char *argv[]) goto err; } else if (!ret) good++; else if (ret == 2) bad++; if (i >= MIN_LOOPS && !bad) break; } /* too hard to reliably test, just ignore */ - if (0 && bad > good) { + if ((0) && bad > good) { fprintf(stderr, "Suspicious timings\n"); goto err; } if (fname != argv[1]) unlink(fname); io_uring_queue_exit(&ring); return T_EXIT_PASS; err: if (fname != argv[1]) diff --git a/test/madvise.c b/test/madvise.c index 8848143..7938ec4 100644 --- a/test/madvise.c +++ b/test/madvise.c @@ -175,21 +175,21 @@ int main(int argc, char *argv[]) goto err; } else if (!ret) good++; else if (ret == 2) bad++; if (i >= MIN_LOOPS && !bad) break; } /* too hard to reliably test, just ignore */ - if (0 && bad > good) + if ((0) && bad > good) fprintf(stderr, "Suspicious timings (%u > %u)\n", bad, good); if (fname != argv[1]) unlink(fname); io_uring_queue_exit(&ring); return T_EXIT_PASS; err: if (fname != argv[1]) unlink(fname); return T_EXIT_FAIL; } From patchwork Mon Dec 19 15:49:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ammar Faizi X-Patchwork-Id: 13076780 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2D9BC10F1B for ; Mon, 19 Dec 2022 15:53:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232645AbiLSPxj (ORCPT ); Mon, 19 Dec 2022 10:53:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232648AbiLSPxK (ORCPT ); Mon, 19 Dec 2022 10:53:10 -0500 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E85830E for ; Mon, 19 Dec 2022 07:50:45 -0800 (PST) Received: from localhost.localdomain (unknown [182.253.183.89]) by gnuweeb.org (Postfix) with ESMTPSA id 244D981907; Mon, 19 Dec 2022 15:50:42 +0000 (UTC) X-GW-Data: lPqxHiMPbJw1wb7CM9QUryAGzr0yq5atzVDdxTR0iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1671465045; bh=T11BVbjIGkgUQLrgzwfeR0xAUc/KGNhY9elGZuv7VKU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DOTeoEyu42pizvEiucuq5rUId8vV+Ybo3pxdzjJBvn2heKwu/q96650LGbuy3fN7i ZV+rLU2xFKKOyMWvb7RvrScB2DO8r1g6l9m61OWevBMmHjjUocIC89c5o/MxHU4Lu1 WRy5Dzx6wfi6BJWekG5uu5XpY7OXqwX3A4R6nX721cwWVHa05MRx0qk3NSkBazEH9t yqLF0h/+DqgWJMjegHRLc3N1IgB3cer/Ue9gG17rcySRSZHWp/6G3OBMh81BnUtTv/ oaEqDjttcoqiyEyw/HozQyqk61bXCRb0/iDhWK1Tt0+kvIxPLI9w4MBgkxzv9e8kID sKYrI3agfZ4zg== From: Ammar Faizi To: Jens Axboe Cc: Ammar Faizi , Pavel Begunkov , Gilang Fachrezy , Muhammad Rizki , VNLX Kernel Department , GNU/Weeb Mailing List , io-uring Mailing List Subject: [PATCH liburing v1 6/8] tests: Declare internal variables as static Date: Mon, 19 Dec 2022 22:49:58 +0700 Message-Id: <20221219155000.2412524-7-ammar.faizi@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221219155000.2412524-1-ammar.faizi@intel.com> References: <20221219155000.2412524-1-ammar.faizi@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org This is a preparation patch to add `-Wmissing-variable-declarations` to the GitHub bot CI. It ensures variables that are not used outside the translation unit be declared as static. The error message looks like this: 35fa71a030ca.c:265:1: note: declare 'static' if the variable is not intended \ to be used outside of this translation unit uint64_t r[1] = {0xffffffffffffffff}; ^ 1 error generated. Signed-off-by: Ammar Faizi --- test/232c93d07b74.c | 6 +++--- test/35fa71a030ca.c | 2 +- test/a0908ae19763.c | 2 +- test/accept-link.c | 4 ++-- test/accept-reuse.c | 2 +- test/double-poll-crash.c | 2 +- test/fc2a85cb02ef.c | 2 +- test/files-exit-hang-timeout.c | 4 ++-- test/nvme.h | 4 ++-- test/poll-link.c | 4 ++-- test/pollfree.c | 2 +- test/sqpoll-cancel-hang.c | 2 +- test/test.h | 3 ++- test/timeout-new.c | 6 +++--- 14 files changed, 23 insertions(+), 22 deletions(-) diff --git a/test/232c93d07b74.c b/test/232c93d07b74.c index 74cc063..4c65b39 100644 --- a/test/232c93d07b74.c +++ b/test/232c93d07b74.c @@ -26,23 +26,23 @@ #define RECV_BUFF_SIZE 2 #define SEND_BUFF_SIZE 3 struct params { int tcp; int non_blocking; __be16 bind_port; }; -pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER; -pthread_cond_t cond = PTHREAD_COND_INITIALIZER; -int rcv_ready = 0; +static pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER; +static pthread_cond_t cond = PTHREAD_COND_INITIALIZER; +static int rcv_ready = 0; static void set_rcv_ready(void) { pthread_mutex_lock(&mutex); rcv_ready = 1; pthread_cond_signal(&cond); pthread_mutex_unlock(&mutex); } diff --git a/test/35fa71a030ca.c b/test/35fa71a030ca.c index 5540d8d..3e2eddb 100644 --- a/test/35fa71a030ca.c +++ b/test/35fa71a030ca.c @@ -255,21 +255,21 @@ static void loop(void) break; sleep_ms(1); if (current_time_ms() - start < 5 * 1000) continue; kill_and_wait(pid, &status); break; } } } -uint64_t r[1] = {0xffffffffffffffff}; +static uint64_t r[1] = {0xffffffffffffffff}; void execute_call(int call) { long res; switch (call) { case 0: *(uint32_t*)0x20000040 = 0; *(uint32_t*)0x20000044 = 0; *(uint32_t*)0x20000048 = 0; *(uint32_t*)0x2000004c = 0; diff --git a/test/a0908ae19763.c b/test/a0908ae19763.c index 8f6aaad..d0c2855 100644 --- a/test/a0908ae19763.c +++ b/test/a0908ae19763.c @@ -7,21 +7,21 @@ #include #include #include #include #include #include "liburing.h" #include "helpers.h" #include "../src/syscall.h" -uint64_t r[1] = {0xffffffffffffffff}; +static uint64_t r[1] = {0xffffffffffffffff}; int main(int argc, char *argv[]) { if (argc > 1) return T_EXIT_SKIP; mmap((void *) 0x20000000, 0x1000000, 3, 0x32, -1, 0); intptr_t res = 0; *(uint32_t*)0x20000080 = 0; *(uint32_t*)0x20000084 = 0; *(uint32_t*)0x20000088 = 0; diff --git a/test/accept-link.c b/test/accept-link.c index 4d42f15..32f73f4 100644 --- a/test/accept-link.c +++ b/test/accept-link.c @@ -9,22 +9,22 @@ #include #include #include #include #include #include #include "liburing.h" #include "helpers.h" -pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER; -pthread_cond_t cond = PTHREAD_COND_INITIALIZER; +static pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER; +static pthread_cond_t cond = PTHREAD_COND_INITIALIZER; static int recv_thread_ready = 0; static int recv_thread_done = 0; static void signal_var(int *var) { pthread_mutex_lock(&mutex); *var = 1; pthread_cond_signal(&cond); pthread_mutex_unlock(&mutex); diff --git a/test/accept-reuse.c b/test/accept-reuse.c index 7df5e56..0808866 100644 --- a/test/accept-reuse.c +++ b/test/accept-reuse.c @@ -4,21 +4,21 @@ #include #include #include #include #include #include #include "liburing.h" #include "helpers.h" #include "../src/syscall.h" -struct io_uring io_uring; +static struct io_uring io_uring; static int sys_io_uring_enter(const int fd, const unsigned to_submit, const unsigned min_complete, const unsigned flags, sigset_t * const sig) { return __sys_io_uring_enter(fd, to_submit, min_complete, flags, sig); } static int submit_sqe(void) { diff --git a/test/double-poll-crash.c b/test/double-poll-crash.c index a0cc985..54f88f4 100644 --- a/test/double-poll-crash.c +++ b/test/double-poll-crash.c @@ -102,21 +102,21 @@ static long syz_open_dev(volatile long a0, volatile long a1, volatile long a2) strncpy(buf, (char*)a0, sizeof(buf) - 1); buf[sizeof(buf) - 1] = 0; while ((hash = strchr(buf, '#'))) { *hash = '0' + (char)(a1 % 10); a1 /= 10; } return open(buf, a2, 0); } } -uint64_t r[4] = {0xffffffffffffffff, 0x0, 0x0, 0xffffffffffffffff}; +static uint64_t r[4] = {0xffffffffffffffff, 0x0, 0x0, 0xffffffffffffffff}; int main(int argc, char *argv[]) { void *mmap_ret; #if !defined(__i386) && !defined(__x86_64__) return T_EXIT_SKIP; #endif if (argc > 1) return T_EXIT_SKIP; diff --git a/test/fc2a85cb02ef.c b/test/fc2a85cb02ef.c index c828f67..cd1af39 100644 --- a/test/fc2a85cb02ef.c +++ b/test/fc2a85cb02ef.c @@ -72,21 +72,21 @@ static int setup_fault(void) unsigned i; for (i = 0; i < sizeof(files) / sizeof(files[0]); i++) { if (!write_file(files[i].file, files[i].val)) { if (files[i].fatal) return 1; } } return 0; } -uint64_t r[2] = {0xffffffffffffffff, 0xffffffffffffffff}; +static uint64_t r[2] = {0xffffffffffffffff, 0xffffffffffffffff}; int main(int argc, char *argv[]) { if (argc > 1) return T_EXIT_SKIP; mmap((void *) 0x20000000ul, 0x1000000ul, 3ul, 0x32ul, -1, 0); if (setup_fault()) { printf("Test needs failslab/fail_futex/fail_page_alloc enabled, skipped\n"); return T_EXIT_SKIP; } diff --git a/test/files-exit-hang-timeout.c b/test/files-exit-hang-timeout.c index 45f01ea..6f77b7c 100644 --- a/test/files-exit-hang-timeout.c +++ b/test/files-exit-hang-timeout.c @@ -14,23 +14,23 @@ #include #include #include #include "liburing.h" #include "helpers.h" #define BACKLOG 512 #define PORT 9100 -struct io_uring ring; +static struct io_uring ring; -struct __kernel_timespec ts = { +static struct __kernel_timespec ts = { .tv_sec = 300, .tv_nsec = 0, }; static void add_timeout(struct io_uring *ring, int fd) { struct io_uring_sqe *sqe; sqe = io_uring_get_sqe(ring); io_uring_prep_timeout(sqe, &ts, 100, 0); diff --git a/test/nvme.h b/test/nvme.h index 52f4172..1254b92 100644 --- a/test/nvme.h +++ b/test/nvme.h @@ -50,22 +50,22 @@ struct nvme_uring_cmd { enum nvme_admin_opcode { nvme_admin_identify = 0x06, }; enum nvme_io_opcode { nvme_cmd_write = 0x01, nvme_cmd_read = 0x02, }; -int nsid; -__u32 lba_shift; +static int nsid; +static __u32 lba_shift; struct nvme_lbaf { __le16 ms; __u8 ds; __u8 rp; }; struct nvme_id_ns { __le64 nsze; __le64 ncap; diff --git a/test/poll-link.c b/test/poll-link.c index b94f954..c0b1cf5 100644 --- a/test/poll-link.c +++ b/test/poll-link.c @@ -9,22 +9,22 @@ #include #include #include #include #include #include #include "helpers.h" #include "liburing.h" -pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER; -pthread_cond_t cond = PTHREAD_COND_INITIALIZER; +static pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER; +static pthread_cond_t cond = PTHREAD_COND_INITIALIZER; static int recv_thread_ready = 0; static int recv_thread_done = 0; static void signal_var(int *var) { pthread_mutex_lock(&mutex); *var = 1; pthread_cond_signal(&cond); pthread_mutex_unlock(&mutex); diff --git a/test/pollfree.c b/test/pollfree.c index ebd88b1..010db65 100644 --- a/test/pollfree.c +++ b/test/pollfree.c @@ -335,21 +335,21 @@ static void loop(void) kill_and_wait(pid, &status); break; } } } #ifndef __NR_io_uring_enter #define __NR_io_uring_enter 426 #endif -uint64_t r[4] = {0xffffffffffffffff, 0xffffffffffffffff, 0x0, 0x0}; +static uint64_t r[4] = {0xffffffffffffffff, 0xffffffffffffffff, 0x0, 0x0}; void execute_call(int call) { intptr_t res = 0; switch (call) { case 0: *(uint64_t*)0x200000c0 = 0; res = syscall(__NR_signalfd4, -1, 0x200000c0ul, 8ul, 0ul); if (res != -1) r[0] = res; diff --git a/test/sqpoll-cancel-hang.c b/test/sqpoll-cancel-hang.c index cd1c309..7faefa2 100644 --- a/test/sqpoll-cancel-hang.c +++ b/test/sqpoll-cancel-hang.c @@ -32,21 +32,21 @@ static uint64_t current_time_ms(void) static void kill_and_wait(int pid, int* status) { kill(-pid, SIGKILL); kill(pid, SIGKILL); while (waitpid(-1, status, __WALL) != pid) { } } #define WAIT_FLAGS __WALL -uint64_t r[3] = {0xffffffffffffffff, 0x0, 0x0}; +static uint64_t r[3] = {0xffffffffffffffff, 0x0, 0x0}; static long syz_io_uring_setup(volatile long a0, volatile long a1, volatile long a2, volatile long a3, volatile long a4, volatile long a5) { uint32_t entries = (uint32_t)a0; struct io_uring_params* setup_params = (struct io_uring_params*)a1; void* vma1 = (void*)a2; void* vma2 = (void*)a3; void** ring_ptr_out = (void**)a4; diff --git a/test/test.h b/test/test.h index 3628163..e99a8d2 100644 --- a/test/test.h +++ b/test/test.h @@ -7,21 +7,22 @@ #ifdef __cplusplus extern "C" { #endif typedef struct io_uring_test_config { unsigned int flags; const char *description; } io_uring_test_config; -io_uring_test_config io_uring_test_configs[] = { +__attribute__((__unused__)) +static io_uring_test_config io_uring_test_configs[] = { { 0, "default" }, { IORING_SETUP_SQE128, "large SQE"}, { IORING_SETUP_CQE32, "large CQE"}, { IORING_SETUP_SQE128 | IORING_SETUP_CQE32, "large SQE/CQE" }, }; #define FOR_ALL_TEST_CONFIGS \ for (int i = 0; i < sizeof(io_uring_test_configs) / sizeof(io_uring_test_configs[0]); i++) #define IORING_GET_TEST_CONFIG_FLAGS() (io_uring_test_configs[i].flags) diff --git a/test/timeout-new.c b/test/timeout-new.c index 8640678..35cb7bb 100644 --- a/test/timeout-new.c +++ b/test/timeout-new.c @@ -5,23 +5,23 @@ */ #include #include #include #include #include "liburing.h" #define TIMEOUT_MSEC 200 #define TIMEOUT_SEC 10 -int thread_ret0, thread_ret1; -int cnt = 0; -pthread_mutex_t mutex; +static int thread_ret0, thread_ret1; +static int cnt = 0; +static pthread_mutex_t mutex; static void msec_to_ts(struct __kernel_timespec *ts, unsigned int msec) { ts->tv_sec = msec / 1000; ts->tv_nsec = (msec % 1000) * 1000000; } static unsigned long long mtime_since(const struct timeval *s, const struct timeval *e) { From patchwork Mon Dec 19 15:49:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ammar Faizi X-Patchwork-Id: 13076781 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37A34C4332F for ; Mon, 19 Dec 2022 15:53:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232714AbiLSPxm (ORCPT ); Mon, 19 Dec 2022 10:53:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232663AbiLSPxK (ORCPT ); Mon, 19 Dec 2022 10:53:10 -0500 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBCF1E5A for ; Mon, 19 Dec 2022 07:50:48 -0800 (PST) Received: from localhost.localdomain (unknown [182.253.183.89]) by gnuweeb.org (Postfix) with ESMTPSA id 2C2F88191C; Mon, 19 Dec 2022 15:50:45 +0000 (UTC) X-GW-Data: lPqxHiMPbJw1wb7CM9QUryAGzr0yq5atzVDdxTR0iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1671465048; bh=3KScUysxnhrfiadv4/f41SW2hPuPIQ2i6Q69sW6VId4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mdnmOzVZKktJSC5JwmXZNJkj9/++Jmbg/ifsKuB3+YC5AOEZFwXUsUiaFe+xHG6G8 rdUdJ9rKksCMdxxHv59fYEkSGkYhOBZipZ/DEWiS+exJMFm7Z3WK43YZz/3Czfrssb u0LAzPumHG0FqlxfME5IXcLZCphs9O3PLgJs2+t7OchZvYAikn/MEQI2Ul574Bku9m qGzLeUeajx4BzcnXLQVyBhJR3Z4sUISM6yqusuhPcAyseVEYgV1fwsflgTjjQXffjO UZAmh/bh56qFKXxGeGEGLbKB25rLLBU048BxVd2Wo/BlHFH+R+gKxlehw5qdQwNBpG +1VyLtuRGpvOA== From: Ammar Faizi To: Jens Axboe Cc: Ammar Faizi , Pavel Begunkov , Gilang Fachrezy , Muhammad Rizki , VNLX Kernel Department , GNU/Weeb Mailing List , io-uring Mailing List Subject: [PATCH liburing v1 7/8] github: Add more extra flags for clang build Date: Mon, 19 Dec 2022 22:49:59 +0700 Message-Id: <20221219155000.2412524-8-ammar.faizi@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221219155000.2412524-1-ammar.faizi@intel.com> References: <20221219155000.2412524-1-ammar.faizi@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Add these 4 flags: -Wstrict-prototypes -Wunreachable-code-loop-increment -Wunreachable-code -Wmissing-variable-declarations for stricter clang build. Signed-off-by: Ammar Faizi --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 4c0bd26..c2aa3e6 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -20,21 +20,21 @@ jobs: cc: x86_64-linux-gnu-gcc cxx: x86_64-linux-gnu-g++ # x86-64 clang - arch: x86_64 cc_pkg: clang cxx_pkg: clang cc: clang cxx: clang++ liburing_extra_flags: -Wshorten-64-to-32 - extra_flags: -Wmissing-prototypes + extra_flags: -Wmissing-prototypes -Wstrict-prototypes -Wunreachable-code-loop-increment -Wunreachable-code -Wmissing-variable-declarations # x86 (32-bit) gcc - arch: i686 cc_pkg: gcc-i686-linux-gnu cxx_pkg: g++-i686-linux-gnu cc: i686-linux-gnu-gcc cxx: i686-linux-gnu-g++ # aarch64 gcc - arch: aarch64 From patchwork Mon Dec 19 15:50:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ammar Faizi X-Patchwork-Id: 13076782 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BADD6C3DA71 for ; Mon, 19 Dec 2022 15:53:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232666AbiLSPxm (ORCPT ); Mon, 19 Dec 2022 10:53:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232664AbiLSPxK (ORCPT ); Mon, 19 Dec 2022 10:53:10 -0500 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68F501166 for ; Mon, 19 Dec 2022 07:50:52 -0800 (PST) Received: from localhost.localdomain (unknown [182.253.183.89]) by gnuweeb.org (Postfix) with ESMTPSA id 339BD81930; Mon, 19 Dec 2022 15:50:48 +0000 (UTC) X-GW-Data: lPqxHiMPbJw1wb7CM9QUryAGzr0yq5atzVDdxTR0iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1671465052; bh=j2AB9YkhkwD65xQctqMhzrGIN73QOyK63B9gEyv9Vwg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=omLJ+zJvfftJdcFoRe3F4HFY+t7AKaIxOOSLTH4wXsw940W/VFmGg5JHgalF4An6o L7A2Cb3mWpVdd6SZmxRJq8ZGPcozF+1xMbLqEPc7igl00b4YoEBp4HUooGFjgGNjEO m8mFt9l/QnbJ5jHbhgQst4UaLQwqTdvsdEvqPz/8Abq4uJdBCbcPy8VMldcNalypOV 9pe3M7/5ed9E6i3l7RaPdSIzr4Js3HOTFvYeDt68bOYlThW2eOxhK8fAYkVrpRSD59 W9yW+vS1pYgt5oF3giypxoIQa53/eSKJCwTkix/PiEOCCtGiEyjhAIr1fz3qBe66Mo m1ROsZhWqQ0sg== From: Ammar Faizi To: Jens Axboe Cc: Ammar Faizi , Pavel Begunkov , Gilang Fachrezy , Muhammad Rizki , VNLX Kernel Department , GNU/Weeb Mailing List , io-uring Mailing List , Christian Hergert , Christian Mazakas Subject: [PATCH liburing v1 8/8] CHANGELOG: Update the CHANGELOG file Date: Mon, 19 Dec 2022 22:50:00 +0700 Message-Id: <20221219155000.2412524-9-ammar.faizi@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221219155000.2412524-1-ammar.faizi@intel.com> References: <20221219155000.2412524-1-ammar.faizi@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Cc: Christian Hergert # version check Cc: Christian Mazakas # FFI support Signed-off-by: Ammar Faizi --- CHANGELOG | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG b/CHANGELOG index 09511af..68b732c 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,10 +1,16 @@ +liburing-2.4 release + +- Add io_uring_{major,minor,check}_version() functions. +- Add IO_URING_{MAJOR,MINOR,CHECK}_VERSION() macros. +- FFI support (for non-C/C++ languages integration). + liburing-2.3 release - Support non-libc build for aarch64. - Add io_uring_{enter,enter2,register,setup} syscall functions. - Add sync cancel interface, io_uring_register_sync_cancel(). - Fix return value of io_uring_submit_and_wait_timeout() to match the man page. - Improvements to the regression tests - Add support and test case for passthrough IO - Add recv and recvmsg multishot helpers and support