From patchwork Thu Jan 5 15:38:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nirmoy Das X-Patchwork-Id: 13090092 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16568C3DA7A for ; Thu, 5 Jan 2023 15:38:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9641F10E043; Thu, 5 Jan 2023 15:38:42 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 519CE10E043 for ; Thu, 5 Jan 2023 15:38:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672933120; x=1704469120; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Pb8afxV4bAlmjOA0dZq/Xwuhat9CaA3Xm7T/+Ng24Is=; b=fZbnt7Nsbq1m+yByt8gsqp7CDxmCapo6ACigOGzBIFpm59d7eL9Ix032 MMtO0LDn1fab3h7CGohNp2W24emsUyZ4QWDCl3fdJ3i7K6SeeUyG/avO7 VEOLRcux1kTGl8YUvqD0LVoBPXbsra7EH0xfFQijOUMtxGD+NiC0FxPdu 0EniMxzTGNqAj//5mP+2bXufj7iAdGK2Pxhx2+C7atC32zmc1k4sEIY6Y mN5VmJRWzID7tAjJQtTYE4q86NsAgtiJiuCvok8A4x9euHqEX8IGeF+it VKaVn6egoMSv14si+5NJDFzt/qZtGwrBXuMvUepOJC0XrTYdOf/9X5G6r A==; X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="320943581" X-IronPort-AV: E=Sophos;i="5.96,303,1665471600"; d="scan'208";a="320943581" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2023 07:38:39 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="648969665" X-IronPort-AV: E=Sophos;i="5.96,303,1665471600"; d="scan'208";a="648969665" Received: from nirmoyda-desk.igk.intel.com ([10.102.13.19]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2023 07:38:37 -0800 From: Nirmoy Das To: intel-gfx@lists.freedesktop.org Date: Thu, 5 Jan 2023 16:38:31 +0100 Message-Id: <20230105153831.28256-1-nirmoy.das@intel.com> X-Mailer: git-send-email 2.38.0 MIME-Version: 1.0 Organization: Intel Deutschland GmbH, Registered Address: Am Campeon 10, 85579 Neubiberg, Germany, Commercial Register: Amtsgericht Muenchen HRB 186928 Subject: [Intel-gfx] [PATCH] drm/i915: Update doc for __intel_wakeref_put() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: --cc=andi.shyti@linux.intel.com, andrzej.hajda@intel.com, chris.p.wilson@intel.com, Nirmoy Das Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Fix the __intel_wakeref_put() doc to reflect current behaviour. Fixes: c7302f204490 ("drm/i915: Defer final intel_wakeref_put to process context") Signed-off-by: Nirmoy Das Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/intel_wakeref.h | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_wakeref.h b/drivers/gpu/drm/i915/intel_wakeref.h index 4f4c2e15e736..b5e1c61b5003 100644 --- a/drivers/gpu/drm/i915/intel_wakeref.h +++ b/drivers/gpu/drm/i915/intel_wakeref.h @@ -135,14 +135,12 @@ intel_wakeref_might_get(struct intel_wakeref *wf) * @flags: control flags * * Release our hold on the wakeref. When there are no more users, - * the runtime pm wakeref will be released after the @fn callback is called - * underneath the wakeref mutex. + * the runtime pm wakeref will be released after the intel_wakeref_ops->put() + * callback is called underneath the wakeref mutex. * - * Note that @fn is allowed to fail, in which case the runtime-pm wakeref - * is retained and an error reported. + * Note that intel_wakeref_ops->put() is allowed to fail, in which case the + * runtime-pm wakeref is retained. * - * Returns: 0 if the wakeref was released successfully, or a negative error - * code otherwise. */ static inline void __intel_wakeref_put(struct intel_wakeref *wf, unsigned long flags)