From patchwork Thu Jan 24 16:58:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10779551 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 967161515 for ; Thu, 24 Jan 2019 16:59:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 157E0304B4 for ; Thu, 24 Jan 2019 16:58:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0736130586; Thu, 24 Jan 2019 16:58:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 563E5304B4 for ; Thu, 24 Jan 2019 16:58:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727658AbfAXQ66 (ORCPT ); Thu, 24 Jan 2019 11:58:58 -0500 Received: from mail-ed1-f67.google.com ([209.85.208.67]:41785 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726252AbfAXQ65 (ORCPT ); Thu, 24 Jan 2019 11:58:57 -0500 Received: by mail-ed1-f67.google.com with SMTP id a20so5143532edc.8 for ; Thu, 24 Jan 2019 08:58:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RtsztvXLlPailp5EdBbJQywHawsntMUfvlxqGQH2rkw=; b=fZjAqFlqSg6v5+lJjSiTqeAUnP5qtmrqdWq+flkVtLaU5JN4osTx2pWVLEY/Lh67QM 5iHmXEHqwEy+ElawGFg/v4kYJFgNEr5pMcKsqA091w2YriwD3DWspb7Hpbu8n1MC3nYy h6D8wM8RTDB//B07vmcSW/zsJOCEZqHad9oKY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RtsztvXLlPailp5EdBbJQywHawsntMUfvlxqGQH2rkw=; b=paFAHhNQeojzx0cnwjeFgTIVtl9HaGAWj15SIfWXMBIyK/yx4kbqdrH6zpGHR3ZsxS a8wHvHFECc64or7w1BB2S23fdvAIWNW37n7LxBI4JYk0C1smpJ6e2vOaAAR4mLxAPb98 U9oLMBlcC3fWSlrLYhSmlosjlT4mrSpNUAgwurvcwj32NZa5jojhBCAeIqg5Yqb2BAk6 yKz36t4gZkBR3AzWdZcSrFNhD9BI2U8Trqhzs97oGam7iMfNdq7MOm3VrxuUM5xE38LY rl9OavCcTUaMYM68Qithu7IwYYj2MqvQyBnfoDtuELpw9NB5CyitwG6fKPH0PK6tE68P bOGQ== X-Gm-Message-State: AJcUukde+ZpVBC8hMSf4PT78/u5l7zXrKFb9BrrUx4nt4AWnva20qg2Z o0tuG3t4jafOFVTlEcl6TmSQ+w== X-Google-Smtp-Source: ALg8bN6XLngT/BZgEYaXUVr0kFk6qrBU1PJ4qhynxx2maGLbkKn9LGXI6pFeyghvMMmS3LX9gqOedA== X-Received: by 2002:a17:906:55b:: with SMTP id k27mr2203798eja.78.1548349135976; Thu, 24 Jan 2019 08:58:55 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id w31sm11219233edw.82.2019.01.24.08.58.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jan 2019 08:58:54 -0800 (PST) From: Daniel Vetter To: DRI Development Cc: Intel Graphics Development , Daniel Vetter , Daniel Vetter , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH 11/26] drm/exynos: Use drm_fb_helper_fill_info Date: Thu, 24 Jan 2019 17:58:16 +0100 Message-Id: <20190124165831.16427-12-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190124165831.16427-1-daniel.vetter@ffwll.ch> References: <20190124165831.16427-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This will give the exynos fbdev a name! Signed-off-by: Daniel Vetter Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c index f057082a9b30..b2018961b9cf 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c @@ -87,12 +87,10 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper, return PTR_ERR(fbi); } - fbi->par = helper; fbi->flags = FBINFO_FLAG_DEFAULT; fbi->fbops = &exynos_drm_fb_ops; - drm_fb_helper_fill_fix(fbi, fb->pitches[0], fb->format->depth); - drm_fb_helper_fill_var(fbi, helper, sizes->fb_width, sizes->fb_height); + drm_fb_helper_fill_info(fbi, helper); nr_pages = exynos_gem->size >> PAGE_SHIFT; From patchwork Thu Jan 24 16:58:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10779579 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9D85D1515 for ; Thu, 24 Jan 2019 16:59:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9D03F30D9D for ; Thu, 24 Jan 2019 16:59:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9060030DD8; Thu, 24 Jan 2019 16:59:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 023B130D9D for ; Thu, 24 Jan 2019 16:59:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728562AbfAXQ7X (ORCPT ); Thu, 24 Jan 2019 11:59:23 -0500 Received: from mail-ed1-f67.google.com ([209.85.208.67]:34329 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727722AbfAXQ7X (ORCPT ); Thu, 24 Jan 2019 11:59:23 -0500 Received: by mail-ed1-f67.google.com with SMTP id b3so5187957ede.1 for ; Thu, 24 Jan 2019 08:59:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ptbpNHmP1IxQtArJCgNoGU5Wyd+HU0A6AohvI8TPRfU=; b=Rt6PfzU432vYC255tCk6KIHHyvRhuBe6Cr4ECdk/HGjbKFVxwPColt3cfVmfVrV9MS W3MhOCZ+cgpmhyGTXgM7/8jsM5lmi5V4fGOykTlXt+o+TxxaaPYJ7sqKU0rIiEKQ5+eS S5lUV2UAwWSu6AlE4Fx7HCnide18gGuMeiHXs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ptbpNHmP1IxQtArJCgNoGU5Wyd+HU0A6AohvI8TPRfU=; b=O73nbiqYH1zfAQN0LvT4FsHMxKCbPtMnk3vw2p2XNHOtVilRrMoxVAHuuhOxrowd82 +1XTrc49VnXsM9yJDOfIEcwAuaVkh2kJcMJN7m1rFhtU9qfG0NcZpszdbhKy4C6tD0pJ 43LMs9PPqxH/THN4IXp5vZBq2uc8YuAEDhIcRUUMTsGqpKeLiNXY14IL4WZh6HW/e/nj yjz9hzL/s1wcRP0+B0bTCTaUduRiCI/HWpw6izO4NyUW02DajE2oS8jp/O60n2y7HDxZ MjbRmPAdWp3OjD8rQFsyvegPivNaOovaosDD4AwVmi8h0gONPCwRmx+IYSMqUroi7HUP k7JA== X-Gm-Message-State: AJcUukdxDIhpOFcWAYPcxTC3Mg5+uoADu8Fg7xfPVNbDuoHA0eI4uJnb Vu/4ETnCKKEpyGNgK/0g34aptg== X-Google-Smtp-Source: ALg8bN6QRj6TYEc0DG6xoIG4I77HrQVorGJHHpvEscd+oOzXyorDQyWoWiFnODoPZMRCl94pbLsKsQ== X-Received: by 2002:a50:fb03:: with SMTP id d3mr7224510edq.183.1548349160604; Thu, 24 Jan 2019 08:59:20 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id w31sm11219233edw.82.2019.01.24.08.59.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jan 2019 08:59:19 -0800 (PST) From: Daniel Vetter To: DRI Development Cc: Intel Graphics Development , Daniel Vetter , Daniel Vetter , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , Patrik Jakobsson , Ben Skeggs , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Thierry Reding , Jonathan Hunter , Hans de Goede , Greg Kroah-Hartman , Bartlomiej Zolnierkiewicz , Alexander Kapshuk , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org Subject: [PATCH 26/26] drm/: Don't set FBINFO_(FLAG_)DEFAULT Date: Thu, 24 Jan 2019 17:58:31 +0100 Message-Id: <20190124165831.16427-27-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190124165831.16427-1-daniel.vetter@ffwll.ch> References: <20190124165831.16427-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It's 0. Signed-off-by: Daniel Vetter Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: Patrik Jakobsson Cc: Ben Skeggs Cc: Sandy Huang Cc: "Heiko Stübner" Cc: Thierry Reding Cc: Jonathan Hunter Cc: Hans de Goede Cc: Greg Kroah-Hartman Cc: Daniel Vetter Cc: Bartlomiej Zolnierkiewicz Cc: Alexander Kapshuk Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: nouveau@lists.freedesktop.org Cc: linux-rockchip@lists.infradead.org Cc: linux-tegra@vger.kernel.org Acked-by: Thierry Reding --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 1 - drivers/gpu/drm/gma500/framebuffer.c | 1 - drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 ++-- drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 1 - drivers/gpu/drm/tegra/fb.c | 1 - 5 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c index b2018961b9cf..00bfcd28e589 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c @@ -87,7 +87,6 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper, return PTR_ERR(fbi); } - fbi->flags = FBINFO_FLAG_DEFAULT; fbi->fbops = &exynos_drm_fb_ops; drm_fb_helper_fill_info(fbi, helper); diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c index c7a5c29f9a69..3b59dbadfa63 100644 --- a/drivers/gpu/drm/gma500/framebuffer.c +++ b/drivers/gpu/drm/gma500/framebuffer.c @@ -401,7 +401,6 @@ static int psbfb_create(struct psb_fbdev *fbdev, fbdev->psb_fb_helper.fb = fb; - info->flags = FBINFO_DEFAULT; if (dev_priv->ops->accel_2d && pitch_lines > 8) /* 2D engine */ info->fbops = &psbfb_ops; else if (gtt_roll) { /* GTT rolling seems best */ diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c index 3a3d454b65e3..1136ee26005f 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c @@ -370,9 +370,9 @@ nouveau_fbcon_create(struct drm_fb_helper *helper, fbcon->helper.fb = &fb->base; if (!chan) - info->flags = FBINFO_DEFAULT | FBINFO_HWACCEL_DISABLED; + info->flags = FBINFO_HWACCEL_DISABLED; else - info->flags = FBINFO_DEFAULT | FBINFO_HWACCEL_COPYAREA | + info->flags = FBINFO_HWACCEL_COPYAREA | FBINFO_HWACCEL_FILLRECT | FBINFO_HWACCEL_IMAGEBLIT; info->fbops = &nouveau_fbcon_sw_ops; diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c index d12164878e05..fed7d7698164 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c @@ -90,7 +90,6 @@ static int rockchip_drm_fbdev_create(struct drm_fb_helper *helper, goto out; } - fbi->flags = FBINFO_FLAG_DEFAULT; fbi->fbops = &rockchip_drm_fbdev_ops; fb = helper->fb; diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c index 82348ddd0b83..ea82184073bd 100644 --- a/drivers/gpu/drm/tegra/fb.c +++ b/drivers/gpu/drm/tegra/fb.c @@ -255,7 +255,6 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper, helper->fb = fb; helper->fbdev = info; - info->flags = FBINFO_FLAG_DEFAULT; info->fbops = &tegra_fb_ops; drm_fb_helper_fill_info(info, helper);