From patchwork Mon Jan 16 14:01:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philippe Schenker X-Patchwork-Id: 13103275 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 179DCC54EBE for ; Mon, 16 Jan 2023 14:08:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=HsnbMgxJPsHdxlHUOMK2sjb3PgHJc+oahp2L7Jsdr1s=; b=ij1f8AwzuxgBt7 j9rd5dvEYaaYDfBaoX+rmM+ZNn85QtNw/Mpoajnax3gBTVbizXhlHKWCdTOCnpcKIwwHMDNKIz75Q GvObMRGmngyx0MDlVstvEsStjAYGN5rgo4I0Bc7xvjzPom73fXdq2+xyhA+zd9HNV+7sl8yAL1i4/ 6I9VhVlBoZgC0v9PzQI7/MzFhIrvN+kv2nH2Ko2SiBmltAdykOFR+qDBEoiWlp0qCWKFYE44aB8G8 7pxH8cCHIdiPCZHRb3YNIZ4D/5GXT/qwCrDKrTx1GOX5/oZnU1B58DwJXziBC5Rj7EB2rngUZiQQf ximjklvI7Z2YKsDyAQ2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHQ8k-00AjKz-Cp; Mon, 16 Jan 2023 14:07:12 +0000 Received: from smtp-8faf.mail.infomaniak.ch ([2001:1600:3:17::8faf]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHQ3t-00AgPf-2y for linux-arm-kernel@lists.infradead.org; Mon, 16 Jan 2023 14:02:11 +0000 Received: from smtp-3-0000.mail.infomaniak.ch (unknown [10.4.36.107]) by smtp-2-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4NwYc90nXCzMqcMb; Mon, 16 Jan 2023 15:02:01 +0100 (CET) Received: from unknown by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4NwYc81GLdzGsp; Mon, 16 Jan 2023 15:02:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pschenker.ch; s=20220412; t=1673877721; bh=A6GZwkHnaoIZ28gxZUhGOXzEzh7g91KUo/Qw0h2sKB4=; h=From:To:Cc:Subject:Date:From; b=TKYlhNeXlGFMKUiXm+/BS6fmCAtv53XpEYN8DQwHLt46AHrZdFVcNecmDMtHtcdiU k2mGbd4GTydvxcQCJdaW7uHqgZEYoUHAU+14U1MDwjsuLMEYjAIUDx9oKLG21b552p Oq8D9JQ4Omcf/3DENcTx+z6puBxwCytsM5LzT4m0= From: Philippe Schenker To: devicetree@vger.kernel.org Cc: Philippe Schenker , Andrejs Cainikovs , Fabio Estevam , Francesco Dolcini , Krzysztof Kozlowski , Marcel Ziswiler , NXP Linux Team , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] arm64: dts: imx8mm-verdin: Do not power down eth-phy Date: Mon, 16 Jan 2023 15:01:52 +0100 Message-Id: <20230116140153.23938-1-dev@pschenker.ch> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Infomaniak-Routing: alpha X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230116_060209_621969_F727BE4A X-CRM114-Status: GOOD ( 10.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Philippe Schenker Currently if suspending using either freeze or memory state, the fec driver tries to power down the phy which leads to crash of the kernel and non-responsible kernel with the following call trace: [ 24.839889 ] Call trace: [ 24.839892 ] phy_error+0x18/0x60 [ 24.839898 ] kszphy_handle_interrupt+0x6c/0x80 [ 24.839903 ] phy_interrupt+0x20/0x2c [ 24.839909 ] irq_thread_fn+0x30/0xa0 [ 24.839919 ] irq_thread+0x178/0x2c0 [ 24.839925 ] kthread+0x154/0x160 [ 24.839932 ] ret_from_fork+0x10/0x20 Since there is currently no functionality in the phy subsystem to power down phys let's just disable the feature of powering-down the ethernet phy. Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial support for verdin imx8m mini") Signed-off-by: Philippe Schenker --- arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi index 7e8b3b0fa306..4df3c9760151 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi @@ -102,6 +102,7 @@ reg_ethphy: regulator-ethphy { off-on-delay = <500000>; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_reg_eth>; + regulator-always-on; regulator-boot-on; regulator-max-microvolt = <3300000>; regulator-min-microvolt = <3300000>;