From patchwork Tue Jan 17 18:04:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Nirmoy Das X-Patchwork-Id: 13104966 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99AE2C54E76 for ; Tue, 17 Jan 2023 18:04:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F8B110E30F; Tue, 17 Jan 2023 18:04:52 +0000 (UTC) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 82C3810E30F; Tue, 17 Jan 2023 18:04:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673978689; x=1705514689; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=OD7j79DRiTFV8ZWi8Id42iAqpnY4oi7w03hVQl4OcHs=; b=KRJA8sFFtiXfOMZfUmYZBM0f0lo1/5cORJO5Vf7qhiDdI+GPr2ljzbT6 wJuV+Sm76jJp0CI6DJ0dgLoDPMy78VD8Q6Kzog1gqXcq6TP1Ic0V0Hh8O UUvZuIM0dIq3bJkRJlsGB1OS1hGcbP2gbIlNyUTlFCwbIGazAY52Jukbb jdObbGjRnotjFYdYG4lCf46lI2chEGRc/XSlbqi9XcU4kcEBmTLLvW1Z6 5+vSblJF9lE4Jqsti6dXLtKZTnaQTosAMUTX7TKA8qBa4VsWQDkmRRDkE 4liDjlubx+YnPMo9ZINT7zKmXi5RRTWTe+EGOEE4EIdSrHjxwCmJD/lre Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="387116359" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="387116359" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 10:04:48 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="659467378" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="659467378" Received: from nirmoyda-desk.igk.intel.com ([10.102.42.231]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 10:04:47 -0800 From: Nirmoy Das To: dri-devel@lists.freedesktop.org Subject: [PATCH v2] drm/radeon: Do not use deprecated drm log API Date: Tue, 17 Jan 2023 19:04:16 +0100 Message-Id: <20230117180417.21066-1-nirmoy.das@intel.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Organization: Intel Deutschland GmbH, Registered Address: Am Campeon 10, 85579 Neubiberg, Germany, Commercial Register: Amtsgericht Muenchen HRB 186928 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , amd-gfx@lists.freedesktop.org, Nirmoy Das Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Replace deprecated DRM_DEBUG_KMS_RATELIMITED() and DRM_ERROR() with proper APIs. v2: replace pr_err with dev_err(Alex). Cc: Alex Deucher Cc: Christian König Signed-off-by: Nirmoy Das --- drivers/gpu/drm/radeon/radeon_dp_auxch.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_dp_auxch.c b/drivers/gpu/drm/radeon/radeon_dp_auxch.c index 69379b95146e..1e5b6baf76a1 100644 --- a/drivers/gpu/drm/radeon/radeon_dp_auxch.c +++ b/drivers/gpu/drm/radeon/radeon_dp_auxch.c @@ -158,7 +158,7 @@ radeon_dp_aux_transfer_native(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg } while (retry_count++ < 1000); if (retry_count >= 1000) { - DRM_ERROR("auxch hw never signalled completion, error %08x\n", tmp); + dev_err(rdev->dev, "auxch hw never signalled completion, error %08x\n", tmp); ret = -EIO; goto done; } @@ -168,8 +168,7 @@ radeon_dp_aux_transfer_native(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg goto done; } if (tmp & AUX_RX_ERROR_FLAGS) { - DRM_DEBUG_KMS_RATELIMITED("dp_aux_ch flags not zero: %08x\n", - tmp); + drm_dbg_kms_ratelimited(dev, "dp_aux_ch flags not zero: %08x\n", tmp); ret = -EIO; goto done; } From patchwork Tue Jan 17 18:04:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nirmoy Das X-Patchwork-Id: 13104967 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11FADC3DA78 for ; Tue, 17 Jan 2023 18:04:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0F61310E31D; Tue, 17 Jan 2023 18:04:58 +0000 (UTC) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id AA69510E30F; Tue, 17 Jan 2023 18:04:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673978691; x=1705514691; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mjFAk5Yl7unq5VwkxZCfHQDMadAmpn9x0q8TYzUqatY=; b=nYDJxU04MG1WQcToHNVch9rDj/DCC2+xxGLhHxCqJ5v6OBqEVbYbAJwT jZoiRN1rNjbX253tdbSsTF5KkbwM98d7bhSByyXZtzKsFMGA6nxjP9lPW 6gBhkSPaGBF6TdeKIpL4+QLp/M6/cJy9H+6Wg6KnnsnksapVBtTf+Sez9 UUVxchCT1VOWLAS/5eBWnA+QKyuWgWi3FUqhGOCL6puPVLvBjmCc2NkLq gyKUHmrpG3hemMn3GFrwsvnHJNu0LxFtmWOJ5Ki4PqGYQRxX7GWIo3jQj tUvTuN6w0FaF9k6v2R1bXdLLTT6MElgv3J9plywwQMt2c35DY+pjg1usz w==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="387116378" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="387116378" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 10:04:51 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="659467390" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="659467390" Received: from nirmoyda-desk.igk.intel.com ([10.102.42.231]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 10:04:49 -0800 From: Nirmoy Das To: dri-devel@lists.freedesktop.org Subject: [PATCH 2/2] drm_print: Remove deprecated DRM_DEBUG_KMS_RATELIMITED() Date: Tue, 17 Jan 2023 19:04:17 +0100 Message-Id: <20230117180417.21066-2-nirmoy.das@intel.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230117180417.21066-1-nirmoy.das@intel.com> References: <20230117180417.21066-1-nirmoy.das@intel.com> MIME-Version: 1.0 Organization: Intel Deutschland GmbH, Registered Address: Am Campeon 10, 85579 Neubiberg, Germany, Commercial Register: Amtsgericht Muenchen HRB 186928 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sam Ravnborg , amd-gfx@lists.freedesktop.org, Thomas Zimmermann , Nirmoy Das Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" There are no current users of DRM_DEBUG_KMS_RATELIMITED() so remove it. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: Sam Ravnborg Signed-off-by: Nirmoy Das Reviewed-by: Sam Ravnborg Reviewed-by: Alex Deucher --- include/drm/drm_print.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h index a44fb7ef257f..c3753da97c4e 100644 --- a/include/drm/drm_print.h +++ b/include/drm/drm_print.h @@ -605,9 +605,6 @@ void __drm_err(const char *format, ...); #define drm_dbg_kms_ratelimited(drm, fmt, ...) \ __DRM_DEFINE_DBG_RATELIMITED(KMS, drm, fmt, ## __VA_ARGS__) -/* NOTE: this is deprecated in favor of drm_dbg_kms_ratelimited(NULL, ...). */ -#define DRM_DEBUG_KMS_RATELIMITED(fmt, ...) drm_dbg_kms_ratelimited(NULL, fmt, ## __VA_ARGS__) - /* * struct drm_device based WARNs *