From patchwork Fri Jan 25 00:52:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Desaulniers X-Patchwork-Id: 10780981 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A11476C2 for ; Fri, 25 Jan 2019 10:15:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8E17B2E51B for ; Fri, 25 Jan 2019 10:15:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 81DB42E527; Fri, 25 Jan 2019 10:15:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2B6562E51B for ; Fri, 25 Jan 2019 10:15:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CF4CD6F2D4; Fri, 25 Jan 2019 10:14:50 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-vs1-xe4a.google.com (mail-vs1-xe4a.google.com [IPv6:2607:f8b0:4864:20::e4a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7BDA06E411 for ; Fri, 25 Jan 2019 00:53:23 +0000 (UTC) Received: by mail-vs1-xe4a.google.com with SMTP id a82so2982661vsd.19 for ; Thu, 24 Jan 2019 16:53:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=lImYpiAn1uJlETxYy7nHGrYS1qOku0eBJBZYPcEb9VQ=; b=FlJfe/HNbnM4SuWc6OEQUqx5kb1d4kejttJoXZWF4b3UN1vN4qca0648NB26Hle+Z5 n4weYZ+KY2cNfU7D6xjyPCHFZAFxGhw6xu8E76N9+ueh6Vg/RwbyoNirFHIfJrUMr1nT zOXMRiUibr4Xamy0FqWGekXjsSc5REb/Dkl6ociixAFWwfGWW0uRdmmnLnAzIRjILH/D 7XPbglJEq2KekZesJ+ozJzkM9KsX5YbTTX/TaI3kGGXaIEgViyjWVtAMPJa1KmCwuSA1 EvGelrkfgDHBr2RWcYSBdtCxS8xwRnP0X7Xvx1gtE2g5ArKeIgjzRdN1DIAG3YYs2hDU VSGg== X-Gm-Message-State: AJcUukebG2SNXmRgLAMU66ONv0YX9McGW8gBLXsrJUbtxKbYjrzKN3wh 6iwDICjo91OdtkkW340bsESumvB5lhEO6X93Og0= X-Google-Smtp-Source: ALg8bN5gjC2t14WSAJstQ+OAgdmNd0+EtOob/jdgNeSBgNP66NpeJ/4VYrKvORwUINDWmrKNyJ2F3mUHXNfET2Cl0WY= X-Received: by 2002:a67:8542:: with SMTP id h63mr7284273vsd.43.1548377602513; Thu, 24 Jan 2019 16:53:22 -0800 (PST) Date: Thu, 24 Jan 2019 16:52:59 -0800 Message-Id: <20190125005304.183322-1-ndesaulniers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.20.1.321.g9e740568ce-goog X-Patchwork-Bot: notify Subject: [PATCH] drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines From: ndesaulniers@google.com To: airlied@linux.ie, daniel@ffwll.ch X-Mailman-Approved-At: Fri, 25 Jan 2019 10:14:49 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: S@google.com, Dmytro Laktyushkin , Leo Li , =?utf-8?q?Michel_D=C3=A4nzer?= , dri-devel@lists.freedesktop.org, Nick Desaulniers , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Shirish , Matthias Kaehlcke , Matthias Kaehlcke , Tony Cheng , amd-gfx@lists.freedesktop.org, James Y Knight , Alex Deucher , Nathan Chancellor , =?utf-8?q?Christian_K=C3=B6ni?= =?utf-8?q?g?= , Guenter Roeck Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP arch/x86/Makefile disables SSE and SSE2 for the whole kernel. The AMDGPU drivers modified in this patch re-enable SSE but not SSE2. Turn on SSE2 to support emitting double precision floating point instructions rather than calls to non-existent (usually available from gcc_s or compiler_rt) floating point helper routines. Link: https://gcc.gnu.org/onlinedocs/gccint/Soft-float-library-routines.html Link: https://github.com/ClangBuiltLinux/linux/issues/327 Cc: stable@vger.kernel.org # 4.19 Reported-by: S, Shirish Reported-by: Matthias Kaehlcke Suggested-by: James Y Knight Suggested-by: Nathan Chancellor Signed-off-by: Nick Desaulniers Tested-by: Guenter Roeck Tested-by: Nathan Chancellor Reviewed-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/calcs/Makefile | 2 +- drivers/gpu/drm/amd/display/dc/dml/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/calcs/Makefile b/drivers/gpu/drm/amd/display/dc/calcs/Makefile index 95f332ee3e7e..dc85a3c088af 100644 --- a/drivers/gpu/drm/amd/display/dc/calcs/Makefile +++ b/drivers/gpu/drm/amd/display/dc/calcs/Makefile @@ -30,7 +30,7 @@ else ifneq ($(call cc-option, -mstack-alignment=16),) cc_stack_align := -mstack-alignment=16 endif -calcs_ccflags := -mhard-float -msse $(cc_stack_align) +calcs_ccflags := -mhard-float -msse -msse2 $(cc_stack_align) CFLAGS_dcn_calcs.o := $(calcs_ccflags) CFLAGS_dcn_calc_auto.o := $(calcs_ccflags) diff --git a/drivers/gpu/drm/amd/display/dc/dml/Makefile b/drivers/gpu/drm/amd/display/dc/dml/Makefile index d97ca6528f9d..33c7d7588712 100644 --- a/drivers/gpu/drm/amd/display/dc/dml/Makefile +++ b/drivers/gpu/drm/amd/display/dc/dml/Makefile @@ -30,7 +30,7 @@ else ifneq ($(call cc-option, -mstack-alignment=16),) cc_stack_align := -mstack-alignment=16 endif -dml_ccflags := -mhard-float -msse $(cc_stack_align) +dml_ccflags := -mhard-float -msse -msse2 $(cc_stack_align) CFLAGS_display_mode_lib.o := $(dml_ccflags) CFLAGS_display_pipe_clocks.o := $(dml_ccflags)