From patchwork Mon Jan 30 14:01:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13121178 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8E53C54EED for ; Mon, 30 Jan 2023 14:02:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237031AbjA3OCm (ORCPT ); Mon, 30 Jan 2023 09:02:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237044AbjA3OCW (ORCPT ); Mon, 30 Jan 2023 09:02:22 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08AFA3B0E8; Mon, 30 Jan 2023 06:02:14 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B9BD8B8114D; Mon, 30 Jan 2023 14:02:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05641C433D2; Mon, 30 Jan 2023 14:02:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675087331; bh=6tA93H1Tk/wXbdlyFNn8xOAv7o+DOjEyIt6ZwZlTS/g=; h=From:To:Cc:Subject:Date:From; b=lXM+eeR1gUyS9lgFEhe3pbRMkHnGaXl11XPCNctbljg9skgaRfkrzsRc7d63qTi/2 gVyv3NFRhYpBvau3YnETqSd+TQgXh7KLRFPa9XpZJwHN0/P4GNLSUBZIHJ9CPhUzeJ 8IFsmqVJy8vKTHpTm2Hp4MVlRjvIKrMzdDwGhpHtIYmFboQBu/R0La2sqze/cjYDvA 6jeOCNHpvxf0bLoUDqyY2c4MA7cv+hNqZp2gQ76JBQVonNrwt4n4yqzIZIXKoWx7gh fVQo9DolPP7wzqJdskSSQ2KPD3UNrCma5U9gb2nK0+UpzjtKU0ls7bgxBsseFa9NQb kGP1MjJXa7YmA== From: Arnd Bergmann To: Mark Brown , Serge Semin , Ramil Zaripov Cc: Arnd Bergmann , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [v2] spi: dw_bt1: fix MUX_MMIO dependencies Date: Mon, 30 Jan 2023 15:01:40 +0100 Message-Id: <20230130140156.3620863-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org From: Arnd Bergmann Selecting a symbol with additional dependencies requires adding the same dependency here: WARNING: unmet direct dependencies detected for MUX_MMIO Depends on [n]: MULTIPLEXER [=y] && OF [=n] Selected by [y]: - SPI_DW_BT1 [=y] && SPI [=y] && SPI_MASTER [=y] && SPI_DESIGNWARE [=y] && (MIPS_BAIKAL_T1 || COMPILE_TEST [=y]) Drop the 'select' here to avoid the problem. Anyone using the dw-bt1 SPI driver should make sure they include the mux driver as well now. Fixes: 7218838109fe ("spi: dw-bt1: Fix undefined devm_mux_control_get symbol") Fixes: abf00907538e ("spi: dw: Add Baikal-T1 SPI Controller glue driver") Link: https://lore.kernel.org/all/20221218192523.c6vnfo26ua6xqf26@mobilestation/ Signed-off-by: Arnd Bergmann Reviewed-by: Serge Semin --- drivers/spi/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 61fffc8eecc7..711c1c3bbd78 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -295,7 +295,6 @@ config SPI_DW_BT1 tristate "Baikal-T1 SPI driver for DW SPI core" depends on MIPS_BAIKAL_T1 || COMPILE_TEST select MULTIPLEXER - select MUX_MMIO help Baikal-T1 SoC is equipped with three DW APB SSI-based MMIO SPI controllers. Two of them are pretty much normal: with IRQ, DMA,