From patchwork Tue Jan 31 09:53:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 13122857 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24544C38142 for ; Tue, 31 Jan 2023 10:34:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=uYvtf0f4bQMAap7+GmqwaPwOSDohhrEvz2QRK2xRMMs=; b=Z1ZRXeld7wM9we 5eOFZKIdeGyaUDGb8xqoqWHPmcyqP9G1r4XifVbIErFFXoY/bXDR2mt6tm3cYfVhLJSkNlPcIKr5e 2RKR4e4PwXYv2/55LHr3QpDd9OvYx0YZQ8JZg/BiOXdumDWB82r5pS1MLmlO9jay/ZaG+t7vm9vUR fXs0wR8Aogf9NOTFazFvLV9SA0ijBRHTCpv8zf0pHnKxqvjSDvxyHQ/fr8x9kXbTUQATW9dBNO8Zi IV6NJwHi0qUeo4UIooI0PTKPyA5bFihsHg31rICLAsJDA7rrzrXeHekQ1KbLjRGn1pA/mwlSEOn2m HSscaCwxXgnHkm2JX4kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMnwW-007R6j-Mc; Tue, 31 Jan 2023 10:32:50 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMnKp-007AS4-3Q for linux-arm-kernel@lists.infradead.org; Tue, 31 Jan 2023 09:53:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1675158831; x=1706694831; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=E0qM+XuYdFeYfKG57gc15FoIBLKs/j9Sc/S2XXkR5nI=; b=P5urhTLjR0gz0yWwwSq8a0IE5iKpm+fAPHj1t5FPOjGLxm1xjDnGDtC+ Eh9Ssd2wFw9XxauF8w18z3vOEBzRWa6UAZueuW9E035K67QBLWhHrm1eM Grh8MALvYa6vDHLe7ai9URGNLC/b/Hq8DrRhJLXKusvR4GVKIgZdBpXa1 /iiUNWyC0Ic+llIUw6jbiBsPKQnvCPvYXknwDGBqz9shsEvVgBgVyIs3i rREIWdH8FOmV/kDnqbR2U/kJIUMzGsW7RNGcJg+287e0/Vv9jIlb3Q81X awt7R3JoT+52jxNY9IP4jqz2EYWrA2aors3X5DtbYEIvhtJnXTnZCwJgw g==; X-IronPort-AV: E=Sophos;i="5.97,259,1669071600"; d="scan'208";a="28765252" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 31 Jan 2023 10:53:44 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Tue, 31 Jan 2023 10:53:44 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Tue, 31 Jan 2023 10:53:44 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1675158824; x=1706694824; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=E0qM+XuYdFeYfKG57gc15FoIBLKs/j9Sc/S2XXkR5nI=; b=Qc5/TfLORYwVf3fgdBzw6SP8FuJ04ocDQO9hy1QY2tqnlBXswVisSoGT n7xNbZTTTWkJ+n348N4saeUpnSLk6QmueW6aUMZ+U1SHA03UIPrZJQC6Q Txr7teGL1uWESrN2uoqwW7SmJZEK0ucrx2AcnKBxUA1TwgWYcSkhKpZ6l XsMFWP6fYnptcDMS1PWVPln7OtG2mhMz7eBnJ8uhInRfKHdlwHerF6/Sf URZGNISFi5sy2XAqh3x327PEGW25dLl10m8XnueOlDhRXJhIlPGXxR1/z AksHouWhkRYNE6Pod/oXnjS4UPzuZPfq51lRkq+lcSWyTLEdAoekdUN53 Q==; X-IronPort-AV: E=Sophos;i="5.97,259,1669071600"; d="scan'208";a="28765251" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 31 Jan 2023 10:53:44 +0100 Received: from steina-w.tq-net.de (unknown [10.123.53.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 7DF54280056; Tue, 31 Jan 2023 10:53:44 +0100 (CET) From: Alexander Stein To: Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Alexander Stein , Pengutronix Kernel Team , NXP Linux Team , linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/1] firmware: imx: scu: use dev_err_probe Date: Tue, 31 Jan 2023 10:53:40 +0100 Message-Id: <20230131095340.600363-1-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230131_015351_819826_077AB225 X-CRM114-Status: GOOD ( 12.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This simplifies the code and silences -517 error messages. Also the reason is listed in /sys/kernel/debug/devices_deferred. Signed-off-by: Alexander Stein Reviewed-by: Mukesh Ojha --- drivers/firmware/imx/imx-scu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c index dca79caccd01..47db49911e7b 100644 --- a/drivers/firmware/imx/imx-scu.c +++ b/drivers/firmware/imx/imx-scu.c @@ -310,9 +310,8 @@ static int imx_scu_probe(struct platform_device *pdev) sc_chan->ch = mbox_request_channel_byname(cl, chan_name); if (IS_ERR(sc_chan->ch)) { ret = PTR_ERR(sc_chan->ch); - if (ret != -EPROBE_DEFER) - dev_err(dev, "Failed to request mbox chan %s ret %d\n", - chan_name, ret); + dev_err_probe(dev, ret, "Failed to request mbox chan %s\n", + chan_name); kfree(chan_name); return ret; }