From patchwork Thu Feb 2 01:23:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ira Weiny X-Patchwork-Id: 13125179 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC1DFC636CD for ; Thu, 2 Feb 2023 01:23:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230519AbjBBBXk (ORCPT ); Wed, 1 Feb 2023 20:23:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229882AbjBBBXj (ORCPT ); Wed, 1 Feb 2023 20:23:39 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BCFB757B4 for ; Wed, 1 Feb 2023 17:23:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675301010; x=1706837010; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=qB93D8gcQzE8bWgRKNIX9AGpk9Y6HJXYcaDXaCc5Lzg=; b=ApiMtdMviiwNh2vRHZL2wrTnm7Ufux3DNaOsFYR3sgJ9NyN1ZSd4+T+e O0448lauOx5/Tv9ymP9EXsxKOGdwnp6Iu5FwRwYb+7d8X+41xDjCmzSms kYy/C5sjiIQtd88jW1WXVFiVxR4qFRsd7+mRiE5Jcx8pE56om5Ve7HxkO CvInXCFLRJKuD8XFcTCvsmbkiYJomgrD94t1+KwUDLWy9xRTQkipLp1Hd yEtLAzsYsYChLZ3XWqXhSWPurqf60J1/B5r0c7/ERhBrwwC+zv4rBIjoM tgSfyXRjEozsIT1liX1vMhz038s908tjyxpeuxZFhAW9J6v0euAPl/R1R Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="308661522" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="308661522" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 17:23:29 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="993888775" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="993888775" Received: from iweiny-desk3.amr.corp.intel.com (HELO localhost) ([10.212.15.11]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 17:23:28 -0800 From: Ira Weiny Date: Wed, 01 Feb 2023 17:23:10 -0800 Subject: [PATCH v3 1/4] cxl/mem: Remove unused CXL_CMD_FLAG_NONE define MIME-Version: 1.0 Message-Id: <20221222-cxl-misc-v3-1-60d4f35e4b39@intel.com> References: <20221222-cxl-misc-v3-0-60d4f35e4b39@intel.com> In-Reply-To: <20221222-cxl-misc-v3-0-60d4f35e4b39@intel.com> To: Dan Williams Cc: "Jiang, Dave" , Alison Schofield , Vishal Verma , Ben Widawsky , Robert Richter , Jonathan Cameron , linux-cxl@vger.kernel.org, Ira Weiny , Jonathan Cameron X-Mailer: b4 0.11.0-dev-e429b X-Developer-Signature: v=1; a=ed25519-sha256; t=1675301007; l=641; i=ira.weiny@intel.com; s=20221222; h=from:subject:message-id; bh=qB93D8gcQzE8bWgRKNIX9AGpk9Y6HJXYcaDXaCc5Lzg=; b=ahbwdgzr3SFWf+4H7vHU8wSqaPoZ7gYi0KOYLXNdLbHs6+MiRLXdZ7y24KpCzZNFeNWCtO/6c5xk UKIhumeNAVoJwxBwozYaykFLQsM9RhZJe1HQbx6NqFMsdEJhjp54 X-Developer-Key: i=ira.weiny@intel.com; a=ed25519; pk=brwqReAJklzu/xZ9FpSsMPSQ/qkSalbg6scP3w809Ec= Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org CXL_CMD_FLAG_NONE is not used, remove it. Reviewed-by: Jonathan Cameron Reviewed-by: Dave Jiang Signed-off-by: Ira Weiny --- drivers/cxl/cxlmem.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h index ab138004f644..2d85776236dd 100644 --- a/drivers/cxl/cxlmem.h +++ b/drivers/cxl/cxlmem.h @@ -393,7 +393,6 @@ struct cxl_mem_command { struct cxl_command_info info; enum cxl_opcode opcode; u32 flags; -#define CXL_CMD_FLAG_NONE 0 #define CXL_CMD_FLAG_FORCE_ENABLE BIT(0) }; From patchwork Thu Feb 2 01:23:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ira Weiny X-Patchwork-Id: 13125180 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C48BC636CD for ; Thu, 2 Feb 2023 01:23:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231438AbjBBBXm (ORCPT ); Wed, 1 Feb 2023 20:23:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229882AbjBBBXk (ORCPT ); Wed, 1 Feb 2023 20:23:40 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35FDB6AC82 for ; Wed, 1 Feb 2023 17:23:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675301011; x=1706837011; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=R4XKfG9JMHsfbq65atGQCPp98ZqBkdqh//cpSQf3DTY=; b=OYc1snI389WiyIUfXtUeSFnJH93SLVdH0vc0YG4nzZhVRdAgdiQMdOYj xH8E6Dq4UJ+zfeBlvlAps7wJzPFP25EMP1ufwjJVovYfXz93uFVd/lUxt EuHxVdbZzJiuDOtgJ0bk+Zn2e/Z64O87T27NJHcldFe5QA2345CdMOaX7 qPWbKrEZr68TlC0LrcatIy6hFAaRauCmK75UzqnQm5aPOxFLyrveWS4XB oRNE+UDHAmvWJjkolH/snFkhSAxg5sxGQXmcrBVX2ozvk22/OkVuC1cAK WG2GRC0ahdEDFKaEfTQ0xrVf2l0IvkWdtGbFGeoVo/vVItukwjvV3qHLQ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="308661526" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="308661526" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 17:23:29 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="993888782" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="993888782" Received: from iweiny-desk3.amr.corp.intel.com (HELO localhost) ([10.212.15.11]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 17:23:29 -0800 From: Ira Weiny Date: Wed, 01 Feb 2023 17:23:11 -0800 Subject: [PATCH v3 2/4] cxl/uapi: Add warning on CXL command enum MIME-Version: 1.0 Message-Id: <20221222-cxl-misc-v3-2-60d4f35e4b39@intel.com> References: <20221222-cxl-misc-v3-0-60d4f35e4b39@intel.com> In-Reply-To: <20221222-cxl-misc-v3-0-60d4f35e4b39@intel.com> To: Dan Williams Cc: "Jiang, Dave" , Alison Schofield , Vishal Verma , Ben Widawsky , Robert Richter , Jonathan Cameron , linux-cxl@vger.kernel.org, Ira Weiny , Jonathan Cameron X-Mailer: b4 0.11.0-dev-e429b X-Developer-Signature: v=1; a=ed25519-sha256; t=1675301007; l=1198; i=ira.weiny@intel.com; s=20221222; h=from:subject:message-id; bh=R4XKfG9JMHsfbq65atGQCPp98ZqBkdqh//cpSQf3DTY=; b=bim2eULyAMgHMnUaiAwHsX5GoZ6pDKAIdFSAgY0bNSQIntgYSxLFmpR+Odq/Mm3VwLP8FRmqVYD2 f19t6If7BMzBIJdhF+vWKcTmEyRnrnSDG3Krb1diP1J9DdotfziS X-Developer-Key: i=ira.weiny@intel.com; a=ed25519; pk=brwqReAJklzu/xZ9FpSsMPSQ/qkSalbg6scP3w809Ec= Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org The CXL command enum is exported to user space and must maintain backwards compatibility. Add comment that new defines must be added to the end of the list. Suggested-by: Dan Williams Reviewed-by: Jonathan Cameron Reviewed-by: Dave Jiang Signed-off-by: Ira Weiny --- include/uapi/linux/cxl_mem.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/uapi/linux/cxl_mem.h b/include/uapi/linux/cxl_mem.h index c71021a2a9ed..459a3f7f764b 100644 --- a/include/uapi/linux/cxl_mem.h +++ b/include/uapi/linux/cxl_mem.h @@ -19,6 +19,10 @@ #define CXL_MEM_QUERY_COMMANDS _IOR(0xCE, 1, struct cxl_mem_query_commands) #define CXL_MEM_SEND_COMMAND _IOWR(0xCE, 2, struct cxl_send_command) +/* + * NOTE: New defines must be added to the end of the list to preserve + * compatibility because this enum is exported to user space. + */ #define CXL_CMDS \ ___C(INVALID, "Invalid Command"), \ ___C(IDENTIFY, "Identify Command"), \ From patchwork Thu Feb 2 01:23:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ira Weiny X-Patchwork-Id: 13125181 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5BBDC05027 for ; Thu, 2 Feb 2023 01:23:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229651AbjBBBXq (ORCPT ); Wed, 1 Feb 2023 20:23:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229686AbjBBBXp (ORCPT ); Wed, 1 Feb 2023 20:23:45 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E284D3FF12 for ; Wed, 1 Feb 2023 17:23:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675301016; x=1706837016; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=+i9oSZfQ5g+3vvuIPaluv8EpQnA5jiwde6foWG0D3TI=; b=CQERrmgJ00NXKCyqWc6gGK5O/G+lAzvp+wK/H6RBemwJvUgT6xTkzOq3 9Km1TnE8gZYIkSrfQe1Gy12+xJZ1Ljf8il8yoz2y2HyNsrAneE9Oj4DkO jV1J6ge55ld5qgpLy1HNH8mMlz/+vfATKXbGtc6CrAbRzwixm2QPVilie YD2lX2haN8JH9nSbG2+8nl1Zvb8m9XRqvyMhkqR/q8qkih2XslZ18Zoxg twMy9OzOBIfF6PgwfkI36a0Azb7343VGkkzV8+QlRJ+g1gcF0lErfDfPm KwThbpBdnNDJrzT0Qj6jM+JN0tVugjR4REXSyY6Z+YAT4koA99oUIN8Lf A==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="308661530" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="308661530" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 17:23:30 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="993888785" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="993888785" Received: from iweiny-desk3.amr.corp.intel.com (HELO localhost) ([10.212.15.11]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 17:23:30 -0800 From: Ira Weiny Date: Wed, 01 Feb 2023 17:23:12 -0800 Subject: [PATCH v3 3/4] cxl/uapi: Tag commands from cxl_query_cmd() MIME-Version: 1.0 Message-Id: <20221222-cxl-misc-v3-3-60d4f35e4b39@intel.com> References: <20221222-cxl-misc-v3-0-60d4f35e4b39@intel.com> In-Reply-To: <20221222-cxl-misc-v3-0-60d4f35e4b39@intel.com> To: Dan Williams Cc: "Jiang, Dave" , Alison Schofield , Vishal Verma , Ben Widawsky , Robert Richter , Jonathan Cameron , linux-cxl@vger.kernel.org, Ira Weiny , Jonathan Cameron X-Mailer: b4 0.11.0-dev-e429b X-Developer-Signature: v=1; a=ed25519-sha256; t=1675301007; l=2301; i=ira.weiny@intel.com; s=20221222; h=from:subject:message-id; bh=+i9oSZfQ5g+3vvuIPaluv8EpQnA5jiwde6foWG0D3TI=; b=YrdrwfWlDCcCBJlkSctsmssLIrnL91qoX5tWATw7rDp2H61VSZGKaI1Km4pgaUnwN61jb2p0cQX6 neSasFptDXGnftNJhGM4NSFzNU5YTHggnS+JXPq9ICA1srd532ae X-Developer-Key: i=ira.weiny@intel.com; a=ed25519; pk=brwqReAJklzu/xZ9FpSsMPSQ/qkSalbg6scP3w809Ec= Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org It was pointed out that commands not supported by the device or excluded by the kernel were being returned in cxl_query_cmd().[1] While libcxl correctly handles failing commands, it is more efficient to not issue an invalid command in the first place. This can't be done without additional information being returned from cxl_query_cmd(). In addition, information about the availability of commands can be useful for debugging. Add flags to struct cxl_command_info which reflect if a command is enabled and/or exclusive to the kernel. [1] https://lore.kernel.org/all/63b4ec4e37cc1_5178e2941d@dwillia2-xfh.jf.intel.com.notmuch/ Suggested-by: Dan Williams Signed-off-by: Ira Weiny --- Changes for v3: Dan Pass enabled/exclusive flags to user space rather than masking those commands. --- drivers/cxl/core/mbox.c | 9 +++++++-- include/uapi/linux/cxl_mem.h | 4 +++- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index b03fba212799..6ab4613f3cf9 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -445,9 +445,14 @@ int cxl_query_cmd(struct cxl_memdev *cxlmd, * structures. */ cxl_for_each_cmd(cmd) { - const struct cxl_command_info *info = &cmd->info; + struct cxl_command_info info = cmd->info; - if (copy_to_user(&q->commands[j++], info, sizeof(*info))) + if (test_bit(info.id, cxlmd->cxlds->enabled_cmds)) + info.flags |= CXL_MEM_COMMAND_FLAG_ENABLED; + if (test_bit(info.id, cxlmd->cxlds->exclusive_cmds)) + info.flags |= CXL_MEM_COMMAND_FLAG_EXCLUSIVE; + + if (copy_to_user(&q->commands[j++], &info, sizeof(info))) return -EFAULT; if (j == n_commands) diff --git a/include/uapi/linux/cxl_mem.h b/include/uapi/linux/cxl_mem.h index 459a3f7f764b..4aee64b7cc1a 100644 --- a/include/uapi/linux/cxl_mem.h +++ b/include/uapi/linux/cxl_mem.h @@ -91,7 +91,9 @@ struct cxl_command_info { __u32 id; __u32 flags; -#define CXL_MEM_COMMAND_FLAG_MASK GENMASK(0, 0) +#define CXL_MEM_COMMAND_FLAG_MASK GENMASK(1, 0) +#define CXL_MEM_COMMAND_FLAG_ENABLED BIT(0) +#define CXL_MEM_COMMAND_FLAG_EXCLUSIVE BIT(1) __u32 size_in; __u32 size_out; From patchwork Thu Feb 2 01:23:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ira Weiny X-Patchwork-Id: 13125182 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EBF1C636CD for ; Thu, 2 Feb 2023 01:23:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229686AbjBBBXt (ORCPT ); Wed, 1 Feb 2023 20:23:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231465AbjBBBXs (ORCPT ); Wed, 1 Feb 2023 20:23:48 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D5176A728 for ; Wed, 1 Feb 2023 17:23:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675301019; x=1706837019; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=7PhF1Q7E2qMzGGQiJjo+QsGen/5l8XdaAtvrNQSJs8o=; b=YlLuOUDNAkrL6YhMIeb7Nxya+s3X3s96LVhud/m76vUInZ8NY2DQfNTt /V6XHPMwd2/+DZq+19yyriubFFw+rsvlJ37WQiPhwcY+lOWbP0ag3MLpu uCml/gZWk/O4oksO/LG/r69Q/Imk4JrSHuVtPV1GrFK5Atx2jM0wWvJtk lSUDKaOr4YD7MIxSu5M/kqOWY/PfYPm8sTFHJcotuctkPSHP5mX2sHx6v 9xndNeJpJHRhrss7bWsf3kJR9GuSmUtJyt9TqaGQhx5r0Pns0npXHdQsK Ha8ju8Jw4a+Hwv6t69xd82DiGOtLmHxmUEVKsLPmUOrE9Zu62LCGtDL3F g==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="308661535" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="308661535" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 17:23:30 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="993888789" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="993888789" Received: from iweiny-desk3.amr.corp.intel.com (HELO localhost) ([10.212.15.11]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 17:23:30 -0800 From: Ira Weiny Date: Wed, 01 Feb 2023 17:23:13 -0800 Subject: [PATCH v3 4/4] cxl/mem: Fix UAPI command comment MIME-Version: 1.0 Message-Id: <20221222-cxl-misc-v3-4-60d4f35e4b39@intel.com> References: <20221222-cxl-misc-v3-0-60d4f35e4b39@intel.com> In-Reply-To: <20221222-cxl-misc-v3-0-60d4f35e4b39@intel.com> To: Dan Williams Cc: "Jiang, Dave" , Alison Schofield , Vishal Verma , Ben Widawsky , Robert Richter , Jonathan Cameron , linux-cxl@vger.kernel.org, Ira Weiny , Jonathan Cameron X-Mailer: b4 0.11.0-dev-e429b X-Developer-Signature: v=1; a=ed25519-sha256; t=1675301007; l=1434; i=ira.weiny@intel.com; s=20221222; h=from:subject:message-id; bh=7PhF1Q7E2qMzGGQiJjo+QsGen/5l8XdaAtvrNQSJs8o=; b=THWGImun12SQ1WKHPTGf0vfmTUuDh30U8ebHd9m6M+Kahakmw8Nrj4z0oyKBx6KAL4YZuOiObrKs cMu3So7YCohHD+xJKHgK26sAOd6JHeobOAboHeMw/8rgD7c8BJ8y X-Developer-Key: i=ira.weiny@intel.com; a=ed25519; pk=brwqReAJklzu/xZ9FpSsMPSQ/qkSalbg6scP3w809Ec= Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org The command comment had grammatical errors. In an attempt to fix those it was noted that the comment and the query command were not in sync. Now that the query command returns excluded and device unsupported command information. Update the kdoc and fix the grammatical errors. [1] https://lore.kernel.org/all/63b4ec4e37cc1_5178e2941d@dwillia2-xfh.jf.intel.com.notmuch/ Signed-off-by: Ira Weiny Reviewed-by: Jonathan Cameron --- Changes for v3: Adjust commit message for updated query command behavior. --- include/uapi/linux/cxl_mem.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/include/uapi/linux/cxl_mem.h b/include/uapi/linux/cxl_mem.h index 4aee64b7cc1a..b1d41e3be4e5 100644 --- a/include/uapi/linux/cxl_mem.h +++ b/include/uapi/linux/cxl_mem.h @@ -11,9 +11,10 @@ /** * DOC: UAPI * - * Not all of all commands that the driver supports are always available for use - * by userspace. Userspace must check the results from the QUERY command in - * order to determine the live set of commands. + * Not all of the commands that the driver supports are available for use by + * userspace at all times. Userspace can check the result of the QUERY command + * to determine the live set of commands. Alternatively, it can issue the + * command and check for failure. */ #define CXL_MEM_QUERY_COMMANDS _IOR(0xCE, 1, struct cxl_mem_query_commands)