From patchwork Thu Feb 2 07:03:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neal Liu X-Patchwork-Id: 13125784 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90C2FC05027 for ; Thu, 2 Feb 2023 11:03:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=u0m51mEnf/nLhocfhF9naUBk2rxKV/2GjpSiSxVy4qs=; b=x7wJf8+n1FXlnC Z3nPVek2kz8AwPdwTPCBzyWfe8zNpYtZ45aiAnG2IVGD5PPSrBtBwkEf9h/qgBEoeXIlbTHjWK/J7 clkwSTcpLgb+UoYFbQLSsVTmaQ1T7f5EZiw+HRkLS+Q0q8FmPdoyqV0z/RjXPFdUcvNx8041ZOMvW aX8mYMDj6elWRhCor5TBd0FkPLBHLUYSnOKZZu4dN7/WgVqQn5ERncEVjG8WtnF5uUnlPNR3T98ww VvZddaSb1emVDP4AQMysUZ24wFa1NsCPkTuJFX3eH3QN7lPIgvAap5IUyLPmnNCPHX3qPo7h/BPYu etzKn4fhdOLiwJFgA+IA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNXMb-00FWHG-N7; Thu, 02 Feb 2023 11:02:45 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNXMT-00FWFY-VA for linux-arm-kernel@bombadil.infradead.org; Thu, 02 Feb 2023 11:02:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Content-Transfer-Encoding :MIME-Version:Message-ID:Date:Subject:CC:To:From:Sender:Reply-To:Content-ID: Content-Description:In-Reply-To:References; bh=gAbqcMHYqWD3lIlf7L9TaQNRHJgTRd2rmgLc770qFuc=; b=Nje2UKBbUMfqK6QXi4ZJmi0VNZ PdqQsma7WCmBDjxudlSOr1y3syIPEQkdXmoa1KSq+0SURuDmYK6+lzwaF73GbFHLO0hANJzYB4FCN wviDn1YvIRh9yTRP22duXVw20zVaao2rhJhu2HH1YD88g/AIE2+2kUxZAdse5DxLWTPIn/CObt+zh 6vA9H4LmAAoLQWSu5AcXFIF8tngfzrD4qX/fsfIsdNRSSQ2Ukpo/yB/O+C91FvraCDTVGgKjpH7fv 6Nzlzvc44NZBhAanN/3K7K257yaXrIxwJmMLRzT8g3zUGHUS3CfbTcqeDGFMgFB7ptZX/RKFOSb3a REh5y7Bw==; Received: from twspam01.aspeedtech.com ([211.20.114.71]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pNTdm-0054IA-1A for linux-arm-kernel@lists.infradead.org; Thu, 02 Feb 2023 07:04:17 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 3126q2Ri020440; Thu, 2 Feb 2023 14:52:02 +0800 (GMT-8) (envelope-from neal_liu@aspeedtech.com) Received: from localhost.localdomain (192.168.10.10) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 2 Feb 2023 15:03:48 +0800 From: Neal Liu To: Joel Stanley , Andrew Jeffery , Neal Liu , Herbert Xu , "David S . Miller" CC: , , , Subject: [PATCH v2 -next] crypto: aspeed: fix type warnings Date: Thu, 2 Feb 2023 15:03:45 +0800 Message-ID: <20230202070345.191514-1-neal_liu@aspeedtech.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [192.168.10.10] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 3126q2Ri020440 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230202_070415_099159_7465C0C4 X-CRM114-Status: GOOD ( 12.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This patch fixes following warnings: 1. sparse: incorrect type in assignment (different base types) Fix: change to __le32 type. 2. sparse: cast removes address space '__iomem' of expression Fix: use readb to avoid dereferencing the memory. Signed-off-by: Neal Liu --- Change since v1: keep iomem marker to remain its purpose. drivers/crypto/aspeed/aspeed-acry.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/aspeed/aspeed-acry.c b/drivers/crypto/aspeed/aspeed-acry.c index 164c524015f0..f2429e699d14 100644 --- a/drivers/crypto/aspeed/aspeed-acry.c +++ b/drivers/crypto/aspeed/aspeed-acry.c @@ -252,7 +252,7 @@ static int aspeed_acry_rsa_ctx_copy(struct aspeed_acry_dev *acry_dev, void *buf, enum aspeed_rsa_key_mode mode) { const u8 *src = xbuf; - u32 *dw_buf = (u32 *)buf; + __le32 *dw_buf = (__le32 *)buf; int nbits, ndw; int i, j, idx; u32 data = 0; @@ -302,7 +302,7 @@ static int aspeed_acry_rsa_ctx_copy(struct aspeed_acry_dev *acry_dev, void *buf, static int aspeed_acry_rsa_transfer(struct aspeed_acry_dev *acry_dev) { struct akcipher_request *req = acry_dev->req; - u8 *sram_buffer = (u8 *)acry_dev->acry_sram; + u8 __iomem *sram_buffer = (u8 __iomem *)acry_dev->acry_sram; struct scatterlist *out_sg = req->dst; static u8 dram_buffer[ASPEED_ACRY_SRAM_MAX_LEN]; int leading_zero = 1; @@ -321,11 +321,11 @@ static int aspeed_acry_rsa_transfer(struct aspeed_acry_dev *acry_dev) for (j = ASPEED_ACRY_SRAM_MAX_LEN - 1; j >= 0; j--) { data_idx = acry_dev->data_byte_mapping[j]; - if (sram_buffer[data_idx] == 0 && leading_zero) { + if (readb(sram_buffer + data_idx) == 0 && leading_zero) { result_nbytes--; } else { leading_zero = 0; - dram_buffer[i] = sram_buffer[data_idx]; + dram_buffer[i] = readb(sram_buffer + data_idx); i++; } }