From patchwork Fri Feb 3 01:04:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ira Weiny X-Patchwork-Id: 13126878 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D08CC63797 for ; Fri, 3 Feb 2023 01:05:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232905AbjBCBFb (ORCPT ); Thu, 2 Feb 2023 20:05:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232866AbjBCBFa (ORCPT ); Thu, 2 Feb 2023 20:05:30 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55BFF470AE for ; Thu, 2 Feb 2023 17:05:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675386329; x=1706922329; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=qB93D8gcQzE8bWgRKNIX9AGpk9Y6HJXYcaDXaCc5Lzg=; b=AIo0EVK2m/1Gkcx2Zi7hVJqNgk8fYlbTN3Iy/ACceHi1UCAiZgenkUUy plFJ8UTj2DMTq4kN/FehdYqeQpBE51Cw73nHCe7cB1hgnZf1P685LRWXZ V84P6rYbKUHlIUqGmqAEV+Wtcxn3izOPZsaS+WOmQA5Ho2rAZQ2UzoeyE jFEcunaZ7AEOAX+F7PXmNGe/Jr4BYCxQ0+xieNxPd9ETwahmgZK/hUSQF Mme6ZTR6ojdYHZQFrcZOPh8SjNWHGyvyQDPiYrf11auECkr+RM6izsF/5 UFbnbv/lEPuelt16JQllXLxm8HtnPtflktKdOkdMaTwPuN2+EDPwkeZf4 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="393215317" X-IronPort-AV: E=Sophos;i="5.97,269,1669104000"; d="scan'208";a="393215317" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2023 17:04:37 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="839412544" X-IronPort-AV: E=Sophos;i="5.97,269,1669104000"; d="scan'208";a="839412544" Received: from iweiny-desk3.amr.corp.intel.com (HELO localhost) ([10.212.229.82]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2023 17:04:37 -0800 From: Ira Weiny Date: Thu, 02 Feb 2023 17:04:24 -0800 Subject: [PATCH v4 1/4] cxl/mem: Remove unused CXL_CMD_FLAG_NONE define MIME-Version: 1.0 Message-Id: <20221222-cxl-misc-v4-1-62f701c1cdd1@intel.com> References: <20221222-cxl-misc-v4-0-62f701c1cdd1@intel.com> In-Reply-To: <20221222-cxl-misc-v4-0-62f701c1cdd1@intel.com> To: Dan Williams Cc: "Jiang, Dave" , Alison Schofield , Vishal Verma , Ben Widawsky , Robert Richter , Jonathan Cameron , linux-cxl@vger.kernel.org, Ira Weiny , Jonathan Cameron X-Mailer: b4 0.11.0-dev-e429b X-Developer-Signature: v=1; a=ed25519-sha256; t=1675386275; l=641; i=ira.weiny@intel.com; s=20221222; h=from:subject:message-id; bh=qB93D8gcQzE8bWgRKNIX9AGpk9Y6HJXYcaDXaCc5Lzg=; b=NLscQIUsOFf1KqCP9u174u4OsarPf5ioNrqCLlMivQpSZ/9xVr7zSgxhUGdnf5LOqSQeaUHKXrnq BxXnzwpqDq5vi83Kdd1GyJ6CR9IRMYzWKaHu053aACYE64Abldi4 X-Developer-Key: i=ira.weiny@intel.com; a=ed25519; pk=brwqReAJklzu/xZ9FpSsMPSQ/qkSalbg6scP3w809Ec= Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org CXL_CMD_FLAG_NONE is not used, remove it. Reviewed-by: Jonathan Cameron Reviewed-by: Dave Jiang Signed-off-by: Ira Weiny --- drivers/cxl/cxlmem.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h index ab138004f644..2d85776236dd 100644 --- a/drivers/cxl/cxlmem.h +++ b/drivers/cxl/cxlmem.h @@ -393,7 +393,6 @@ struct cxl_mem_command { struct cxl_command_info info; enum cxl_opcode opcode; u32 flags; -#define CXL_CMD_FLAG_NONE 0 #define CXL_CMD_FLAG_FORCE_ENABLE BIT(0) }; From patchwork Fri Feb 3 01:04:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ira Weiny X-Patchwork-Id: 13126877 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BCC4C636D4 for ; Fri, 3 Feb 2023 01:05:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230021AbjBCBFa (ORCPT ); Thu, 2 Feb 2023 20:05:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232409AbjBCBF3 (ORCPT ); Thu, 2 Feb 2023 20:05:29 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1216C54573 for ; Thu, 2 Feb 2023 17:05:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675386329; x=1706922329; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=R4XKfG9JMHsfbq65atGQCPp98ZqBkdqh//cpSQf3DTY=; b=es+CQvkbDnzListSqj2/3nB6cZEMFk9PwlnQ/f6wk9oU2kbk5PqfZd0s HpzB8f4pibmvkl6ajT77iB5jxEERLD0XgzcJMEr3s2mA7/tivejSAaC+O wOvkrJ5HETvpxjq20TqEYlr692i9TB0/7mmTVkNcP/By8pU2dMBDEh1BT 1JEUKV8rDHPsoiWQVrBGO4CO8Yhi+zC5P3e7wKS/rlHfm0+CS0/njx7OI aRPlf7X7Y7jcQGEP/6zeyrwwHmVGQncJt8JDW5PC+bK+Ln8R0YA2Oby6O VE1psew2HAfuMMgpj2ttpLNNn7VfUtKUJ9IplC6o5R2elidOopJ4+cnnq g==; X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="393215324" X-IronPort-AV: E=Sophos;i="5.97,269,1669104000"; d="scan'208";a="393215324" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2023 17:04:38 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="839412549" X-IronPort-AV: E=Sophos;i="5.97,269,1669104000"; d="scan'208";a="839412549" Received: from iweiny-desk3.amr.corp.intel.com (HELO localhost) ([10.212.229.82]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2023 17:04:37 -0800 From: Ira Weiny Date: Thu, 02 Feb 2023 17:04:25 -0800 Subject: [PATCH v4 2/4] cxl/uapi: Add warning on CXL command enum MIME-Version: 1.0 Message-Id: <20221222-cxl-misc-v4-2-62f701c1cdd1@intel.com> References: <20221222-cxl-misc-v4-0-62f701c1cdd1@intel.com> In-Reply-To: <20221222-cxl-misc-v4-0-62f701c1cdd1@intel.com> To: Dan Williams Cc: "Jiang, Dave" , Alison Schofield , Vishal Verma , Ben Widawsky , Robert Richter , Jonathan Cameron , linux-cxl@vger.kernel.org, Ira Weiny , Jonathan Cameron X-Mailer: b4 0.11.0-dev-e429b X-Developer-Signature: v=1; a=ed25519-sha256; t=1675386275; l=1198; i=ira.weiny@intel.com; s=20221222; h=from:subject:message-id; bh=R4XKfG9JMHsfbq65atGQCPp98ZqBkdqh//cpSQf3DTY=; b=Dio+sSBtQhPz45HxQHbI9y33WppAFDXybPuPB8Qxp/JO1En/ixHIms4wwJxnAa8fRl/roGQA+9Ya H6PFlDsBAyZjkRMaAhJIuN8lCIKsS1zQCDEYHPpcZQGbDSPcy53R X-Developer-Key: i=ira.weiny@intel.com; a=ed25519; pk=brwqReAJklzu/xZ9FpSsMPSQ/qkSalbg6scP3w809Ec= Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org The CXL command enum is exported to user space and must maintain backwards compatibility. Add comment that new defines must be added to the end of the list. Suggested-by: Dan Williams Reviewed-by: Jonathan Cameron Reviewed-by: Dave Jiang Signed-off-by: Ira Weiny --- include/uapi/linux/cxl_mem.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/uapi/linux/cxl_mem.h b/include/uapi/linux/cxl_mem.h index c71021a2a9ed..459a3f7f764b 100644 --- a/include/uapi/linux/cxl_mem.h +++ b/include/uapi/linux/cxl_mem.h @@ -19,6 +19,10 @@ #define CXL_MEM_QUERY_COMMANDS _IOR(0xCE, 1, struct cxl_mem_query_commands) #define CXL_MEM_SEND_COMMAND _IOWR(0xCE, 2, struct cxl_send_command) +/* + * NOTE: New defines must be added to the end of the list to preserve + * compatibility because this enum is exported to user space. + */ #define CXL_CMDS \ ___C(INVALID, "Invalid Command"), \ ___C(IDENTIFY, "Identify Command"), \ From patchwork Fri Feb 3 01:04:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ira Weiny X-Patchwork-Id: 13126879 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAD36C636D3 for ; Fri, 3 Feb 2023 01:05:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232866AbjBCBFc (ORCPT ); Thu, 2 Feb 2023 20:05:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232724AbjBCBFa (ORCPT ); Thu, 2 Feb 2023 20:05:30 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE337564BF for ; Thu, 2 Feb 2023 17:05:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675386329; x=1706922329; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=cAdCW2dnn9H6Ph5wxfVjzfIXzViYzjaE5/x4RpEKk2s=; b=WAL0N4i2S4U3U9zCuBuGbNmxVpPn8rjb2v6MvjKkNbcDy6lUIwy3Gn3+ PxtBoWhUWka1b5svvgY7OND3QMzPPi8NjihYayPm1yfVSn0Xz8Ndbzote qkYn0pdEPkgYGkzukY6Fnm2ZU0ZPsmq7AaArkZZN9AJHRc7xD3H96BySM vBUHqgNmY6QtIa5TnYkUbrKI3FkTvq2dGQB4m2MBxelwb2fQiG0H3LM7+ adDX5okwxlquvDmoh5SFrjAwtdKJbzAfLp4FsqZ174QbKdtz+ngLrmCQn 2Y6V2w1QrTOhB4yUSzt9AS3OnUlM6DZguNTFlE0ahDsz0cUGS3QK40VdA A==; X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="393215332" X-IronPort-AV: E=Sophos;i="5.97,269,1669104000"; d="scan'208";a="393215332" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2023 17:04:39 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="839412552" X-IronPort-AV: E=Sophos;i="5.97,269,1669104000"; d="scan'208";a="839412552" Received: from iweiny-desk3.amr.corp.intel.com (HELO localhost) ([10.212.229.82]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2023 17:04:38 -0800 From: Ira Weiny Date: Thu, 02 Feb 2023 17:04:26 -0800 Subject: [PATCH v4 3/4] cxl/uapi: Tag commands from cxl_query_cmd() MIME-Version: 1.0 Message-Id: <20221222-cxl-misc-v4-3-62f701c1cdd1@intel.com> References: <20221222-cxl-misc-v4-0-62f701c1cdd1@intel.com> In-Reply-To: <20221222-cxl-misc-v4-0-62f701c1cdd1@intel.com> To: Dan Williams Cc: "Jiang, Dave" , Alison Schofield , Vishal Verma , Ben Widawsky , Robert Richter , Jonathan Cameron , linux-cxl@vger.kernel.org, Ira Weiny , Jonathan Cameron X-Mailer: b4 0.11.0-dev-e429b X-Developer-Signature: v=1; a=ed25519-sha256; t=1675386275; l=3329; i=ira.weiny@intel.com; s=20221222; h=from:subject:message-id; bh=cAdCW2dnn9H6Ph5wxfVjzfIXzViYzjaE5/x4RpEKk2s=; b=vXX5i89dEhPSLlYhMnjaW2TqoEo0Ey7f8VUgy3u9x61H7rsib+ruLmQRVLD2G6AYbGqYJwqUWEUa KB1rR3HyDcts6RLdTcrI8piVMuRWhZDETSU5TsxNjcKlp9cHLvK5 X-Developer-Key: i=ira.weiny@intel.com; a=ed25519; pk=brwqReAJklzu/xZ9FpSsMPSQ/qkSalbg6scP3w809Ec= Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org It was pointed out that commands not supported by the device or excluded by the kernel were being returned in cxl_query_cmd().[1] While libcxl correctly handles failing commands, it is more efficient to not issue an invalid command in the first place. This can't be done without additional information being returned from cxl_query_cmd(). In addition, information about the availability of commands can be useful for debugging. Add flags to struct cxl_command_info which reflect if a command is enabled and/or exclusive to the kernel. [1] https://lore.kernel.org/all/63b4ec4e37cc1_5178e2941d@dwillia2-xfh.jf.intel.com.notmuch/ Suggested-by: Dan Williams Signed-off-by: Ira Weiny --- Changes for v4: Jonathan Add Documentation for the flags --- drivers/cxl/core/mbox.c | 9 +++++++-- include/uapi/linux/cxl_mem.h | 19 +++++++++++++++++-- 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index b03fba212799..6ab4613f3cf9 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -445,9 +445,14 @@ int cxl_query_cmd(struct cxl_memdev *cxlmd, * structures. */ cxl_for_each_cmd(cmd) { - const struct cxl_command_info *info = &cmd->info; + struct cxl_command_info info = cmd->info; - if (copy_to_user(&q->commands[j++], info, sizeof(*info))) + if (test_bit(info.id, cxlmd->cxlds->enabled_cmds)) + info.flags |= CXL_MEM_COMMAND_FLAG_ENABLED; + if (test_bit(info.id, cxlmd->cxlds->exclusive_cmds)) + info.flags |= CXL_MEM_COMMAND_FLAG_EXCLUSIVE; + + if (copy_to_user(&q->commands[j++], &info, sizeof(info))) return -EFAULT; if (j == n_commands) diff --git a/include/uapi/linux/cxl_mem.h b/include/uapi/linux/cxl_mem.h index 459a3f7f764b..9fe832afee37 100644 --- a/include/uapi/linux/cxl_mem.h +++ b/include/uapi/linux/cxl_mem.h @@ -72,6 +72,19 @@ static const struct { * struct cxl_command_info - Command information returned from a query. * @id: ID number for the command. * @flags: Flags that specify command behavior. + * + * CXL_MEM_COMMAND_FLAG_USER_ENABLED + * + * The given command id is supported by the driver and is supported by + * a related opcode on the device. + * + * CXL_MEM_COMMAND_FLAG_EXCLUSIVE + * + * Requests with the given command id will terminate with EBUSY as the + * kernel actively owns management of the given resource. For example, + * the label-storage-area can not be written while the kernel is + * actively managing that space. + * * @size_in: Expected input size, or ~0 if variable length. * @size_out: Expected output size, or ~0 if variable length. * @@ -81,7 +94,7 @@ static const struct { * bytes of output. * * - @id = 10 - * - @flags = 0 + * - @flags = CXL_MEM_COMMAND_FLAG_ENABLED * - @size_in = ~0 * - @size_out = 0 * @@ -91,7 +104,9 @@ struct cxl_command_info { __u32 id; __u32 flags; -#define CXL_MEM_COMMAND_FLAG_MASK GENMASK(0, 0) +#define CXL_MEM_COMMAND_FLAG_MASK GENMASK(1, 0) +#define CXL_MEM_COMMAND_FLAG_ENABLED BIT(0) +#define CXL_MEM_COMMAND_FLAG_EXCLUSIVE BIT(1) __u32 size_in; __u32 size_out; From patchwork Fri Feb 3 01:04:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ira Weiny X-Patchwork-Id: 13126880 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56675C6379F for ; Fri, 3 Feb 2023 01:05:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232196AbjBCBFc (ORCPT ); Thu, 2 Feb 2023 20:05:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232409AbjBCBFb (ORCPT ); Thu, 2 Feb 2023 20:05:31 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9052754573 for ; Thu, 2 Feb 2023 17:05:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675386330; x=1706922330; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=NDzI6WbNEgD6Cpe2U35qUyQ0qr523OSvCxvoyB+CSA8=; b=C2mv24Ns3nFznVLYJ6K+N7ZKevXSiwociAf27fr2LhsLTZa9KU6CwajG nV1DqkqtqPf+eEH3pMYnUDi6W1x4u23Nr1dIGqo1Vh8DyT/LtLtHcQNCg Qk2PX0YztoOGtuVIfsFmTBO9SUS8nVv+ddMwzU6cxNzduYYSGDbD1YrzM XELK5+BWaRspduSWQ5sYO552irYLCbTBJnHSmgmza6lRJP2JgElRtA9+V 1zG6ZBUnsT/BYman2cXVZCbHGg4VzDjP9t/hgmy4RZCw9LY7MSPcUJM7g L2eS+dREC57WSBbBJFU8/4yV2CDPoDdChqs4aigXsgBlS6Qmtdf3YoP/f A==; X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="393215340" X-IronPort-AV: E=Sophos;i="5.97,269,1669104000"; d="scan'208";a="393215340" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2023 17:04:40 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="839412557" X-IronPort-AV: E=Sophos;i="5.97,269,1669104000"; d="scan'208";a="839412557" Received: from iweiny-desk3.amr.corp.intel.com (HELO localhost) ([10.212.229.82]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2023 17:04:39 -0800 From: Ira Weiny Date: Thu, 02 Feb 2023 17:04:27 -0800 Subject: [PATCH v4 4/4] cxl/mem: Fix UAPI command comment MIME-Version: 1.0 Message-Id: <20221222-cxl-misc-v4-4-62f701c1cdd1@intel.com> References: <20221222-cxl-misc-v4-0-62f701c1cdd1@intel.com> In-Reply-To: <20221222-cxl-misc-v4-0-62f701c1cdd1@intel.com> To: Dan Williams Cc: "Jiang, Dave" , Alison Schofield , Vishal Verma , Ben Widawsky , Robert Richter , Jonathan Cameron , linux-cxl@vger.kernel.org, Ira Weiny , Jonathan Cameron X-Mailer: b4 0.11.0-dev-e429b X-Developer-Signature: v=1; a=ed25519-sha256; t=1675386275; l=1411; i=ira.weiny@intel.com; s=20221222; h=from:subject:message-id; bh=NDzI6WbNEgD6Cpe2U35qUyQ0qr523OSvCxvoyB+CSA8=; b=2hGscOWMEPp7Lvl8qIz9IAX0UX7k3kCD9dvmXO7KiWMGZAUEs5dear1QOwORPSgUIWRLiCobpTrF uJUtvO1+B/qU5WSR8Tu5UPbCKl1vS/qtROa7rcNrPdhAus+gTm5u X-Developer-Key: i=ira.weiny@intel.com; a=ed25519; pk=brwqReAJklzu/xZ9FpSsMPSQ/qkSalbg6scP3w809Ec= Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org The command comment had grammatical errors. In an attempt to fix those it was noted that the comment and the query command were not in sync. Now that the query command returns excluded and device unsupported command information. Update the kdoc and fix the grammatical errors. [1] https://lore.kernel.org/all/63b4ec4e37cc1_5178e2941d@dwillia2-xfh.jf.intel.com.notmuch/ Reviewed-by: Jonathan Cameron Signed-off-by: Ira Weiny --- include/uapi/linux/cxl_mem.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/include/uapi/linux/cxl_mem.h b/include/uapi/linux/cxl_mem.h index 9fe832afee37..86bbacf2a315 100644 --- a/include/uapi/linux/cxl_mem.h +++ b/include/uapi/linux/cxl_mem.h @@ -11,9 +11,10 @@ /** * DOC: UAPI * - * Not all of all commands that the driver supports are always available for use - * by userspace. Userspace must check the results from the QUERY command in - * order to determine the live set of commands. + * Not all of the commands that the driver supports are available for use by + * userspace at all times. Userspace can check the result of the QUERY command + * to determine the live set of commands. Alternatively, it can issue the + * command and check for failure. */ #define CXL_MEM_QUERY_COMMANDS _IOR(0xCE, 1, struct cxl_mem_query_commands)