From patchwork Mon Feb 6 23:43:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 13130782 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 172B7C05027 for ; Mon, 6 Feb 2023 23:43:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229646AbjBFXnt (ORCPT ); Mon, 6 Feb 2023 18:43:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbjBFXns (ORCPT ); Mon, 6 Feb 2023 18:43:48 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1292E93EC; Mon, 6 Feb 2023 15:43:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=7LhKrP+OMnczNpnIjHIKtPU0AEjCEtO5qg7hH6vxr+s=; b=1z526e5murJWIxQeGB/3s3xANE Z3s2q2JmA4TfkjPbb4b8CK0K2MellrJqP4TJqqoUbd/Ctv+IroFwBFakqjwDXO+dFkvTU6LRIvAtK BlsS5Ce+u0MvtE9DiY5ad98uqefmBhoOuKNMUX+o2hlwwCSAIkJsXrwdjQW4u8orw4FxS27kaO/fY xQakzMql2j8TCi0wRHi7rJpLVqFdwq1uH5Ny70o5zDm1V5j2SnbiwObPoIgOAXkw7ZJmgVXxVPLkY kCg9bgL7O+nEEE7oaXqJ3gPae0bo/0p3Lm021bCZqz20wUjgNlvOCS9+CnEtN+x8jBZ7HihdInBWB SFup6RIw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPB9F-00ADBV-SJ; Mon, 06 Feb 2023 23:43:45 +0000 From: Luis Chamberlain To: shuah@kernel.org, linux-kselftest@vger.kernel.org Cc: gregkh@linuxfoundation.org, tiwai@suse.de, tianfei.zhang@intel.com, russell.h.weight@intel.com, keescook@chromium.org, tweek@google.com, a.manzanares@samsung.com, dave@stgolabs.net, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain Subject: [PATCH 1/2] selftests/kmod: increase the kmod timeout from 45 to 165 Date: Mon, 6 Feb 2023 15:43:43 -0800 Message-Id: <20230206234344.2433950-2-mcgrof@kernel.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230206234344.2433950-1-mcgrof@kernel.org> References: <20230206234344.2433950-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org The default sefltests timeout is 45 seconds. If you run the kmod selftests on your own with say: ./tools/testings/selftests/kmod.sh Then the default timeout won't be in effect. I've never ran kmod selftests using the generic make wrapper (./tools/testing/selftests/run_kselftest.sh -s) util now that I have support for it on kdevops [0]. And with that the test is limitted to the default timeout which we quickly run into. Bump this up to what I see is required on 8GiB / 8 vcpu libvirt q35 guest as can be easily created now with kdevops. To run selftests with kdevops: make menuconfig # enable dedicated selftests and kmod test make make bringup make linux make selftests-kmod This ends up taking about 280 seconds now, give or take add 50 seconds more more and we end up with 350. Document the rationale. [0] https://github.com/linux-kdevops/kdevops Signed-off-by: Luis Chamberlain --- tools/testing/selftests/kmod/settings | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 tools/testing/selftests/kmod/settings diff --git a/tools/testing/selftests/kmod/settings b/tools/testing/selftests/kmod/settings new file mode 100644 index 000000000000..6fca0f1a4594 --- /dev/null +++ b/tools/testing/selftests/kmod/settings @@ -0,0 +1,4 @@ +# measured from a manual run: +# time ./tools/testing/selftests/kmod/kmod.sh +# Then add ~50 seconds more gracetime. +timeout=350 From patchwork Mon Feb 6 23:43:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 13130784 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0F80C636D3 for ; Mon, 6 Feb 2023 23:43:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229954AbjBFXnu (ORCPT ); Mon, 6 Feb 2023 18:43:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbjBFXnt (ORCPT ); Mon, 6 Feb 2023 18:43:49 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1332B20D39; Mon, 6 Feb 2023 15:43:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=Cbgf/3ExiLkHeTDiZkg2YzpW1KimliBdCulTSMGSMg0=; b=C6wiMemruzk9Tl7wyo+11Q6EXQ oQVGA/1/oLDLf+j4d3Kho6plTzXnY5XAGp2QbDRGXybpiSfifMXylUGWX+UhDIL6d0PhIqCJ1bS3h ovoJDhqw6y3xWVso4DJMI+nHMGlT7GX98uEwCwo2kUZwtCNxNsJ1eTc6X5jjxW9YLvrrOtkoc8FmP BK3e3lxjNP3kxa18wnVYcEPdK4TJPbmFHBlc7nb5Khe1uB66jQrzy4cKvTfNCXCrwUN114GmHOpO4 v0KwU37J3nHbYaxGjwlbvhQsP7pqjJXAGc4yuOZ348RxCKH0BzHD2p178lY5ELoq43uwrtk94+V0v /aIH8UEQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPB9F-00ADBX-Te; Mon, 06 Feb 2023 23:43:45 +0000 From: Luis Chamberlain To: shuah@kernel.org, linux-kselftest@vger.kernel.org Cc: gregkh@linuxfoundation.org, tiwai@suse.de, tianfei.zhang@intel.com, russell.h.weight@intel.com, keescook@chromium.org, tweek@google.com, a.manzanares@samsung.com, dave@stgolabs.net, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain Subject: [PATCH 2/2] selftests/firmware: increase timeout from 165 to 230 Date: Mon, 6 Feb 2023 15:43:44 -0800 Message-Id: <20230206234344.2433950-3-mcgrof@kernel.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230206234344.2433950-1-mcgrof@kernel.org> References: <20230206234344.2433950-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Bump the timeout up to what we can empirally need on a q35 8MiB system / 8 vcpus as supported easily now with kdevops [0]. To test firmware_loader with kdevops: make menuconfig # enable dedicated selftests and firmware test make make bringup make linux make selftests-firmware In practice this test now takes about 170 seconds so let's give it a bit more breathing room we end up with 230. Note: I'm seeing a failure only on Android setups running this test in a loop, we eventually OOM on linux-next tag next-20230119. [0] https://github.com/linux-kdevops/kdevops Signed-off-by: Luis Chamberlain --- tools/testing/selftests/firmware/settings | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/firmware/settings b/tools/testing/selftests/firmware/settings index 085e664ee093..75773074af35 100644 --- a/tools/testing/selftests/firmware/settings +++ b/tools/testing/selftests/firmware/settings @@ -5,4 +5,10 @@ # Additionally, fw_fallback may take 5 seconds for internal timeouts in each # of the 3 configs, so at least another 15 seconds are needed. Add another # 10 seconds for each testing config: 120 + 15 + 30 -timeout=165 +# +# That's 165.. but we also now have some other batched tests, we get the +# current timeout value by running manually withtout the timeout: +# +# time ./tools/testing/selftests/firmware/fw_run_tests.sh +# then add give or take about 50 seconds. +timeout=230