From patchwork Tue Feb 7 20:58:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13132113 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17D5AC64EC5 for ; Tue, 7 Feb 2023 20:58:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229765AbjBGU6t (ORCPT ); Tue, 7 Feb 2023 15:58:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229698AbjBGU6q (ORCPT ); Tue, 7 Feb 2023 15:58:46 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDAD213D6E for ; Tue, 7 Feb 2023 12:58:42 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id bg5-20020a05600c3c8500b003e00c739ce4so8397wmb.5 for ; Tue, 07 Feb 2023 12:58:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PoMfks5Pi2TAoCgRVsoQ1C6g7O43cRdI/G6Mr7ISRn4=; b=rqB6aQWQXXK0ao4JHOkfgdGuPUpCbCE2deHTaQQffNIrwCaCjse2g8b0W9RZzk5DYF 4OPSf2Ny5DW3A5rqDgqk2VfPJSlS8NQ5iOs/s/md60pjpOqm3Wv5lGN+opgQAz055zbZ dEsY6iu27kXRwanAzT7WfUT1kp0AhEvXZB/9T7QR72HhHO0odF9VHXV3jWTr2Ydo98zf thLTDWrNHOWPciBFNe1eMzLrJ0NPqw7s1s08/STrDABCE/qdy79Vf0DdSl2pXVMpsjSh H8s8X8tfvknB180sxMePHNAkDigo0kbZ9Y3yFpxIgf2wGE/dSaNN4wC0cmVHbnViguta hcOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PoMfks5Pi2TAoCgRVsoQ1C6g7O43cRdI/G6Mr7ISRn4=; b=zLwZGSXq+exm7i2cMA8x6RBkKK5Bnj5i7QZI31AqzKHRU5Jl9Ias9/pPDhMOJHARtq Uu64xbhPhohdWoR74FO+RAMTDdgZ43sT60t/VaLKBeuHPAhoBFU4T2zmcO4XpRqew8K6 U6eQRkqY4RS2om7X/vHutO05d1b3w+wDdW+vyP6TCq2mgB6oOtt7fPibenaMbv5p2PTD pioiaEO+NWYktlU1gnX5qbDcd1675L513Dcr/RwNciRN6zzWxSaN2EbDJ30rJWlidSUY aFGoVRW2mafHF/WjhJGLMYbgSmPJGgU0UZOklFsfFqyoTeNHoMVzzc0htmhJLR/v7QZ+ MFzw== X-Gm-Message-State: AO0yUKUG08ZrIZbgiAP3l/vxiEfFxMtU1dv51GBEf8XkCjFSbVYJuEMG mzARBcDPHMijeRgxzuw0OLQQbw== X-Google-Smtp-Source: AK7set8Q72ioTFcT19F9jM5+EYeJZLiNJr2rD2fLqftya65j/IfRY0HWMv1i/xlLir0XRTm0WZEADg== X-Received: by 2002:a05:600c:3d0e:b0:3df:efdd:9dc7 with SMTP id bh14-20020a05600c3d0e00b003dfefdd9dc7mr281774wmb.10.1675803521352; Tue, 07 Feb 2023 12:58:41 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h27-20020a05600c2cbb00b003db12112fcfsm16555649wmc.4.2023.02.07.12.58.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 12:58:41 -0800 (PST) From: Krzysztof Kozlowski To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 1/4] media: dt-bindings: samsung-fimc: drop simple-bus Date: Tue, 7 Feb 2023 21:58:31 +0100 Message-Id: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The FIMC camera node wrapper is not a bus, so using simple-bus fallback compatible just to instantiate its children nodes was never correct. Drop the simple-bus compatible and expect driver to explicitly populate children devices. Signed-off-by: Krzysztof Kozlowski Acked-by: Rob Herring --- Changes since v1: 1. None --- Documentation/devicetree/bindings/media/samsung-fimc.txt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/media/samsung-fimc.txt b/Documentation/devicetree/bindings/media/samsung-fimc.txt index 20447529c985..f90267f1180e 100644 --- a/Documentation/devicetree/bindings/media/samsung-fimc.txt +++ b/Documentation/devicetree/bindings/media/samsung-fimc.txt @@ -15,7 +15,7 @@ Common 'camera' node Required properties: -- compatible: must be "samsung,fimc", "simple-bus" +- compatible: must be "samsung,fimc" - clocks: list of clock specifiers, corresponding to entries in the clock-names property; - clock-names : must contain "sclk_cam0", "sclk_cam1", "pxl_async0", @@ -156,8 +156,8 @@ Example: }; }; - camera { - compatible = "samsung,fimc", "simple-bus"; + camera@11800000 { + compatible = "samsung,fimc"; clocks = <&clock 132>, <&clock 133>, <&clock 351>, <&clock 352>; clock-names = "sclk_cam0", "sclk_cam1", "pxl_async0", @@ -166,6 +166,7 @@ Example: clock-output-names = "cam_a_clkout", "cam_b_clkout"; pinctrl-names = "default"; pinctrl-0 = <&cam_port_a_clk_active>; + ranges; #address-cells = <1>; #size-cells = <1>; From patchwork Tue Feb 7 20:58:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13132112 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98B3CC636CC for ; Tue, 7 Feb 2023 20:58:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229775AbjBGU6s (ORCPT ); Tue, 7 Feb 2023 15:58:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229623AbjBGU6q (ORCPT ); Tue, 7 Feb 2023 15:58:46 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B188413DF5 for ; Tue, 7 Feb 2023 12:58:44 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id n13so11932829wmr.4 for ; Tue, 07 Feb 2023 12:58:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ig92pyMbU2zuSYAVil0uen1pAtlV0COrB7Gvugo1C0s=; b=MUpe8RWh84Giqhg4fNSII6pvgNJL95YzWbpB90rqFpF18Il8U42VPn4Dx5x0kgyUPc wRAuaVnM2hQol1S6jcQOVtJK39CV0S+mXCutMqL1BctyduPwifErwRNpngNmU0PnXziD jH4Z1+fruERiY/Cj4x7wVUJH2+rFCF7ITCyRmB0ZuZSNlaHzd6Hp82O5tZ/O7Ck9/7Ax rY+f96I3tng5z1waAUgjaqY4HzR/VJTqp0vubPfIkko6chBuPqF0RCnmqepdvazBC9u6 DHD5IoQ9i9sSTMZ4wrLQIxLBGMdVOKQt1UWMv5/av8D7LR+QZS4ApqUy4oxsZKGQdGiU u78w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ig92pyMbU2zuSYAVil0uen1pAtlV0COrB7Gvugo1C0s=; b=msTrlihprEeU1OlV7tkul/8tvGMZ5kc2ptaaX8diHXBeOQ2RqaEhMJHxalS8Bu7ElE vVxQKWpjCcgZRnZfs6vex74RNlCOzp2/r22x8oyPAY83pTVFXTG+KwOxYgzht/LOkhF4 WxwvQLPdqLXbsUAhuc+kuZW+uowZiEVLFh/Pc9ux7YGCRZWDIrtVWD8E0sCZAiA5wy4Z q4Ix7QAVtBfq1KFpXpaD3MYub4ZPvsSe8VxT3FsANhdRBzxkTEArChiDDxH8UP2I+TGg BvXQnVqb0nx3PCZrTsWBOIrM1hZIF2QoVZouF99u/AicC22whNozV7cBp3AkfAK8nC17 qQ7g== X-Gm-Message-State: AO0yUKX4KdgSznOjZF9ZpIVn5tsGQF4F70Lh7pBqLhqwGyeJ1d7NzuFp uvhFpQGpgAvNLSVHeEJxZ/Mi1FhmUCHPOHWa X-Google-Smtp-Source: AK7set+IQt2wJhcPIudLzOOHNQqXw0jcwOEm0J8mi1ZdCP0P500dXLXECHPj3fQHqtj7LnfzKFlh5Q== X-Received: by 2002:a05:600c:1708:b0:3de:e8c5:d826 with SMTP id c8-20020a05600c170800b003dee8c5d826mr4444405wmn.28.1675803523206; Tue, 07 Feb 2023 12:58:43 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h27-20020a05600c2cbb00b003db12112fcfsm16555649wmc.4.2023.02.07.12.58.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 12:58:42 -0800 (PST) From: Krzysztof Kozlowski To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 2/4] media: samsung: exynos4-is: drop unused pinctrl bits Date: Tue, 7 Feb 2023 21:58:32 +0100 Message-Id: <20230207205834.673163-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> References: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Drop unused pinctrl header and pctrl member of struct fimc_is. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. New patch --- drivers/media/platform/samsung/exynos4-is/fimc-is.h | 3 --- drivers/media/platform/samsung/exynos4-is/media-dev.h | 1 - 2 files changed, 4 deletions(-) diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-is.h b/drivers/media/platform/samsung/exynos4-is/fimc-is.h index 06586e455b1d..c126b779aafc 100644 --- a/drivers/media/platform/samsung/exynos4-is/fimc-is.h +++ b/drivers/media/platform/samsung/exynos4-is/fimc-is.h @@ -14,7 +14,6 @@ #include #include #include -#include #include #include #include @@ -231,7 +230,6 @@ struct chain_config { /** * struct fimc_is - fimc-is data structure * @pdev: pointer to FIMC-IS platform device - * @pctrl: pointer to pinctrl structure for this device * @v4l2_dev: pointer to the top level v4l2_device * @fw: data structure describing the FIMC-IS firmware binary * @memory: memory region assigned for the FIMC-IS (firmware) @@ -262,7 +260,6 @@ struct chain_config { */ struct fimc_is { struct platform_device *pdev; - struct pinctrl *pctrl; struct v4l2_device *v4l2_dev; struct fimc_is_firmware fw; diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.h b/drivers/media/platform/samsung/exynos4-is/media-dev.h index 62ad5d7e035a..079105d88bab 100644 --- a/drivers/media/platform/samsung/exynos4-is/media-dev.h +++ b/drivers/media/platform/samsung/exynos4-is/media-dev.h @@ -11,7 +11,6 @@ #include #include #include -#include #include #include #include From patchwork Tue Feb 7 20:58:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13132114 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABA22C636CC for ; Tue, 7 Feb 2023 20:58:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229830AbjBGU6u (ORCPT ); Tue, 7 Feb 2023 15:58:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbjBGU6r (ORCPT ); Tue, 7 Feb 2023 15:58:47 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36CE61E9F3 for ; Tue, 7 Feb 2023 12:58:46 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id bg13-20020a05600c3c8d00b003d9712b29d2so15606wmb.2 for ; Tue, 07 Feb 2023 12:58:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dRrfTafHWOPP66W8TWUXdxmmbu6jMm7VMDj6nUG7ys4=; b=DqtTAyD+/DfVIXIixTTLeibbPWfARnoKPtZ503G/plOAdpSOZov9AsNRpB3pUQJUCv 5FCNQSbkC0AV7x/c4JKBbGIsoJuPYgqyzs2xF/miMtoLpyWrGtikd+RQT0vvCwpOV1c/ LVTXvBnhyoXTiKlSEA51+3WcZhlTyji8x5IDX0Mn2tghG16exPAaIpGzWridsqZMAxkx VxKKiazE0E9AuPVSkwv+0S9b9bro79BmeeJuIJsR8uaXenubEjuo5LA+Zoz2D1YzSnPv MGCiAbPamcfmHPYxaGJLC6H7KwYpZsFvUAOhnYsAIRJaKV7/5/MSyTniqrwxKqarbPsk QrEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dRrfTafHWOPP66W8TWUXdxmmbu6jMm7VMDj6nUG7ys4=; b=IL79+utv85bRFEWU/p9u4bqK9/UuMoBSboHIqNZEdYpM7JR4sBBci3Rwx5XUBlZmKG GgmvyxmnoMQu+iiWNedUiyWCI9GAbCyFVwEtfbpl+22Ih2fMmO+Skwv235baplPWs8+b eACHwP+BUstDKA6kIo0bdVLFjCQVNhz0tnGwMVBjzisPALELaG2+yK84bjCyRJi8Rar9 LOJ668BzPBekzdGwOBGGSahLaSNC+VW3V+1O8zTqfvClX1p98P617cgcQR0fZ3yXPLoy 98UbVpmAj+/nEbISny4oZr1LhaOVMNfl0gQTPBq3LyPCaqeDF0T5FisO1VTbdzqhnY7Q OJrQ== X-Gm-Message-State: AO0yUKWgGx/xSThxRXaKI3FveKmmmMM1dpOSNdGi3Rc/w8kNO4+sGUVL 2F9OBeLiip0NnT2Wd4YRJwE6mw== X-Google-Smtp-Source: AK7set8unV2JpGoXq+wRRje/TXgj4zlNonWi0Sr7sORRaCG8wxSrplHwWE6VetjIA5RfaZHnpx1ibg== X-Received: by 2002:a05:600c:4383:b0:3dc:57e8:1d1c with SMTP id e3-20020a05600c438300b003dc57e81d1cmr5511078wmn.9.1675803524727; Tue, 07 Feb 2023 12:58:44 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h27-20020a05600c2cbb00b003db12112fcfsm16555649wmc.4.2023.02.07.12.58.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 12:58:44 -0800 (PST) From: Krzysztof Kozlowski To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 3/4] media: samsung: exynos4-is: do not require pinctrl Date: Tue, 7 Feb 2023 21:58:33 +0100 Message-Id: <20230207205834.673163-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> References: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Driver does not handle pin configuration switching and several DTS provide empty pinctrl property, just to satisfy the driver's requirement for it. Drop requirement for pinctrl property as it is really optional. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. New patch --- drivers/media/platform/samsung/exynos4-is/media-dev.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.c b/drivers/media/platform/samsung/exynos4-is/media-dev.c index 98a60f01129d..22baa429ed5d 100644 --- a/drivers/media/platform/samsung/exynos4-is/media-dev.c +++ b/drivers/media/platform/samsung/exynos4-is/media-dev.c @@ -1470,10 +1470,8 @@ static int fimc_md_probe(struct platform_device *pdev) goto err_v4l2dev; pinctrl = devm_pinctrl_get(dev); - if (IS_ERR(pinctrl)) { - ret = dev_err_probe(dev, PTR_ERR(pinctrl), "Failed to get pinctrl\n"); - goto err_clk; - } + if (IS_ERR(pinctrl)) + dev_dbg(dev, "Failed to get pinctrl: %pe\n", pinctrl); platform_set_drvdata(pdev, fmd); From patchwork Tue Feb 7 20:58:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13132115 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB5AEC64EC4 for ; Tue, 7 Feb 2023 20:58:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229827AbjBGU6w (ORCPT ); Tue, 7 Feb 2023 15:58:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229781AbjBGU6t (ORCPT ); Tue, 7 Feb 2023 15:58:49 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C54413DF5 for ; Tue, 7 Feb 2023 12:58:48 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id z13so4466949wmp.2 for ; Tue, 07 Feb 2023 12:58:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZVDEkwpSNBnNA5bvC0eSecX/xh6oUxrJTLdGIKP8nY4=; b=uH2KAUVklw9v43h9yxNBufniyLS6TjEIIWPQXE6iftGk2v0fGkbNJAd8CeWQXDyGTO 3+jQagCE3g33wzfpDvz1FKzLwayfNTWXZNUcGSwHDCQsY+10LxPptS0u9tN4OmmlfFp4 htkSYBlpb35kapv9Bddhu7pUZi6razflGKlvnFtGXW45pT/knPZScLm0kaj7vZDkGSMR ZfG4xCoTvpdrG+4szCkJASSht4esYG0MqkaPVSJzHa0os1OC2MJRRiftDXTcvRO00kTg AY4PXW31vld/2p1G2SfdyAP7/xPUMTFv2mefqhx+SpSVz9eHHvVpvL2nyB0DjMCGYV6L +PKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZVDEkwpSNBnNA5bvC0eSecX/xh6oUxrJTLdGIKP8nY4=; b=4cRcaLwTpsuaXL1li/nyoEHVLvecTLJ5yeD6EdO4+b5h0VwJvFR2PC/MaAyP5kUMAJ R+i6zVgrJ/j2bnDqpoWBhbcC7IUzne2cAMwPGyIsjCjPkgkstCVL8vSUV/XV0y2GhIDu BxwWF1t66BAPNdelIvJgW40jYZl0vZfLvjICfONgq6G7l3U3VaG2CnPbhpojEB7GzD5J FOiKdKPlizw5m8xsjJabmOS97KA1l5//ToKUD3SPPiUehbbbnIp5b6hiC/0HC3eF+tiR JM0CUIqIH3KebHosM17DHvOAsZctkavYS2zqmt2HK1GYYf9GSdgTFFCtkZTYauViTVw1 dLMg== X-Gm-Message-State: AO0yUKWS8jZrVcwzPrIVD50rK2OllKd8B3uOYRXwftWHLMxxrc3auPmL 4KVsCVvYzLw02h1B0418b5gDRQ== X-Google-Smtp-Source: AK7set9g0Q4PXzjyBw/7a9A5YeoIjf44d801s6Qofr8X7o0oi+hxj5dbCa8KvDcVQ6d9cBKnOlSLiQ== X-Received: by 2002:a05:600c:1688:b0:3dc:4042:5c21 with SMTP id k8-20020a05600c168800b003dc40425c21mr4443353wmn.6.1675803527622; Tue, 07 Feb 2023 12:58:47 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h27-20020a05600c2cbb00b003db12112fcfsm16555649wmc.4.2023.02.07.12.58.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 12:58:47 -0800 (PST) From: Krzysztof Kozlowski To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 4/4] media: samsung: exynos4-is: drop simple-bus from compatibles Date: Tue, 7 Feb 2023 21:58:34 +0100 Message-Id: <20230207205834.673163-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> References: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The FIMC camera node wrapper is not a bus, so using simple-bus fallback compatible just to instantiate its children nodes was never correct. Driver should explicitly populate all its children devices. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Do not depopulate on errors because it causes several errors. --- drivers/media/platform/samsung/exynos4-is/media-dev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.c b/drivers/media/platform/samsung/exynos4-is/media-dev.c index 22baa429ed5d..6839007edf1d 100644 --- a/drivers/media/platform/samsung/exynos4-is/media-dev.c +++ b/drivers/media/platform/samsung/exynos4-is/media-dev.c @@ -1440,6 +1440,10 @@ static int fimc_md_probe(struct platform_device *pdev) if (!fmd) return -ENOMEM; + ret = of_platform_populate(dev->of_node, NULL, NULL, dev); + if (ret < 0) + return -ENOMEM; + spin_lock_init(&fmd->slock); INIT_LIST_HEAD(&fmd->pipelines); fmd->pdev = pdev;